From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5A796940FBF for ; Thu, 3 Aug 2023 06:42:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=TQbmjK2/6IzLdsM4GoJaibVv7Tn55LQQMTEsP98eUs4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1691044952; v=1; b=qEJhMzm4ega+XU5w2fg6Q/7mwYM4wyN6BCKdlk+ForWjpxWal43yxw67u29dRNFIwGTzSWqe F6TTO6OlzMGM7Z4L4r+cY70hKbxo4rKuUeThb/dPIuNlt3ZVE1mitHW/OeamQLg+y2kocC2BeRr ClTivkofDWuA4qIreL+NqoxA= X-Received: by 127.0.0.2 with SMTP id smfVYY7687511x1cXJn3hh00; Wed, 02 Aug 2023 23:42:32 -0700 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.73]) by mx.groups.io with SMTP id smtpd.web10.8471.1691044952260067410 for ; Wed, 02 Aug 2023 23:42:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YVfT3Lnr500plWA0ClJ9IBOCxr1k9hZ9/Sd2J0j2HYep4aE6uW4QIQ933/ho9tQ1FtvvFw8/YBjjBC4fs1vkrlGa+qq6zISRz5iKhCNu+6c9x3NnDMM6qXwwWo68k8aOe7x3PWsoo0n+lxxg0zbgDwxOYSKlCGchEvh3hvAkbrq/l4mFwKvZIALHlngV6IjOmj4c8pVXZoz4mH/vpwZliecL93/Ym+85H2XSNdLLPs/xDd/Pcte/v8KSMS98DpTtSOsnuQb/LdGR1ftLjVxmD8OfE/E2CIqzYZLrJTwvqEjse2X4AB3zLfW7iW4i3woyiPIeDJFs/aaUMRTJkatw8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aQP6DyrszYr8aWyOOzEfu4t76/xFzXXQeCewbra5DD4=; b=gfPCHtTPIjOdJYCUmSZGNyfx34DYdGxqLk4JP9xAq6Tb/9g2LA/r6u0m6VfWW5C2TyTcGRP6RuKid3fPYzKc9xLOcv4wfAnZIWqU8T9Tbopod7nJm2mC+irNpg48MUpJWcodtR1YcT88eLjX+iz0GK95De9/8SsjWjOsEUnOb3QnDYwiMKbQxHeS5TC6+s2jXXR7egfBwHpUJ73uERuKnuz8wDHEbBqPXXx01ZNqfbiW2XS/nwpoL7rp4WJPjvYLX/6GszEJAWj8EY6IdPyx06oRThm490Kuh+nITwuk0LGJegh8sO4TJsRmfewdedvA6RaMp7xS52mqqmAfOxIc2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by PH0PR12MB8098.namprd12.prod.outlook.com (2603:10b6:510:29a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.47; Thu, 3 Aug 2023 06:42:27 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ae22:8546:91f7:a85e]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ae22:8546:91f7:a85e%7]) with mapi id 15.20.6631.046; Thu, 3 Aug 2023 06:42:27 +0000 From: "Chang, Abner via groups.io" To: "Attar, AbdulLateef (Abdul Lateef)" , "devel@edk2.groups.io" CC: "Attar, AbdulLateef (Abdul Lateef)" , Sai Chaganty , Isaac Oram , Nate DeSimone , Liming Gao Subject: Re: [edk2-devel] [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based IRQ/GSI Thread-Topic: [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based IRQ/GSI Thread-Index: AQHZxdStZ9JuvLUZiUitY4415bS//q/YH5GQ Date: Thu, 3 Aug 2023 06:42:27 +0000 Message-ID: References: <91291c25394aa9b63d1c5865e3137328903dfb87.1691044467.git.abdattar@amd.com> In-Reply-To: <91291c25394aa9b63d1c5865e3137328903dfb87.1691044467.git.abdattar@amd.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=93560c2c-c3f9-48fb-9e5d-7deafc3bbea1;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-08-03T06:42:04Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|PH0PR12MB8098:EE_ x-ms-office365-filtering-correlation-id: 787b6f1e-ea87-4ac3-fa50-08db93eccd7b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: wwtdc6RfEiNP5q/3b7q8AYIubRMfg3+RkkDPeh9YVe8rbE8c3/T97+KgI+TPKDHPNCIGvll3n325IOco3YgffzwPFA5/qSmJXQXmZ3RJ+Fm4I04YVxmmjbV1zfxC0/IjDzXIvrdhsoFZYYwhXwOib7JP2/kvXY8Ey1mqOMFq0lCC8v1MktgJJ1bthZYTTtzEku8UKJ4ZWi1Gs+jCdJpekD3ZYA9hCUfupU6EHeCP8E730AALL+zDjBahjWaH2nWJ/uSzIRsyIC/VsTMuvXmIbWJEBbdugmUnU9Bep4RDFNIbOQFf1XW5FVwbHbmc9ZxsIefsKKWaIyBYlcmTBYUKdJiwVjEuCGJQoYR6QI61evwbNGpEffpYN/9SqWVERX4vmgpmg1uNqfcNMHHTzvNGMXrHlD2fAiuJdzW1z56bd79aokJbKdETl+Krxd0dOdMuVHFwoH2FK8WMXCNjH557oveyv2qg4uYpOLkKcBWaTowlNx8gRp++gLaLYfKE2ZHbbKFleNw6DyJO9WHMiqM95GCbrDR88joNaX1xfrsS1R9IYBqbqApKIJCmPY8+iKte9GDnaIBFEStaX/yaHvGnCzqh6B2t0GYMQ16hMYVnsg4dhldFG19BtKfLxfs5gPCt x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gMG7k1Vrwr1jr6zQo3aK3YSy0jFvtulCUmASiJSccvJAXdrNvuhQxn1b3+en?= =?us-ascii?Q?cR1qBFKVS7hpvknlrPn2vyLP0DruQtv7FSAItrL1nsU6ehqWlT963IcP/LeI?= =?us-ascii?Q?sFQMxrfSw6ilGQMDObggTivTNrmaurolOhahfKpIOyNy15yjrr4tof63AbL4?= =?us-ascii?Q?O9ZsNnrwEDsejA5og2io6Tj09J2nsTbcHORV2ritVEOf+wWkE/oWAEiXKYv7?= =?us-ascii?Q?JyyLx5DbGaSO1jlwA02J78/rgqCTCHZBh8ZOnf6e096iCr7r3xop+I7EwISz?= =?us-ascii?Q?O4hQFDHWvUWEdgvucM8rhqKdE9u/ow6f1yJ2S7bVA0s/3wVDNMLeaS/gZhHE?= =?us-ascii?Q?72eWFAGKmvpH1spDl3m9dDDR9LIqJq259WQAI61JpQEuYol+GTB8JABZ6fQA?= =?us-ascii?Q?GVbh9B1AJTiSXFTkc2V/Oan1CmSnnFumqly0BfFfDlD/7S7raYifRjjb2dY6?= =?us-ascii?Q?fmj0nMWPlH57Ko0euYNUgpVjs3gq6mzm4QrUaB4diV2SfK7A2Fy9fhM70BBM?= =?us-ascii?Q?niN+yGU4QUyTkis4CEE1WY9QdsLcQGk9BE6/1TD3oNGP3jcsI9W1IdCohCWu?= =?us-ascii?Q?gcTutArxnhWJNAi6Rp2KsojYTH+y3yX4mOdMgI/rZ8Z7IejciAt8DINmDmqa?= =?us-ascii?Q?vz+hOYsZJIqBDIpmvxN+zycpVv/gr9tqFTvpTlMKYXkEDSJYunBhd9hkmMHb?= =?us-ascii?Q?goOAloOs2HvzGirwn1Vre3ZFM+N2gkPUcoGSV+ahSLTMB/WKnQiv2J0UwiVt?= =?us-ascii?Q?Jm4Po2nXDn8G77XgwIgNywZrNLYMgJrzY2Ky70IWy63inOAOn/segfH3VQFo?= =?us-ascii?Q?5nnkYVmMYT06waQ3hHS8Qp+qnx7t95ylN4eliCxzFViLrXUIxSV8XernH3g4?= =?us-ascii?Q?Jjs9odY48yhxSjXebVZ3zzZKA2x0b3m38qNnHrPTgDv40SwYEUVF3zyIeP0Q?= =?us-ascii?Q?VTt14VfjH/q7Alq4T51tm7EhL0s3bRwrNpK1V6dLREuquowmcq2SUoCpuhVe?= =?us-ascii?Q?LP/crFAiqw3D6v4kqWhzOXdsz+Jo81EomE7AkIMCcNqOM4ooaHuWvX7lYqLj?= =?us-ascii?Q?Va+b4m2YzBKGCcv5xVL7W/qDA3nfeernXk3QZZDl+GNSconaZvQbwsqr1XRs?= =?us-ascii?Q?UAWxhoxaPKiYcIto234l6TbbTF+hBSBDZ3mmlZ+Q/luPWnXelkkrKqWiuup0?= =?us-ascii?Q?HycEMOZk4ZxhEOs8xyCdZtMt3A6vJ34KF9GmMsqJDN+ugdGw4MP7WM+Hxbds?= =?us-ascii?Q?G0LA6ciLKTspQ8Jf+btS7lYx8ZM1YxBb2F2F70lKbceO1ZHnJ4FTxFt9HAc+?= =?us-ascii?Q?sLXaLNUp79lOG+loGiQO4loSN++THBiupH6sf/1ZgEnQoBX3h9zJlvyFQTBN?= =?us-ascii?Q?nyL6wGvydzrrMaayZfb0mB1HuVmLULWm/smRYEMFi3lH5fG/LcUk0UcylJkt?= =?us-ascii?Q?Q7ASbPkCQXKhNBpLY1NDiDVCWv0MvHjpw7HkOg6HmBmhz4sja88BgdLalXNd?= =?us-ascii?Q?El9FMGPYzzknMP1wgfCIQvwxwT58wSqs6hux8w+xPSUzspj7Lr34njccghjL?= =?us-ascii?Q?lOYW0xUCWvND4Alv/2A=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 787b6f1e-ea87-4ac3-fa50-08db93eccd7b X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2023 06:42:27.1792 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZPdEVNbiII+F8IvDFo+A/ltOreIvqzjvQAyivnHr3npUV1qOgSVxre9YtYQFb0bSlEwR32w8LFTA7bkAgDuluQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB8098 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Zr3Dy0cfaYKqvQNdOUKhAK30x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=qEJhMzm4; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Acked-by: Abner Chang > -----Original Message----- > From: Abdul Lateef Attar > Sent: Thursday, August 3, 2023 2:35 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Sai > Chaganty ; Isaac Oram > ; Nate DeSimone > ; Liming Gao ; > Chang, Abner > Subject: [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based > IRQ/GSI > > From: Abdul Lateef Attar > > Create a new PCD to hold the IRQ or GSI number for SPCR, > with default values of 4. > Update the ACPI SPCR table's IRQ value based on PCD. > > Cc: Sai Chaganty > Cc: Isaac Oram > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Abner Chang > Signed-off-by: Abdul Lateef Attar > > Change-Id: I7218903fa5572f8139ad45db598ab085f079713b > --- > .../OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dec | 5 +++++ > .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpiDxe.inf | 4 ++++ > .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.h | 3 +++ > .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 7 ++++--- > 4 files changed, 16 insertions(+), 3 deletions(-) > > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d > ec > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d > ec > index b084fad89220..d69d650f3f20 100644 > --- > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d > ec > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d > ec > @@ -7,6 +7,7 @@ > # for the build infrastructure. > # > # Copyright (c) 2020, Intel Corporation. All rights reserved.
> +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -24,6 +25,10 @@ [Includes] > [Guids] > gSpcrFeaturePkgTokenSpaceGuid =3D { 0xe978c988, 0xeeba, 0x4671, { 0xb8= , > 0x0d, 0xcc, 0x8b, 0x89, 0xb5, 0xd1, 0xef }} > > +[PcdsFixedAtBuild] > + # SPCR default IRQ set to 4 > + gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrInterrupt|4|UINT8|0x00000010 > + > [PcdsFeatureFlag] > > gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrFeatureEnable|FALSE|BOOLEAN|0x > 00000001 > > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > AcpiDxe.inf > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > AcpiDxe.inf > index 9a4f95e86bbf..cd43afea5242 100644 > --- > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > AcpiDxe.inf > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > AcpiDxe.inf > @@ -24,6 +24,7 @@ [LibraryClasses] > UefiDriverEntryPoint > UefiLib > SpcrDeviceLib > + PcdLib > > [Packages] > MdePkg/MdePkg.dec > @@ -51,5 +52,8 @@ [Pcd] > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio > > +[FixedPcd] > + gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrInterrupt > + > [Depex] > TRUE > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.h > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.h > index c11da439fcb8..245a847762c5 100644 > --- > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.h > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.h > @@ -3,6 +3,8 @@ > SPCR is abbreviation of Serial Port Console Redirection Table (SPCR). > > Copyright (c) 2004 - 2020, Intel Corporation. All rights reserved.
> + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > + > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -23,6 +25,7 @@ > #include > #include > #include > +#include > > #include > #include > diff --git > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.c > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.c > index 51449d0fad9e..e92db96caaa9 100644 > --- > a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.c > +++ > b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr > Acpi.c > @@ -3,7 +3,7 @@ > SPCR is abbreviation of Serial Port Console Redirection Table (SPCR). > > Copyright (c) 2004 - 2020, Intel Corporation. All rights reserved.
> - Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -83,8 +83,8 @@ > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE gSpcrInfo =3D { > }, > > 0x03, //INTERRUPT_TYPE, > - 0x04, //IRQ, > - 0x04, //GLOBAL_SYSTEM_INTERRUPT, > + FixedPcdGet8 (PcdSpcrInterrupt), // IRQ, > + FixedPcdGet8 (PcdSpcrInterrupt), // GLOBAL_SYSTEM_INTERRUPT, > 0x07, //BAUD_RATE, > 0x00, //PARITY, > 0x01, //STOP_BITS, > @@ -441,6 +441,7 @@ OutOfBandACPITableConstruction ( > gSpcrInfo.FlowControl =3D UART_FLOW_CONTROL_HARDWARE; > } > > + > if (HasIsaSerialNode(SavedDevicePath)) { > GetIsaTypeInfo (SavedDevicePath); > } else { > -- > 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107520): https://edk2.groups.io/g/devel/message/107520 Mute This Topic: https://groups.io/mt/100521521/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-