From: "Chang, Abner" <abner.chang@amd.com>
To: "Pierre.Gondois@arm.com" <Pierre.Gondois@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [PATCH 17/24] RedfishPkg: Remove duplicated words
Date: Wed, 24 Aug 2022 13:32:36 +0000 [thread overview]
Message-ID: <MN2PR12MB396667D201058C75E34F7FA9EA739@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20220823160031.991072-18-Pierre.Gondois@arm.com>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
> Sent: Wednesday, August 24, 2022 12:00 AM
> To: devel@edk2.groups.io
> Cc: Pierre Gondois <pierre.gondois@arm.com>; Chang, Abner
> <Abner.Chang@amd.com>
> Subject: [PATCH 17/24] RedfishPkg: Remove duplicated words
>
> [CAUTION: External Email]
>
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> In an effort to clean the documentation of the above package, remove
> duplicated words.
>
> Cc: Abner Chang <abner.chang@amd.com>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
> RedfishPkg/RedfishDiscoverDxe/ComponentName.c | 4 ++--
> RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 2 +-
> RedfishPkg/RedfishRestExDxe/ComponentName.c | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/RedfishPkg/RedfishDiscoverDxe/ComponentName.c
> b/RedfishPkg/RedfishDiscoverDxe/ComponentName.c
> index f34d7ab5d953..886f0b97b0de 100644
> --- a/RedfishPkg/RedfishDiscoverDxe/ComponentName.c
> +++ b/RedfishPkg/RedfishDiscoverDxe/ComponentName.c
> @@ -19,7 +19,7 @@
>
> @param[in] This A pointer to the EFI_COMPONENT_NAME_PROTOCOL
> instance.
> @param[in] Language A pointer to a three-character ISO 639-2 language
> identifier.
> - This is the language of the driver name that that the caller
> + This is the language of the driver name that
> + the caller
> is requesting, and it must match one of the languages specified
> in SupportedLanguages. The number of languages supported
> by a
> driver is up to the driver writer.
> @@ -130,7 +130,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED
> EFI_UNICODE_STRING_TABLE *gRedfishDiscoverControl
>
> @param[in] This A pointer to the EFI_COMPONENT_NAME_PROTOCOL
> instance.
> @param[in] Language A pointer to a three-character ISO 639-2 language
> identifier.
> - This is the language of the driver name that that the caller
> + This is the language of the driver name that
> + the caller
> is requesting, and it must match one of the languages specified
> in SupportedLanguages. The number of languages supported
> by a
> driver is up to the driver writer.
> diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> index bf50c78c9280..a542d97fe09e 100644
> --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
> @@ -1325,7 +1325,7 @@ EFI_REDFISH_DISCOVER_PROTOCOL
> mRedfishDiscover = {
> @param[in] ControllerHandle MAC address of this network interface.
> @param[in] NetworkProtocolType Network protocol type.
> @param[out] IsNewInstance BOOLEAN means new instance or not.
> - @param[out] NetworkInterface Pointer to to
> EFI_REDFISH_DISCOVER_NETWORK_INTERFACE_INTERNAL.
> + @param[out] NetworkInterface Pointer to
> EFI_REDFISH_DISCOVER_NETWORK_INTERFACE_INTERNAL.
>
> @retval EFI_STATUS
> **/
> diff --git a/RedfishPkg/RedfishRestExDxe/ComponentName.c
> b/RedfishPkg/RedfishRestExDxe/ComponentName.c
> index de4828369083..a1b61162a3f5 100644
> --- a/RedfishPkg/RedfishRestExDxe/ComponentName.c
> +++ b/RedfishPkg/RedfishRestExDxe/ComponentName.c
> @@ -24,7 +24,7 @@
>
> @param[in] This A pointer to the EFI_COMPONENT_NAME_PROTOCOL
> instance.
> @param[in] Language A pointer to a three-character ISO 639-2 language
> identifier.
> - This is the language of the driver name that that the caller
> + This is the language of the driver name that
> + the caller
> is requesting, and it must match one of the languages specified
> in SupportedLanguages. The number of languages supported
> by a
> driver is up to the driver writer.
> @@ -135,7 +135,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED
> EFI_UNICODE_STRING_TABLE *gRedfishRestExControlle
>
> @param[in] This A pointer to the EFI_COMPONENT_NAME_PROTOCOL
> instance.
> @param[in] Language A pointer to a three-character ISO 639-2 language
> identifier.
> - This is the language of the driver name that that the caller
> + This is the language of the driver name that
> + the caller
> is requesting, and it must match one of the languages specified
> in SupportedLanguages. The number of languages supported
> by a
> driver is up to the driver writer.
> --
> 2.25.1
next prev parent reply other threads:[~2022-08-24 13:32 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 16:00 [PATCH 00/24] Remove duplicated words PierreGondois
2022-08-23 16:00 ` [PATCH 01/24] .pytool: " PierreGondois
2022-08-23 16:00 ` [PATCH 02/24] ArmPkg: " PierreGondois
2022-08-23 17:13 ` [edk2-devel] " Sami Mujawar
2022-08-24 13:28 ` Leif Lindholm
2022-09-05 13:54 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 03/24] ArmPlatformPkg: " PierreGondois
2022-08-23 17:12 ` [edk2-devel] " Sami Mujawar
2022-08-24 13:26 ` Leif Lindholm
2022-09-05 13:54 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 04/24] ArmVirtPkg: " PierreGondois
2022-08-23 17:12 ` [edk2-devel] " Sami Mujawar
2022-09-05 13:55 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 05/24] BaseTools: " PierreGondois
2022-08-23 16:00 ` [PATCH 06/24] CryptoPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 07/24] DynamicTablesPkg: " PierreGondois
2022-08-23 17:09 ` Sami Mujawar
2022-08-23 16:00 ` [PATCH 08/24] EmbeddedPkg: " PierreGondois
2022-08-24 13:29 ` Leif Lindholm
2022-08-24 13:31 ` Chang, Abner
2022-09-05 13:54 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 09/24] EmulatorPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 10/24] FatPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 11/24] IntelFsp2WrapperPkg: " PierreGondois
2022-08-23 16:55 ` Chiu, Chasel
2022-09-01 23:18 ` [edk2-devel] " Nate DeSimone
2022-09-01 23:24 ` Nate DeSimone
2022-08-23 16:00 ` [PATCH 12/24] MdeModulePkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 13/24] MdePkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 14/24] NetworkPkg: " PierreGondois
2022-09-02 14:31 ` [edk2-devel] " Maciej Rabeda
2022-08-23 16:00 ` [PATCH 15/24] OvmfPkg: " PierreGondois
2022-08-23 23:00 ` Yao, Jiewen
2022-09-05 13:55 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 16/24] PcAtChipsetPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 17/24] RedfishPkg: " PierreGondois
2022-08-24 13:32 ` Chang, Abner [this message]
2022-08-23 16:00 ` [PATCH 18/24] SecurityPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 19/24] ShellPkg: " PierreGondois
2022-08-24 5:34 ` Gao, Zhichao
2022-08-23 16:00 ` [PATCH 20/24] SourceLevelDebugPkg: " PierreGondois
2022-08-24 0:50 ` Wu, Hao A
2022-08-24 1:06 ` [edk2-devel] " Ni, Ray
2022-08-23 16:00 ` [PATCH 21/24] StandaloneMmPkg: " PierreGondois
2022-08-23 17:11 ` Sami Mujawar
2022-08-23 23:00 ` Yao, Jiewen
2022-09-05 13:55 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 22/24] UefiCpuPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 23/24] UefiPayloadPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 24/24] UnitTestFrameworkPkg: " PierreGondois
2022-08-25 3:12 ` Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB396667D201058C75E34F7FA9EA739@MN2PR12MB3966.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox