From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.54]) by mx.groups.io with SMTP id smtpd.web09.156.1660089915166989812 for ; Tue, 09 Aug 2022 17:05:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=mFZ5iFpJ; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.95.54, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PWe3QyFTnBTNqAYZSrvMVwqRvoP9QF4+dxx0isg8eFLUTooamE+2aKtZesX35KEi4EZ5bSR1hdenq1Sv3UpANKwwvS2OvA3mAOAXeqeTgdiowEJ8uTELQWw+GnOUSke/PYl5HnZkVVMi6xfL3FDKwmpzvNcpA4pZQ/3LFYcKYvc2LE+57IdwQwBXHjO8aph6e1rJpPt5edgFnnco+hluWqMfUanpDua9ZZlxUVXSOk9wRKD1mbdNCxLLhL0isDBcZQJY/ZkxXHfP3EM7fEOKwWtXglo/nhjG+haH9FH+lrkpGbpKNrTfZEENuLucgm2IcW9/0vyvV4TxyezRz61DHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+J250m6Vqb6/9ZlW9iD61OO7DQ7FotYbzvDkhbjOmIM=; b=Gj7fMLpOge9MexE8XNEkkjbQ4sIZAhnelFCPnVBMZsOklP1cvXscoNu+Bcx4t5EZoMu+vRJ9wgVcDAfoHe6yGFq8jBnLTftHljWWriHWtmf4Pf2meas76tqmuP+/BkOGiUGjHCjIWvrxjTrhmTTWCyI4P47suzhMElWXmwGf3eIrZBHbGR7n4O/KOsma5c3u2O3BNO5l0cZ7LL3ztEeZOaWcEs/SksnZtgwvsNjitvIdorrbk04WfLdrL1Coo/kWhY/3INomIbZJtZtqabwQEO2UU+fQl+urJHhcte/MZIjHdESaOC6Wwglv2AHOwIRFJSPlIbrBJ+9UEwobP62Zgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+J250m6Vqb6/9ZlW9iD61OO7DQ7FotYbzvDkhbjOmIM=; b=mFZ5iFpJ80aPu3F1gjdNbgYnstBgG4IqjZisFegH2xnaixoOhaLFFDbOe1G1wvx7440kSMyRCQnCFd0gkdUYr7MbM0H5f7MATMFPNsLpFSJDRmERYp5Ip38hk77y5JZf69IePuS1tAARghJXUkqzt47YKwDnaip9SOZ5dFlsqpI= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by BYAPR12MB2983.namprd12.prod.outlook.com (2603:10b6:a03:d6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16; Wed, 10 Aug 2022 00:05:10 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e850:8264:41be:cb1f]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e850:8264:41be:cb1f%4]) with mapi id 15.20.5504.020; Wed, 10 Aug 2022 00:05:10 +0000 From: "Chang, Abner" To: Igor Kulchytskyy , "devel@edk2.groups.io" CC: "nickle.wang@hpe.com" Subject: Re: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Topic: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Index: AQHYqljLKVm7X4buzUSN71MsFikpzK2mL5pggAC4fKCAAFu9eQ== Date: Wed, 10 Aug 2022 00:05:10 +0000 Message-ID: References: <1659875125-9504-1-git-send-email-igork@ami.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-08-09T07:34:38.0000000Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 98363b2c-af4c-42e4-0997-08da7a63fd9e x-ms-traffictypediagnostic: BYAPR12MB2983:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /3aggJYkNikeaRag2CIUdlXkvndGAtYTG6FIA5iW+uvTxb0gkOzAyJO5W2IjlHtwvSLe4By0X642l80X0QOOZbVPd3jSksjpiTU3EiNOWeRIQVJGoTmVNP1ES1Z9O6SaoVFH75Zg6Fm/c5GMon8jOs3p76jBCB3DtIkKOrIroRqjN/3xwZ3X4rxtksjyLAMuVm/5K6sEqw/YEzaw+AGqhGwAIzeHRENlQHmOfvWXcn08aSu5hmpT50J30lw7Uj/gz8ILvaasWKos47LCliEZDUYKHnUloAd9VtGz4OhzUSVeGstIenCyLFa0lLoy5pPy7XAhhFJcPjV4vWvXilSIKW5aJjQ9s4nkovoEcDsifkVBRdIYpZplSrSUETL+SosMn/nkbVGhysxLqucGE/GKKUNrXFIb7VxUJcoIcPK6O91zOSB1jhf6TiV3LnrA3GM/Z0MGeB3KRaS+YZQPcjcr9r+sfArEbUguHT+KYVhoC3L4JIfAxlXs6fllw9PItKMsM9wO0Novd3YUUMpAVInxZSmeo52FNSUPmuJOmC1TM51oc0nQk4RJIVLOZxww/lxi3jpxjwkhSw0Jd/cVPeNuFgffl5L853tmq/yl+3mPoEhglSNxvniEOq/4po3yF9scnswR+Ick6zgf8PJMoJH1SAFufaBP4rhpPdlXFdYz5gnWPKiFO2GC31kvGojQyJJgsVqVPgrUzIG0aTaj3MRZYPoMYeCNHIkVtK6tW/242FrHGxHQd/wN4vDNytZi0X9ds/yAcEABKS3Snv095SSsxcWjN6jVSX7PBE9jBUYfBarVFFZ2EpbTO/eTxyKeSCnKYd4hHy0NCVpVn/iTgWYy2w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(366004)(396003)(346002)(136003)(2906002)(83380400001)(38070700005)(166002)(122000001)(55016003)(91956017)(45080400002)(316002)(8936002)(52536014)(110136005)(38100700002)(8676002)(4326008)(76116006)(66476007)(66446008)(26005)(6506007)(9686003)(7696005)(64756008)(71200400001)(186003)(5660300002)(41300700001)(53546011)(478600001)(66556008)(66946007)(86362001)(33656002)(40140700001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nyqkZfhuHS3V/XCtCYq5BWbfUX1ak+TKklfuBVnDd7JiY7E5Nv7otz49CECi?= =?us-ascii?Q?ZbWtejeSjtvZKGT9kmTR0NW3d+LuR6MsOpHwkZejKWu8GHOiZ1+IDgbisYqG?= =?us-ascii?Q?IGIKPggZ9KXj1w1dUD0Ya4ce2M5BiR7a59VUYky1vjPX8NiyfKpMysSUrylv?= =?us-ascii?Q?u7+LF2p9hF3MtpBilhjajePQ6o05zPGxzq0e93J0SJ+kISOfMH57npe0cXge?= =?us-ascii?Q?pGvcrskeDJcaJfk4oz0Sun0i+VzbGlOnXHSu3OC5GPvsG/1YeBb/RsjJYPoc?= =?us-ascii?Q?X83+ZbFH/GRvaB0PzIjykA9LxAzV63mLGkfQ3d6bXQGnLkza+uV7lrcdwUzr?= =?us-ascii?Q?W5bYblt3W5DFRkRH2jJgRV4vXRGphrRAffQ0Ql0QmtMywtOoxst/vRLDXQQN?= =?us-ascii?Q?LhYa1wS5wmTNPqv2F0+bsCV/z4lFvpIU2QPWGwi19NT0ARASf0I42KVFak/3?= =?us-ascii?Q?sRV4Kx6POtGhWs8Pq9L+/2ia0Q6IJm5FAVI5d5pfajif7Fq1VYc08QF4ZbCE?= =?us-ascii?Q?IZxmig0pacwHqaO3QbkM1tNSb/+WhmcqZDLve2cAkgje3uNfLXobCjtmfATH?= =?us-ascii?Q?FXBgLh4gfKTTPE3FOwzAuoXaXwdbTZlrgkgQwehH8rfMwm9uXtZlM6zS3vyE?= =?us-ascii?Q?t/yo8NXadTm43lq3zHN55MQ481dzo2ql4fn6K5SjwFYmcyzmhMUBmoJZiK8u?= =?us-ascii?Q?r8akfNr1EaXGhJkkC05pQS1tvUVmFsbiZG+dyyqANDL5gni86W1qpwKkSXKO?= =?us-ascii?Q?FywHxAOxVXACn1UyHKIfIypH0Tk+dn7lJSnkNflsqeipyk+6oIElErmKbtV4?= =?us-ascii?Q?1PVdnt4fXVcN1jXHdoD3HDUQNY9Oj25+QWZIab2sBPd0MAyA5FYs2P+Cwpcb?= =?us-ascii?Q?trvCzRQ0gQygIhQpYG+shHw1vVLQcigQRdxRuy1sTiAqQ/D7v9rWwwpnsn6O?= =?us-ascii?Q?SJn+BI0I1XUhoXNNrgERtPN+QsKefj/ngnb9y6lklRP+a5o6vh2Qhxw6my/p?= =?us-ascii?Q?1oiffMLZ/AM8Z+zK+ME2CR97sNn/ovg+Af0/4tIcK7QTRq070GF6+dukkP5E?= =?us-ascii?Q?DWpOj7T99QwZSdxkIv4JvKkXdJhqOZ5gM1zdOjbxmTg05c2/IzWiGSBbhJWc?= =?us-ascii?Q?hnFdskNBs6HSkNkHTGIKf5nC0z3f/BbLNv/lirLPZxA1nsjB3yV7sIfZRM/s?= =?us-ascii?Q?isAYvx0Zfhrg240OEBxuG2rTbdokS3pk0fwYuYx5wyrk9Hh1qcHJX2h2rxrK?= =?us-ascii?Q?kftGK3/Pad46sc2ufNTawb47L8fFkM6AUlB5tns6jSvJNKtFOt3gXbbAqsp6?= =?us-ascii?Q?ITbE3nakn/+1Qdd6sz1qaUT5LVZeYplnCrPpksbkLWZblF/f4N9iJNx2bgCp?= =?us-ascii?Q?QhZFualQI4GfLiq++0N2JSI+dPkr5IOX4FP7ivtRbcgk8ZUQfwhrtcaNL/py?= =?us-ascii?Q?pJS6pe3Px+23Sphoh9I6d1YmvMFE1vr2reyNt/Bzk08jM3+e8UeV0ZaZeCfN?= =?us-ascii?Q?qUKijosiBLQ9hmGEWToBxBG0ZOMdQRHT3BgqkbXcUelSWScVlIELN/lThUuv?= =?us-ascii?Q?jQwoK+7h7+H93cYOloy4Bb6xeOrg4zd66K7X6gnx1OgQDKRPgijQLm2fq06Z?= =?us-ascii?Q?bw=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98363b2c-af4c-42e4-0997-08da7a63fd9e X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2022 00:05:10.1065 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PS7EDBN4RrzerIkZ8r1oHpqp1ysBS7JFG2QjTnu144bTFOPv7urO2Qk/LjTRVBajFKx9iqIqXNrOrxC1X9ykwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2983 Content-Language: zh-CN Content-Type: multipart/alternative; boundary="_000_MN2PR12MB396668BE47CBAC080EB45978EA659MN2PR12MB3966namp_" --_000_MN2PR12MB396668BE47CBAC080EB45978EA659MN2PR12MB3966namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, please create the new patch set with the prefix [PATCH V2]. Also, use = git move to move Redfish.h to Include\ to keep the commit history, this one= could be the patch 3. Thank you, Abner Get Outlook for Android ________________________________ From: Igor Kulchytskyy Sent: Wednesday, August 10, 2022 3:21:46 AM To: Chang, Abner ; devel@edk2.groups.io Cc: nickle.wang@hpe.com Subject: RE: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Red= fish host interface is not supported [CAUTION: External Email] Hi Abner, Thank you for your feedback. I agree with you. What should I do to change it? Should I create a new patch? Thank you, Igor -----Original Message----- From: Chang, Abner Sent: Tuesday, August 09, 2022 3:35 AM To: Igor Kulchytskyy ; devel@edk2.groups.io Cc: nickle.wang@hpe.com Subject: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish= host interface is not supported **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** [AMD Official Use Only - General] Hi Igor, my feedback is inline. > -----Original Message----- > From: Igor Kulchytskyy > Sent: Sunday, August 7, 2022 8:26 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nickle.wang@hpe.com; Igor > Kulchytskyy > Subject: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host > interface is not supported > > [CAUTION: External Email] > > Host Interface details are discribed by the SMBIOS Type 42 table. > The table is published by the RedfishHostInterfaceDxe driver. > That driver supports PCI-E and USB host interface types. > The table is consumed by the RedfishGetHostInterfaceProtocolData > function in the RedfishDiscoverDxe driver. > That function only supports PCI-E interface. > > > Cc: Abner Chang > Cc: Nickle Wang > Signed-off-by: Igor Kulchytskyy > --- > RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c | 11 > ++++++++-- > - > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git > a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > index d79750b..a3b977f 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > @@ -65,10 +65,15 @@ RedfishGetHostInterfaceProtocolData ( > RecordTmp =3D (UINT8 *)Record + Offset; > > // > - // Check Device Type, only PCI/PCIe Network Interface v2 is supp= orted > now. > + // Check Device Type, PCI/PCIe and USB Network Interface v2 is s= upported. > // > - if (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) { > - ASSERT (SpecificDataLen =3D=3D sizeof > (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1); > + if ((*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) || (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)) { > + if (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2){ > + ASSERT (SpecificDataLen =3D=3D sizeof > (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1); > + } > + if (*RecordTmp =3D=3D > + REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2){ [Chang, Abner] We can do if-else here because we only support two types of network device = now. Abner > + ASSERT (SpecificDataLen > sizeof > (REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2) + 1); > + } > *DeviceDescriptor =3D (REDFISH_INTERFACE_DATA *)RecordTmp; > Offset =3D Offset + SpecificDataLen; > RecordTmp =3D (UINT8 *)Record + Offset; > -- > 2.6.1.windows.1 > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is > intended to be read only by the individual or entity to whom it is > addressed or by their designee. If the reader of this message is not > the intended recipient, you are on notice that any distribution of > this message, in any form, is strictly prohibited. Please promptly > notify the sender by reply e-mail or by telephone at 770-246-8600, and th= en delete or destroy all copies of the transmission. -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . --_000_MN2PR12MB396668BE47CBAC080EB45978EA659MN2PR12MB3966namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Yes, please create the new patch set with the prefix [PATCH V2]. Also, use = git move to move Redfish.h to Include\ to keep the commit history, this one= could be the patch 3.

Thank you,
Abner
From: Igor Kulchytskyy <= igork@ami.com>
Sent: Wednesday, August 10, 2022 3:21:46 AM
To: Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io &= lt;devel@edk2.groups.io>
Cc: nickle.wang@hpe.com <nickle.wang@hpe.com>
Subject: RE: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: = USB Redfish host interface is not supported
 
[CAUTION: External Email]

Hi Abner,
Thank you for your feedback.
I agree with you.
What should I do to change it?
Should I create a new patch?
Thank you,
Igor

-----Original Message-----
From: Chang, Abner <Abner.Chang@amd.com>
Sent: Tuesday, August 09, 2022 3:35 AM
To: Igor Kulchytskyy <igork@ami.com>; devel@edk2.groups.io
Cc: nickle.wang@hpe.com
Subject: [EXTERNAL] RE: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish= host interface is not supported


**CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.**
[AMD Official Use Only - General]

Hi Igor, my feedback is inline.

> -----Original Message-----
> From: Igor Kulchytskyy <igork@ami.com>
> Sent: Sunday, August 7, 2022 8:26 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; nickle.wang@hpe.com; Igo= r
> Kulchytskyy <igork@ami.com>
> Subject: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host
> interface is not supported
>
> [CAUTION: External Email]
>
> Host Interface details are discribed by the SMBIOS Type 42 table.
> The table is published by the RedfishHostInterfaceDxe driver.
> That driver supports PCI-E and USB host interface types.
> The table is consumed by the RedfishGetHostInterfaceProtocolData
> function in the RedfishDiscoverDxe driver.
> That function only supports PCI-E interface.
>
>
> Cc: Abner Chang <Abner.Chang@amd.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Signed-off-by: Igor Kulchytskyy <igork@ami.com>
> ---
>  RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c | 11<= br> > ++++++++--
> -
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git
> a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c
> b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c
> index d79750b..a3b977f 100644
> --- a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c
> +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c
> @@ -65,10 +65,15 @@ RedfishGetHostInterfaceProtocolData (
>          RecordTmp &= nbsp;     =3D (UINT8 *)Record + Offset;
>
>          //
> -        // Check Device Type, only= PCI/PCIe Network Interface v2 is supported
> now.
> +        // Check Device Type, PCI/= PCIe and USB Network Interface v2 is supported.
>          //
> -        if (*RecordTmp =3D=3D
> REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) {
> -          ASSERT (Specif= icDataLen =3D=3D sizeof
> (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1);
> +        if ((*RecordTmp =3D=3D
> REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) || (*RecordTmp =3D=3D<= br> > REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)) {
> +          if (*RecordTmp= =3D=3D
> REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2){
> +           &nb= sp;  ASSERT (SpecificDataLen =3D=3D sizeof
> (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1);
> +          }
> +          if (*RecordTmp= =3D=3D
> + REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2){
[Chang, Abner]
We can do if-else here because we only support two types of network device = now.
Abner

> +           &nb= sp;  ASSERT (SpecificDataLen > sizeof
> (REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2) + 1);
> +          }
>            *Dev= iceDescriptor =3D (REDFISH_INTERFACE_DATA *)RecordTmp;
>            Offs= et            =3D Of= fset + SpecificDataLen;
>            Reco= rdTmp         =3D (UINT8 *)Record += Offset;
> --
> 2.6.1.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is
> intended to be read only by the individual or entity to whom it is
> addressed or by their designee. If the reader of this message is not > the intended recipient, you are on notice that any distribution of
> this message, in any form, is strictly prohibited. Please promptly
> notify the sender by reply e-mail or by telephone at 770-246-8600, and= then delete or destroy all copies of the transmission.
-The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are on notice that any distribution of = this message, in any form, is strictly prohibited. Please promptly notify t= he sender by reply e-mail or by telephone at 770-246-8600, and then delete = or destroy all copies of the transmission.
--_000_MN2PR12MB396668BE47CBAC080EB45978EA659MN2PR12MB3966namp_--