From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.73]) by mx.groups.io with SMTP id smtpd.web10.506.1668303426768981310 for ; Sat, 12 Nov 2022 17:37:07 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=y7v4yz7L; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.223.73, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H6fWL0HnY2yMMBzHz/hHA/xljmxi3FSlo1gxAl5ohHP3vtgPOkAzSF+fK5fK4NIouVc9cYv0O4q2A6Rt9edajFPiHM2UDcKw4UEeLUu8b6bOZYYDLX4pElioZ/dg9SN0Ww1zcgVsqHMXo71QEtdsCyAxq+qqpg5vuzD5Gx4jN9KPFKgKIFrfgJc3fTOsD/35XuPiIyY3CJd5ZmTz5oy80QLghOgroPB24geS3kxTsCIaGPmlqc7uPjQ498mvIim4rAJ67hpyjBDLbGdyXJ1yjNl8HjQVpPQYRlWShV0nQ4WrZkSSDphcOtzogrilNXrv+hWPDgqiQmKYXcUJNcpjWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qw+21BzQYwrPm3DR37k8ndJngJvFgD0OxHbINmngT8I=; b=lEF6YShC1qurkNUpjIhjCSGDCYX0yap2oSB78r4dzxYBReOhFfRuTezsvYPiSoDsDFLa7EBXN6FU0Vcr5trXU05uSC1+8K0BIS2+NwpVY9G5rpISjOHxhGY9m9ZHMzitL/FVq2hVNVM99Mx+PS3A/OBjgKeUn1KJXurLt0OYch7zLzwjpXnyLZOE9HtGzuTGfS/QVP6P5P5z+5QY3t6hrBqrsSTrd96Ots/fNwC2aSfrL1xG+npUk6tfAvhLAeVWiwpjuyTcSeRSEUKVst2ulN7ftdWPDosNTKlUy8muDJiaGFK1M/g+TND1AYjGF8pbzy1KLrzqd3iLbN+FgOmZZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qw+21BzQYwrPm3DR37k8ndJngJvFgD0OxHbINmngT8I=; b=y7v4yz7LWKpsWYW/+2QAutRkbix31clHVtIJI46YCIKv0g/jOlHvgv+UDXc5FxMAEgJFpKk+Uar3ycimEgUpGxZ4N8BgsPQz04+9x/XY2gstY4UwH35A8Lqv17bLDkjTqMcDz4gU9IvHKJm7sDxP7igyk/JA+ftMGXXk+/LVwYM= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SJ0PR12MB7067.namprd12.prod.outlook.com (2603:10b6:a03:4ae::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Sun, 13 Nov 2022 01:37:02 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ce0a:283e:839:34bd]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ce0a:283e:839:34bd%3]) with mapi id 15.20.5813.016; Sun, 13 Nov 2022 01:37:02 +0000 From: "Chang, Abner" To: "devel@edk2.groups.io" , "michael.d.kinney@intel.com" , Michael Kubacki CC: "Wee, Sing" , Rebecca Cran , "lersek@redhat.com" , "heyi.guo@linaro.org" Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification] Create release/2.30 branch Thread-Topic: [edk2-devel] [edk2-CCodingStandardsSpecification] Create release/2.30 branch Thread-Index: AQHY6iTO/YoJYNprhk6n4u7gZgA2Y64j7deAgADKZ8CADnIecIAAmBCAgAfCNSA= Date: Sun, 13 Nov 2022 01:37:02 +0000 Message-ID: References: <20221027165416.1610-1-abner.chang@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-11-13T01:36:59Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=fea54a07-3d92-496c-95e2-d89ed4dbe575; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SJ0PR12MB7067:EE_ x-ms-office365-filtering-correlation-id: 1f55c1ed-cdbc-4b67-b964-08dac517904c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SB2JbsSF4ThfnmBIC6QRgrGP8RhhgioTWRhyP5axhc15To9WT2lap/Pz/5uchC35EIBn+M35zVVGXXyROw8D/bNEagGcuiSthiaw8ir5+81vgIuMY3JJAFa1WpAqgod/toqVE4j1hQznamvhnttsn7zcUZ/0fdLeMP6lIa9mrs7d0Ex0p+4uqM4xCDEB/ALNfgzocz/WhqNFt7lDwEzew56z3DVHVE4JCIHSCyoX/2dVKiekCaY0mMc9FRjIG5C5hGgtmHv/kaOfcXUyxc0SSNgzTrSVuLtmusrRe5DYzqxVdHAnO/OrmiHE0nGqDlqArIe8INXXpQ40cHBD631vFMKT7Omim2U8nGgC/kS9jXr02XHRSZXVICxdBSAJehrnCoXuWk1A09p/LvlvXFqk8oibcEFk9SFzXjm82IqS9nDvqKLp6hkzWqcaOrO+qjFX5GXCEtgoXTqCXB3iszEKE7aoSxkm/0EfxS7uNWs1+3ivl0olpjUlPxUvFSNVBlsidZ+/2/J+bs6U1LWoC+lfNHLngVjJp6utuGNgU1FgYLRHjJZ/S7bTj9Um//SfIAn8n5dmYF6r9xGPodIVGmulOxxcilAaHaoqHYVM/idp0fDeBTBSa82Oe8D8XKKSSTpX2vfhVMidsWF98oO12gIpl6u7z7SBd9aRlyQM75KDsLSypies15u1C0Az5N5w+jpb+SyWofvbRyLuO4/Unv//rzu0yKJBoB+xpXwktyBmTMA+6pRs0bi22TWld0p+cqzLE7YoLTLqNHpbieQzAn0X7j9jX2u4YbtVXo8ApdoiAuG/fnT3+/vev5I636aCQzk888hkn6/tTSQzfBymYpSgog== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(366004)(396003)(346002)(451199015)(66476007)(66556008)(66446008)(66946007)(76116006)(2906002)(38100700002)(122000001)(64756008)(5660300002)(83380400001)(41300700001)(8936002)(38070700005)(52536014)(30864003)(4326008)(8676002)(66899015)(71200400001)(478600001)(53546011)(9686003)(33656002)(7696005)(6506007)(26005)(45080400002)(316002)(186003)(110136005)(54906003)(966005)(86362001)(55016003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wzfffvLJ9TkuLD8nrOIvs6dDlZMpkP7IVADUSkKGT3XWh8keRULethwy++iP?= =?us-ascii?Q?BjHxnaCssVKjVaosEAJIR0bOIU+PYTGQ/QA/X2oWON42xlMaOaC7qk1A+hN1?= =?us-ascii?Q?ACeL7XEGlKaEsStnVjSNbLWI73gJpDQok1isy0m82nAA+wzT35P+oeyajSih?= =?us-ascii?Q?DvyDjYsvyi5CU2k5AxWO51bNjtRdvOH9rRsaaLi4hg0CpdMb/w2qlkWrwREO?= =?us-ascii?Q?1IK5E6+wkeAcmY82AAwvHm3m5UBBEhM2tFdJCPJ3XSscMTBn0Z7L9ci9PX6o?= =?us-ascii?Q?8rVh7Nk8shmc5nRDBt2moQ+vNURRncV77Ma/6Go3DmS6DtGDGZ9aTbMcdLRc?= =?us-ascii?Q?HVIq8ZrfBjq+CCJkqPj4rwjIN80/vz4mHurmQkL12KgTie8zSYvFc8MgxA/s?= =?us-ascii?Q?ULNTI5tSJRygenx20oHBjyLtqXqwKw6j3JRn2J9bM0wqbtpvFbnYhlOKyeXI?= =?us-ascii?Q?BKytyB2OmUlhKojT4r3UPAfmppOlBlMecagUJaVXKR6EAcKMPyhhxh8eQcaU?= =?us-ascii?Q?XLlLPFNM64lCb5IV9ZMs8pibHVgCMJy5N+A5J6hF/Tgr7cTLvb3fquP8dF2o?= =?us-ascii?Q?j/kL60SihSGT+1c032bQQ5hOxGfa1lBVCmbFpoBCHNbwLzZux0u7EBdYlRJr?= =?us-ascii?Q?6HsfCDcmSObLQNRe3B8qD1OpFwD2r0fpodnA/efRCupNM80ZxCs9pZgJzqdU?= =?us-ascii?Q?b4ScmRXcp5P1dTNBE5IwTdu6IIUck/vabsxxWrL2dX8RVdmr03n6NvkI+Kz4?= =?us-ascii?Q?u+QCe2nsWalPnyyAupRCkWTGY+sQ0RXPq7fJV5pej2/1ILZSRrY9D8QrvGur?= =?us-ascii?Q?tnU30g8LfTPCVnimeY695klm8AnUo2WMMUyTUqsW0a9NMM2T107t+ULb+7ME?= =?us-ascii?Q?UvO1WcriP7gerYao78Hc6lGW5IeltjJkrGdOiAYbVquuFccwk84ZBfrpOdmf?= =?us-ascii?Q?+hvJDMwNVoygVpOWApcyjyIjrgLccDuOHvE176tSsgrouXM0wA8z7iKY/wAt?= =?us-ascii?Q?bC8yNMuYfOQRJI2Lr7gf3jdemFSIVpx+JUd87BjClTUbrd5rV+uHCcMPKKrR?= =?us-ascii?Q?YZ43iDQhdlGAfU8YlnQT9+mvol0IEK2sQ6azzDyFdhfmCVBm+w4m4vHpMURe?= =?us-ascii?Q?cGRbnk+UjPaiIJHQRTKZE7+EuEfDTGUKBVgcfO53UbAvHDvKEeK5px3R0VFA?= =?us-ascii?Q?AXIETwlX1XP/zfn9jQRJZeHxxGLRxzFswtVAq5ypMVbOEv1r1oLmrHe0yQO9?= =?us-ascii?Q?6BSCNwOjZ69kgAhmik+oLrtBgHsGUlc/08IsX7Jcc/3ZS1dQpknihTFpV1ZK?= =?us-ascii?Q?p5kH9UhX9A7B6qt0VxWZ1oNJrlmKmg2bPZca/NlJFVNSLwZCC6YLAC41b40d?= =?us-ascii?Q?NKW0G92p9wZnOIh+Mbks5ttla/bpinfwr3+Nl2G/ijHHqEgXRp8o67QhRW2j?= =?us-ascii?Q?pr7eGxo3IG1v3svKAGRQPCPAdugyp4Bx9+XdIeW0tH3icSA8ICmIomdqVcUj?= =?us-ascii?Q?ZXfhfPYcqse9TWZ4iuSzpMo1MoCfAx85M8xDUhYAUAK2f9rDUVXfx0xxn+l0?= =?us-ascii?Q?epno5AYefVVuyT9zUrg=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f55c1ed-cdbc-4b67-b964-08dac517904c X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2022 01:37:02.1588 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PGBohG9w51h8Avb56UtoeRkWgtHHAgAb1wToREPwVzO67l7YvoVVU6E81YWi1yslw1ypwQBpiJQVAlUblzZ4Uw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7067 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Yes Mike, we can merge the patch 1/2 for the line in 80 columns topic. Not = sure if Uncrustify is smart enough to correct the existing code that have t= he line with column > 80, especially for the postfix comment that makes the= line has > 80 columns. Or we just leave the code there. But for the patch 2/2: The multi line function (https://edk2.groups.io/g/de= vel/topic/30907266#13206), there is no conclusion yet however I think we ca= n fix it in CCS v2.3. My reply is here: https://edk2.groups.io/g/devel/message/96324 Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > D Kinney via groups.io > Sent: Tuesday, November 8, 2022 1:07 AM > To: Chang, Abner ; devel@edk2.groups.io; > Michael Kubacki ; Kinney, Michael D > > Cc: Wee, Sing ; Rebecca Cran > ; lersek@redhat.com; heyi.guo@linaro.org > Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification] Create > release/2.30 branch >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > Hi Abner, >=20 > Thanks for the review. I agree we should try to get a few more of these > resolved for Version 2.3. >=20 > +Michael Kubacki for Uncrustify configuration settings discussion on the > +column width > and args per line in function call topics. We need to know what the curre= nt > Uncrustify configuration settings for these 2 topics. It would be better = of the > spec and the Uncrustify settings were aligned and for any changes going > forward they are made to the spec and Uncrustify settings at the same tim= e. >=20 > Details of these 2 topics are as follows: >=20 > * TianoCore BZ links: >=20 > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugz > illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D713&data=3D05%7C01%7Cab > ner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e28499%7C3dd8961 > fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CUnkno > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DD69iyxD8b723VL > 9I2okQHPr%2FTILymNgLR1%2BC9zdeKXE%3D&reserved=3D0 - Update > EDK II C Coding standard to state a stronger preference for 80 column lin= e > widths >=20 > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugz > illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D714&data=3D05%7C01%7Cab > ner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e28499%7C3dd8961 > fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CUnkno > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DiytS8GVsHwWl8 > oLHM4C0IKemmVp5Y9qyPrcGD5kehRw%3D&reserved=3D0 - Update EDK > II C Coding Standards to allow multiple arguments per line in a function = call >=20 > * The patch emails and discussions are in groups.io: >=20 > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk > 2.groups.io%2Fg%2Fdevel%2Fmessage%2F13204&data=3D05%7C01%7Cab > ner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e28499%7C3dd8961 > fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CUnkno > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D8wsQDvWYYEag > M3u8zHTGiladwgosQ%2BUAyQVByqnqstU%3D&reserved=3D0 >=20 > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk > 2.groups.io%2Fg%2Fdevel%2Fmessage%2F13205&data=3D05%7C01%7Cab > ner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e28499%7C3dd8961 > fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CUnkno > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3Dqg06y6ulcsV67iiT > VLO081VAm2mFw0CA49djt3SmwxQ%3D&reserved=3D0 > Leif provide a Reviewed-by: > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk > 2.groups.io%2Fg%2Fdevel%2Fmessage%2F13228&data=3D05%7C01%7Cab > ner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e28499%7C3dd8961 > fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CUnkno > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DPwYZPFfScXiZcX > akiqSM%2BEGoIY2ay8KyVPQ0cYkf8h8%3D&reserved=3D0 >=20 > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk > 2.groups.io%2Fg%2Fdevel%2Fmessage%2F13206&data=3D05%7C01%7Cab > ner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e28499%7C3dd8961 > fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CUnkno > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DbPuRMrDPRm2 > %2Fr3ahPJ8tsb78xQ1QowIbKGb2Nj3A5ME%3D&reserved=3D0 > There is a good discussion of this change with no Rb. >=20 > * The links to the formatted versions of the reviews are no longer workin= g, > but they can be view on GitHub in the branch Laszlo provided and select= the > "Display the rich diff" view of the markdown changes: >=20 > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith > ub.com%2Flersek%2Fedk2- > CCodingStandardsSpecification%2Fcommit%2F2c5534a24b15616fdaa0247885 > 8ed1d8908dc653&data=3D05%7C01%7Cabner.chang%40amd.com%7Cc310 > 1043683346dc8bac08dac0e28499%7C3dd8961fe4884e608e11a82d994e183d% > 7C0%7C0%7C638034376370079115%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi > MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300 > 0%7C%7C%7C&sdata=3Dw8LngdyWH5fu1dhszkdgMmkWBkXq3tF9nvgN0z > SYqVw%3D&reserved=3D0 >=20 > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith > ub.com%2Flersek%2Fedk2- > CCodingStandardsSpecification%2Fcommit%2Fe3797dc48316052005cefa2624 > 6ab2fd32641881&data=3D05%7C01%7Cabner.chang%40amd.com%7Cc310 > 1043683346dc8bac08dac0e28499%7C3dd8961fe4884e608e11a82d994e183d% > 7C0%7C0%7C638034376370079115%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi > MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300 > 0%7C%7C%7C&sdata=3DRUnEumRPpYd7%2Fl9ENVu6g7KeyscFZnMjN%2B > Zeb7S9b9E%3D&reserved=3D0 >=20 > Best regards, >=20 > Mike >=20 > > -----Original Message----- > > From: Chang, Abner > > Sent: Monday, November 7, 2022 6:18 AM > > To: Kinney, Michael D ; > > devel@edk2.groups.io > > Cc: Wee, Sing ; Rebecca Cran > > ; lersek@redhat.com; heyi.guo@linaro.org > > Subject: RE: [edk2-devel] [edk2-CCodingStandardsSpecification] Create > > release/2.30 branch > > > > [AMD Official Use Only - General] > > > > Hi Mike, > > You probably missed this email. I checked the below C coding standard s= pec > related BZ and had some comments in line below. > > > > > -----Original Message----- > > > From: Chang, Abner > > > Sent: Saturday, October 29, 2022 11:33 AM > > > To: Kinney, Michael D ; > > > devel@edk2.groups.io > > > Subject: RE: [edk2-devel] [edk2-CCodingStandardsSpecification] > > > Create > > > release/2.30 branch > > > > > > [AMD Official Use Only - General] > > > > > > Hi Mike, > > > Below are the tickets pulled out from BZ, is there any one you think > > > is not necessary now? > > > Abner > > > > > > 713 EDK2 Document michael.d.kinney@intel.com CONF -= -- > > > Update EDK II C Coding standard to state a stronger preference > > > for 80 column line widths 2021-07-27 > > Seems no conclusion from the discussion in BZ. > > > > > 1766 EDK2 Document michael.d.kinney@intel.com C= ONF --- > > > Remove use of STATIC macros from EDK II C Coding Standard > > > Specification 2020-12-09 > > No conclusion yet. > > > > > 1698 EDK2 Document michael.d.kinney@intel.com C= ONF --- > > > Spurious rule about comment style in CCS 6.2.3 2021-07-27 > > Had we addressed this issue on the coding standard spec yet? If not, we > can fix this in the version 2.3. > > > > > 714 EDK2 Document michael.d.kinney@intel.com CONF -= -- > > > Update EDK II C Coding Standards to allow multiple arguments per > > > line in a function call 2021-07-27 > > Have these patches been reviewed? > > [edk2] [edk2-CCodingStandardsSpecification PATCH 0/2] improvements > > related to line wrapping [edk2] [edk2-CCodingStandardsSpecification > > PATCH 1/2] Source Files / General Rules: limit line lengths to 80 > > columns [edk2] [edk2-CCodingStandardsSpecification PATCH 2/2] Source > > Files / Spacing / Multi-line func. calls: allow condensed arguments > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fmid. > m > > ail-archive.com%2F20170811164851.9466-1- > lersek%40redhat.com&data=3D0 > > > 5%7C01%7Cabner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e284 > 99%7C3d > > > d8961fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CU > nknown% > > > 7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haW > wiLCJX > > > VCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DRtbRn2cTrhwUvlFxjWP7bEg > o7gnGR8R9v > > EKSe65RXEg%3D&reserved=3D0 > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fmid. > m > > ail-archive.com%2F20170811164851.9466-2- > lersek%40redhat.com&data=3D0 > > > 5%7C01%7Cabner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e284 > 99%7C3d > > > d8961fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CU > nknown% > > > 7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haW > wiLCJX > > > VCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3Dq7qLZjyr6IUpYtNraPlZKQJvB > ekm11v%2 > > FkJbztxA76eI%3D&reserved=3D0 > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fmid. > m > > ail-archive.com%2F20170811164851.9466-3- > lersek%40redhat.com&data=3D0 > > > 5%7C01%7Cabner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e284 > 99%7C3d > > > d8961fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CU > nknown% > > > 7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haW > wiLCJX > > > VCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DM0sZmbstyxn7iWay996bjUJ > maBqblRFNr > > 52P6JCOOhk%3D&reserved=3D0 > > > > > 2664 EDK2 Document michael.d.kinney@intel.com C= ONF --- > > > Discrepancies/inconsistencies in coding standards, style and > > > examples 2021-10-02 > > I think we can fix the above inconsistent issues in the version 2.3 rel= ease. > > > > Thanks > > Abner > > > > > > > > > -----Original Message----- > > > > From: Kinney, Michael D > > > > Sent: Friday, October 28, 2022 11:22 PM > > > > To: devel@edk2.groups.io; Chang, Abner ; > > > Kinney, > > > > Michael D > > > > Subject: RE: [edk2-devel] [edk2-CCodingStandardsSpecification] > > > > Create > > > > release/2.30 branch > > > > > > > > Caution: This message originated from an External Source. Use > > > > proper caution when opening attachments, clicking links, or respond= ing. > > > > > > > > > > > > Hi Abner, > > > > > > > > Have you reviewed the open BZs against the EDK II C Coding Standard= . > > > > > > > > Are there any other issues that are considered important to fix > > > > before making a new official release? > > > > > > > > Thanks, > > > > > > > > Mike > > > > > > > > > -----Original Message----- > > > > > From: devel@edk2.groups.io On Behalf Of > > > > > Chang, Abner via groups.io > > > > > Sent: Thursday, October 27, 2022 9:54 AM > > > > > To: devel@edk2.groups.io > > > > > Cc: Abner Chang > > > > > Subject: [edk2-devel] [edk2-CCodingStandardsSpecification] > > > > > Create > > > > > release/2.30 branch > > > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > Signed-off-by: Abner Chang > > > > > --- > > > > > book.json | 3 +-- > > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > > > diff --git a/book.json b/book.json index d112b26..1fdd570 100644 > > > > > --- a/book.json > > > > > +++ b/book.json > > > > > @@ -1,8 +1,7 @@ > > > > > { > > > > > > > > > > "variables" : { > > > > > > > > > > - "draft" : "yes", > > > > > > > > > > "title" : "EDK II C Coding Standards Specification", > > > > > > > > > > - "version" : "Revision 2.2" > > > > > > > > > > + "version" : "Revision 2.3" > > > > > > > > > > }, > > > > > > > > > > "plugins": ["puml-aleung"], > > > > > > > > > > "pluginsConfig": {} > > > > > > > > > > -- > > > > > 2.37.1.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > >=20 >=20 >=20 >=20