From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 32FA0D801D3 for ; Wed, 13 Dec 2023 11:09:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QCIo5qSoHWCj45axGljephZC/38q+e108PpV1wR/YCg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702465746; v=1; b=wsRYuK9SJhV2UnbAB2zyrPx70ezJnchT5w52DJpdP/J4H+8ftV3pHUQaAVIMToRrp+D4lOUC holL0K+x7dJiVj7LrOwuyJmoNhP0zv1IENYMH1WgP0kqQybZohnb2w2gNqRnfA29Xg+/yKGo1xL We76m3AlwE9qZObd77qctfCk= X-Received: by 127.0.0.2 with SMTP id m5FEYY7687511xCo0ZsHa27X; Wed, 13 Dec 2023 03:09:06 -0800 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.70]) by mx.groups.io with SMTP id smtpd.web11.33330.1702465746034778500 for ; Wed, 13 Dec 2023 03:09:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HG1gg9hel5kBs0Zr5KUZ3iEPlu1qjdDlQcGV1v4BoCWZtAqUYZcVYW23pC41864DYF5ewO3f9BDvaYOQwTVPbjcV0YvMp1qrJPI15TzSwfP+v20DBCxBrWnCS8AzEwvZ06cjie5TKDgX9SFoNpJMabT2whImii8BmwT2BMf/x1Rr5+kda1LLnlgm7wEW6AfEeOD3PXFKnuFY04KMd6T6icBZf8AQLEJFH1VefFA35pLEOEaKhsReLQ18ai9XYHnBy2oiTkyXw1antX2vpvU1wGjkFLpLsZk7PhksG2XK6R6lnTK6EkluPYrMCGBKe4/qDnKhPrIRtLRQBLim/Kdl2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a0zYuaf3To47YCDTC2JFr40nxLmdyZNh4yJ4ToQPTrY=; b=LGL6bf9hHabEZizuwXexgLw9MHNIZJz1JYGb9sTJn8weLqNpIPj6LyZH/WBhwKvB1pYireyaT6fSw1BX484C/VEnaStGeunWiAPHnJVJcQ5mLTyEuh3rUVLLpUguBQe2260DuxG5dULJCHmltB7l1u9NKA8LZJUmqpOdHxAqYFN/fdLKmdpZ6fSrsO0bgIB0qapvpLXPsXDh/5Wfeu8o08vsxJineU5rV1QG+f3XUSyi6y/eMg5elBW8G5Jg8erqtMHYFr9EGkh8imEf4qELDD/m5btEv+2DblijbD3cjvanzFtqI/A6x0qijtMLA2NxJT4uS8CkIMWTIXIqCspPtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DS0PR12MB7560.namprd12.prod.outlook.com (2603:10b6:8:133::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.33; Wed, 13 Dec 2023 11:09:03 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7068.033; Wed, 13 Dec 2023 11:09:03 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: Nickle Wang , Igor Kulchytskyy Subject: Re: [edk2-devel] [RFC PATCH] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses Thread-Topic: [RFC PATCH] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses Thread-Index: AQHaKRCypQt3GSkevUyn941nt5DXD7CnFpkQ Date: Wed, 13 Dec 2023 11:09:03 +0000 Message-ID: References: <20231207132419.6107-1-mike.maslenkin@gmail.com> In-Reply-To: <20231207132419.6107-1-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=76438a8e-23d6-45b2-a984-48b49a47e84e;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-12-13T11:06:04Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DS0PR12MB7560:EE_ x-ms-office365-filtering-correlation-id: fa28d0a8-8855-4095-d156-08dbfbcbea87 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: K6dcwnhIVa8pnkBNyCj9KKY2qrlDCNoO8frA6FG/LesWFMF/pCqFZeNtkBHL8/1bgsb6AO1XRIvZ0FzMjnTj/nT8oDdTUcnjeSuyCmBNhDvl1/tcxsThonX7isLb0iK1CrzoB5LeOtBT3zF/hU6TnvsLm8PbOWMIFX7ljciAl6p7MXUEFO55Nr2u4uOtA8ncl8uJx/rUm+ZKUWNVu2caCQU6HSgz2ET4wGErdyxNZHpv8SR/EAi/12BIn5Vqef/5Grf+imBDlodJ516/Q3Zms8ktwpUw15OL1Vl8zZOWSQw9AszPu/smWWH8oy4XPqybqgXdtWel/8hC2ZTvPGNUXb0NctgD/HpjfqFRMkKKsLLphVccBdUTjOAOmX9lgJMZnT9y7LcUlKKJZmAxJ4YIq0XpRQsG39h/37oUi9iClsS/9NRY+dH9TeT8OfcBjNtNGD3a1gmldZodZFPavxJ1ibz1eWrRsLwmq0RbBIbOCoGOUtH6HNOSLKHuiqkFrT3x+dXB3ksvCQu2GOx1qLIrrg34TMSCg157bmiFjc7S14uYl33/RZqcVF8QzijShgyEzkwQciZKU7jk+EGifwlKltUU6RyMn5M98xFxZuLmeUex1qfkuuatmxJEk7yi4v6n+VoVNnZeJcGfAbxkeMpqD3gp6IVvwIq+e0TuTRC9SmA= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MoEp6nrWY5DlbvMHPQwJiEkUO+mjx8xCXr3Iyr6rXgwevNcS8fA1tFRb+iBf?= =?us-ascii?Q?ok8IV2mQniqd8IJCF69uBOP5i9MBDDGCv+XwCDWaWd7k5v7+hZTjuxunUTGz?= =?us-ascii?Q?OyC2U0mazopiJFZSyIwkx+DaClEdUgTN0hsH8qx85T/xvv/9Ljo466S8nKll?= =?us-ascii?Q?T2Z44b+dUNpW1rpQGxIG4cXIcZbk1KgQ/KZyNrFJpKItePttW4Zfdy/z1RCx?= =?us-ascii?Q?b4bIFWJbH/RexhHT0rqL+CMo5RSD+TVDymGdzN5xKfR4VbWwFahcczXVw5xy?= =?us-ascii?Q?Fw3TR28ymVt7OtDoqEDcDw+oI0v7lyjfctrOIGEaWO8uKqE+RN1zCK80Qdwl?= =?us-ascii?Q?f8ZeuEEDZW37CRWUbNV4DfSjjn6XfU/CfSTOjCpKfQjHcESN2CWiPQDBTH0X?= =?us-ascii?Q?xE2m91TNWHQeWt7uMePzDjBEcykxx9PKPyf69Zz2N0WgmL1ayEU9JrASDxEI?= =?us-ascii?Q?R8wRyhXfWjM3OoZ8M6/lO6n2JYbrl+SiTh9l2Q+igc0oounDjckQvYkg2h6/?= =?us-ascii?Q?zhgG7CsEIURK7w2SOXcU8ZoRSGRSfq6S/x1GjE6Mv54SD8nFEKPSNBsD8ber?= =?us-ascii?Q?dUxmfKP2Rjde3cup9iOfgKu2TFmw29fRQB6Yrema7IKdKnaITjRoiaDoOrVo?= =?us-ascii?Q?OuQO2r+Y9Le9kPK6qGI9dog7aNd/LK77wsyRqAwyEcMajw3RrX4mLWSYaut1?= =?us-ascii?Q?uDL0FHHdi/BkVeeT/Bae29s/myCxRqx79eKGytVRmowAaVJTDGq9+uMpn55F?= =?us-ascii?Q?bU8l+7TxYrCCJfynWsCKB6W0YbUz3z6ukdj0xUBdlrC9dO8cwvh0lBG5ECV8?= =?us-ascii?Q?4mCSNArw6J38a++TNHJAol5mzjL2C7B+1NE+kLnr9jrbEcS/e5Rx6P5alPsK?= =?us-ascii?Q?r41go2xEWrvTJGIgbxAAQwpTHZrt6PSYqwTE4fUT2z98KIvAD9NGz9z8ohjZ?= =?us-ascii?Q?5BDs0ZcLTtLi54U9IOHi6R88Y0Z3tqzsYYjB/SKCTQ3IiWRRdjXblHxMmL8z?= =?us-ascii?Q?eW3WDg+gbfIfFJFQpFZsl6AJYXh0Litdwzb5uZPoI2BWh6yMcg89H+nX4zqk?= =?us-ascii?Q?KV/oFKiqJa6AOnkWPxSP/uaUs4AnNYTOqqeObvZFNpti22Ynm+xox6VrsKH3?= =?us-ascii?Q?GtKCJ0yMO7YOTT4muIIAbt5ohSsY5vM3HDxkAzIwckOSrEZo4GPk5SWdf0MA?= =?us-ascii?Q?pVR6wxHwv340qSnE/nbeBGEOV4k46tY1FAZlu9B6XHzA5aRHhyGHtz7LStPi?= =?us-ascii?Q?JjIRWSC4E07kjWuzsvAhnMxodd8t88ZaPvISRWzYxfzHzzzb49edRAQzY0F6?= =?us-ascii?Q?gGD57sjqNZw8jmEIQj+wxYv0br46IiXKEhbBjHp44wEq0wAg5t4UXg+tsCUT?= =?us-ascii?Q?GOet7wL2LZlHMY+4/NnkOu6ac1xDK/lzKcC4WKkG5ktmdad4ziOMHxTCaAb5?= =?us-ascii?Q?obWq/dIW5m+YoZDSCwGMJ8Wv3hsWlqE8WzZBEjKNMz/f/ttB41E+2XWomZYq?= =?us-ascii?Q?iORBmbQFI1NnBDHAPCbKv8Qo2or66vXax7PYhhCFfqungEOVYxyJ2tludJnH?= =?us-ascii?Q?WzsQzco2GGwPwktE4Oc=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa28d0a8-8855-4095-d156-08dbfbcbea87 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2023 11:09:03.4470 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bYJyZ0TU8E8JNrjCrKgnAC+rU1T7ojlsK9s0Sd9MjGAQeNnNUMBqG6jkzIp18ORxilIRb4z3k40YB7CrHtXgKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7560 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: JxQnxJduMv5FeKmSWqQfcqPNx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=wsRYuK9S; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] > -----Original Message----- > From: Mike Maslenkin > Sent: Thursday, December 7, 2023 9:24 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Nickle Wang > ; Igor Kulchytskyy > Subject: [RFC PATCH] RedfishPkg: RedfishDiscoverDxe: add [] brackets to U= RI > for IPv6 addresses > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > URI is generated based on the RedfishLocation containing an ASCII string > representing the IP address. So, in the case of IPv4 the canonical > representation of an IPv4 address was inserted into the resulting Unicode > string i.e: "http{,s}://X.X.X.X/". > > In the case of IPv6, to access resources, the IP address must be specifie= d > in brackets, i.e. the resulting string should look like: > "http{,s}://[X::X:X:X:X]/". > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 20 ++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > index 28ba2d3a9fca..49c96bd28b27 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > @@ -863,9 +863,23 @@ AddAndSignalNewRedfishService ( > } > > > > if (RedfishLocation !=3D NULL) { > > - DiscoveredInstance->Information.Location =3D (CHAR16 *)AllocatePoo= l > (AsciiStrSize ((const CHAR8 *)RedfishLocation) * sizeof (CHAR16)); > > - AsciiStrToUnicodeStrS ((const CHAR8 *)RedfishLocation, > DiscoveredInstance->Information.Location, AsciiStrSize ((const CHAR8 > *)RedfishLocation) * sizeof (CHAR16)); > > - DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s.\n", > DiscoveredInstance->Information.Location)); > > + UINTN AllocSize; > > + CONST CHAR8 *IpAddress; Please move the local variable declarations at the beginning of this functi= on. All others look good to me. Thanks Abner > > + > > + IpAddress =3D (CONST CHAR8 *)RedfishLocation; > > + AllocSize =3D AsciiStrSize (IpAddress) * sizeof (CHAR16); > > + > > + if (CheckIsIpVersion6 (NetworkInterface)) { > > + AllocSize +=3D 2 * sizeof (CHAR16); // take into account '[' and= ']' > > + > > + DiscoveredInstance->Information.Location =3D (CHAR16 *)AllocateP= ool > (AllocSize); > > + UnicodeSPrintAsciiFormat (DiscoveredInstance->Information.Locati= on, > AllocSize, "[%a]", IpAddress); > > + } else { > > + DiscoveredInstance->Information.Location =3D (CHAR16 *)AllocateP= ool > (AllocSize); > > + AsciiStrToUnicodeStrS (IpAddress, DiscoveredInstance- > >Information.Location, AllocSize); > > + } > > + > > + DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s\n", > DiscoveredInstance->Information.Location)); > > } > > > > if (Uuid !=3D NULL) { > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112470): https://edk2.groups.io/g/devel/message/112470 Mute This Topic: https://groups.io/mt/103033764/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-