public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chang, Abner" <abner.chang@amd.com>
To: Mike Maslenkin <mike.maslenkin@gmail.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "nicklew@nvidia.com" <nicklew@nvidia.com>,
	"igork@ami.com" <igork@ami.com>
Subject: Re: [PATCH] RedfishPkg: Fix SortLib library class name typo.
Date: Sat, 1 Jul 2023 03:22:51 +0000	[thread overview]
Message-ID: <MN2PR12MB39666DE266E3C5CD51906302EA2BA@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <MN2PR12MB3966172DE0E54B10C96B8FE3EA27A@MN2PR12MB3966.namprd12.prod.outlook.com>

[AMD Official Use Only - General]

Hi Mike,
The changes for both RedfishPkg and RedfishClinetPkg were merged. Thanks to your contribution.
Abner

> -----Original Message-----
> From: Chang, Abner
> Sent: Tuesday, June 27, 2023 8:05 AM
> To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> Cc: nicklew@nvidia.com; igork@ami.com
> Subject: RE: [PATCH] RedfishPkg: Fix SortLib library class name typo.
>
> Hi Mike, could you please create a PR for this change? Then I can merge it once
> the change passed CI.
>
> Thanks
> Abner
>
> > -----Original Message-----
> > From: Chang, Abner
> > Sent: Wednesday, June 21, 2023 8:26 AM
> > To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> > Cc: nicklew@nvidia.com; igork@ami.com
> > Subject: RE: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> >
> > Reviewed-by: Abner Chang <abner.chang@amd.com>
> >
> > > -----Original Message-----
> > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Sent: Wednesday, June 21, 2023 5:30 AM
> > > To: devel@edk2.groups.io
> > > Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> > > igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Subject: [PATCH] RedfishPkg: Fix SortLib library class name typo.
> > >
> > > Caution: This message originated from an External Source. Use proper
> > caution
> > > when opening attachments, clicking links, or responding.
> > >
> > >
> > > BaseSortLib is the library instance name not the class name.
> > >
> > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > ---
> > >  RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf | 2 +-
> > >  RedfishPkg/RedfishLibs.dsc.inc                            | 2 +-
> > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > index 5c1c7cffa650..6ff5dba75c30 100644
> > > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > > @@ -25,7 +25,7 @@
> > >
> > >
> > >  [LibraryClasses]
> > >
> > >    BaseLib
> > >
> > > -  BaseSortLib
> > >
> > > +  SortLib
> > >
> > >    DebugLib
> > >
> > >    MemoryAllocationLib
> > >
> > >    UefiRuntimeServicesTableLib
> > >
> > > diff --git a/RedfishPkg/RedfishLibs.dsc.inc
> b/RedfishPkg/RedfishLibs.dsc.inc
> > > index 6e497899b556..03b7ef6f3289 100644
> > > --- a/RedfishPkg/RedfishLibs.dsc.inc
> > > +++ b/RedfishPkg/RedfishLibs.dsc.inc
> > > @@ -14,7 +14,7 @@
> > >  !if $(REDFISH_ENABLE) == TRUE
> > >
> > >    RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf
> > >
> > >    Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> > >
> > > -  BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> > >
> > > +  SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
> > >
> > >    RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
> > >
> > >    JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf
> > >
> > >    RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf
> > >
> > > --
> > > 2.32.0 (Apple Git-132)


      parent reply	other threads:[~2023-07-01  3:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20 21:29 [PATCH] RedfishPkg: Fix SortLib library class name typo Mike Maslenkin
2023-06-21  0:25 ` Chang, Abner
2023-06-27  0:05   ` Chang, Abner
2023-06-29 22:43     ` Mike Maslenkin
2023-06-30  2:13       ` Chang, Abner
2023-06-30  9:04         ` Mike Maslenkin
2023-06-30 16:15           ` Chang, Abner
2023-07-01  3:22     ` Chang, Abner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR12MB39666DE266E3C5CD51906302EA2BA@MN2PR12MB3966.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox