From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (NAM04-BN8-obe.outbound.protection.outlook.com [40.107.100.47]) by mx.groups.io with SMTP id smtpd.web10.1339.1688181776066113179 for ; Fri, 30 Jun 2023 20:22:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=xGfRgHr+; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.100.47, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oQpKOql8GYlgqLF+B1/7vCRNyG6FxQIW1ulOTaSD1FjW5i6K7modMlJPycmhB6LOtnv1rly0eRc8xUYJHn59VqPlDJiVlBbZUc/2yYQ4usSEFD5wyaHXCSuLjGWNowrzh6gqZek9tP5OswR6TxIXbmVq4+5LeUKKT95DlS0W/Xaq/sS8FRnD4h20LAqvTg3JRRfkCRu1PUVDZ5zJT35U9zwtQaZ89/5DZhz1+1qH3w8cfd5u7pq0d3xwyJzrAEHYKnHIkTM0qi3C9Fyy+7VZICgjcAo4qq//Wl8+PaZ9fJiYELXWQW/RMOfHbYt60XRaWhYoRD/fsFwcJC7tqethrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=19XAC/VHU4R6RybbH75z0OBiwLUZviiqp8r8B6Dhohs=; b=ochzyL0x9ppSjaCFtWhrFUMfbf9X5NWL8povVZi8PE9iq8awHuGZ4CwoXIEzXlB6mnz6JoxMkDcirUSkgyEcJhDSYP7aU0FTnNL45KFIWBzFPWwv8N0ggcE+Np6bG8tNUk7Y4tZ9N53X+JBWhoX5AjU9O53oBcwvpxCu7ASU8bPcbsrBeE1W1zil6PxO35tOId3BlycRCxER6jF5yvqwR65v6EBvgPRTIZggxV1F6d3ZBbs2F/iGH6CABbkpoLALNlxwILNhyB8JWGFlXCVBkeWQayq71K+IubWOPEwk5XSBxLIa1s+9vc4f0ek5n7u0zmZxQ+ppFhPPimwKMj8K4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=19XAC/VHU4R6RybbH75z0OBiwLUZviiqp8r8B6Dhohs=; b=xGfRgHr+iq6IQksFsFxjgWekJzkTiJHHkBUc0z35tbCxai/ssNyvBcQk8f269qC5rWY228MB7Fqu0DoaiFcI1xpyQQLUMrCoiFSqEOQUzjWNWRw+D7DaZB9p6kPVqJPnegTd4EeKilVGsh6RoNXCkLajTQH3FH89hPS2sVwnqEY= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SA3PR12MB7829.namprd12.prod.outlook.com (2603:10b6:806:316::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Sat, 1 Jul 2023 03:22:52 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040%6]) with mapi id 15.20.6544.019; Sat, 1 Jul 2023 03:22:51 +0000 From: "Chang, Abner" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [PATCH] RedfishPkg: Fix SortLib library class name typo. Thread-Topic: [PATCH] RedfishPkg: Fix SortLib library class name typo. Thread-Index: AQHZo750VIBXLxWHvkykcJJ/kxJwSa+UZkcggAloNDCABoBn4A== Date: Sat, 1 Jul 2023 03:22:51 +0000 Message-ID: References: <20230620212950.28118-1-mike.maslenkin@gmail.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=bbf189bf-1c31-4cb9-8f91-ad8324677995;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-06-21T00:25:29Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SA3PR12MB7829:EE_ x-ms-office365-filtering-correlation-id: be2ae8ff-f86f-464f-f92c-08db79e273d5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3xsl0BJshQhEH5HrZjEi7ELsAulbOQ35uid0sKxkodRmiuN6AljTdAV73Hu7wSfZCZcCzb0f6roozU9cKRqhtajhn379Rsbwfk78wcdCXKL+sQtaS/4hHpna+pGiKXUZwTE7F4K8a15KgZn/3uH1jhs6JgOHOIM+TOxbg9+s8vBhnUzhAcZop6ngf6azw27MSPJnEahakCvFha0q+gCOUq/9EyzyxIuW5/+U7fbuCQObTpoKoNKSfR7WDKUS1YhtUWst/SNrG4uO8nbdv7zBiYdssFFrPG0anciB9kPPN9NO4jgSHeNpEMoKv4270zQ6W5Mqm2hl825VsGITqzgLiOI1WqzbEYlzPnl6hZUcRpJKew2ZGCQcyTaDFMHRr8FR/89BpVJ/XeClrvBrMFHVyHdKu/oKGgXFsYLYkXeJRS2JqN1tsOWGUG/GdLU/sgIg58RUylvS384fQ4xdQVR7Ho9VUfkXgVHQFp8IrqgDWCRhmtD7sKqN7MBq5VweUOJwk0Aok7Xsg/X5WBo5Uc+CTc5NXEFgZb/E6CYazybxvLWk9AQRD4XvXGxlM08VBmTmrbt3KCs2NYZ3dDXFWSz/2rC37MtVNJ5g3UmLQySBMupzwaDnj1DEWv1Xx1IU9tnu x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(376002)(136003)(366004)(39860400002)(451199021)(4326008)(66476007)(66556008)(38070700005)(478600001)(6506007)(83380400001)(7696005)(110136005)(54906003)(71200400001)(53546011)(9686003)(186003)(2906002)(66946007)(76116006)(55016003)(316002)(8676002)(38100700002)(52536014)(64756008)(5660300002)(8936002)(122000001)(86362001)(33656002)(41300700001)(66446008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?w9c6/S+F8PVaDKIe731uUrVJdrzb6P7BBf6GqvdtmyaWzLTNgnRRenf2zSVh?= =?us-ascii?Q?41U5uvdxxZSZG7LpLihI7oDRanvkJUGSXl1vGJF3GzN+FUUf30U2hxJhbu31?= =?us-ascii?Q?Upm/Nc5N7OU+lFjUppE7donNXP+foQ8dzfeBY2qVCHhNF/Z/1KrPRp0IKZbR?= =?us-ascii?Q?pGUvGQ+1d8j65Fn+v+837uT4epnTximBu/nxfrXGsf7iNCut2u+PPGrPbKoz?= =?us-ascii?Q?2ki5RNzYgCpeU2FbX4/28yVIff9bV6B+5IjO54rCYEa16JaU+mcFdD7GEEXd?= =?us-ascii?Q?QH/74IySZH6CEdPa4G9XVl/4Bwz/uwm1FjRJwKzGdKN+JtzeySXXm1tHpIxw?= =?us-ascii?Q?hvUVhhvZFFxf2CU9Ej0VuKOWv5p7+bJbw5M0ZZXpZFeARmfXxpodKuFhygRD?= =?us-ascii?Q?bpi0A0IS4hUF14ZMkB4g+ql7POwfSWg5p43jlVZkWiBS6zmTND8qPAAO19OA?= =?us-ascii?Q?5zYxLUlkgZLMHRsrfBFQ7MKgUVHdO4xKbBNg9w6/4Ki1suh5xUtd9rUCbZAk?= =?us-ascii?Q?mfDHs4o85g5cQASDgZoupoD7mn/nwHQQ/9SWb/p0S/WguRIrD6FMKkBzHMis?= =?us-ascii?Q?ED+Zbwv7+c/axdT8Qde2IDNOqRldVapfw+xPOHED1AVg+vasNIg/rxGRiWOK?= =?us-ascii?Q?oQcDQJm82r2bPrpMxP+IzzDHLNagL7kUYr5vGCFDC1NGyrazTvI227EE2vtE?= =?us-ascii?Q?WjbBGIXDL8J5d+O4bKZhteWLZ2S0E+fNm+6OLGXJ8/8pV8xikY/PmOUnV3r6?= =?us-ascii?Q?zg2RodfWczHahK1DjOdr2DVkyK8gsh0ltRGHk+Sej36WlJPo3nZkvRcZRWs5?= =?us-ascii?Q?lGsQjaoOznULiNEIqO8Lm5XTOCFTMd+/OR0gAeOdfA66NomnCuLcnMT2MBK3?= =?us-ascii?Q?MZS3kZUEduS9SZvkbr8M4vZStdLYY7SOfC7SI/a2K0d41YETVRFozXxTiLWx?= =?us-ascii?Q?OcOZ2jp9OKzij9Bm1KT/4FOFUqckdJycbdGszw8jNCG5iCGKPp30puQn+cPX?= =?us-ascii?Q?XKhEYXq9GlvSnW20dPSHQ/ftWoLf1Y61x+7qtqmwz1TfJXc2/gZxkeMcazt1?= =?us-ascii?Q?zV8vBaPSuwM6gGqgUKACjoPqZ8Uikv+L4RHrLIvhxKZNE99wshrVWdBozdsB?= =?us-ascii?Q?f19Knwgfni5cm2IJeXs8Udax6A1W//9xoIzWmNVkHSVWk+AKmz1K0N6jcN2B?= =?us-ascii?Q?0PCzZdZUI4FeelFTlx68ypl4z7FWd5j23yeLdoHFNkQ+V8LvqZfar1jokKnX?= =?us-ascii?Q?bLeWAU8bFRRpPOXWO52FW9etpaJdvsQEq7WXgrSb8K8V7E8C9crdrsMRt5tt?= =?us-ascii?Q?+OeL4/+ij5LXeTbgWb3YM2f1UUMTagXN15b/tRdZPd+awNTj7TCW/Jtar/iS?= =?us-ascii?Q?mz7BmJVNUWQv9+syWC4hHreUv5S7XrEKIMn6y8g/I4eO62LbDBtvyRZ1+mV+?= =?us-ascii?Q?mtsvIYkszdzIirzDE4OTmH/g+V0DBJB2yej6aj1SITNBnoDJQjl08w7J/pGe?= =?us-ascii?Q?LeQxvEMDoMRV14dpTKGdeKznPPRfiTz67XTa/Hc8/Pk6LEnSaZXW5CMgyw?= =?us-ascii?Q?=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be2ae8ff-f86f-464f-f92c-08db79e273d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2023 03:22:51.5863 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wlGL2HlJS0dGGRarEJM6HGA7473lsSpmqJ8mh30XouqSK7Ywrndtjx58PY/A5kbjdaPCTEYIcWtdrJZ23b0eQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7829 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Mike, The changes for both RedfishPkg and RedfishClinetPkg were merged. Thanks to= your contribution. Abner > -----Original Message----- > From: Chang, Abner > Sent: Tuesday, June 27, 2023 8:05 AM > To: Mike Maslenkin ; devel@edk2.groups.io > Cc: nicklew@nvidia.com; igork@ami.com > Subject: RE: [PATCH] RedfishPkg: Fix SortLib library class name typo. > > Hi Mike, could you please create a PR for this change? Then I can merge i= t once > the change passed CI. > > Thanks > Abner > > > -----Original Message----- > > From: Chang, Abner > > Sent: Wednesday, June 21, 2023 8:26 AM > > To: Mike Maslenkin ; devel@edk2.groups.io > > Cc: nicklew@nvidia.com; igork@ami.com > > Subject: RE: [PATCH] RedfishPkg: Fix SortLib library class name typo. > > > > Reviewed-by: Abner Chang > > > > > -----Original Message----- > > > From: Mike Maslenkin > > > Sent: Wednesday, June 21, 2023 5:30 AM > > > To: devel@edk2.groups.io > > > Cc: Chang, Abner ; nicklew@nvidia.com; > > > igork@ami.com; Mike Maslenkin > > > Subject: [PATCH] RedfishPkg: Fix SortLib library class name typo. > > > > > > Caution: This message originated from an External Source. Use proper > > caution > > > when opening attachments, clicking links, or responding. > > > > > > > > > BaseSortLib is the library instance name not the class name. > > > > > > Signed-off-by: Mike Maslenkin > > > Cc: Abner Chang > > > Cc: Nickle Wang > > > Cc: Igor Kulchytskyy > > > --- > > > RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf | 2 +- > > > RedfishPkg/RedfishLibs.dsc.inc | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.in= f > > > b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > > index 5c1c7cffa650..6ff5dba75c30 100644 > > > --- a/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > > +++ b/RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf > > > @@ -25,7 +25,7 @@ > > > > > > > > > [LibraryClasses] > > > > > > BaseLib > > > > > > - BaseSortLib > > > > > > + SortLib > > > > > > DebugLib > > > > > > MemoryAllocationLib > > > > > > UefiRuntimeServicesTableLib > > > > > > diff --git a/RedfishPkg/RedfishLibs.dsc.inc > b/RedfishPkg/RedfishLibs.dsc.inc > > > index 6e497899b556..03b7ef6f3289 100644 > > > --- a/RedfishPkg/RedfishLibs.dsc.inc > > > +++ b/RedfishPkg/RedfishLibs.dsc.inc > > > @@ -14,7 +14,7 @@ > > > !if $(REDFISH_ENABLE) =3D=3D TRUE > > > > > > RestExLib|RedfishPkg/Library/DxeRestExLib/DxeRestExLib.inf > > > > > > Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf > > > > > > - BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > > > > > > + SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > > > > > > RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLi= b.inf > > > > > > JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf > > > > > > RedfishLib|RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.inf > > > > > > -- > > > 2.32.0 (Apple Git-132)