From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 33A82AC0864 for ; Tue, 26 Dec 2023 01:17:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DKnlDImI82C+1XgNC4S6ywJSwREoF93d+OqHeeVeYEc=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1703553458; v=1; b=USzPzXbT/ZfzR8qVUBDHgfntkhfpq8wMFr+0VdEAv2A6p7vHxfpEDNY13iuKyn+KcgG2KV9s iqDUSwfPpw8WuUn8UmtG2VvYJr37AaNGwfTNWZMBQTp7SqEvL8O1IvVSQuC2rlkrmjODVjpQYjm +Xs6Ew7qPmf1+PNTuSKZ3Ji8= X-Received: by 127.0.0.2 with SMTP id PvUxYY7687511xBXbKRfBbEd; Mon, 25 Dec 2023 17:17:38 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.52]) by mx.groups.io with SMTP id smtpd.web11.72792.1703553458168564486 for ; Mon, 25 Dec 2023 17:17:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HdY2f87btZfnGDJUDvVwGq0W7T7lu0mvpQ8lkCrs9ucP6TOb0UphB+DNagE9ZLpnwhcSQI4vknjGWnjWWXmY3PquAp4tLwwGvGh9itbq5IHdmU7yxsAktn8cuydUOzqnIlFKxN+Pq0oOlgXIuRSkcpYNbUhZeA1USYoHIXuGszFMDM7z1dTuhjp7eBX9U1w4IAwdwKggF0OcQBDAdwxVH/mueEgVG78PRxq14L5TL1tLg3M44zs7jFbpLYGnJdXEPTtOF167jWOu4TD0nz2tZA/7mKAxcRRqSqcA+38zxUwZys89LTYHYzKbP5NOqOhpEZDpK4sZ0rnWwjK4waf3bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nZSSVDxTgQU8unuPzOTPSZ0VO0fpucjz7o0FMteDb1o=; b=AljWUMBsFkrBy2samOAERmbU5RGGBHSPX5l/cyAzqmlSfDTqFauA+Ibw9BmAckhn1rTJe7YHs//DZSPlrQCnXobVyq37ezi3/mF4BKhrHthlyvB8uaGkEj8tmjGr9+DL1Vjkhr73Ce+t6GKu012EsuYeCVAtpaYkD/pelBAYgMVKD3h6iupFbT5DKxxAM4L9KPFk/7liZbUIIwESzlorsZU1Dd0x0dUDki0mfqlxut8X/cAaSOE25s3bCRnk81jnrI60a8efSkNSAYInfcLjih1mXWPwtRldCnCVGhETn4EG5c8V8rdf/2HEcKG7Q6u4ezDRYceacmZBtF2aJ3FUtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM4PR12MB6134.namprd12.prod.outlook.com (2603:10b6:8:ad::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.27; Tue, 26 Dec 2023 01:17:36 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7113.026; Tue, 26 Dec 2023 01:17:35 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v3 13/16] RedfishDiscoverDxe: add a helper function deallocating string resources. Thread-Topic: [PATCH v3 13/16] RedfishDiscoverDxe: add a helper function deallocating string resources. Thread-Index: AQHaNrzjsJZSd5jwQ0KJsCSuHNWhw7C6xR7A Date: Tue, 26 Dec 2023 01:17:35 +0000 Message-ID: References: <20231224225927.9119-1-mike.maslenkin@gmail.com> <20231224225927.9119-14-mike.maslenkin@gmail.com> In-Reply-To: <20231224225927.9119-14-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=1252beab-35af-47ee-91be-debcf88a0dda;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-12-26T01:17:30Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM4PR12MB6134:EE_ x-ms-office365-filtering-correlation-id: c1b99bc4-f33e-49d4-22a4-08dc05b071b1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: zXwNlHqdNA4/4WB7x15XUTEuiW/zOCYItdHE1NP90q0FQP3ZFWv1XLqv5UnGPnCHePWC45qOgQzkMuqdIIoOrIycpLl5O9x5cDgvSNPtOcgxQsgD3z+9tHdozSHrZAKoPynkKBBSBeH3XBDe5oPDcoNV9Y96tmlcp2/ca6e3Zyzt3LtlHM7nDTrdCRlR6+jSKtUWJo50NTaTKdMzQWe8gf2elqoWjRHHFZaQy1qwJNeI6KaReGTf/LODSKIisElo/t6ZAHYl/0Af5cuZG5D4M81JPXc3Wmer8OkdOjRJXIdFm3FdHedZM7OWgM3F/SRfTMFD+v/teKUKdDc+WLwRXRBkHuqIObbfJAPF9bHwRzoWHLUMroNAWOB6g0TeJwah2dTMaxAvqdEHM+/5/eIhRgVneEXuJl1fE2n0PyC1sG+Syc3VA95KbsL0CecEqFEnFFwyeuUZ1nDy/wMUFL/cGUd+DzKe287UEentMoSKXEXS1MR/fOy1y8zojNCIg7xFh0IS/rWRYnvTv4WbGInvlrgqAMX9uokT82k1rUAky1hej2zw9ERQIMvq+Ta+iOY3XG5JpNHmM8W1NAGLRboY79XAsuTzXWjKY/QSc9ILMcQZ6Ub50uZO/AmZvdMATiNlIMfg3jTMXjrk53pkisjk3rkjDgQqoMStOaFdkm2kNDA= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BfwqXgX8ceH1l1deh73dq01np5vRN0CWpUwE4N+9Az0v5hvkRlX8lSZ0Tlzg?= =?us-ascii?Q?geV2nCI/kpbGbulEGvXoz06ip9MeBLLYIvLAZB1VYbFxY4u0tatjJ3zM8hCn?= =?us-ascii?Q?TX4shDmMS1bf0BwsdiQiCh3q3ySyia/qljaDnGlfPydtbzhdzjSIlgn6GlWR?= =?us-ascii?Q?qb0jtiy+XGW8Jg0lnH7TdE390RhVnzdd4jsR+Gxr8XXWE5WOhFDPSPI5FzAQ?= =?us-ascii?Q?bgTPWT83hwtm8UFQkDSdJaCpxKQ/3NzNWIFAcozqxa4mgFW+jKugIWMUI0sp?= =?us-ascii?Q?9PDcZJMC6LxrnPied1Vlp1efM1gu/YSTXSkewzVTipV/Bsj+UR0FlRTvcrbY?= =?us-ascii?Q?c6cWhnSVHD/e3kWyswD7zULDnsloBH00h4h8hVhkNX3ZdlGk9qYivmbr7Yyl?= =?us-ascii?Q?A1A0PyorHPquDOC4Nbo438rXnKbDFTazqZ721LdjvTs2+exL67bTZCfjQSKV?= =?us-ascii?Q?mhNenWO0+izvehYeWyS8Eyk4Bj9XL8Cs3gmxJWJoy41tJJLUsh2tp7NaXpT4?= =?us-ascii?Q?NG7Hly3Uoa4OdbhiyoNT4go0FblDedvIOoiV/E3eqaDdMi2VVxG6jhdp46na?= =?us-ascii?Q?xjqdEHV5Kj/JOZ/1eWdInJqpVGxeJKEvRwUMFx5E40mk8HrqVuFBetyUYYD5?= =?us-ascii?Q?HTplO9PFkuaFNdX+7LVm7kZXVtmcoQ+Y71SDY7QX4Mg4PXoYJFaudOO1hNX5?= =?us-ascii?Q?kB/mdI2KNl7HJYX2cdPtGtJldXPx6mc2AWlAe61cFyX5EV7ShREAUuJAtv3U?= =?us-ascii?Q?1hu0QiUJS+GgIKgVRbG59niG9egOkjHE1Ugoud3rAar+rSi3iQhGc5iI5Exy?= =?us-ascii?Q?ku2c4UgvXxzyTHC6qoNVkrO3TCgoyeMavbfhIDM/oxV0y/OJKUUevzx7PCkp?= =?us-ascii?Q?hqJ3tZQzEsrrWg1Pl00PkXTMa8CLVLqwUvMzTJBWrrS7Zs3XdaKDSNHPL7D4?= =?us-ascii?Q?UWlguV5c5fGwd90gcHKOPuPYZ435vrimjMwdeMGwJg93s9ojrTw+tZih4OM7?= =?us-ascii?Q?fV9DN+urgv0uIamGNFKdvjRYWbUCC01mYV4hW+arPmvPzR42Qy+XOO7Ja63H?= =?us-ascii?Q?YjDcinpPvPk5S3/ecNAgsoTufaM9X8yydmiDgYU4t4bzTysuadejYSzWe/Qa?= =?us-ascii?Q?f4UubkKp2xI4BGdATwT1ppv6lijh709UrujK7ae1GzvzaMg/DFsidfEFBJ9A?= =?us-ascii?Q?szoHyC20WWcuyP0b/4vAqFQ6RDi0rF0xxzGb9a5KgEIy5Ni+4GuzJFm0QUjr?= =?us-ascii?Q?2FCi5N+ovw7/Wl1mDO+HWR4HYIbprXuTmPQlKHp5LseqZvl8o6eY8inkpd9B?= =?us-ascii?Q?SGfMDpxLe24vmIxICTDSSC6c4TCy8fya0qZB9Ww1wIlj6IAQ6nXw6xqyv0EC?= =?us-ascii?Q?tTJwsz2lnZoda/JEES70/XfscrSCMmXcedM0mRKbiauqGW9d8OznnEIEEA3i?= =?us-ascii?Q?oBNFeiUPJIOOIPaVVYrB84q0A8BT8BbhLQwEdxuuMPeFRYn1YmGhtA8VDyJW?= =?us-ascii?Q?pn67FX1GBaUuYRPLbLBCGDV5zzM2OVxfbkUuDjFoQsq3k8Qi2Gqoxfc9ejcV?= =?us-ascii?Q?oDitRCnMSm4OAO5YXuM=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1b99bc4-f33e-49d4-22a4-08dc05b071b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2023 01:17:35.9460 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SM077ukMDVO2bliBfD0kkxgq2P5Vf1yrQlw9oSXrPYjFbSr7tEkKqq8kMHWDvRZ5chJI7Xi2bzkQn9RnNcIcBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6134 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 2Ol2m5dxluYuFiLC9WOtmz9Wx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=USzPzXbT; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Monday, December 25, 2023 6:59 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH v3 13/16] RedfishDiscoverDxe: add a helper function > deallocating string resources. > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > This patch adds a handy helper function deallocating resources from the > EFI_REDFISH_DISCOVERED_INFORMATION structure instance. > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 68 ++++++++++++------- > 1 file changed, 44 insertions(+), 24 deletions(-) > > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > index 76f87e4fe5e7..ff0c3ff1d1f5 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > @@ -712,6 +712,49 @@ DiscoverRedfishHostInterface ( > return Status; > > } > > > > +/** > > + The function releases particular strings into the structure instance. > > + > > + @param[in] Information EFI_REDFISH_DISCOVERED_INFORMATION > > + > > +**/ > > +STATIC > > +VOID > > +FreeInformationData ( > > + IN EFI_REDFISH_DISCOVERED_INFORMATION *Information > > + ) > > +{ > > + if (Information->Location !=3D NULL) { > > + FreePool (Information->Location); > > + Information->Location =3D NULL; > > + } > > + > > + if (Information->Uuid !=3D NULL) { > > + FreePool (Information->Uuid); > > + Information->Uuid =3D NULL; > > + } > > + > > + if (Information->Os !=3D NULL) { > > + FreePool (Information->Os); > > + Information->Os =3D NULL; > > + } > > + > > + if (Information->OsVersion !=3D NULL) { > > + FreePool (Information->OsVersion); > > + Information->OsVersion =3D NULL; > > + } > > + > > + if (Information->Product !=3D NULL) { > > + FreePool (Information->Product); > > + Information->Product =3D NULL; > > + } > > + > > + if (Information->ProductVer !=3D NULL) { > > + FreePool (Information->ProductVer); > > + Information->ProductVer =3D NULL; > > + } > > +} > > + > > /** > > The function initializes particular strings into the structure instanc= e. > > > > @@ -1514,30 +1557,7 @@ RedfishServiceReleaseService ( > do { > > if (DiscoveredRedfishInstance->Instance =3D=3D ThisRedfishInstance= ) { > > RemoveEntryList (&DiscoveredRedfishInstance->NextInstance); > > - if (ThisRedfishInstance->Information.Location !=3D NULL) { > > - FreePool (ThisRedfishInstance->Information.Location); > > - } > > - > > - if (ThisRedfishInstance->Information.Uuid !=3D NULL) { > > - FreePool (ThisRedfishInstance->Information.Uuid); > > - } > > - > > - if (ThisRedfishInstance->Information.Os !=3D NULL) { > > - FreePool (ThisRedfishInstance->Information.Os); > > - } > > - > > - if (ThisRedfishInstance->Information.OsVersion !=3D NULL) { > > - FreePool (ThisRedfishInstance->Information.OsVersion); > > - } > > - > > - if (ThisRedfishInstance->Information.Product !=3D NULL) { > > - FreePool (ThisRedfishInstance->Information.Product); > > - } > > - > > - if (ThisRedfishInstance->Information.ProductVer !=3D NULL) { > > - FreePool (ThisRedfishInstance->Information.ProductVer); > > - } > > - > > + FreeInformationData (&ThisRedfishInstance->Information); > > FreePool ((VOID *)ThisRedfishInstance); > > goto ReleaseNext; > > } > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112894): https://edk2.groups.io/g/devel/message/112894 Mute This Topic: https://groups.io/mt/103354132/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-