From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.48]) by mx.groups.io with SMTP id smtpd.web10.4074.1689127379539888873 for ; Tue, 11 Jul 2023 19:02:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=VqoCPjjJ; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.212.48, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BLb+t61yF2eRI2dJttTOxD+CGRH2T87eBQXpois5dpNAV38jhGyPSyiU6ryG0Vj2yJJQPtiupf5/YHnpaJUEssNjQ0HS1tPJaZi7RHkIkdCvINA5fkDic71c7IocjwEIPGpgQMGs6/aKIvzW16u4/1tGjVFKGfeliMIjy/Zx1wr33RMnh4qGeGqjXsuhMdBwtFajVkWfGJ8TGlv+4wPcKeLH5A91b0Gh+IuKAAlhVp79M8pb4bl+nvgcOsDZKvkpOhi3hnBpQ9e2lt4tv01bnEkQ941bty8yAgmxJNZNXEQfKBQk0fU1/TdAhknyctyB2IMe5PppiCYRAZdwCsyTxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=htzm/uaVAiDynvzVCd+DRc8flb/dpv2r7UEvihZcJgs=; b=mjschN/Je35nycRTnf5kEB9Xd+wwgi+MbY4rwxcr/kQt+nvQoaerPnbkoY8acbHBogYae24/vd8UO5liZZEttb+W0aXgfahErJbkDniGbiN+S3YqCWy0i562Z24yLVZRUPbJe3JmdjHF3zoCkP2FvGE8HorPS0Jfk5ayDjb4R9QLYKYJa8jg8gVe3ofLL9UWRTWYj3J5isSFTQ6gNkKG/n9Y5Jp3NYf+kSnVVFJXQmXp47g9iJMAbrxp2qf+F55XO/USPjnb94LN0cR+GxBFgy2W0NorbDWkd0yKf6a1KgKoJhRLVYnDrysQJrweHg20dpOzzZ1ZiF2m2T/KORE1VQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=htzm/uaVAiDynvzVCd+DRc8flb/dpv2r7UEvihZcJgs=; b=VqoCPjjJrC9kncR9d+f87GMckfZn4bTgv/XIZM8WHrkLHBL5wYrQekg4LZq50cMFikTBuWGNmPwfFGgUyJHqRfBSP0SeGU2ZDim/eOXl2ULe2jDbg3ci3VI3xvvESF0ndgQZNjhR7/af9jwP9hoip2fBwWDTafxuA6zDgoxTAzo= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by PH7PR12MB6465.namprd12.prod.outlook.com (2603:10b6:510:1f7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.31; Wed, 12 Jul 2023 02:02:55 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040%6]) with mapi id 15.20.6565.028; Wed, 12 Jul 2023 02:02:55 +0000 From: "Chang, Abner" To: "devel@edk2.groups.io" , "Chang, Abner" , "Chesley, Brit" CC: Isaac Oram , "Attar, AbdulLateef (Abdul Lateef)" , Nickle Wang Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] ManageabilityPkg: Ipmi Get/Set Boot Options Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v1 1/1] ManageabilityPkg: Ipmi Get/Set Boot Options Thread-Index: AQHZs2QIzepVonwvb0WHupFLQdcbAK+zyOZAgAGZ+/A= Date: Wed, 12 Jul 2023 02:02:54 +0000 Message-ID: References: <20230710192323.32-1-Brit.Chesley@amd.com> <1770AC5D28826C6A.5563@groups.io> In-Reply-To: <1770AC5D28826C6A.5563@groups.io> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=9d5c5455-6ee8-46da-b50d-74a6d69afd68;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-07-11T01:34:31Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|PH7PR12MB6465:EE_ x-ms-office365-filtering-correlation-id: 5adb3d02-f381-4132-3c8c-08db827c1b0a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: p9+CZh9/daciVnU+zoucRsqQMRUhQkpwW8ztpl0iu6eMGRR6ihGqWTipYWUZyTWxHUL+PoFAFhvkO369VTZ4yPsfNOGyRyyvHosx2W4AyFSQ8xppUPP0RqHhkX2rTW0mGtCXMkyjAFbvzOFD4HaxjvpO86sh3l5oteRcpPOKEm0sa6lXHrVRRqOtUm9Q+U5dVDukqMPv2K60OSTVCrfT2pgf/xaOdCFumiYjDO5yGYBjS18pDqCjeftrVujMzyHoGXJEGtoqmoXd7cY+UM3DqOzHdhRH/Uub2QkPa5XYXZY3ZKr6mraEk9CFPKnxnGlJ6B0f8lyAsJvAfmYOjOr8X74gx86ZYywuctac5+Meg9yqKjmlypU2V2/hMca5xFOQy5WGAF9d/iHazfDCkmuBocOlV/3Vh0AkHPEdpB/YuOkzS99hE26VYeLvp+TbrD2XNry0wDJrisW4oCOLGtUT7gcmTJDOMD5iTUQib1keaBawTMEU+sXpi4SxzYksNe1iaAZ0sel5lEhCwWk90jZg/9NxYn2BC3Gdz2nMpLFFL20NkVaHhqzSl6T1OvdJIA3TRj8BPjGm4Z+vmcKSIXxvDYenojXxWsfQkxcBdzsvYNQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(39860400002)(366004)(346002)(136003)(451199021)(7696005)(478600001)(71200400001)(33656002)(83380400001)(6506007)(186003)(53546011)(55016003)(966005)(9686003)(316002)(2906002)(41300700001)(38100700002)(122000001)(66476007)(66556008)(4326008)(66946007)(66446008)(6636002)(76116006)(64756008)(86362001)(8936002)(38070700005)(8676002)(5660300002)(52536014)(54906003)(110136005)(66899021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fT0A142i7DuASWLAi39s5xqMYJEScV5gNM/m5dc9srihrirJyV9OmSUN1rrD?= =?us-ascii?Q?uTenpALZKLOmmhYWtYea71R9H8fNdPYCp77QfQ4cW5gNJg6LalUpgV49ZNDn?= =?us-ascii?Q?FKZERkq81WC0ry3jaxlEfi5WdD9KxO+qBIhklW+GYA3F2/cBJZiU2++jmccy?= =?us-ascii?Q?3bmH1gZDsovpi8UXUYLpJN4sWAeZF1TPzq/1qzJVOOGjpimBHXzOdxsRx5NC?= =?us-ascii?Q?r7dEQjTc+/yZp4SP/tTDyBTBede7cCwT2OM8j+inP8C/oqjotZJ3bZ+s6UIQ?= =?us-ascii?Q?eykEvXCnl8+PBd9QRCV45Pi2yPYgMX9/tsz+0WnKEwu7E7UrVQvXJ+MJuivE?= =?us-ascii?Q?hLIeg7+KqVa0ETe7Ao9AYf/TnaJQSKI/M+YmMmvqYiajMKc0dmAcqQOTge0Q?= =?us-ascii?Q?0MNu8g/hsogx6Uu7HbsjIY8mLBCKDgbL+vUD2YrhIyIS4IE4Y19g4mMmqDaj?= =?us-ascii?Q?xtYkOGLGQozCUqRq6ONjKnvQjtd7ZuomNfGv0HJN0YAsCPOscA2ZoqR/Apyk?= =?us-ascii?Q?Q6HmPoOogk+iLxBVcTHzicO+Id7VxnZpHgE5yXH9MP8Lwk4t7VfSaRkgnzgu?= =?us-ascii?Q?wAGp1w3Qgk8bofhRlsRm59F6ht2cElOsccFM7yzo9az6k5NvtpJwWHFMC7Ba?= =?us-ascii?Q?Rnv4wpqlkmILIKlZikNapix04OV+V0Ols/fgeQt3PaL8wCTY9yDaSMaJk2xI?= =?us-ascii?Q?qKGZYAGQkxsJhWCySna2a5IM22kAqycjfjZgdCajC3Mo8sukqwBvW51GCUQJ?= =?us-ascii?Q?1A6ep+8+d8YNpOmpyH9mio4z83jOPXNv+4sGiWyZZWeAWqC0l2vC+gmTfdpv?= =?us-ascii?Q?EXeFJDsmDOSxQL/fCxsafoaMIAAfOMjrH3RbBlxd4RKCBNhfDggMUkkAiXiC?= =?us-ascii?Q?ErdA5cuA3bL1KldVX9ZZGu3062Uh7287IA7T6x9TUBUC42ysnnVl34domVgI?= =?us-ascii?Q?LO/10E1Sgb2Qh/myxWPidB8cgnw7vIXGAluqUzbk+iXFA4RNhtYlt3DdGLlG?= =?us-ascii?Q?IkMOAw6VggDjRu3Pk4uZgrkV31XmxShidroz37Rlte/tcQfVUB798rpdfnAF?= =?us-ascii?Q?/W/9wq/dBd2I1w4ikqQ3Y2DoPbdWZr06x2k9R5GEECIgMO3oW+pgoc8qV0gD?= =?us-ascii?Q?BITx50c6ucPV2xemID+QKvSm6mrxsiPWfy0Ck+vv4O+50AGJgyVVRwbgvkOK?= =?us-ascii?Q?FhFu+5jM9+gF4b+6aJhzBKySgRQoMk26ozm2SSHcQdfOPL1QQ2cmVe5lyHIh?= =?us-ascii?Q?eMiJkXGMkbme5KWmEZitbYi6LG6CXtQ1IJyEkRQRplM5KOYM50ayHd4KNVLl?= =?us-ascii?Q?qCdKw0L3V2FRBDYwL1pGJ1P4LOtso97/58XxzYcC2UJjk733kTfCbhVd5etY?= =?us-ascii?Q?0xg5PwER0k3G5TPzBr0WTkBTV0lyO6P0PpQphTXLmdqi6qIQO1ABa7aKgzHR?= =?us-ascii?Q?N7+y+UHzWUMqqg9uDfO0wFbryACLjFE+JYoEQDGBHCvqFnCZuVs3QOCtQxGN?= =?us-ascii?Q?upupxuPVBjunWKjIEh5KUYN8ZiLekAgu1AkQ4e6rkPYLmceqsv65LlG23w?= =?us-ascii?Q?=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5adb3d02-f381-4132-3c8c-08db827c1b0a X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2023 02:02:54.4033 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VfAKHmDf2txtfBdHSEq3V5HQ5Fh1gz5mtZZyvIZ5Bl3E+52zty6MrxMRmIIaWBsoIxpe7yDQGnCEjJ7BZ9KR0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6465 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Brit, I am going to push this change with updating the file header with = AMD copyrights. Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Tuesday, July 11, 2023 9:36 AM > To: Chesley, Brit ; devel@edk2.groups.io > Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef= ) > ; Nickle Wang > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] ManageabilityPkg= : > Ipmi Get/Set Boot Options > > [AMD Official Use Only - General] > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > [AMD Official Use Only - General] > > Thank you Brit for the contribution! Let's wait for 1-2 days to see if th= ere is any > other comments for this change. > > Reviewed-by: Abner Chang > > > -----Original Message----- > > From: Chesley, Brit > > Sent: Tuesday, July 11, 2023 3:23 AM > > To: devel@edk2.groups.io > > Cc: Chang, Abner ; Isaac Oram > > ; Attar, AbdulLateef (Abdul Lateef) > > ; Nickle Wang > > Subject: [edk2-platforms][PATCH v1 1/1] ManageabilityPkg: Ipmi Get/Set > > Boot Options > > > > From: Brit Chesley > > > > BZ #: 4455. > > Support parameter selectors for IPMI Get/Set boot options. The size of > > the response data is now dependent on the parameter selector, rather > > than being fixed. > > > > Cc: Abner Chang > > Cc: Isaac Oram > > Cc: Abdul Lateef Attar > > Cc: Nickle Wang > > Signed-off-by: Brit Chesley > > --- > > .../IpmiCommandLibNetFnChassis.c | 124 ++++++++++++++---- > > 1 file changed, 102 insertions(+), 22 deletions(-) > > > > diff --git > > > a/Features/ManageabilityPkg/Library/IpmiCommandLib/IpmiCommandLibNe > > tFnChassis.c > > > b/Features/ManageabilityPkg/Library/IpmiCommandLib/IpmiCommandLibNe > > tFnChassis.c > > index 0c40ad20b98a..01682f55b36d 100644 > > --- > > > a/Features/ManageabilityPkg/Library/IpmiCommandLib/IpmiCommandLibNe > > tFnChassis.c > > +++ > > > b/Features/ManageabilityPkg/Library/IpmiCommandLib/IpmiCommandLibNe > > tFnChassis.c > > @@ -152,17 +152,58 @@ IpmiSetSystemBootOptions ( > > ) > > { > > EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof (*BootOptionsResponse); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_CHASSIS, > > - IPMI_CHASSIS_SET_SYSTEM_BOOT_OPTIONS, > > - (VOID *)BootOptionsRequest, > > - sizeof (*BootOptionsRequest), > > - (VOID *)BootOptionsResponse, > > - &DataSize > > - ); > > + UINT32 RequestDataSize; > > + UINT32 ResponseDataSize; > > + > > + ResponseDataSize =3D sizeof (*BootOptionsResponse); > > + RequestDataSize =3D sizeof (*BootOptionsRequest); > > + > > + switch (BootOptionsRequest->ParameterValid.Bits.ParameterSelector) { > > + case IPMI_BOOT_OPTIONS_PARAMETER_SELECTOR_SET_IN_PROGRESS: > > + RequestDataSize +=3D sizeof > > (IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_0); > > + break; > > + > > + case > > > IPMI_BOOT_OPTIONS_PARAMETER_SELECTOR_SERVICE_PARTITION_SELECT > > OR: > > + RequestDataSize +=3D sizeof > > (IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_1); > > + break; > > + > > + case > > IPMI_BOOT_OPTIONS_PARAMETER_SELECTOR_SERVICE_PARTITION_SCAN: > > + RequestDataSize +=3D sizeof > > (IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_2); > > + break; > > + > > + case IPMI_BOOT_OPTIONS_PARAMETER_SELECTOR_BMC_BOOT_FLAG: > > + RequestDataSize +=3D sizeof > > (IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_3); > > + break; > > + > > + case IPMI_BOOT_OPTIONS_PARAMETER_BOOT_INFO_ACK: > > + RequestDataSize +=3D sizeof > > (IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_4); > > + break; > > + > > + case IPMI_BOOT_OPTIONS_PARAMETER_BOOT_FLAGS: > > + RequestDataSize +=3D sizeof > > (IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_5); > > + break; > > + > > + case IPMI_BOOT_OPTIONS_PARAMETER_BOOT_INITIATOR_INFO: > > + RequestDataSize +=3D sizeof > > (IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_6); > > + break; > > + > > + case IPMI_BOOT_OPTIONS_PARAMETER_BOOT_INITIATOR_MAILBOX: > > + RequestDataSize +=3D sizeof > > (IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_7); > > + break; > > + > > + default: > > + return EFI_INVALID_PARAMETER; > > + break; > > + } > > + > > + Status =3D IpmiSubmitCommand ( > > + IPMI_NETFN_CHASSIS, > > + IPMI_CHASSIS_SET_SYSTEM_BOOT_OPTIONS, > > + (VOID *)BootOptionsRequest, > > + RequestDataSize, > > + (VOID *)BootOptionsResponse, > > + &ResponseDataSize > > + ); > > return Status; > > } > > > > @@ -184,16 +225,55 @@ IpmiGetSystemBootOptions ( > > ) > > { > > EFI_STATUS Status; > > - UINT32 DataSize; > > - > > - DataSize =3D sizeof (*BootOptionsResponse); > > - Status =3D IpmiSubmitCommand ( > > - IPMI_NETFN_CHASSIS, > > - IPMI_CHASSIS_GET_SYSTEM_BOOT_OPTIONS, > > - (VOID *)BootOptionsRequest, > > - sizeof (*BootOptionsRequest), > > - (VOID *)BootOptionsResponse, > > - &DataSize > > - ); > > + UINT32 ResponseDataSize; > > + > > + ResponseDataSize =3D sizeof (*BootOptionsResponse); > > + > > + switch (BootOptionsRequest->ParameterSelector.Bits.ParameterSelector= ) { > > + case IPMI_BOOT_OPTIONS_PARAMETER_SELECTOR_SET_IN_PROGRESS: > > + ResponseDataSize +=3D sizeof > > (IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_0); > > + break; > > + > > + case > > > IPMI_BOOT_OPTIONS_PARAMETER_SELECTOR_SERVICE_PARTITION_SELECT > > OR: > > + ResponseDataSize +=3D sizeof > > (IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_1); > > + break; > > + > > + case > > IPMI_BOOT_OPTIONS_PARAMETER_SELECTOR_SERVICE_PARTITION_SCAN: > > + ResponseDataSize +=3D sizeof > > (IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_2); > > + break; > > + > > + case IPMI_BOOT_OPTIONS_PARAMETER_SELECTOR_BMC_BOOT_FLAG: > > + ResponseDataSize +=3D sizeof > > (IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_3); > > + break; > > + > > + case IPMI_BOOT_OPTIONS_PARAMETER_BOOT_INFO_ACK: > > + ResponseDataSize +=3D sizeof > > (IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_4); > > + break; > > + > > + case IPMI_BOOT_OPTIONS_PARAMETER_BOOT_FLAGS: > > + ResponseDataSize +=3D sizeof > > (IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_5); > > + break; > > + > > + case IPMI_BOOT_OPTIONS_PARAMETER_BOOT_INITIATOR_INFO: > > + ResponseDataSize +=3D sizeof > > (IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_6); > > + break; > > + > > + case IPMI_BOOT_OPTIONS_PARAMETER_BOOT_INITIATOR_MAILBOX: > > + ResponseDataSize +=3D sizeof > > (IPMI_BOOT_OPTIONS_RESPONSE_PARAMETER_7); > > + break; > > + > > + default: > > + return EFI_INVALID_PARAMETER; > > + break; > > + } > > + > > + Status =3D IpmiSubmitCommand ( > > + IPMI_NETFN_CHASSIS, > > + IPMI_CHASSIS_GET_SYSTEM_BOOT_OPTIONS, > > + (VOID *)BootOptionsRequest, > > + sizeof (*BootOptionsRequest), > > + (VOID *)BootOptionsResponse, > > + &ResponseDataSize > > + ); > > return Status; > > } > > -- > > 2.36.1 > > > >=20 >