From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: "mikuback@linux.microsoft.com" <mikuback@linux.microsoft.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Nickle Wang <nicklew@nvidia.com>, Igor Kulchytskyy <igork@ami.com>
Subject: Re: [edk2-devel] [PATCH v2 1/7] RedfishPkg/PlatformHostInterfaceBmcUsbNicLib: Fix DEBUG macro args
Date: Thu, 14 Sep 2023 02:50:33 +0000 [thread overview]
Message-ID: <MN2PR12MB396676116A5EE23D749FB80CEAF7A@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230913170617.429-2-mikuback@linux.microsoft.com>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Thursday, September 14, 2023 1:06 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Nickle Wang
> <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: [PATCH v2 1/7] RedfishPkg/PlatformHostInterfaceBmcUsbNicLib: Fix
> DEBUG macro args
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Some macros added have a mismatched number of print specifiers to
> arguments.
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>
> RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfa
> ceBmcUsbNicLib.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> faceBmcUsbNicLib.c
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> faceBmcUsbNicLib.c
> index d18d83b93808..95900579118b 100644
> ---
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> faceBmcUsbNicLib.c
> +++
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> faceBmcUsbNicLib.c
> @@ -65,10 +65,10 @@ ProbeRedfishCredentialBootstrap (
> (ResponseData.CompletionCode ==
> REDFISH_IPMI_COMP_CODE_BOOTSTRAP_CREDENTIAL_DISABLED)
> ))
> {
> - DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " Redfish Credentail
> Bootstrapping is supported\n", __func__));
> + DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " Redfish Credential
> Bootstrapping is supported\n"));
> ReturnBool = TRUE;
> } else {
> - DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " Redfish Credentail
> Bootstrapping is not supported\n", __func__));
> + DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " Redfish Credential
> Bootstrapping is not supported\n"));
> ReturnBool = FALSE;
> }
>
> @@ -645,7 +645,7 @@ HostInterfaceIpmiCheckMacAddress (
> &ResponseDataSize
> );
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, " - Fails to send command.\n", ChannelNum));
> + DEBUG ((DEBUG_ERROR, " - Channel %d fails to send command.\n",
> ChannelNum));
> continue;
> }
>
> @@ -1084,7 +1084,7 @@ CheckBmcUsbNicOnHandles (
> (VOID **)&DevicePath
> );
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, " Failed to locate SNP on %d handle.\n",
> __func__, Index));
> + DEBUG ((DEBUG_ERROR, " Failed to locate SNP on %d handle.\n",
> Index));
> continue;
> }
>
> --
> 2.42.0.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108631): https://edk2.groups.io/g/devel/message/108631
Mute This Topic: https://groups.io/mt/101341647/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-09-14 2:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 17:06 [edk2-devel] [PATCH v2 0/7] Add DebugMacroCheck Michael Kubacki
2023-09-13 17:06 ` [edk2-devel] [PATCH v2 1/7] RedfishPkg/PlatformHostInterfaceBmcUsbNicLib: Fix DEBUG macro args Michael Kubacki
2023-09-14 2:50 ` Chang, Abner via groups.io [this message]
2023-09-13 17:06 ` [edk2-devel] [PATCH v2 2/7] pip-requirements.txt: Add regex Michael Kubacki
2023-09-13 17:06 ` [edk2-devel] [PATCH v2 3/7] SecurityPkg.ci.yaml: Add debug macro exception Michael Kubacki
2023-09-13 17:06 ` [edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: " Michael Kubacki
2023-09-13 17:10 ` Ard Biesheuvel
2023-09-18 22:35 ` Michael Kubacki
2023-09-19 0:05 ` Michael D Kinney
2023-09-19 14:46 ` Ard Biesheuvel
2023-09-19 14:52 ` Leif Lindholm
2023-09-19 15:10 ` Michael D Kinney
2023-09-19 15:12 ` Michael Kubacki
2023-09-13 17:06 ` [edk2-devel] [PATCH v2 5/7] DynamicTablesPkg.ci.yaml: " Michael Kubacki
2023-09-14 8:42 ` Sami Mujawar
[not found] ` <1784B757CEFF413A.31544@groups.io>
2023-09-14 9:22 ` Sami Mujawar
2023-09-18 19:27 ` Michael Kubacki
2023-09-18 22:36 ` Michael Kubacki
2023-09-19 0:26 ` Michael D Kinney
2023-09-13 17:06 ` [edk2-devel] [PATCH v2 6/7] OvmfPkg/PlatformCI: Disable DebugMacroCheck Michael Kubacki
2023-09-13 17:06 ` [edk2-devel] [PATCH v2 7/7] BaseTools/Plugin: Add DebugMacroCheck Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB396676116A5EE23D749FB80CEAF7A@MN2PR12MB3966.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox