From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2A83BAC00E0 for ; Thu, 14 Sep 2023 02:50:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9nlruPrq6/+yNl0NF7xx9mdamMotdide434Af4SfP+w=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694659837; v=1; b=YA5y0l3ZsLmQ111bkwi4d32pbbjYoCueIckfwRG/dH2w9G+WtE9X6GwenPhUyX5HOWqX9umI G/9440M+XwFmTrYQw69/TXyYATh9ALTCJL8AIGSJnbi6RKlsTpYzgCi34nj0e6oeDMcAk/zJnMj LywXz5/OzNbGneLY5fcAHEhA= X-Received: by 127.0.0.2 with SMTP id 54ZvYY7687511xwZssNPBMwZ; Wed, 13 Sep 2023 19:50:37 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.46]) by mx.groups.io with SMTP id smtpd.web11.3761.1694659836947408573 for ; Wed, 13 Sep 2023 19:50:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iqJG5mQ1+b32274JLGNdtXxh6RlME1GOktCRKzq3Col4rpQ+j8cwA2cbRx2RUHWS06Z0TZrmGzrUJ4iNh0tpVAklll1FaLsu8yaifXzo7oNXcSwdfcIVdLjczV9+epD9Vpmz7igPcpOrvgF1vatMussKU/4fWOgZvMLLPFQO8CLVkYVVnYza6yuJrS9Pvg8lycyNZ5aOok8/ZSv0kElj2QW+uh2IVXb/TmOisdMZZPLsLXPZF6SfIakiQKSFqUICNHwg9kRDijVGabF0iwx8PwqGbWOxOYx1lOMouhoSJqwyiBg+Ft5hJ7GOEqyzzjo5XRjnlcCB/V+k+3k/rXm/6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z46WCJhUx0BTRALWPOUA5Pk6f6xdluNdrihyhyUWF0w=; b=EkH49dntce4Sf1bV9Hw54FmTr4b+9g1ZGR9vmDnTJOCjdclh744sUWG+qy81Vy1EgZwiHiQQMfTRsD5dzhUDM5sLakBEB/+r1mdW+6aqEwD9qQ5jQJQtTNtzZ1rxoYIpG05WarYR5iuyktO+KMX0+qfv3SD4WqhQKV7s94PaW+wsp359jXN5OianYHQjhSSwilzLTXl7QY1aOVWg1aINQf2o338FoMUHgffD84IdOKTBwW9YoH83ge8stsQWwUTlkO+KQodZdRm1Pd5HD1CW03TcXArGXHEx1LkobpgD19Co3XuDE3zKeA9UI+Agc0C5WXh5EqTQG7n2pMqgsC1x4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SN7PR12MB7419.namprd12.prod.outlook.com (2603:10b6:806:2a6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.30; Thu, 14 Sep 2023 02:50:33 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02%4]) with mapi id 15.20.6792.020; Thu, 14 Sep 2023 02:50:33 +0000 From: "Chang, Abner via groups.io" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: Nickle Wang , Igor Kulchytskyy Subject: Re: [edk2-devel] [PATCH v2 1/7] RedfishPkg/PlatformHostInterfaceBmcUsbNicLib: Fix DEBUG macro args Thread-Topic: [PATCH v2 1/7] RedfishPkg/PlatformHostInterfaceBmcUsbNicLib: Fix DEBUG macro args Thread-Index: AQHZ5mTMCVaweO8EukaI9Z6ljg4vv7AZn5Nw Date: Thu, 14 Sep 2023 02:50:33 +0000 Message-ID: References: <20230913170617.429-1-mikuback@linux.microsoft.com> <20230913170617.429-2-mikuback@linux.microsoft.com> In-Reply-To: <20230913170617.429-2-mikuback@linux.microsoft.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=039c1383-7e3f-4fe0-9c96-1f55ca331959;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-09-14T02:50:12Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SN7PR12MB7419:EE_ x-ms-office365-filtering-correlation-id: b23dbc52-31f1-44d5-ea52-08dbb4cd5d95 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: LhAXRT5/Ydu64+Je1CjKkBUYAGrvBvuWtVzwho0FiHm8jTr/HGf2lbY0CgQ8Efm2QOlGiPhKWAv5bV/ObjZYgIAUpiBIvtOqobT4hAO0gQIO2I3w+GBAvIJ/gH3+naKZReUpsNo7bYSwWWuIrlmBi7uzF20wFpWLVYUHr6OY3vw/+NO+ZotiZR2hi4hvDHqr7vP0nXrB20ZaC343SYeKNpL2DQO2jfwXH+ZqTryq4po6YJXTvy3vnYCIge2pHL5gGeR4qxlqt1/8222qGLQ7x7QMXxZpld3vCJBXMCotshZEJz7X3nkGU+Alfp6wunQj/pMkwoq2n3YxEoY7fZBE5Fi/NTE7ZsG1jQm7IUVN09XardEqQntQ0it9NMcEg/JBQHTXv9VQDMTR00ggUI35xqwXjXJb4mLRaduiphfqVCmCJo4eALqMAFcoQVMBqRSuu7Vf1k1y1u1KMZd5+PT33KJ9dhK6mJ1EnWGwtuigbmsuj4/t0ZzE2Kl8xzxtUpsLIAChjyBE82M/B2f5ufpefWLGZ3sDxImp+0Aso3S6HYQ844vEbNs4DC7gRUPXdg6As2lFfYxvS7ApP/12UHHPgl+ipKLEF6k9QSeoDG5L4dsg2KRNSxVlSzy07mTx/dnQvqSsj+SNrTdairRMPsfF8Q== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mYb0zur/HHL37MUiLakDCBhwRSDujc2Hosi5nWgnJVJJom+K6+103vNhGI+i?= =?us-ascii?Q?xCTyOFWnf+tpQDSspYqpjGt4wsQXfoSOTQ9m7RKghu+WPlsUbs7Zvbs+UOrf?= =?us-ascii?Q?qHLYY92Q9N4Xe1wkjAzpq6mcs2EphgNFhB1hwfPlNnCuOz7A81zqVjfeLEaJ?= =?us-ascii?Q?VovZ1t3pSwOS1z1cemuE9a82acgiqkilrKRx2+uOa55MnDgVhL+ji3Pia8p7?= =?us-ascii?Q?mj9JbS3bobxOq9EKgnWty0UIaK9/lg9QdkQ9qGPaTJFOZezm33yZXhskCJsJ?= =?us-ascii?Q?Pxg+xTBhuvj8h4qlhCyFOiiWyR44J5ej0ejCaDQP6aT3iOpe5jmpUR6adcGX?= =?us-ascii?Q?OobOjogLBmeFvLKQMqfXnYn1ZIoxPSPrSrzctZF++ANZq7WUbssayhXiZjwl?= =?us-ascii?Q?jnx6qcHJh208jAZb4Bhh+/N+TIaz2gO5NSdVzglHy0Y0aO2AcAttPYGa5fl6?= =?us-ascii?Q?cj8Qc8cuui1+vwoxP8+lBVIAeIXKVoHa7m8AFf45HhpzRFOzbfBQFkIz2vPE?= =?us-ascii?Q?zIdLYSBHaNoVFo9VQSsrpgXLGgykLicvBGnw4F2sYKwhvpkKzmH2iXj3V62y?= =?us-ascii?Q?oR5vhvMXTKpOAj1FhrchoMnCBbP+XTEFbZZFNmuMJckpPkTBDWiemeQKf6+D?= =?us-ascii?Q?AACTBqnNFXdlhCE5xicxKDcgdrs3rG79GBp3fy/EREDGVg9hm7o0qObWs483?= =?us-ascii?Q?GbnrXcrt64hCmLwJFMFfeQdL/R0bYXZs64dwwoKfq78GnYbOKTaSAhJBB/rV?= =?us-ascii?Q?rTCvPtN8z5WtpN+wrorh7XbosWl5BM4rd3DxFNGAYM40xMXCf2nFOmgEpRxP?= =?us-ascii?Q?3+BolEHTS00P4uLfVE0MqvOtD6XccAYxx29HUgraF8zPaeVHcx1P/PmZVhWy?= =?us-ascii?Q?e6OChhYKEx/w02R+EXgOnV+F+bUYL5SNMiGIaYHXoQp4bGtgPLO61ixbqmAq?= =?us-ascii?Q?PTxL9HB5C0QxCAcWxwz15iWFxcj89hJt0evNL9tOib+EFIZzysC7SN2PhoMQ?= =?us-ascii?Q?QNYSM7EFQYQgfL+mMTWyVm+LpWlB146FDR1gJmlYWkbBPOh9k3Dpr9mOd2Em?= =?us-ascii?Q?4zC9pP2ZXxPfYUC+nCxjEOrzzISepxzKZlCjAje4ZDwWnze7bK9WRVrbiZW/?= =?us-ascii?Q?AQ/YrjHXeEyvbEBkWn0TuUnHpbR+6f402t0VrudTG/g/XrSjG1bPPpDcNER5?= =?us-ascii?Q?AOPO4UiQ3NspYNATQx7dTHbDW1xk7Jod3DFSxUHoLC/4tu/6AiE+no46KGzR?= =?us-ascii?Q?2exQNxEYsp7LSDKwgJ3sT6A/slFpEvogO5H1Fdk0HfFp6y76FogyjtYCazqx?= =?us-ascii?Q?oyB8vcQKPoukWXfMYbvx68nvDkcGo5q0HUU7aD8UaXiRfKZBt9x5a3LgkFnw?= =?us-ascii?Q?YYFLpgNuulRY0bviPovhL6Zsm9owuuh7dvV0JAvLsj7tKvJBGottslMtPqyh?= =?us-ascii?Q?y/iQnEwhixlLYM4h0VvUEepB2PuIs6OPDcjWYXmRHKy/bQ+imDJ+pmfM4vyv?= =?us-ascii?Q?23gczbM6iFvWYGNg3UsTNYkqrMfou+YMUmfJ9jKy05ZVnLop+rlO2h50j/mD?= =?us-ascii?Q?tgrsXekpCb88c12TuU4=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b23dbc52-31f1-44d5-ea52-08dbb4cd5d95 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2023 02:50:33.3957 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xMINMWdFqbJaKiPePT0lNwDyFg4emdMleDSGthNUpM/CPTGNeScFw7CVW/SF3yVLPI1iKcVr51s5wvHMu7TdbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7419 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: SpoFbd2ezofP8odah9jVgXmFx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=YA5y0l3Z; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Thursday, September 14, 2023 1:06 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Nickle Wang > ; Igor Kulchytskyy > Subject: [PATCH v2 1/7] RedfishPkg/PlatformHostInterfaceBmcUsbNicLib: Fix > DEBUG macro args > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > From: Michael Kubacki > > Some macros added have a mismatched number of print specifiers to > arguments. > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Michael Kubacki > --- > > RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfa > ceBmcUsbNicLib.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter > faceBmcUsbNicLib.c > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter > faceBmcUsbNicLib.c > index d18d83b93808..95900579118b 100644 > --- > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter > faceBmcUsbNicLib.c > +++ > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter > faceBmcUsbNicLib.c > @@ -65,10 +65,10 @@ ProbeRedfishCredentialBootstrap ( > (ResponseData.CompletionCode =3D=3D > REDFISH_IPMI_COMP_CODE_BOOTSTRAP_CREDENTIAL_DISABLED) > )) > { > - DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " Redfish Credentail > Bootstrapping is supported\n", __func__)); > + DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " Redfish Credential > Bootstrapping is supported\n")); > ReturnBool =3D TRUE; > } else { > - DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " Redfish Credentail > Bootstrapping is not supported\n", __func__)); > + DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " Redfish Credential > Bootstrapping is not supported\n")); > ReturnBool =3D FALSE; > } > > @@ -645,7 +645,7 @@ HostInterfaceIpmiCheckMacAddress ( > &ResponseDat= aSize > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, " - Fails to send command.\n", ChannelNu= m)); > + DEBUG ((DEBUG_ERROR, " - Channel %d fails to send command.\n"= , > ChannelNum)); > continue; > } > > @@ -1084,7 +1084,7 @@ CheckBmcUsbNicOnHandles ( > (VOID **)&DevicePath > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, " Failed to locate SNP on %d handle.\n", > __func__, Index)); > + DEBUG ((DEBUG_ERROR, " Failed to locate SNP on %d handle.\n", > Index)); > continue; > } > > -- > 2.42.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108631): https://edk2.groups.io/g/devel/message/108631 Mute This Topic: https://groups.io/mt/101341647/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-