From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 13CA8AC0939 for ; Fri, 27 Oct 2023 02:34:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Vf1QgjGTmNvpJl2EAoIrMfdxl6K0MYPQX4o6s8QUQMg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698374093; v=1; b=i0ht300WifLmc6qoCmuVsMoNxoMEwAb2tlYMTNReworYs/tl0wZ+kvCdqk/YN/aX7LBQQmT1 6D43zM8wpi0jlSNMJRvgxOGbr2FLUmcdiSlmJPUKUq+P9pvxYbaCg6AlXYO1ldEWdNa+xu9pG7P r9PxjPCU0/p4PV9qH7giFpbA= X-Received: by 127.0.0.2 with SMTP id 0whDYY7687511xLQmIWxzpMm; Thu, 26 Oct 2023 19:34:53 -0700 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.86]) by mx.groups.io with SMTP id smtpd.web10.218063.1698374092977103779 for ; Thu, 26 Oct 2023 19:34:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QwBwiwiICO9e9oHZKMgtD1j+LJk899vHXFHUnhUGZW9cK5SNbs0vPDo35WLpQkQ18th1d+KXvJPQ3a79IS4aCnfvrSwGXIE2vt0jlyaAp7+1a+7gpNgz9t+F8CEjEPejJpj20bzJT+O0V2JraEP7B1WeWvlUpUzUFREeVq0Mt9GLWkCCophS50c4B8u6FmErA7au7YOV0rHpZXSiyewRk+Ku0PFesqTVFTbNo9Lrtp6QvrFZ4y2VMQA11kgKtgcOwXJb7KzChaqAnSZIpHm72q1Czph1tytPYdFz8CIhFalaeEVvsXiL9bfHKgL3urGCZvkGO55wXhfeJ45Luh2gpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CFZRzbhnSOxzwUHxqSYbkASs3GN+RHr6CnRNIZMjMDA=; b=JYtXacXaamzncUm404hGxspbrkzHOhPK+/3CvAfaMqpiTuAEj1Hd9yu3kZCg1rvnH8+L7dRLKKl8pLzDLtdp+3DbJOAhoTamv3oyR539j0dwcil6e1kUvTj9RzDV3z3tTsdO7AtKmLAkgtoFiUUAqsd1JkooUPhuWc9UD1jQZiLzFw7fGKudSJAaWmg7AufmFoFIB/V5TtLe89wXWv6w3EbOThD6hwrvpW+llmSrxpV1ibYLHDX4MEqZLcBWvwqLdTvAlHEllO7C8RozwahCZv1VSiLlgLgOMXJojrl6aWciF/rJ7ZykGQULF2f4HVEWvWZ1Xr3nORE6ZTC4tLu2hA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SA1PR12MB6678.namprd12.prod.outlook.com (2603:10b6:806:251::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.34; Fri, 27 Oct 2023 02:34:49 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420%6]) with mapi id 15.20.6933.019; Fri, 27 Oct 2023 02:34:49 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH v2 09/11] RedfishClientPkg: fix StrnCpyS arguments Thread-Topic: [edk2-redfish-client][PATCH v2 09/11] RedfishClientPkg: fix StrnCpyS arguments Thread-Index: AQHaCGe2lZrV8hZxh0y/WFMqhlTWNbBc603g Date: Fri, 27 Oct 2023 02:34:49 +0000 Message-ID: References: <20231026235354.67625-1-mike.maslenkin@gmail.com> <20231026235354.67625-10-mike.maslenkin@gmail.com> In-Reply-To: <20231026235354.67625-10-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=7f8b2455-38eb-4d3b-a138-0515d11cc5ff;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-27T02:34:06Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SA1PR12MB6678:EE_ x-ms-office365-filtering-correlation-id: a470fb27-3052-4293-718e-08dbd6954a9d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: aboDddSrsDQvIYSSg5XnvzOnN01Eu3RJrIY64FPZ9zh34NGhxSrj+3LoFu+mSnHs7OwIcSFtzP37mMV7wpo5CxADdAWt/4JJ56ig/GG0vJ7LXAWwCNImC9w3N9NDAYjmuyjpr5xnoXpYeEHThRPb9WUIHTGs4ShWsizGdFd2ZpJPdig7jRY/eLI3+TVWbl5M6fYJF9bky7Snc+09qASRKSvhqJ169+kL4WOYLnlB739onVMvy6Xf55lsU9Y0brIf6stMU5C0OkOOQ8jPJ5jE2tcLehw58KgtgMnZVhBTpF64/ZQW0lzisnDRJFmLe7lemYJIpUB3QSPnfwkb2vTyVoG5YbKdSdjVinoMAO+w0IcpBGcJ9heW047Fkkb8jCENRICxT53KjMJojCINyL584IsHFnnqR4D7p0Qk4BKJWrfscG3J9KKnVwgr1RP1oux5ZLyw3C11bF/XJfR4IEN/40Kn2Zl8dzuBkFIIgBWB29PKDfwmoRh/RcDGdl5qbkHJQk1lWyUALz4/SjItsTkrhRhjED79alwBtIre+89spKjxz+Fx4oIJDEsZMiLIZB3r6XDWgR6gCuI44Fgn5vJ7TydxpMHCOpQQ1jfMGiCs9x/DIcPrnoO9V+G2uVf4+8eK4GL7oEC+Ytoh0nq+Jh+nEpujeil+E2of+hasWSVXes8= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?65jO+g9KA3B7w/1nkFm1lDHsvg0KUuhbdC9Qh7gfJU/1SqEyZgiXM21VA0wc?= =?us-ascii?Q?yL0oPYsuOQpgmq+ZcQ/5u8X0db+7osPkVoYT3tIRKp7K/s6aEhNB3rLidvka?= =?us-ascii?Q?/f5Oo1X0So3Thhj8J+4LZj4IMHw/kV00qa8Yc7o0IvPS2Wd/yDvxTMaeOCv9?= =?us-ascii?Q?wm1x881ly8Qptw4bPhTow4Qm/DX3nrqVGw7ZYRx0IuAtyHF/tL2xoZWuM90f?= =?us-ascii?Q?fK1KAk55JSVl/7L1lDQ7xO0UA9Skm7XW3U0ufdyr+rnMVQoXLC01eFUThU0z?= =?us-ascii?Q?dj4mcljC2KL5Emw8nndg5B6JSkobo4xo/kW+n8lN9j4MEXhJLQ9m0sN79y/H?= =?us-ascii?Q?74PdtrXa1ZrPYYr8zXRG6PZbDwGWSKkNV7k1Y5EOX++lAQrEu8pK3jROQwOd?= =?us-ascii?Q?tf5BpX6IorFEm01F815EB2Ut8oL+yoSPOsDKmYmSc8HGohoXHwd1YgvQP1ki?= =?us-ascii?Q?RtF8ek4EnEpO7ii/Rry+QWweaiBZgO+taDaJrfWdFAheG4d3SP4UJslgTNI3?= =?us-ascii?Q?StrfnaAmimbLsbrYdq5h8h0WhjEUFe6gMuVhT/oDlWFTkVJnkZEXXEeM/Mu2?= =?us-ascii?Q?AQ9+t/jjfjkqKRIyYQJMN5EdGXvNlB19r7xwVbHHyQ+LAKw0b849IbkDpYir?= =?us-ascii?Q?F+SPrmL0w4wSzkxE4hAj6llWboy15Ls4zCTGNZ50gfGh6IZpbbD48Dd/AKxD?= =?us-ascii?Q?opIgW2VGl2ROWfN2XoEPtHIdBdhO+xqSKykXkUvMqRCU7ixPI86cX5wlnN0L?= =?us-ascii?Q?q59+b7gEZZQTuvqgY7rfQUpKRuF4oTyU6+Hv35mxBYKfvom4ypEo07VlCSKh?= =?us-ascii?Q?Exu6NgzUFRovBXMTs4EtUjGoFBbOxLAJ2bJjrVZWoDPKw3YieoqZS8I75hyF?= =?us-ascii?Q?9sqyDg0zh3FAhvtDwBGN8C03pFHSe3VyT9CMCrjTuvtQMH51+XkYXL3DZnu8?= =?us-ascii?Q?/Tn4/BQ1qirwYp4N1LiSPfj5Dxg4brgRpOzk7WfMfaZtBGxL5E6gKYVazCYZ?= =?us-ascii?Q?+qrECQvlXt6tvfizqv8nZxXgkMabOgXg4hcW9ZHwZugNhBdKxt5k6ZNUJjEa?= =?us-ascii?Q?6C0l07Pbt84I1BnO4R2BETSSqmaD1HxlQomMkZ61NVDvSipFl4676h0Aaze4?= =?us-ascii?Q?qOk6JZhxQHdFY5WaYAZOUPm9k9djLtLYvF8WD9TPGdFDlOc0z2PsYN4c4lmK?= =?us-ascii?Q?7G2PGQK3L7hBfK+ZSuDZ/pp20cVgIwqMHnnHlE9UX8DuHMV0istpaUuWTuMR?= =?us-ascii?Q?a66U+WZDh2LwlcBVn4w1Pu5eVGsbCe9P00/7aAuS/TTJWUt17b9RDRwglZEP?= =?us-ascii?Q?ChYeaecM0WWBqW5FxUz+JIfzlJy3KpOnspt9OfLlesyBmx2/yL+m8rCugPwt?= =?us-ascii?Q?Ew2+/QEiXRul/91eF4Mtr+0Ewp8wo1lJEwEi6oQCBAd3dpaUsJAWUPUe+u8x?= =?us-ascii?Q?siHGwToEiUg3vJzY5efuqraOuD9P2BTF0p6t5dJbqvVbHD/q9x/kSj/37bVh?= =?us-ascii?Q?xqJq+aBd4AwM9SvTom3fJWOTqnoQqpq3ZtlZhCr8Bxqz175z68PTijYMmY0a?= =?us-ascii?Q?YYCVCUrnL49MLbUwdNVJOlNiMRvAL95W2WR6Abug?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a470fb27-3052-4293-718e-08dbd6954a9d X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2023 02:34:49.2957 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BBP3jcgGbw09tIKRpAO4FQIIbOxZ/BqmHNqgxhxH+Mn9C2fpIWP9Yc9alBPgi0BJxmDVF7yj1z9uNlIY+nIEVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6678 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: dngv4VEy5ucpiiM00KoS2GWFx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=i0ht300W; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Friday, October 27, 2023 7:54 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH v2 09/11] RedfishClientPkg: fix Strn= CpyS > arguments > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > StrnCpyS accepts string length in characters, not in bytes. > > Signed-off-by: Mike Maslenkin > --- > RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe= .c > b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > index 8ac165dec59e..c19d4a46d6af 100644 > --- a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > +++ b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > @@ -331,7 +331,7 @@ NewInternalInstance ( > } > > > > NewInternalData->NodeName =3D AllocateZeroPool (StrSize (NodeName)); > > - StrnCpyS (NewInternalData->NodeName, StrSize (NodeName), (CONST > CHAR16 *)NodeName, StrLen (NodeName)); > > + StrnCpyS (NewInternalData->NodeName, StrLen (NodeName) + 1, (CONST > CHAR16 *)NodeName, StrLen (NodeName)); > > NewInternalData->SiblingList =3D NULL; > > NewInternalData->ChildList =3D NULL; > > if (NodeIsCollection) { > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110168): https://edk2.groups.io/g/devel/message/110168 Mute This Topic: https://groups.io/mt/102211778/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-