[edk2-devel] [PATCH 1/2] MdePkg/Mctp.h: Correct typo in structure member name

[edk2-devel] [PATCH 1/2] MdePkg/Mctp.h: Correct typo in structure member name

[Konstantin Aladyshev]

Correct MCTP_TRANSPORT_HEADER structure field 'SourceEndpointIdId' to
'SourceEndpointId'.

Signed-off-by: Abner Chang <abner.chang@amd.com>
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
 MdePkg/Include/IndustryStandard/Mctp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/Mctp.h b/MdePkg/Include/IndustryStandard/Mctp.h
index 5e603b9cf6..1c86cc627e 100644
--- a/MdePkg/Include/IndustryStandard/Mctp.h
+++ b/MdePkg/Include/IndustryStandard/Mctp.h
@@ -111,7 +111,7 @@ typedef union {
     UINT32    HeaderVersion         : 4; ///< The version of header.
     UINT32    Reserved              : 4; ///< Reserved for future definitions.
     UINT32    DestinationEndpointId : 8; ///< Destination endpoint Id (EID).
-    UINT32    SourceEndpointIdId    : 8; ///< Source endpoint Id (EID)
+    UINT32    SourceEndpointId      : 8; ///< Source endpoint Id (EID)
     UINT32    MessageTag            : 3; ///< Check the MCTP Base specification for the
                                          ///< usages.
     UINT32    TagOwner              : 1; ///< Tag owner identifies the message was
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109631): https://edk2.groups.io/g/devel/message/109631
Mute This Topic: https://groups.io/mt/101994932/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 2/2] MdePkg/Pldm.h: Add define for the PLDM response flag

[Konstantin Aladyshev]

The PLDM protocol uses Request bit to help differentiate between PLDM
request and response messages.
Currently the Pldm.h header only have a flag for the request message.
Add a flag for the response message as well.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
 MdePkg/Include/IndustryStandard/Pldm.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdePkg/Include/IndustryStandard/Pldm.h b/MdePkg/Include/IndustryStandard/Pldm.h
index c821f081f8..c2909dbd76 100644
--- a/MdePkg/Include/IndustryStandard/Pldm.h
+++ b/MdePkg/Include/IndustryStandard/Pldm.h
@@ -40,6 +40,7 @@ typedef struct  {
 typedef PLDM_MESSAGE_HEADER PLDM_REQUEST_HEADER;
 
 #define PLDM_MESSAGE_HEADER_IS_REQUEST        1
+#define PLDM_MESSAGE_HEADER_IS_RESPONSE       0
 #define PLDM_MESSAGE_HEADER_IS_DATAGRAM       1
 #define PLDM_MESSAGE_HEADER_INSTANCE_ID_MASK  0x1f
 
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109632): https://edk2.groups.io/g/devel/message/109632
Mute This Topic: https://groups.io/mt/101994933/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/2] MdePkg/Pldm.h: Add define for the PLDM response flag

[Chang, Abner via groups.io]

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Konstantin Aladyshev <aladyshev22@gmail.com>
> Sent: Monday, October 16, 2023 9:18 PM
> To: devel@edk2.groups.io
> Cc: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> zhiguang.liu@intel.com; Chang, Abner <Abner.Chang@amd.com>; Konstantin
> Aladyshev <aladyshev22@gmail.com>
> Subject: [PATCH 2/2] MdePkg/Pldm.h: Add define for the PLDM response flag
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> The PLDM protocol uses Request bit to help differentiate between PLDM
> request and response messages.
> Currently the Pldm.h header only have a flag for the request message.
> Add a flag for the response message as well.
>
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
> ---
>  MdePkg/Include/IndustryStandard/Pldm.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/Pldm.h
> b/MdePkg/Include/IndustryStandard/Pldm.h
> index c821f081f8..c2909dbd76 100644
> --- a/MdePkg/Include/IndustryStandard/Pldm.h
> +++ b/MdePkg/Include/IndustryStandard/Pldm.h
> @@ -40,6 +40,7 @@ typedef struct  {
>  typedef PLDM_MESSAGE_HEADER PLDM_REQUEST_HEADER;
>
>
>
>  #define PLDM_MESSAGE_HEADER_IS_REQUEST        1
>
> +#define PLDM_MESSAGE_HEADER_IS_RESPONSE       0
>
>  #define PLDM_MESSAGE_HEADER_IS_DATAGRAM       1
>
>  #define PLDM_MESSAGE_HEADER_INSTANCE_ID_MASK  0x1f
>
>
>
> --
> 2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109708): https://edk2.groups.io/g/devel/message/109708
Mute This Topic: https://groups.io/mt/101994933/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] MdePkg/Mctp.h: Correct typo in structure member name

[Chang, Abner via groups.io]

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Konstantin Aladyshev <aladyshev22@gmail.com>
> Sent: Monday, October 16, 2023 9:18 PM
> To: devel@edk2.groups.io
> Cc: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> zhiguang.liu@intel.com; Chang, Abner <Abner.Chang@amd.com>; Konstantin
> Aladyshev <aladyshev22@gmail.com>
> Subject: [PATCH 1/2] MdePkg/Mctp.h: Correct typo in structure member
> name
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Correct MCTP_TRANSPORT_HEADER structure field 'SourceEndpointIdId' to
> 'SourceEndpointId'.
>
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
> ---
>  MdePkg/Include/IndustryStandard/Mctp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/Mctp.h
> b/MdePkg/Include/IndustryStandard/Mctp.h
> index 5e603b9cf6..1c86cc627e 100644
> --- a/MdePkg/Include/IndustryStandard/Mctp.h
> +++ b/MdePkg/Include/IndustryStandard/Mctp.h
> @@ -111,7 +111,7 @@ typedef union {
>      UINT32    HeaderVersion         : 4; ///< The version of header.
>
>      UINT32    Reserved              : 4; ///< Reserved for future definitions.
>
>      UINT32    DestinationEndpointId : 8; ///< Destination endpoint Id (EID).
>
> -    UINT32    SourceEndpointIdId    : 8; ///< Source endpoint Id (EID)
>
> +    UINT32    SourceEndpointId      : 8; ///< Source endpoint Id (EID)
>
>      UINT32    MessageTag            : 3; ///< Check the MCTP Base specification for
> the
>
>                                           ///< usages.
>
>      UINT32    TagOwner              : 1; ///< Tag owner identifies the message was
>
> --
> 2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109709): https://edk2.groups.io/g/devel/message/109709
Mute This Topic: https://groups.io/mt/101994932/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-