From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1AE5578003C for ; Tue, 26 Dec 2023 01:20:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=vZzQVIgKInsjiwZmbatlG9D/8oD9UmnKnyZ63BpQOCM=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1703553646; v=1; b=ET0uNjG0aAf59IdORojzC3jEEuIQgZHQmsYlcnuzhXwcetzcFQEa1S9JLuH+SrIm3i6CxH9F 9vjzCB5SPKwWbDyiZ84LI+C1OJQz7uf/eTMpxvpafJ3hHtvtrz29Sr8IH23f2P6cmufZ0adC6L6 hl+Yg28/XEA0YgRkuWFzrg1Q= X-Received: by 127.0.0.2 with SMTP id EeOkYY7687511x2VJQdRXFzg; Mon, 25 Dec 2023 17:20:46 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.82]) by mx.groups.io with SMTP id smtpd.web10.73179.1703553645922689446 for ; Mon, 25 Dec 2023 17:20:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WGORUXbGGWOVCZg7F9DYhg5HAGU0Jnxo2o/BqWEPTZ5YScz1yD4ys3bBAIK8s6HI+Z9vQmnLr80LzfFf4jEKZZJJqrBsdvafsbP86wJW6KPwZKS9rWNzSJuleKP1TJXqGNS0a5mPUxTxqQ0wQJiX33HZSm4iSfbuqixJTX3XQ3UhH3OfgB1eXCGcn/zszRCNKIc1H5wXGzt+IvXLtNEzzNOLYDrszSXL8qhYAhz41tAZUN78ME6uqK2c3YkXdMEgLWpcF/1XuUTLQ2v5KogLtj4t4ML98tm97lTMQwZ4PzRtJYKEPfP7D+JwVOmlFa4u13PfyG1kmjOQAi1kkg0IDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=APiBOYOz4/rD+OgdvRUwyEEJ6RHQU+02TumCi4CRBfU=; b=Ni/T0mONy2b1cxh3H7G0fgGg+LXRcbOY0S5caRCOnhb8fOAiw4uhAopSc33o/4l2il0UfkTVQTyfAA72TZoC06W8vIxgxKrnKBKXOW5OhWhQNUFDrhNq6fldlBEHtzn3nrALJ7Y5N8XILe0fv3ogJGGZTkA38SexpEHrzYK3NKfGW7wJj2OzhQAbc9Gwa2jsDUBxYvmd4cBBdoFe0jbK5F3Fs+/bRiakhWI/TSUHplDNpFZgX+E8BCPaLuqxaAeLmGFmuaEVLTeCVBLzEzQbid1uaKVDU1CEIrC8IJfr8qyDmZohLs0seW92bfJxqCB0tpLJAD9pRM1qH11D+Rz3lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM4PR12MB6134.namprd12.prod.outlook.com (2603:10b6:8:ad::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.27; Tue, 26 Dec 2023 01:20:43 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7113.026; Tue, 26 Dec 2023 01:20:43 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v3 14/16] RedfishDiscoverDxe: release resources when refreshing information data Thread-Topic: [PATCH v3 14/16] RedfishDiscoverDxe: release resources when refreshing information data Thread-Index: AQHaNrzjpIWIPlZ8IEKnyJkq3giPKLC6xe5A Date: Tue, 26 Dec 2023 01:20:42 +0000 Message-ID: References: <20231224225927.9119-1-mike.maslenkin@gmail.com> <20231224225927.9119-15-mike.maslenkin@gmail.com> In-Reply-To: <20231224225927.9119-15-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=facce566-92d1-4ef3-8ed0-fe8dece2ecac;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-12-26T01:20:24Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM4PR12MB6134:EE_ x-ms-office365-filtering-correlation-id: 25d4095f-3efe-47e3-fbaa-08dc05b0e100 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 1gyhF5LvExbO+ZIuMVfPoXkWSXWq5XdsS5y3LtG+xnmfgF0ySPu88F9T4phcw4h5n7Vyh8Z5BE77nSd5YPa40Zf9nmVPm58C2IPG+ud2XmdrmNl4TICU3+oBe+NdOtQqvHa2k67LyA39DNY2Pgyq/YUOnIEr6fCxIXz1YqFKk1M+HtkooCwJhVXy0XcGPN30LBRAVeGZ7T8SnJQ3oLhY8ZA+Ch9PKmhqynTZse2fQEKxxG7xU1oirOmuojxcOWv/KGLpGKoeKVrNZX9OEKX7g5k3W0JoAvpUcoFjk+m0Uyhe2AxbiOFCtmm62TOkJ5WKj22w56H8YHEi3kaJF7RwFcaBGbpTN7oMI/EQkneS9VNAFxNnKQ+TaXuCFB8e9XJoneuYyFp2ntLzS9IvIuu5gqO0V+WrtrEYL0qSxuKpL2N/Ewlq+9aCODeI8Sj1EWjgKyTqMvWJtp82T62rMTDaTvut/7dvt8iqf8/QpgHNiI8hGCntikcv4sss5SG6taktr71HoNsvGF6L/uQ13km8dGKFUmdssTOgk884efjQMVZhFwxlLGJGc2fGGM4TF+dTNILLdFuzaFAHAbGHEozAeEztEax66NuWZN/Pp7U1DCPcXwOh9GyE0eKhU3ldSMTmGYwdF61pXfpE87b0pr1onjbVlb4It2Bi1hsVDOm8NkI= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cyB6XpC8oMw60Sp6emlhYYumfy2hKpP9hLXvotI61zJWqF3z90Grfw/x08FA?= =?us-ascii?Q?/5aFXUgug22CDkY4OdhYka1KaDeFyBZ5Ms7bFuMvVYbY5XImPIEVSL0PagGW?= =?us-ascii?Q?l8RP9dfYFqqq2TcPRQY7iBOXB6wA8UOreH9f9uuzHunw8FbXV9evozUsh0e0?= =?us-ascii?Q?e+zGyYs63n95b0uog8Pty2zrFQFRiLMjK48wd9Xkbw3qUY+O6XTQrZapNptv?= =?us-ascii?Q?Sk4sRJFTSCtxVNv4+M4jOTgVfkHPaClO1Qi4hx7eLjWEsOyCsbf2bpiwr8uY?= =?us-ascii?Q?4N2OxAIZeauiC/r3YOcLXBs9h8jtrVk0CHrit+1B62+yUY0ue6q30wFhh4m/?= =?us-ascii?Q?pcSqjdm71dlm7RaA+TWjQ6XfyRnwR4ZLYJFDFv5VghFm0GbN8cPqQA5Wmt5y?= =?us-ascii?Q?LSz1u6gkXYkEh20nuafe4YNH8FMLiWIXhJGacRwTMRkKqID6xfijee8LJvyH?= =?us-ascii?Q?48bOejXYapmYu2lZwg0YH2+Jj1UBabS20yKigIHuQTP1i5tJqmJzNkOSxit6?= =?us-ascii?Q?Xpc7cAcgFJKC+x0/dMo7GcIV8jVnIpLqME0mKmSqQIB33tT9zRonKvlWkd/B?= =?us-ascii?Q?of5f1dxZMDbMTWzh/ETi62mLRMgk7qIZ8j8KVB6e87mu+0UIpeeXPdkFPKH0?= =?us-ascii?Q?gdriCpE1OZz8g+LJoqpDGC+Ww1NSGUrzMCsb7ob8MK5ajFXrNrlXy5XtZ3Iz?= =?us-ascii?Q?LbWv/LyZK97JhE7CLmGcuyQ+9hOULHn87oKssBaFCT7XcSo4jkrZToc25Gif?= =?us-ascii?Q?dyL8007H+2nR9lz2WnNTF0GokHKMpI3ridd9eC156x5YTlouoUazkMpr/lwL?= =?us-ascii?Q?m6zByOjN63aNE+n1arXp49RH0+T65JNh0z+/yhtLwhOfMO8nYbELJMWo/BjL?= =?us-ascii?Q?jWoJHZleq5psGI/EmhbQ0kHFpoo1+Bhb9CFhWkPprhAYVRm9PZKrMd0oF5L7?= =?us-ascii?Q?Li/W7xd/tNdRWfRo1IqY7AdG5zv0mB5DW1NN1isr7S0cMKckccD6hm8TdEjl?= =?us-ascii?Q?/0p3MxOAYnVE/6D3dWahonBdD4opq/K82bPmGmH3N9GHb2V1Evjm/YHyPDxA?= =?us-ascii?Q?tIC53tuJDlYlYgGWPrR2MSC9Gzb84giww+jpb9xzbX31395aA46kCdi6T7DD?= =?us-ascii?Q?kDFMEFcw6kvwMB/v0mNXnaux/Qjb8Jdkt+6NONymZb1XUkD41mSqtWr3Mcs9?= =?us-ascii?Q?YVKtswlZzJ/x6LHz28XqVVQKRia1mjmJdpJ/5+c+VCUntbc7EskLYIBthPdp?= =?us-ascii?Q?wps7xhRhss7sQ2ZKZCs1F0vCmLUEkRZKa+jw79q6dHVO3khkbuHIaDcWAYXK?= =?us-ascii?Q?Ompfl/DGwMkDA4KppeWHBnFwvukCP+QhJMwuqrQxfkOgLBZ8XAdcsOm81gOh?= =?us-ascii?Q?8ExaDD3gBZ3MVaerBah8vBKnneQ3qBnz82vWwVXDO2TdIl+bStTqvbLq3Ib/?= =?us-ascii?Q?BXc4cAH5o5CVZXGVq/RwMUn59myJxUu1+NjZ2KF4JAIqv0A24a2BwxK/HiYd?= =?us-ascii?Q?qQY2BOp4C9bUsoKEC0rajOOKVOaN3TmL6e7FrItx6uVKGGWdPhalgCpdh4zX?= =?us-ascii?Q?wolKhvvofimEkwMeJPI=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25d4095f-3efe-47e3-fbaa-08dc05b0e100 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2023 01:20:42.6757 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d2PP+dMac7jiYPQzuvrmJndW2XrDThaZ8hYNFQrZ+2IOa3NhK7QU1E7KoXzC0IhZ+b9wAPbS4Nus5wAG+E1aow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6134 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: KHtUx2SWZDtD5Ss54wMYfxAlx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ET0uNjG0; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Monday, December 25, 2023 6:59 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH v3 14/16] RedfishDiscoverDxe: release resources when > refreshing information data > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > It is required to free previously allocated strings stored in > DiscoveredInstance->Information structure. > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > index ff0c3ff1d1f5..bbd1f4b86400 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > @@ -961,6 +961,8 @@ AddAndSignalNewRedfishService ( > FreePool ((VOID *)DiscoveredList); > > return EFI_OUT_OF_RESOURCES; > > } > > + } else { > > + FreeInformationData (&DiscoveredInstance->Information); > > } > > > > DEBUG ((DEBUG_MANAGEABILITY, "*** Redfish Service Information > ***\n")); > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112895): https://edk2.groups.io/g/devel/message/112895 Mute This Topic: https://groups.io/mt/103354133/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-