From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C1937740034 for ; Thu, 26 Oct 2023 05:03:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mLGFdwrPhdBQN8uX5iiL7mqw++i63MvCmv5bqaJb3Do=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698296589; v=1; b=nwaPui4pyqKaFILtStl/jV9hLY2oFfujprzZNU7omFQjr5LO988u9HY8Cw4hL0Bz4tqdhwJs t8quvPGrNPUIuHmGF2k56Shq7LpMyMm4CpSD4OErpC1DMeQnmSV8RR/+A5RTwqB8Xo1TVevMNR8 fEo1WP+ohYUHc+5EEPpf+O/A= X-Received: by 127.0.0.2 with SMTP id bLwyYY7687511xLtsAgtvzj7; Wed, 25 Oct 2023 22:03:09 -0700 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.80]) by mx.groups.io with SMTP id smtpd.web11.63794.1698296588365562847 for ; Wed, 25 Oct 2023 22:03:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ox/ZG3GE0y47Hfqhqc0tLHuUplGM3kU8KAzu7YaF3bTi8kkrYq7BasI+0yXqev4Rt0T/g+U44VWLVNHrkK+jxh5kuNwhZR4hcv67XltYeHIMQjB3b73Q2tlNvOxU2y0s2BgZaP/heQ5dqRNTJqCMiqSaZGDFPMZDTYQOCMNkGEtKrTrhGBcvaF+0sNbiDuCWarfkfYqIPe2B22JIPS6yAT12Gm+yrHPKo7iW3OCA4QzVxmWdeDupDKgRMSBQki+9Fdy5qiONxxJWqKE7Ts+EAtF4W1n8NyWJsc5paUvLmAr3Ld0BH4hA2OVvbRcuDYlGAxS90k/wIhTkABvvcisrcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VBlD93Wji2717W90rNdv0eEsfw2Kf3uCydtXVfO0UBk=; b=n+mRozwLNH0QWrVsbLhEqkhkrIN9pVfuDSHFzlWNOi34a2xcmcyRu4HN4FfAOxE8J0x2pJyESPlXzSGCw5dM9JmEZ2+HblIbNer4wN+NGeXYjJKOP8/AULw66WcCkVirud0hoiTuox4mnGYhvaIk+Git/KPEnl/H20A8ODTEAoRFwJrue8Ow32Syw/vqBXAsVo+8Qy+sufxaijZZy403P6mqjuh1+aSFI+CTMXPg8GVZ8iWIeTZp+bDQ5Knc7svmzPllO4jtSIthB1nwo3EcNA6cfSj/bVsAs0vK+GE/nOrohlLBTfLDF+poXezvovsdG1vdzHzdy59rnP2o/PfCFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MW4PR12MB6683.namprd12.prod.outlook.com (2603:10b6:303:1e2::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Thu, 26 Oct 2023 05:03:05 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420%6]) with mapi id 15.20.6933.019; Thu, 26 Oct 2023 05:03:04 +0000 From: "Chang, Abner via groups.io" To: Konstantin Aladyshev , "devel@edk2.groups.io" CC: "Attar, AbdulLateef (Abdul Lateef)" , "nicklew@nvidia.com" Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 00/16] MTCP-over-KCS support Thread-Topic: [PATCH edk2-platforms v3 00/16] MTCP-over-KCS support Thread-Index: AQHaBbGU+a9whfjsFECc0pszYz6JzrBYO1vAgANMZjA= Date: Thu, 26 Oct 2023 05:03:02 +0000 Message-ID: References: <20231023130511.4521-1-aladyshev22@gmail.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=6227ce01-fd3a-4603-95a6-8231d3e29f57;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-24T02:39:55Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MW4PR12MB6683:EE_ x-ms-office365-filtering-correlation-id: 8540445b-3753-48af-8b70-08dbd5e0d544 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 0od1C3FKLzhaQn0qB0vtiKNaaF/NSSB09xsyQU6GmLxQ4VGg4RNG7xiohK9A2oAEAq3AElqU31foMq+fb0VtS7aLaXPZeaRm0NpHko/eZoisPAo7/qZO3pWSCPDttZNmbMSMgwUZlb6+0S3Eb5VGuwgBNBDXwECzVoEA9zDlzPFX9NILp0ZZm7NplFqalMl7EHY5s5c/yQ7FzVQNVATETPMwOuJitRMif/eIQr2fFuG+ameV0EYasbIqkfBkw1qC9jff7k+g4Tw0/2sZg70Dp7l4j+zcTvnNIdChF4zWPSCkoakInaCMSAeYMiDgVA7iB7CvIiqtsYfRPrcB6T/2Bl00J8AMYm6lzTO6g3quH4Ip45fXgxpzy+QdOZWtWU+moOEP2NA7nPPYoeQcLLi5Dh+tKwixY+B541A4VbEvQjGD4YNPEDYmXWwOnVySKh0Y/j7pN95132I5DArZuI38MxRpNWra0Acf7BPsjdvjDwS0tqzNv8jTd6dXsZzEaIrffs8xYDYuTzcrbSzKSKZSdZxp2SpNvyIO9C6du82keqgjF/AOHmD4MA7cKCHi2uig0LHhp1mxFWt5ugmgk6fTROADdtE5tFESX7to3dp5VL1Hon2JEXX7UtlWxRC2svHwyiL4oGQGimgU6pnXyuFmuw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8YKs+Sza5dtdLr+K9GudrHKZfTudgEhMcLPWH/b7g4DWKtSpgpc6mlPdqvVJ?= =?us-ascii?Q?UjaJwXp7lEDQ6zCs0H0UFpXKIPbGHstzpFuGHPl7mCZ+Q1gjtSRxlmpjJSy+?= =?us-ascii?Q?OTlyTeb3oHVByhZWLqEpXIWBVB2Ef7Ifltq9DFsLTDPEflcVfpqAbQxTypak?= =?us-ascii?Q?gDSNt3kuPG7F/iZCkha27jGtdhvrvehKtmrD35XQKRUpxaUDKundKPuLh4yr?= =?us-ascii?Q?dH8tFCrZVP8qcAvXa4LNTR4FrtX80oFI00SIWw3tk4JN5biekMcsJyc9Auy1?= =?us-ascii?Q?jkl9bpLSHR/Wtqr0t1HJOnzEFStF53vzXUBu2aXokRqDw8zTMndwuLPAY32g?= =?us-ascii?Q?6EOfDW/R9Y3O/tifCOtZHIXhDb9lpjoW3iUPMt5rPEf2hf6MEteiuqHXtb2g?= =?us-ascii?Q?kfT+m9vOLOcuosposLOipfE0rBOC1r5XlI5MtMiFpQHzA/3EH0kLF0mKez4k?= =?us-ascii?Q?vYwOBxSihVHUiDVtVkTDxaFV4njShd1Z+3/4tBXqFzePUXTADFU4H7o4W6qo?= =?us-ascii?Q?NF6lqARljZ8iCRuChMdGpy9v2S4Q6RW7Dqp/0ilpRl4DBx/MmbpIfSl82Bwl?= =?us-ascii?Q?KTKI/j2Be9iPHQvLjFjI26dH+UIg68kShX1OjB+ZM9i0N0+pqzxLjDlMZw8M?= =?us-ascii?Q?CjE3+FsJPjZ+S4j7cf7CYroIMdVAOYuof2x5oWr5N45Me73ujVVkz8jo8TJt?= =?us-ascii?Q?bsXbiR0PbDbWpFqnbO5O69x0l2sm5BOjmaGFa6RMX7nycDHoRDay5MZYT4Bb?= =?us-ascii?Q?6lR2WmlWnlgbeILr8Uhd4j4ANf0dFvBFJgBYX4NrOUSPl93J7FXRPWN3Ov+I?= =?us-ascii?Q?StK7zUAaFT4inz5nqsm0OWN2GNVXzsEaMdMNA3nR7skt+1qMiu5wdEtSSk/W?= =?us-ascii?Q?cWvuyM9jsBsCWoZ2afU5//FzEPMj2Vsz63vm9q7LfYwWQtDflmljlO6mUXEf?= =?us-ascii?Q?FCggPU7xVOjVIjPNJ3DaZu9xEsIPGfI04PsUG+yIoj1aFfeOyiY62rdXceXh?= =?us-ascii?Q?l3Z8HtEX9FR8SivNvK5SENI0GRBjgRCYKNpaPm7Wj6DPZ6BZapp3IXgOmhNf?= =?us-ascii?Q?GuReo6004sernspLrkP3RJ5dgg3yktCpw2UuRPoXei0SIhOWxNbrdT+wHgNt?= =?us-ascii?Q?+U9abtXDcTThSo0nXDjw6Ifpb2eygNAhf2NO9Y3Er8c4nZTLRIMZPBmGl/ks?= =?us-ascii?Q?Sbp1eoiC2itJ9s1R1IoGITnO7iDQGRyLBTbddTAHpZqG4hBytMoFA7paoc89?= =?us-ascii?Q?Cm77MXv3vYEF9/36fMdJosCZZ+CGJ849L948K3dfnOi/wK18CYjp3J5ODAug?= =?us-ascii?Q?417fUyP7VdW8Tb7eS3u1ASFTG84S7ve308ADV2kPMYdOeC6tFjK9Ri7YV3DY?= =?us-ascii?Q?7i4/Pbc/jzJpvk0+gohdDSwKl4/zhgFPXKexjk766csDJVioTBcaWFlVoTaP?= =?us-ascii?Q?07h4nFUJCDvtCnRFXdWdar7FP6lplYEESxf16w4V/XxqG8MyA4ebD6LEKw2+?= =?us-ascii?Q?4xRBxQP2f8LZj8xFiSA1lFU5j45bQFbZOkNqMfkBmJsUw/8RUec324L9dMip?= =?us-ascii?Q?GWFLKjlEvIFnqS9IBOY=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8540445b-3753-48af-8b70-08dbd5e0d544 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2023 05:03:02.9954 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l+5xGBlaHAnPz5MV9sr+A90NE1rlW4xt9AV/Ok0uvlTSlpCmq6XqPKL2XR5/AteDFelNcMz2GemTz4+Woz9IhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6683 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: maiVTypaBBS7d7kJOiPX5Tanx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=nwaPui4p; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Merged. I will send another patch for Uncrustify updates if any. Abner > -----Original Message----- > From: Chang, Abner > Sent: Tuesday, October 24, 2023 10:44 AM > To: Konstantin Aladyshev ; devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; > nicklew@nvidia.com > Subject: RE: [PATCH edk2-platforms v3 00/16] MTCP-over-KCS support > > For entire V3 and the additional patch 16/16, > Reviewed-by: Abner Chang > > I will do the Uncrustify check and merge this patch set once the correspo= nding > edk2 changes are merged. > Thanks > Abner > > > -----Original Message----- > > From: Konstantin Aladyshev > > Sent: Monday, October 23, 2023 9:05 PM > > To: devel@edk2.groups.io > > Cc: Chang, Abner ; Attar, AbdulLateef (Abdul > > Lateef) ; nicklew@nvidia.com; Konstantin > > Aladyshev > > Subject: [PATCH edk2-platforms v3 00/16] MTCP-over-KCS support > > > > Caution: This message originated from an External Source. Use proper > caution > > when opening attachments, clicking links, or responding. > > > > > > The Manageability KCS transport library needs to support requests both > > from MCTP and IPMI transports. Currently the code only handles IPMI > > case correctly. > > In the MCTP case the communication should be based on the MCTP-over- > KCS > > specification (DSP0254). This specification defines a special KCS > > binding header and trailer structures that need to be present in every > > MCTP message. > > The header structure contains a length field, therefore response packet > > size is not needed to be known beforehand. > > The trailer structure contains a PEC checksum that can be used to check > > itegrity of the response message. > > Modify Manageability KCS transport library code to check which message > > is processed (IPMI or MCTP) and handle each case correctly based on its > > own specification. > > This patch is a result of a joint effort from the Konstantin Aladyshev > > and Abner Chang . > > > > Tested: > > PLDM communication between the HOST and BMC was tested with both > > components implemented via open-source software: > > - The HOST (UEFI firmware) part was based one the edk2 [1] and > > edk2-platforms [2] code, > > - The BMC part was based on the openbmc [3] distribution. > > > > The testing process and all the necessary utilities are described in > > the [4] repository. > > > > The provided changes keep IPMI over KCS stack working as reported by > > Abner Chang. > > > > [1]: https://github.com/tianocore/edk2 > > [2]: https://github.com/tianocore/edk2-platforms > > [3]: https://github.com/openbmc/openbmc > > [4]: https://github.com/Kostr/PLDM > > > > Changes v2 -> v3: > > - Add new patch that adds PLDM completion code check > > > > Changes v1 -> v2: > > - Add new patches with corrections for the PLDM protocol. The > > resulting communication via EDKII_PLDM_PROTOCOL was successfully > > tested. > > > > Abner Chang (4): > > ManageabilityPkg: Add PLDM terminus PCDs > > PldmProtocolDxe: Correct TID argument usage > > ManageabilityPkg/PldmProtocol: Remove PLDM command table > > PldmSmbiosTransferDxe: Implement Set PLDM terminus ID API > > > > Konstantin Aladyshev (12): > > ManageabilityPkg: Add definition for the MCTP KCS TRAILER structure > > ManageabilityPkg: Check MCTP EIDs for reserved values > > ManageabilityPkg: Support both MCTP and IPMI in KCS tranport library > > ManageabilityPkg: Check header fields in the MCTP response > > ManageabilityPkg: Correct typo in MCTP destination EID field > > ManageabilityPkg: Update the algorithm of using MCTP endpoint ID PCD > > ManageabilityPkg: Correct value for the MCTP TAG_OWNER response bit > > ManageabilityPkg: Don't check MCTP header fields if transfer has > > failed > > ManageabilityPkg: Use correct constants for PLDM header checks > > ManageabilityPkg: Return error on multiple-packet MCTP responses > > ManageabilityPkg: Return error on PLDM header check fails > > ManageabilityPkg: Check PLDM completion code > > > > .../Include/Library/BasePldmProtocolLib.h | 16 + > > .../Library/ManageabilityTransportMctpLib.h | 9 +- > > .../Include/Protocol/MctpProtocol.h | 12 +- > > .../Include/Protocol/PldmProtocol.h | 18 +- > > .../Protocol/PldmSmbiosTransferProtocol.h | 26 ++ > > .../Common/KcsCommon.c | 284 +++++++++++++++--- > > .../Dxe/ManageabilityTransportMctp.c | 4 +- > > .../PldmProtocolLibrary/Dxe/PldmProtocolLib.c | 49 ++- > > .../Dxe/PldmProtocolLib.inf | 6 +- > > .../ManageabilityPkg/ManageabilityPkg.dec | 6 + > > .../MctpProtocol/Common/MctpProtocolCommon.c | 129 +++++++- > > .../Universal/MctpProtocol/Dxe/MctpProtocol.c | 51 +++- > > .../PldmProtocol/Common/PldmProtocolCommon.c | 148 +++------ > > .../PldmProtocol/Common/PldmProtocolCommon.h | 25 +- > > .../Universal/PldmProtocol/Dxe/PldmProtocol.c | 69 ++++- > > .../PldmProtocol/Dxe/PldmProtocolDxe.inf | 4 - > > .../PldmSmbiosTransferDxe.c | 28 ++ > > 17 files changed, 690 insertions(+), 194 deletions(-) > > > > -- > > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110070): https://edk2.groups.io/g/devel/message/110070 Mute This Topic: https://groups.io/mt/102134646/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-