public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: Mike Maslenkin <mike.maslenkin@gmail.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "nicklew@nvidia.com" <nicklew@nvidia.com>,
	"igork@ami.com" <igork@ami.com>
Subject: Re: [edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script
Date: Mon, 2 Oct 2023 03:25:00 +0000	[thread overview]
Message-ID: <MN2PR12MB39667C4031B22A5E54107CBCEAC5A@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230929222414.47115-1-mike.maslenkin@gmail.com>

[AMD Official Use Only - General]

Patch set Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Saturday, September 30, 2023 6:24 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Please, look at these changes. I've had some troubles when tried to run
> uncrustify checks locally on macOS and those fixes helped me.
> Also I tried this set on Linux and it worked.
>
> Here is a link to PR:
> https://github.com/tianocore/edk2-redfish-client/pull/53
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109252): https://edk2.groups.io/g/devel/message/109252
Mute This Topic: https://groups.io/mt/101667892/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2023-10-02  3:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-29 22:24 [edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script Mike Maslenkin
2023-09-29 22:24 ` [edk2-devel] [PATCH 1/2] RedfishClientPkg/.github: tune file list for uncrustify check Mike Maslenkin
2023-09-29 22:24 ` [edk2-devel] [PATCH 2/2] RedfishClientPkg/.github: fix " Mike Maslenkin
2023-10-02  3:25 ` Chang, Abner via groups.io [this message]
2023-10-03 12:49 ` [edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script Nickle Wang via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR12MB39667C4031B22A5E54107CBCEAC5A@MN2PR12MB3966.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox