From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web11.8474.1688523528313108767 for ; Tue, 04 Jul 2023 19:18:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=cDBRMiPz; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.40, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OiT4TgY2RBUJx88ZRBtuikRq9dwpwL/YtnCLYlDq6b4/s/PgsU7f92oOqj+tTlZw4GqXP0MmSx5MAXPXt6PV2Yt+5eWvKHRe2wUHkD3Tde3BsWK9IXg1TPCMeY9wB99Pt9xGMK1xMt2VkJQcY2RC+M54WPaPX+LNsXu+R933rDUj2dW4aipVLle1s36KBB4R7a2QXoOVMCKMV1yUBY+MuLdN8/UX7FNxc/kNS3Mb2igaZLVVOJmOm4xCTDxYTIvYeonKWilYv1czZBSbwtks8WcSFGYgkTOq5rsC7PImIH20aAPhISed9IiCGzPq+T7FGeDtqtY7SC5N9SwGXG6ZAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pqi4Ih++5LUpB0WzjwZIjE0UbB9WBw/ljAIyetkdlJk=; b=MrOeRc4N9yyI+ZhjPAP8amLh5lE5eUYYkJkxG6vMVXKUqSrIK8JhWXZtjp1ooguVlVbQJ+aNgWEA0mjZ7+VdmAL5kzSXJHjq4SiY6W1dfNfbjjy+jjit/m/wgVxQpXvTHt6fFfh41aqXq5iTuJs3epY3ft7bvElyQ25Y5C6HCWyimkAZ6/Jz+dEMsKo0YZVIWXaI4tFIWvDSaUL6vksYdhZkN2f9S8ZMAxVAGroQXef3A2FeW3tTUvIR4GyO4HSUNy3UsZvql9F1n/mR85+HjHVSXXQr1Apxn2bWLznSW+3Z6NNdHq1DLypm0O9N23dlTZbQ65wv2uwgEBwHIBIW4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pqi4Ih++5LUpB0WzjwZIjE0UbB9WBw/ljAIyetkdlJk=; b=cDBRMiPzRY5AF+liBXHM5WkfxQZQHZFAt/PIque4PZC0AvVQYtDtk0q7QKGEC1tCSLC59jzQ+cYVSQrP4vjP/DMDxdDUfFDMllUcL/iLgDo8EIAQIhSJn5n+uDIpL4OjzLDmRiWSkG9Z3gHnkUOYQEZ/D/JJ/Y+aJvdwGCc4LoY= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MW5PR12MB5598.namprd12.prod.outlook.com (2603:10b6:303:193::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Wed, 5 Jul 2023 02:18:45 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040%6]) with mapi id 15.20.6544.024; Wed, 5 Jul 2023 02:18:45 +0000 From: "Chang, Abner" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [PATCH 2/3] RedfishPkg/RedfishPlatformConfigDxe: hide debug message Thread-Topic: [PATCH 2/3] RedfishPkg/RedfishPlatformConfigDxe: hide debug message Thread-Index: AQHZrbEqHYjBuuV80UuK4KosFlvSBa+qcXbg Date: Wed, 5 Jul 2023 02:18:44 +0000 Message-ID: References: <20230703132023.7184-1-nicklew@nvidia.com> In-Reply-To: <20230703132023.7184-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=50a6200e-1573-4b79-91a3-9efe891c0600;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-07-05T02:14:27Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MW5PR12MB5598:EE_ x-ms-office365-filtering-correlation-id: 7098645f-2b31-48dd-e34e-08db7cfe28ba x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NMWHgknb5ZgjkPLa5AWDbdsvo5VV0Km6eb21s8Sf++HklQCI0fmxBnuojK6tm88uu+SwPr6HpJEvW1/GPSIf+4ZkdqvIhbAkmmUaryC8cuj8pcyAAccvqwlLTg0iCnkioJ5AbnzEzw95/7sUHejUBGxjIc1Yb81iGQF1DnpTbJPW0XjB9U3b1gyUghRsFQMU1Kws9sXf6/NuqlVd88tz41fEzNiKpLGyqPu9+kCSEQmzEz/JoUFrbPke7WOBAdmTs8Fd0wdpqMZ/H70rzxwtdIQraOuWDA1nsbA/0S6K5vKFnBlE+X0ECkFbnDPyIvclrL1D26FFphQkGtV2qfsoxKFBWOrOl3O1ZiOjRdtk53OALXcoEkqtcyKPT37+yWTEU6UiI8Hm2QjTCLzSdGqLQzIz6tWk6bWue0lPWmAIA7qj/8NDjEN8u4VwTiORt0LHnMTQu7lVtW9wnix9kvpxvbkX94SipbpR+AwlZHL4Ra8cOT2yRXBQ1+JfbLR1DmlQ40yKDTJCdHTrnHqLGs1tfk42bKLzi3gEmMrPvTBQoyvbeRkut1Xc5GDmsTD6lVXe3UfuVAcsOGgVPV9/uBwnuSYggjlxLBHTdnTkeIweZOA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(376002)(136003)(366004)(346002)(39860400002)(451199021)(2906002)(15650500001)(52536014)(8676002)(86362001)(55016003)(8936002)(5660300002)(110136005)(54906003)(53546011)(26005)(478600001)(7696005)(71200400001)(6506007)(186003)(33656002)(9686003)(38100700002)(38070700005)(122000001)(83380400001)(4326008)(316002)(66446008)(66476007)(66556008)(66946007)(76116006)(64756008)(41300700001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eubCVSxPl8WDNapc05YsXX8uRxVdkMIHGXLNeHvYEJnSW7851gUwGCKLcGc8?= =?us-ascii?Q?wzzW72vCCmUpIiniUGS47XSrJzVhv8JN+aFJaUETKAjooj0RM5BARmG2b9RJ?= =?us-ascii?Q?PhUevy/4CvjSBbFeaCTPSnilra+kMdEXaT315haPmVmxL4MBM7AsHZtkCNw1?= =?us-ascii?Q?yORbXzIspP7P/qeNXVd2Wnh/yUNLS6pa7qJvQYMR3U54bzGggVndYuWJk9R7?= =?us-ascii?Q?cfxKhGIlob2iCQ3t+kOh2FC57RWrdJnZYqw18Sxdhq/suo6/kYO7Q/+8YaNo?= =?us-ascii?Q?A8fdaijt08JE9iT+w9c4kBhn1eAiO6JsuIQpQYQwgS4xYcxBfqc2ougF1q8m?= =?us-ascii?Q?I3Kxt6DG/8kYWBh6dbdvR0eC1t2ShFwEo9w3jmRgFd0wuR+1VJx0uPMPv2pL?= =?us-ascii?Q?LO3FL4m5ddnFFtTprwQ6p1bzY9h9cnvXilrS4IxRgLIngLLKxEMISR6pkSmK?= =?us-ascii?Q?0luFEjyubfGX0Kgb3laH/2/uD0nRhnL33ZbGW1SlLBmwdsabUPasGkylPQ1F?= =?us-ascii?Q?/Z679JqmqxWcE1Icadz6X9A4mKi7gi+kq0sO3J2ZdzfRATAznOLVU2ix5kjd?= =?us-ascii?Q?+SbwuTQGMAct5SYA9TrHvuKg2gdlDRQAT4SoMV35p+dN+c8B/IMSlY6j/lad?= =?us-ascii?Q?u4dMyaXTQ3sUULmLU68iIlxM36lM+dwCnPiS6TvqUC+cUac8PegIbllbIHCJ?= =?us-ascii?Q?lR+x6kcUqRixTuwS7VfudiOyVIaGJLUrP2Y7Als+QXw1F9NuF2Z+TUIifKRT?= =?us-ascii?Q?6t6K6IpZ+hvIXikf/oeIqU5zZvRJJO8pCfPOJYsBkzpleimKnTbzA8MPvCtF?= =?us-ascii?Q?onMxb5orTYqO5KxmIHedUMK8JE0XjpGO8vkL4e0jF08/6lZrNOp4dUMFQTzI?= =?us-ascii?Q?/ATjFopvsK34yV86dksC/5G0G0cx/RI0fMCuCvsrXKWDqV+u9aOLf1iLDIJn?= =?us-ascii?Q?v/iRf6L7W9IoznK61oTGPR5cLoDso/8esUrcX19Co/XQXe72yHkVPRaRzSaY?= =?us-ascii?Q?H7b8jqavnRGFa+A8YRJJfYLeZ2E7GgMlHwwKH2JIthkl4Huw8tYQbftnoMIT?= =?us-ascii?Q?aYzH9WYlqtUyAc6XM6JaVlKQGkjUwMRIFgOruyx0JfRUG5IwdK+4TZyDJWhe?= =?us-ascii?Q?dbRN3PAgUBLc536rwFV/KghsHhSSmascZtNQ5LRr6mAriktOBOkdOZ6I9fYK?= =?us-ascii?Q?Oj10xw1et7Yl45x9pLQ6u0DeLqoxDEQrgG1wEZ8Q6Eapt1sOQI7yc1S1NwKZ?= =?us-ascii?Q?ObqHZDjahNUXk+FaRh7SL54QAcSHWTpOFTH3y+SAkqg5QhriQ3Y8tN5FXjke?= =?us-ascii?Q?1rE0eKMx8ci/nwEE8DP8i4Y0MOQchuo4P2E7/xKTHk/sCpJvi9RNCTa/AB6d?= =?us-ascii?Q?qvsFJiINZOKqk7Z9AtxIdi1hUSkLEk6rVwBmtkF0NV2sZYua5QocurOoIL4J?= =?us-ascii?Q?jog8HLTv+7rvYbk9J/fUx8yXY9maXqA0OxHt9JruJXw/xKoybAOk6EdvlBkP?= =?us-ascii?Q?GrJhA2+Nl+fhL25Qg3GOBiaQEehjeIxPd/L1MnoPHubugW8gZ+S5TNgjuiIR?= =?us-ascii?Q?sO6BjwtlRobYB+XgsPo=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7098645f-2b31-48dd-e34e-08db7cfe28ba X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2023 02:18:44.9727 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +Lh2A2Gz4KzDg6bHcMiQ8HJoEKuvKCfHEdSlh4ytSMrCn2C4TyubfnUOphtMODW5Gga4Em7ebLrQwSCbgSo0ew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5598 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Nickle, Besides using REDFISH_PLATFORM_CONFIG_DEBUG, can we update REDFISH_PLATFORM= _CONFIG_DEBUG to DEBUG_MANAGEABILITY? Thanks Abner > -----Original Message----- > From: Nickle Wang > Sent: Monday, July 3, 2023 9:20 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH 2/3] RedfishPkg/RedfishPlatformConfigDxe: hide debug > message > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Change debug message level of showing ordered list op-code > to REDFISH_PLATFORM_CONFIG_DEBUG. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > .../RedfishPlatformConfigDxe.c | 24 +++++++++---------- > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe= .c > b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > index 462f269f6a3f..f2a8e77d9b00 100644 > --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > @@ -955,12 +955,12 @@ DumpOrderedListValue ( > return; > } > > - DEBUG ((DEBUG_ERROR, "Value.Type=3D 0x%x\n", OrderedListStatement- > >Value.Type)); > - DEBUG ((DEBUG_ERROR, "Value.BufferValueType=3D 0x%x\n", > OrderedListStatement->Value.BufferValueType)); > - DEBUG ((DEBUG_ERROR, "Value.BufferLen=3D 0x%x\n", > OrderedListStatement->Value.BufferLen)); > - DEBUG ((DEBUG_ERROR, "Value.Buffer=3D 0x%x\n", OrderedListStatement- > >Value.Buffer)); > - DEBUG ((DEBUG_ERROR, "Value.MaxContainers=3D 0x%x\n", > OrderedListStatement->ExtraData.OrderListData.MaxContainers)); > - DEBUG ((DEBUG_ERROR, "StorageWidth=3D 0x%x\n", OrderedListStatement- > >StorageWidth)); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.Type=3D 0x%x\n", > OrderedListStatement->Value.Type)); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.BufferValueType=3D > 0x%x\n", OrderedListStatement->Value.BufferValueType)); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.BufferLen=3D > 0x%x\n", OrderedListStatement->Value.BufferLen)); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.Buffer=3D 0x%x\n", > OrderedListStatement->Value.Buffer)); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "Value.MaxContainers=3D > 0x%x\n", OrderedListStatement->ExtraData.OrderListData.MaxContainers)); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "StorageWidth=3D 0x%x\n", > OrderedListStatement->StorageWidth)); > > if (OrderedListStatement->Value.Buffer =3D=3D NULL) { > return; > @@ -977,7 +977,7 @@ DumpOrderedListValue ( > Value8 =3D (UINT8 *)OrderedListStatement->Value.Buffer; > Count =3D OrderedListStatement->StorageWidth / sizeof (UINT8); > for (Index =3D 0; Index < Count; Index++) { > - DEBUG ((DEBUG_ERROR, "%d ", Value8[Index])); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", Value8[Index])); > } > > break; > @@ -985,7 +985,7 @@ DumpOrderedListValue ( > Value16 =3D (UINT16 *)OrderedListStatement->Value.Buffer; > Count =3D OrderedListStatement->StorageWidth / sizeof (UINT16); > for (Index =3D 0; Index < Count; Index++) { > - DEBUG ((DEBUG_ERROR, "%d ", Value16[Index])); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", > Value16[Index])); > } > > break; > @@ -993,7 +993,7 @@ DumpOrderedListValue ( > Value32 =3D (UINT32 *)OrderedListStatement->Value.Buffer; > Count =3D OrderedListStatement->StorageWidth / sizeof (UINT32); > for (Index =3D 0; Index < Count; Index++) { > - DEBUG ((DEBUG_ERROR, "%d ", Value32[Index])); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", > Value32[Index])); > } > > break; > @@ -1001,7 +1001,7 @@ DumpOrderedListValue ( > Value64 =3D (UINT64 *)OrderedListStatement->Value.Buffer; > Count =3D OrderedListStatement->StorageWidth / sizeof (UINT64); > for (Index =3D 0; Index < Count; Index++) { > - DEBUG ((DEBUG_ERROR, "%d ", Value64[Index])); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", > Value64[Index])); > } > > break; > @@ -1009,13 +1009,13 @@ DumpOrderedListValue ( > Value8 =3D (UINT8 *)OrderedListStatement->Value.Buffer; > Count =3D OrderedListStatement->StorageWidth / sizeof (UINT8); > for (Index =3D 0; Index < Count; Index++) { > - DEBUG ((DEBUG_ERROR, "%d ", Value8[Index])); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "%d ", Value8[Index])); > } > > break; > } > > - DEBUG ((DEBUG_ERROR, "\n")); > + DEBUG ((REDFISH_PLATFORM_CONFIG_DEBUG, "\n")); > } > > /** > -- > 2.17.1