From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: Joey Vagedes <joey.vagedes@gmail.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Daniel Schaefer <git@danielschaefer.me>
Subject: Re: [edk2-devel] [PATCH v2 05/12] EmbeddedPkg: CI: Add PrEval entry
Date: Tue, 24 Oct 2023 01:21:17 +0000 [thread overview]
Message-ID: <MN2PR12MB39667D0AF390AC76C15E96C3EADFA@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231023175200.9082-6-joeyvagedes@microsoft.com>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: Joey Vagedes <joey.vagedes@gmail.com>
> Sent: Tuesday, October 24, 2023 1:52 AM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Chang, Abner <Abner.Chang@amd.com>;
> Daniel Schaefer <git@danielschaefer.me>
> Subject: [PATCH v2 05/12] EmbeddedPkg: CI: Add PrEval entry
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> From: Joey Vagedes <joey.vagedes@gmail.com>
>
> Adds a PrEval entry to the package's ci.yaml file which is used to
> verify if the package uses a particular library instance when that
> library instance file (INF) is updated.
>
> When a library instance file (INF) is updated, PrEval will review each
> package's DSC as described in the ci.yaml file to determine if the
> package uses said library instance. If the package does use the library
> instance, it will be built and tested to ensure the package is not
> broken from the change.
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Daniel Schaefer <git@danielschaefer.me>
> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
>
> Reviewed-by: Abner Chang <abner.chang@amd.com>
> ---
> EmbeddedPkg/EmbeddedPkg.ci.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/EmbeddedPkg/EmbeddedPkg.ci.yaml
> b/EmbeddedPkg/EmbeddedPkg.ci.yaml
> index 21f30108a29f..96a60a6f8b4d 100644
> --- a/EmbeddedPkg/EmbeddedPkg.ci.yaml
> +++ b/EmbeddedPkg/EmbeddedPkg.ci.yaml
> @@ -6,6 +6,9 @@
> # SPDX-License-Identifier: BSD-2-Clause-Patent
>
> ##
>
> {
>
> + "PrEval": {
>
> + "DscPath": "EmbeddedPkg.dsc",
>
> + },
>
> ## options defined .pytool/Plugin/LicenseCheck
>
> "LicenseCheck": {
>
> "IgnoreFiles": []
>
> --
> 2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109973): https://edk2.groups.io/g/devel/message/109973
Mute This Topic: https://groups.io/mt/102140973/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-10-24 1:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 17:51 [edk2-devel] [PATCH v2 00/12] *** Update Edk2-pytools to latest versions *** Joey Vagedes via groups.io
2023-10-23 17:51 ` [edk2-devel] [PATCH v2 01/12] Edk2: edk2-pytools: Update to latest versions Joey Vagedes via groups.io
2023-10-23 17:51 ` [edk2-devel] [PATCH v2 02/12] UnitTestFrameworkPkg: CI: Add PrEval entry Joey Vagedes via groups.io
2023-10-23 17:51 ` [edk2-devel] [PATCH v2 03/12] CryptoPkg: " Joey Vagedes via groups.io
2023-10-23 17:51 ` [edk2-devel] [PATCH v2 04/12] DynamicTablesPkg: " Joey Vagedes via groups.io
2023-10-23 17:51 ` [edk2-devel] [PATCH v2 05/12] EmbeddedPkg: " Joey Vagedes via groups.io
2023-10-24 1:21 ` Chang, Abner via groups.io [this message]
2023-10-23 17:51 ` [edk2-devel] [PATCH v2 06/12] FmpDevicePkg: " Joey Vagedes via groups.io
2023-10-23 17:51 ` [edk2-devel] [PATCH v2 07/12] IntelFsp2Pkg: " Joey Vagedes via groups.io
2023-10-23 17:51 ` [edk2-devel] [PATCH v2 08/12] RedfishPkg: " Joey Vagedes via groups.io
2023-10-24 1:20 ` Chang, Abner via groups.io
2023-10-24 1:32 ` Nickle Wang via groups.io
2023-10-23 17:51 ` [edk2-devel] [PATCH v2 09/12] PrmPkg: " Joey Vagedes via groups.io
2023-10-23 17:51 ` [edk2-devel] [PATCH v2 10/12] MdePkg: " Joey Vagedes via groups.io
2023-10-23 17:51 ` [edk2-devel] [PATCH v2 11/12] MdeModulePkg: " Joey Vagedes via groups.io
2023-10-23 17:52 ` [edk2-devel] [PATCH v2 12/12] IntelFsp2WrapperPkg: " Joey Vagedes via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB39667D0AF390AC76C15E96C3EADFA@MN2PR12MB3966.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox