From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.71]) by mx.groups.io with SMTP id smtpd.web11.16516.1672934627777286384 for ; Thu, 05 Jan 2023 08:03:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=JtSzcwwR; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.237.71, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iK2OTQzxdxXXpVm7SkxJBbO2/KID+WRU/ZpSkNZhZjcjonKzOXq9SGv4yAEwuFBxmOQbFWB7YyhgpJ+bcsQhbClxb5PzegoCcH85QBSX/HWCeh5HGBuhfZ1Vhe8twmtX/fgcbQygL4XgpuaoJbNQbuMlm8/8Jz04DHqCqHeTI2Esjz4r0ermKDm/CuDRFvaIe1jFpT4CN1G8y1a5pkhqciB7QzO5ynkIuM0NyZPR+YY2EmV8tuh+kEk67zERNhe2Rel7HbvaBCQEN6klyDsAbOLHO97QI3u3nmrsONALgWSPHUsZHRh/NnidPEmoSDAAWfJ5hMFvVdy41smIEu4vwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aF5HUd3YshMOsMNU3M3m7x7vvCO8/M1xpB5iv2M4SJ4=; b=OWUdqBQCY3tHPg/GM4ulzo+PeVbrghf5DtaeU/iLueloIn2OsqNIMZTB5/5zYKAKQZlD3y6j0lWe/xgN9b4jGfnTUPLvXzNd1XyzPY6rF2Gr/J465rifhmcK4lTBpbyxc9nHfIYCxJWWucRH6bNIpLkVjhOurXLS7QnOXrY+2yL/Hsr4AAxzkynFeKVjSGvY4hPX+GtevGngbSBPOtMqWjd2ImbXZriVD9ekB609qTu6pyFz/rTDh6Izm3788N6qq2mABP2eCdLyMyvPtQO9oRM4LJgKl7SMqPtcgzOKcdBQzmADpMmEN4imT0qZjOND3iVlCc2qWCmisipDxdIIJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aF5HUd3YshMOsMNU3M3m7x7vvCO8/M1xpB5iv2M4SJ4=; b=JtSzcwwR7COewxkqJ4yJqLPRMbNyv/dmqUK6Cjnp5F3NTCRO5QnKf//u2v89d62D66WtVWAiV4jqQoJK0YPuI05uFk0GuRhwuVJ2FO3DppzJLpHqoZisBYsvR+RMYvAsln9mf7JC2J6G/CR4l5mE4I2LhTcd9LrkyWHnRwUBeZI= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MW4PR12MB6923.namprd12.prod.outlook.com (2603:10b6:303:208::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 16:03:44 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4%5]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 16:03:44 +0000 From: "Chang, Abner" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Gao, Liming" , Nickle Wang , Igor Kulchytskyy Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/3] Features/IpmiFeaturePkg: Add IPMI functions Thread-Topic: [edk2-devel] [edk2-platforms][PATCH 1/3] Features/IpmiFeaturePkg: Add IPMI functions Thread-Index: AQHZIJoL0lGd2lBSdUWO/m6taVddt66P/SjA Date: Thu, 5 Jan 2023 16:03:43 +0000 Message-ID: References: <20221223132700.1864-1-abner.chang@amd.com> <20221223132700.1864-2-abner.chang@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-01-05T16:03:41Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=27c41bdf-8022-4e2d-b29c-a0476e41b5ea; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MW4PR12MB6923:EE_ x-ms-office365-filtering-correlation-id: 30429d3f-2247-47ce-ee7a-08daef366bae x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CuD9S5hyU4MK+f7bpvLuv6BaXaXxiko7fVeyZB7IjLKTMuX54uJOv1l7mqTz2U9M32K0/Ix39Ns6pBhd3eCc441IiOsWYEWYoj35SFjvBArm0x1qfzJaBvdCA50AixbTPbGq9h9Vlz4KB1DqlS3ebrz/rcCc38DIdz4folZSBSIjWsYWvAf350wyFDrWiKw/KJVSGUdRFSsr0k4NMm+Jr5GLtDh36UvKwFhWFMSec9+qk61WQlBrWVB/kfGFVY6pXKaAD5eieyuJw+aSNy+0VoRpWORWLAbdkfgxkbYWKMgx+BHp0kBW49y4R72I2vVLE4FQ1wsqE61cMZlVIQaa4QJZXLBO5EX9+6kF+mxc9UB7Y2YzFE9jAw0PfVo9IO8PRz5WM8o/Tw6AFck1oM7TJfK6LSNKzZYczCmPo4anPfMYZlpG+5AFGSuHTqZcmVujW3nQCRPE6fhxY6142wc7CbD0Y994QOm5jrNdfZoLIV8yt3tw73Me+v4qmji98LDskbQaBvJCipXDLXHeNTPad0jDkmJt2XxVhaqZewo4XxY20wkA8O5lEuigYXbfC/2OFyD7dXed9OSUmfcUPUsN5TuPb08R7ZQ04HKWBUjmTNnYsx/ukORDb16+y6oeW+z3hyGP22XpHfp2PIfOwD5b55DHgRI16der98H753UtNWziJyZx816YyrX+CVTJ++nlopXVPIPIiYvZHjsRZ+8uIVKAj3pqv34rgUhho1WPBO2qCrcgK0gqCfV1Y0RAj0K696A7Ewljw+E+NTMkCQvmXg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(39860400002)(376002)(136003)(396003)(451199015)(2906002)(5660300002)(41300700001)(8936002)(8676002)(52536014)(4326008)(66899015)(66476007)(66556008)(66946007)(316002)(110136005)(54906003)(76116006)(66446008)(64756008)(45080400002)(478600001)(71200400001)(966005)(55016003)(26005)(33656002)(186003)(83380400001)(9686003)(7696005)(38100700002)(53546011)(6506007)(122000001)(86362001)(38070700005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XHDB0zh9GjmnujV5HsTF9Y2h2j2aruuElNA/diSt9MF2LGWsBQnZKgEItUiM?= =?us-ascii?Q?ExdPR3kDrEHy81KSxDvIBN04thBAQv3lQ6A/Yyw3bMMDPsJ3I5Pwo8NFRDYl?= =?us-ascii?Q?rknnSlvW6KVmGX4Mf/6Etlg2HkbOrZWJc518dsMAxaQ4DULKYoDMhF/sJsgr?= =?us-ascii?Q?NBrKI3gF9NwHeC6T0QB1Dkxm2wsxkIJPPZCjZxQQNOLEUrwcbvswrlBew+ig?= =?us-ascii?Q?xCvrK90QnlufVGHbeCYVKPl+5127loLKgvuv7qY6nhVu6btgzm3nsrfVlMRr?= =?us-ascii?Q?8Ob9qM2pty/Zp76K5Jj+pDFJ2nO2yCYkz3XRqwe0izdohF912JA4XIgJvuKq?= =?us-ascii?Q?g4UAXWR6hpovCmaLecIbeYe0ZQ41ETBoR4fefKsPrufklaya68Jgrgq7xcrP?= =?us-ascii?Q?HR48DlHe6AmCCiUDzQ/EQ7ReeqEGOkiU3I6RFCGD+DGkuQLXk70Fr7Qol30e?= =?us-ascii?Q?naxph/OEeNoEre5HRDG3lPEm87WRsl+ARGzcU/JcrD6Igfk92LXxcdaKU6e0?= =?us-ascii?Q?yggSgoMkkR/KvwvetyNIr7mXqPdTp6r1h9fwgj9j7d8Vqk94bbY6XavDx1kK?= =?us-ascii?Q?nRy2oLUnobFc11PmR1g84AZhNWYHUBjDW6Wyx/xnEPCyLHPtQ+fyvVgf0Jtt?= =?us-ascii?Q?nBh3r1wu/+mHUVqsCBlgUdJp2L0qlGNaQ4EbAkLNiukEgLV1zD7jFk2zA6lZ?= =?us-ascii?Q?uak+bOEsLjHUllVcfbleqHE/wxJlGkh3UJsf6H5ilizgRnHrkajyGm6+bIjI?= =?us-ascii?Q?nLhNGSThc/UPi6wXJkFKnbbJD2s4KngcIQxleu8hokGP37m/+6yL8I96Dnx9?= =?us-ascii?Q?UnSKnBrFbM63Ui+PzEbWJGnQTQR1CC9wWgzumY03ZJnmAd7i4MhfZNIpUDXP?= =?us-ascii?Q?xE2wB2f7agcnwXBc6HJUIPS2UyUtLz9IOCRAmAStLgFxXKVEIqrKjgyXxjrc?= =?us-ascii?Q?8Cru5q5s+BflaBlslSK6Lh92u15yTsnY64FZEpMEb+uChDdxiBhIv6fBBCqU?= =?us-ascii?Q?jMoQqVY5iDe2/G8x5Ii4SrN7e9FbgH4Ex8/DivpgKv6TRkXXK1wFN8rTarkR?= =?us-ascii?Q?v2LvlZQ15PaD7zRS2vbe9YLykYddUOPMYD0WSpRa1Bbhe+tSGdQB3oHj3yvY?= =?us-ascii?Q?mOw6hY2LvSA+Md+kmlBOq2J3TWJAeoLkbqZPHOAD16RRJyEugt/Zcqzt+Dpq?= =?us-ascii?Q?fi8ZdQ6jKMdrPGWfkpAMZ+IjxzpT30m1/y4mkPfEAvIgEZZTmM//RNPOMUGS?= =?us-ascii?Q?xsVsNbaEU41l60Mfjq4gwyW9EPOdMjISZ1PmC9bAiurTbUIkhfXxzzZ78Iq6?= =?us-ascii?Q?mTtXN2fq7d95mq2ahUO1imDLU1tZGKgk7rHldH5aljQhqfORBTGt2v6lFt3Z?= =?us-ascii?Q?jpgkrlq/y1lRFrygOA9Qf6yV5szhG1HO0fR6/aYqr5DQA7pcXjJHpbtsxjCv?= =?us-ascii?Q?SZfxq95TKEDihi+0D/XOQHOpsOPBB1nUcy8JdxkVsHbR03OA2Dk+63uSOoB9?= =?us-ascii?Q?tZI7Qo6rD7J771ae27C5zdSiK6za8ECPNGXS/teOJjubp54TPz7VwKGheLGO?= =?us-ascii?Q?KhTbO4Un5KyJy+VyP3M=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30429d3f-2247-47ce-ee7a-08daef366bae X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 16:03:43.9776 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ThnB1Ogx4pjcgzI8YjD/PVbftBcBHoEzM8BRwaAKNJ3bBa0eeUc9LTuFrl6P7CK6bMDSnKdCY2g5OyDl0w9iyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6923 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Thanks Isaac, V2 was sent to address your comments on patch 1/3 and 2/3. Abner > -----Original Message----- > From: Oram, Isaac W > Sent: Thursday, January 5, 2023 8:10 AM > To: devel@edk2.groups.io; Chang, Abner > Cc: Desimone, Nathaniel L ; Gao, Liming > ; Nickle Wang ; Igor > Kulchytskyy > Subject: RE: [edk2-devel] [edk2-platforms][PATCH 1/3] > Features/IpmiFeaturePkg: Add IPMI functions >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > Abner, >=20 > The @param and IN, OUT tagging on the parameters do not match for > IpmiGetChannelInfo and IpmiGetLanConfigurationParameters functions. > Please align and comment the expected usage and input handling that the > API implementation is expected to provide. >=20 > Regards, > Isaac >=20 >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Friday, December 23, 2022 5:27 AM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; Gao, Liming > ; Nickle Wang ; Igor > Kulchytskyy > Subject: [edk2-devel] [edk2-platforms][PATCH 1/3] > Features/IpmiFeaturePkg: Add IPMI functions >=20 > From: Abner Chang >=20 > Add functions to get system UUID and LAN configuration parameter. >=20 > Signed-off-by: Abner Chang > Cc: Isaac Oram > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Nickle Wang > Cc: Igor Kulchytskyy > --- > .../Include/Library/IpmiCommandLib.h | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) >=20 > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/I > pmiCommandLib.h > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/ > IpmiCommandLib.h > index 18f9d123c9..c816750544 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/I > pmiCommandLib.h > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/ > +++ IpmiCommandLib.h > @@ -2,6 +2,8 @@ > This library abstract how to send/receive IPMI command. >=20 > Copyright (c) 2018-2021, Intel Corporation. All rights reserved.
> +Copyright (C) 2022 Advanced Micro Devices, Inc. All rights > +reserved.
> + > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -88,6 +90,43 @@ IpmiSendMessage ( > IN OUT UINT32 *SendMessageResponseSize > ); >=20 > +/** > + This function gets the system UUID. > + > + @param[out] SystemGuid The pointer to retrieve system UUID. > + > + @retval EFI_SUCCESS UUID is returned. > + @retval EFI_INVALID_PARAMETER SystemGuid is a NULL pointer. > + @retval Others Other errors. > + > +**/ > +EFI_STATUS > +EFIAPI > +IpmiGetSystemUuid ( > + OUT EFI_GUID *SystemGuid > + ); > + > +/** > + This function gets the channel information. > + > + @param[in] GetChannelInfoRequest The get channel information > request. > + @param[in] GetChannelInfoResponse The get channel information > response. > + @param[in,out] GetChannelInfoResponseSize When input, the expected > size of response. > + When output, the exact size= of the returned > + response. > + > + @retval EFI_SUCCESS Get channel information successfully. > + @retval Others Other errors. > + > +**/ > +EFI_STATUS > +EFIAPI > +IpmiGetChannelInfo ( > + IN IPMI_GET_CHANNEL_INFO_REQUEST *GetChannelInfoRequest, > + OUT IPMI_GET_CHANNEL_INFO_RESPONSE *GetChannelInfoResponse, > + OUT UINT32 *GetChannelInfoResponseSize > + ); > + > // > // NetFnTransport > // > @@ -114,6 +153,27 @@ IpmiGetSolConfigurationParameters ( > IN OUT UINT32 > *GetConfigurationParametersResponseSize > ); >=20 > +/** > + This function gets the LAN configuration parameter. > + > + @param[in] GetLanConfigurationParametersRequest Request data > + @param[in] GetLanConfigurationParametersResponse Response data > + @param[in,out] GetLanConfigurationParametersSize When input, the > expected size of response data. > + When out, the ex= act size of response data. > + > + @retval EFI_SUCCESS Lan configuration parameter is returned i= n the > response. > + @retval Others Other errors. > + > +**/ > + > +EFI_STATUS > +EFIAPI > +IpmiGetLanConfigurationParameters ( > + IN IPMI_GET_LAN_CONFIGURATION_PARAMETERS_REQUEST > *GetLanConfigurationParametersRequest, > + OUT IPMI_GET_LAN_CONFIGURATION_PARAMETERS_RESPONSE > *GetLanConfigurationParametersResponse, > + IN OUT UINT32 *GetLanConfigurati= onParametersSize > + ); > + > // > // NetFnChasis > // > -- > 2.37.1.windows.1 >=20 >=20 >=20 >=20 >=20