From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E5541780091 for ; Sat, 21 Oct 2023 14:15:36 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=dsuATYC1Us2WbxaXQIfHxYRYV/iGiTIRgMmShmJfpO8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697897735; v=1; b=hOC3N6QB1HQdwrcd7NW2wjIdjtjdMOd5oYiVLI0JDvYysZxN4YOoAfC1XmCsX1/iFAYtBiPO ZvPozU5ttSf7+x70KgZ2xO9X/BEbOXciQOxuG8xnjR/VKBdmDZzS2cmKZtHux2ZCp+0VSKg4XAC eWh6qLqvTcABu6y127Nc4z+k= X-Received: by 127.0.0.2 with SMTP id fDr8YY7687511xKRwqdeKWK9; Sat, 21 Oct 2023 07:15:35 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web11.80081.1697897734224924556 for ; Sat, 21 Oct 2023 07:15:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jJ7KZSJiNNXUwTmIbiH1NWOB1AYPljTc8ikutP7i+ENZ/A/Aim0f3Opq9LosxmEBH/inhdavviYLdj+YhksPVXZpDcgi3MPWV2hOHxH3pjCrie9yX9gF3+USHDyt+DgZN0UJOyI58pqel1NhTZRiYac8kxZGEoHXKOfUlvzw8ha55zQ7KJu0O6QmdjS2TCrSNcMbInVV96gQsOduWJgcWwIn5S6b+vHV19sQoA6B+vTbvEcW9Ex5+69jury3LLkxWd8JH7l6BNlYE27UdYzZ6zx2Tq/3uZmBP9vR6EKIBkm9jbhRwwMAzHBdagVL1V8hV5sHyrnW9EEgmAKjMj2IxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iO6it4Kz4YQo16s+/BNeB1JqnAQgoIAympQrLTvJS5w=; b=XokFqQJJ/Xq8vPWmZ/HZceI5+zrwK0DtMfgSADWNQBlbNnHc7yEpmgWyYFg1P6O2nny+RkfWRCNb8WF2qV5ykdsYZlIy7jWVZT+sYRMMUIJMcZSlEl61v+G3xR7+hhwlCcXqwLncduouGj90ZYwZaUNe6xk6XXMNOhulyqihq47+lrGsFOZslFcnZXanwt24M2CNdOreKecXaXPZ12gyZUKAjyTw99o/QV5aS3KUjpK1aoX75voI4W/ad6pFUHdcTsxKF9ripn61pOyc/2wh0d48s4qZ67J1p6HBdFTteFjoPcUJL+oqCh1DVAysZseXcUX2l3WUSFc3YuwH9i713w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SJ2PR12MB8182.namprd12.prod.outlook.com (2603:10b6:a03:4fd::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Sat, 21 Oct 2023 14:15:27 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::345a:6816:7343:3e6b]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::345a:6816:7343:3e6b%6]) with mapi id 15.20.6907.025; Sat, 21 Oct 2023 14:15:26 +0000 From: "Chang, Abner via groups.io" To: "devel@edk2.groups.io" , "lisa.huang@intel.com" CC: Isaac Oram , Nate DeSimone Subject: Re: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Topic: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support Standalone MM Thread-Index: AQHaAyEmQZRi0Xh2AE2Iy6Gd4leWvrBUSH3A Date: Sat, 21 Oct 2023 14:15:26 +0000 Message-ID: References: <20231020064616.6637-1-lisa.huang@intel.com> In-Reply-To: <20231020064616.6637-1-lisa.huang@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=f5680497-faff-4ef9-95fb-0d394246569a;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-21T14:03:32Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SJ2PR12MB8182:EE_ x-ms-office365-filtering-correlation-id: 70845aa3-f297-4795-a56e-08dbd2402c69 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: IkmLG/vTKiOY4nj6AzhkT1ZaGrMaIa1B4mTJrYqZKujUDzsOA959RXKNpcMPQAx9LvNF5pze/FdnAPmkOaWougEdl4dWxo9tVz/Cbgu5M7Ox376OafvJkuZmSH2SZ7Ak/nQXdNdYRWIc01VYvrIpWbUoPSbgrjo50m/m/bJDDqw9Et2W3UoOsYF+ENHAF3DxV5xQrIwdJ1YJQZUshrG9uIF+avaU1MB8VUJcFaKHo6dMYZkphclQzUbFAEUIsUYPF1R+msenNgFzc95J4XeOvNs1RXzjvVZdE4uYiCPTK+NMIduPjvgW1FvICSF91bGmmct2fOLZ110yNMHU53e3XPGkF8C8bN0L3U8o8G90iYfRUX2s85mmBCZR9K0bKL4xWXyJoRO1ixYDjgP8ramc8Rqd+f83wui7YnB3TPNpTFaZJYrWF5gFvjfUiUE9fY/A24zu/BJq2WAVQaNc5yQ2naH+OS/tC+AnMRZ6GWtKFPYMmgloVX80UKkB7GbxRNRzucbQKG3zoI/uCa5qJcwhG8O6sXkbVsotji02RILkCmB7AfTvHPRL1U7UZMDC+kZwdTosthBonnbO8l+XyAscSCGSOKruPZgHsG1zrGCnvjUEZpzVReWc+cShUGM2BSDulm/H2uUdWh0kHW9FACsDYA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?e9NdtS+akBY3XXHjkhIJdlhSIW9fgFbM+UKLfwaq1om3OwT9d4LgKImk+BRp?= =?us-ascii?Q?ghvD+F6OeFJNSibO/iPoL1mXnHOImegsLFE/Q9U2a8TD7zl96AhLYRUVOAES?= =?us-ascii?Q?bwIgSt2qKD5RgksjOPNdmvg8xpoqGf1UMQ6EghyprWsQCjmdcSg8WmwsD3AY?= =?us-ascii?Q?K1C+NA8UlGiNNN6XFBoHLwWaW/2jCrCiSkxp7iGd3ACsCHdDxRqBux23FqQx?= =?us-ascii?Q?dBlMVhUKj68LJUpUpq+UHC1/rcNqgb+QfzfIZvbdMpR+jujkAKEK/o0j7nvy?= =?us-ascii?Q?ofN38aGXIAG7vQZBjVr6ClUzlWd7Oq5DJhTQgEx20btRim5daJL5a+yWWjz3?= =?us-ascii?Q?r8CvxqkmOVcAk2O1EK4viTGK5czcqspYfY39ZpZi+3/AC8UVEWO5ixvjE3En?= =?us-ascii?Q?ZTT++p722RLqopOqzzM2e4N0p+mjS9pYM83A9wuRhPtAGzpdGThimLShYBtw?= =?us-ascii?Q?nGcrx4Ba72MSiqsiCLDchkdBX7zwblNmVI0IjZ9723ssmW7qxVuqkp35Q6r6?= =?us-ascii?Q?nN+dJnMoyEkX2+o7F+W5lBGVpmexXBLOJMRnjm7cBqCtuXPHHvMEbEUoRYZo?= =?us-ascii?Q?uFfGS71IG2tzwY/fHvzgqv/94Ap0aVPRWIMueiUhClvsYG6uo2XTZAnoHl8l?= =?us-ascii?Q?Q3Tgt/XPeFV4Dw9sWLZ0Vrh8f/vPdVD/moFD5+8lp1HoDprFlfCaU3d1SYMG?= =?us-ascii?Q?dj/TJM1vRxkjc62k+v9kg5q6BhaBSoHoFc7QA7gBfUEL6vkpbRw6JdW2XLDh?= =?us-ascii?Q?rjuPCRoFBqWaxQZ2gVOJJGTe2Cps/n8qsJFJhspzpD51yUr6TdhLuq5WJ5lm?= =?us-ascii?Q?55+alnF1cAq9K4U5fL87Txe5oDMENSuEvtlZ45xf0ZJEu3Vs0WIt+z1qDjFJ?= =?us-ascii?Q?N0+dpVJMmP8AE1WRCblZD1K7e1QKofhjOjR+34G3cib19osiZMgF1eEA3yvg?= =?us-ascii?Q?LXqqk5URlBiQSv7oUgPLF2y6n8bD/Zv1879Va4pnDYDTvpwaUDn0Y8ZhXQY+?= =?us-ascii?Q?8pGWM9dt7dTGoUBi2bzDEO7ie6EaNLbtMh0wSLAXcop/BBxOfZX6JxN760yf?= =?us-ascii?Q?yByd8cYFsx2kwhuAwxer1fXebxsFKj/TmZpie9MYppWEsUmlvosV+Xwcihjj?= =?us-ascii?Q?xzjGonm1n98SOVVk+TRVevYxPKm/8vh921G4lhuRM9X+OQL08Ig440OhgqfN?= =?us-ascii?Q?1WABCog/0SnDsq68GdvT2F5ptPTCH6XORSC+f0LFkpIuiSquYKzhlG4WvN9h?= =?us-ascii?Q?OGVXEz0X29ggVYiTlow3HxNC8iCwPJaMM8Z5EPcDywcgK5QXgyJPmLvcatCi?= =?us-ascii?Q?Di2+jVOLpf7Ki+BY23rykiSGSqOimCGWV6L3YMI+ntJGXVPkTZLvDwlQ5jfD?= =?us-ascii?Q?lWb6HY0YNB03Io2q/kVKy1p8eLDVBuNP1y2bOZ1Bgf1pO1peCm0xsfedjHXq?= =?us-ascii?Q?tGFM36swvEFkGdnBTEmnrB2T9WqPhI5AJB1C01TN7uCc8+cmoHPZSzQBir8s?= =?us-ascii?Q?tOkZD8T9y+y31iVHBf9YTzpF+4sVI55g5iCAWrWjBtpTBd5NERMBZSFVwmmW?= =?us-ascii?Q?68YksFWdiPZShELL4rA=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70845aa3-f297-4795-a56e-08dbd2402c69 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2023 14:15:26.7753 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OvJfYjWBJFoHMsbVsuP8bbCtYIr789C5lwBtabI+qtwMTYBR/bUGkz9/XOJYsfMhJYHIYhtDgpQrVW3bzOCZbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8182 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: UbgMzhUoNZM5NmZiVSncba1Ux7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=hOC3N6QB; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Hi Lisa, Issac was no longer the maintainer of IpmiFeaturePkg as he was retired. Nat= e had sent the maintainers update for review. As the conversation I had with Issac, we all agreed IpmiFeaturePkg should b= e deprecated as the IPMI related drivers are now located under Manageabilit= yPkg in edk2-platforms. The IPMI implementation in these two packages are d= iverging now, which is not good. Could you please send this patch against ManageabilityPkg? I can help to re= view it, so does Nate as he also proposed himself as the maintainers of Man= ageabilityPkg. Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Huang, > Li-Xia via groups.io > Sent: Friday, October 20, 2023 2:46 PM > To: devel@edk2.groups.io > Cc: Isaac Oram ; Nate DeSimone > > Subject: [edk2-devel] [PATCH v1 1/1] IpmiFeaturePkg/GenericIpmi: Support > Standalone MM > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Add Standalone Mm Generic Impi driver. And add type 'PcdsFixedAtBuild' > for PcdIpmiSmmIoBaseAddress to access in StandaloneMm driver > > Cc: Isaac Oram > Cc: Nate DeSimone > Signed-off-by: Lixia Huang > --- > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > loneMm/StandaloneMmGenericIpmi.c | 148 ++++++++++++++++++++ > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Standa > loneMm/StandaloneMmGenericIpmi.inf | 52 +++++++ > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec > | 2 + > 3 files changed, 202 insertions(+) > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > new file mode 100644 > index 000000000000..52d8d2abdd0d > --- /dev/null > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.c > @@ -0,0 +1,148 @@ > +/** @file > > + Generic StandaloneMm IPMI stack driver > > + > > + @copyright > > + Copyright 2023 Intel Corporation.
> > + SPDX-License-Identifier: BSD-2-Clause-Patent > > +**/ > > + > > +// > > +// Statements that include other files > > +// > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include "IpmiHooks.h" > > +#include "IpmiBmcCommon.h" > > +#include "IpmiBmc.h" > > +#include > > + > > +IPMI_BMC_INSTANCE_DATA *mIpmiInstance; > > +EFI_HANDLE mHandle; > > + > > +EFI_STATUS > > +SmmInitializeIpmiKcsPhysicalLayer ( > > + VOID > > + ) > > +/*++ > > + > > +Routine Description: > > + Setup and initialize the BMC for the SMM phase. In order to verify th= e BMC > is functioning > > + as expected, the BMC Selftest is performed. The results are then chec= ked > and any errors are > > + reported to the error manager. Errors are collected throughout this r= outine > and reported > > + just prior to installing the driver. If there are more errors than > MAX_SOFT_COUNT, then they > > + will be ignored. > > + > > +Arguments: > > + ImageHandle - Handle of this driver image > > + SystemTable - Table containing standard EFI services > > + > > +Returns: > > + EFI_SUCCESS - Successful driver initialization > > + > > +--*/ > > +{ > > + EFI_STATUS Status; > > + > > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer entry \n")); > > + > > + Status =3D gMmst->MmAllocatePool ( > > + EfiRuntimeServicesData, > > + sizeof (IPMI_BMC_INSTANCE_DATA), > > + (VOID **)&mIpmiInstance); > > + > > + if (EFI_ERROR (Status)) { > > + DEBUG ((DEBUG_ERROR, "mIpmiInstance mem alloc failed - 0x%x\n", > Status)); > > + return Status; > > + } else { > > + > > + // > > + // Initialize the KCS transaction timeout. Assume delay unit is 1000= us. > > + // > > + mIpmiInstance->KcsTimeoutPeriod =3D (BMC_KCS_TIMEOUT * 1000*1000) / > KCS_DELAY_UNIT; > > + > > + // > > + // Initialize IPMI IO Base, we still use SMS IO base to get device I= D and > Seltest result since SMM IF may have different cmds supported > > + // > > + mIpmiInstance->IpmiIoBase =3D FixedPcdGet16 > (PcdIpmiSmmIoBaseAddress); > > + mIpmiInstance->Signature =3D SM_IPMI_BMC_SIGN= ATURE; > > + mIpmiInstance->SlaveAddress =3D BMC_SLAVE_ADDRES= S; > > + mIpmiInstance->BmcStatus =3D BMC_NOTREADY; > > + mIpmiInstance->IpmiTransport.IpmiSubmitCommand =3D > IpmiSendCommand; > > + mIpmiInstance->IpmiTransport.GetBmcStatus =3D IpmiGetBmcStatus= ; > > + > > + mHandle =3D NULL; > > + Status =3D gMmst->MmInstallProtocolInterface ( > > + &mHandle, > > + &gSmmIpmiTransportProtocolGuid, > > + EFI_NATIVE_INTERFACE, > > + &mIpmiInstance->IpmiTransport > > + ); > > + ASSERT_EFI_ERROR (Status); > > + > > + DEBUG ((DEBUG_INFO,"SmmInitializeIpmiKcsPhysicalLayer exit \n")); > > + > > + return EFI_SUCCESS; > > + } > > +} > > + > > +/** > > + The module Entry Point of driver. > > + > > + @param ImageHandle The firmware allocated handle for the EFI image= . > > + @param SystemTable A pointer to the MM System Table. > > + > > + @retval EFI_SUCCESS The entry point is executed successfully. > > + @retval Other Some error occurs when executing this entry poi= nt. > > + > > +**/ > > +EFI_STATUS > > +InitializeGenericIpmiStandaloneMm ( > > + IN EFI_HANDLE ImageHandle, > > + IN EFI_MM_SYSTEM_TABLE *SystemTable > > + ) > > +{ > > + SmmInitializeIpmiKcsPhysicalLayer (); > > + return EFI_SUCCESS; > > +} > > + > > +/** > > + Unloads an image. > > + > > + @param[in] ImageHandle Handle that identifies the image to be > unloaded. > > + > > + @retval EFI_SUCCESS The image has been unloaded. > > + @retval EFI_INVALID_PARAMETER ImageHandle is not a valid image handle. > > + > > +**/ > > +EFI_STATUS > > +EFIAPI > > +GenericIpmiStandaloneMmUnload ( > > + IN EFI_HANDLE ImageHandle > > + ) > > +{ > > + EFI_STATUS Status; > > + > > + Status =3D EFI_SUCCESS; > > + if (mIpmiInstance !=3D NULL) { > > + if (mHandle !=3D NULL) { > > + Status =3D gMmst->MmUninstallProtocolInterface ( > > + mHandle, > > + &gSmmIpmiTransportProtocolGuid, > > + &mIpmiInstance->IpmiTransport > > + ); > > + ASSERT_EFI_ERROR (Status); > > + } > > + gMmst->MmFreePool (mIpmiInstance); > > + } > > + > > + return Status; > > +} > \ No newline at end of file > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > new file mode 100644 > index 000000000000..336e28368ed6 > --- /dev/null > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Stan > daloneMm/StandaloneMmGenericIpmi.inf > @@ -0,0 +1,52 @@ > +## @file > > +# StandaloneMm Generic IPMI SMM Driver. > > +# > > +# @copyright > > +# Copyright 2023 Intel Corporation.
> > +# SPDX-License-Identifier: BSD-2-Clause-Patent > > +## > > + > > +[Defines] > > + INF_VERSION =3D 0x00010017 > > + BASE_NAME =3D StandaloneMmGenericIpmi > > + FILE_GUID =3D 6899c3ea-0920-414f-9555-ad2f00= f81060 > > + MODULE_TYPE =3D MM_STANDALONE > > + VERSION_STRING =3D 1.0 > > + PI_SPECIFICATION_VERSION =3D 0x00010032 > > + ENTRY_POINT =3D InitializeGenericIpmiStandalon= eMm > > + UNLOAD_IMAGE =3D GenericIpmiStandaloneMmUnload > > + > > +[Sources] > > + ../Common/IpmiHooks.h > > + ../Common/IpmiHooks.c > > + ../Common/IpmiBmcCommon.h > > + ../Common/KcsBmc.c > > + ../Common/KcsBmc.h > > + ../Common/IpmiBmc.c > > + ../Common/IpmiBmc.h > > + StandaloneMmGenericIpmi.c > > + > > +[Packages] > > + MdePkg/MdePkg.dec > > + IpmiFeaturePkg/IpmiFeaturePkg.dec > > + > > +[LibraryClasses] > > + MemoryAllocationLib > > + BaseLib > > + MmServicesTableLib > > + DebugLib > > + StandaloneMmDriverEntryPoint > > + IoLib > > + ReportStatusCodeLib > > + TimerLib > > + > > +[Protocols] > > + gSmmIpmiTransportProtocolGuid # PROTOCOL > ALWAYS_PRODUCED > > + > > +[Guids] > > + > > +[Pcd] > > + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress > > + > > +[Depex] > > + gIpmiTransportProtocolGuid > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > index 5df71300cbd1..73dca30caae9 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.d > ec > @@ -129,4 +129,6 @@ > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiIoBaseAddress|0xCA2|UINT16|0x > D0000003 > > > gIpmiFeaturePkgTokenSpaceGuid.PcdSioMailboxBaseAddress|0x600|UINT32 > |0xD0000004 > > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiBmcReadyDelayTimer|120|UINT8| > 0xD0000005 > > + > > +[PcdsFixedAtBuild, PcdsDynamic, PcdsDynamicEx] > > > gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiSmmIoBaseAddress|0xCA2|UINT1 > 6|0xD0000006 > > -- > 2.26.2.windows.1 > > > > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#109823): > https://edk2.groups.io/g/devel/message/109823 > Mute This Topic: https://groups.io/mt/102076516/7039027 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [abner.chang@amd.com] > -=3D-=3D-=3D-=3D-=3D-=3D > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109874): https://edk2.groups.io/g/devel/message/109874 Mute This Topic: https://groups.io/mt/102076516/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-