From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A9B88AC0C54 for ; Mon, 18 Dec 2023 04:47:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=buy59ou2Av/QBaPDq1TELFIOMVSwNX491/sCTvEA1xo=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702874850; v=1; b=HPb6pEdRLpBSmhvfYEAqUDnMI4skD9uHCPgQn9GaZCJpqXn9EuAv8cSF2Oto4uiLEBLQKyIK pRW4SeI3UMjnQ19NC/idHp5rSbdGccd/6gDntWlvWzjmAI12DvjwgQ+u7ix6owshch/RWgxl0WS kQ8RuBvZc576ykP4HW3ZCCFk= X-Received: by 127.0.0.2 with SMTP id MroXYY7687511x00nPNetpai; Sun, 17 Dec 2023 20:47:30 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.76]) by mx.groups.io with SMTP id smtpd.web10.35535.1702874844602197825 for ; Sun, 17 Dec 2023 20:47:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FAq1ZmkGltW4UGztW/25dOAwwC/b45Hh3QxdyvSuSTEVYTSTWwMZqAOm2EjNpW6pcoCw9h+Ma5oLF1u6GIJAxtT4BqdNDekekG4pF1yeTImdbTMtdaGDYFPkUIvWwWR/YGlDMj7fliJc1bdPiGMLC7KqBEeVcwj87mqEvtuC5cTg6cpiJSzAvSkaviW1VqofFjpISB59Io0SNzA31t6EViNpybTysgY8Eq8W+XxYG/mCEBQbWfMfobnPimzFdIXciKQ7A+n+85ISyw7JgqD4etlgNKrMj6bJZCFPIlL++s0min3XDWXcOMY4F33kw4GVNcfxiYsQAeiQTM1CJY0l9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yEqYkeV7hMYwfaI8AIv53WBMJVme7Fw0kcfhiMomQCY=; b=YO075K/5fSmlvgt9sDcdkPKoI7hWE7dxiq2+4YsNORdVtY63mJOxlCrq2K/n1C2ZP2AdMa+9Bm7VRUnoBrOEAl8zl5Gs0ggm+DFqrvRU6IRYdXhsYDvK9FlD8oijImYMhtdLYjxziw/qpyaib7wf8q9vK2DOiPP0X72pIhhwxyG3lSEb2HjM31zKsGXCL8JxUpWCz4/6ymY0xvaL6RS5FBkyyZyMbDjjJEcNJX0awOR4uUeRwxPdtGG7aKHJkzstCgL9fGhMlTgNJFotf33ZR3h2424H5wFr8Wsh5VUWqrL/Dw7B8eavBb5u+fmOHvpNb8y9F0oYaWyeBFjbJTHcwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CH0PR12MB5060.namprd12.prod.outlook.com (2603:10b6:610:e3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 04:47:22 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7091.034; Mon, 18 Dec 2023 04:47:21 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 13/14] RedfishDiscoverDxe: handle memory allocation error conditions. Thread-Topic: [PATCH v2 13/14] RedfishDiscoverDxe: handle memory allocation error conditions. Thread-Index: AQHaLuTMjLJrSjialUOoCp8H8hTz1bCuehJg Date: Mon, 18 Dec 2023 04:47:21 +0000 Message-ID: References: <20231214232458.4636-1-mike.maslenkin@gmail.com> <20231214232458.4636-14-mike.maslenkin@gmail.com> In-Reply-To: <20231214232458.4636-14-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=033680bb-cdb6-46f8-ade7-4920fa49882f;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-12-18T04:37:38Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|CH0PR12MB5060:EE_ x-ms-office365-filtering-correlation-id: 04729710-d8b6-4c7b-f875-08dbff846bfe x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: jrUAyOP2MCLMkHIk73Jrjg4AYdTHGPusEPVh486FL8M6Wvq0hPK7VF0iAIMle+Gw+1VrphxWyrCai7xpSeuxzPZjwyOnJkMwNtnHJn3N4Z/kDYp/4c6ho05kp3QSXx2Ycy5Ese/Td6N6sxN0TYHLu8t0RPLLEGxT0kEagBHqmYy+T+VVMBs4Y2kHjd+c35o89NMSp+5mPkE8+0iYvay0K/V4Eyelyuw/qQeL9pdsqqg+9pjw2fw4/4qgbnmE9Rj5mfrG4uM8yBFSp1H/n4BgaPhmJigHu+hFf5YJiY4pyHegVuYg1KMnxJPqwMslKTbINAbFIHIl60g7VJI9ib+aXPJo4yX/TjS6MYtW/isFPvR8MfFWApq77MM9xpYS43Ojf51/SRZC7rZOGD8Rfr5D6SbvTJlpxYSi+ZDUtz3iRarNbaIE5D18Ba6EKfiuhhbcTbxPpMfn1N4oTax6DOvZ1/OR3LfiGroeM3N2jEd6X1xATLvCoOZO5GODnec9yKFa7CeGc4cfQUjTMdNsrTPisiVwILyLJF+xOdKmu1JO2cv1ePzEzOIR8FarsoxLYP9Z3wCkVkdoQBAwJaJ2180JHVfl1+lzG3eag7cw5pTEf/wtGvX1Fr67qH4Yd7yr90GBwxk4RYEDukilazxeW7hxp2EUXHEvijeq1+XccTOFONA= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xOUDGQnslp3kmRtmc7mBHHQF1MutmiFjoL9T0ZK0e02zCQPgpvBSba8qQkLu?= =?us-ascii?Q?gFZ743tYJVDIeh3i9OXvFoDc4wfo88R3RmGpPT219kMFqotEzkC+R1UHRSz1?= =?us-ascii?Q?lYkhMKTrX+hpDZ40jt2+eLlSCQ4b4waQr3tsp8iBy8OcBYocdD8fozuCbfKN?= =?us-ascii?Q?pyiiCmGYv31IlLYN4I1+qYk5ckWhuKhGmudsqpWgWWp4kt+cd+xGwqVNXJUX?= =?us-ascii?Q?01gKw8mlayCHlZ2RriPHVFsBtxdWWUcg5JqJq6wrU61kUobDKeXHbLqNjZLR?= =?us-ascii?Q?H8j5IMO6vn9lW5+eJRwLkrA0naNuF/sJvnDO+uLAttv7xaFc8Kbq23dBbxKw?= =?us-ascii?Q?on1RPaXAvP36DgijmL+qzZmLUVHoGg570zaIyrbyPu8+PJPYtCyISdMKaz9V?= =?us-ascii?Q?Cn7egUOTkyQ3QsC0hcFKV/sdQB5hpFJC2n5pylw2FfjbZg+5DKqq3sT6+sz7?= =?us-ascii?Q?UwTt5Gj5kAtqP6CezUrgldMOK8wm3rZvuk8IUk4UDReE4qt8U4mwMLq1vYDZ?= =?us-ascii?Q?COZay5gPtdR3zHPKYl2dyV35an5U2JgM0VcKIEic+HtILZw/pLQVGgd+hQCE?= =?us-ascii?Q?+4462jEdfUdndR/t12ft1V7RJj3it69MZp0QEXuJRAsLGjvbN2XwDiGyxXZz?= =?us-ascii?Q?BZxpwZIRe/1+OdeZS2JlZ0pERKoe0kMTUkMofRGtUzdBGBjHNCYnBZKHNX8W?= =?us-ascii?Q?wb0ojZa74ourY8nuXZB5CkCgmvBqajKvSOEPwS+ijI6sNS1J/3M1P1EFgzQg?= =?us-ascii?Q?xWpMwAGx1TQv2xgDBkdSmflqOvRvw1wiGi6rzf8OZYF8ejL7vt5UVMW/o1kV?= =?us-ascii?Q?uCDrxDy4VVW5Iw6m/MnPaVL/H9pykbhfrGLCi22mFs/xpkHloRx34eOAz/Gm?= =?us-ascii?Q?L/XSMbj4gID3/0dJRIqzJxdO99Q5tlte5awUUcoV3lVyIhy/9e8db2bseWCz?= =?us-ascii?Q?+TB0LJkI8jQIjpeNEPpmCusBOOH1YyZeLmTSpBhYrReuGiSt1XkkBC40g6wJ?= =?us-ascii?Q?BapGYLS1Vhu2OVh94NMR39XVzQjslXaxab7kMXmuq1bGtzoRRaL/MNcROBOj?= =?us-ascii?Q?3u6pq6gVaAa4v59elh6aM0zuWu+y9kHf4SNqlXUAgGCRtIBDIZRA9VZK1BHN?= =?us-ascii?Q?5xDoCFP7fXqiZq3Y1sfPZc5BHzJ5jm61g7NSq19oc1Pa5hFU+wQTEnr6rggr?= =?us-ascii?Q?aEufiR0WV8Nn8Z1zW5quXhH6aAEQS0u6tqaijJ8+8+TNq2RUUUSAuaMFBFtV?= =?us-ascii?Q?ev3Yq3M/kkagx5Jyb912BCKP8pvTRYQC/GgMz0PhUKna2qqpsAlQg7Ory5Fv?= =?us-ascii?Q?IvcHntVCdY6eBmyWBkFPmkiUZLyxbPpz0AUOhwp0cvHVEWJQI20fmR3cwQ8+?= =?us-ascii?Q?c+MIXISfbpMMs+f/V9LsqPG7ZBCAI/6XL/hg8jt+X950fD5OYQWvDHmKDVgT?= =?us-ascii?Q?F1B22t7om5B6p4uEMqGh4qDDkoSRQaNBKVf32RsDNq/XuE4BNtGB8tgm5h7Q?= =?us-ascii?Q?P1j1820RrQ4o/A1laXkseDnvSl5JVroJFUUez9NVtQEL8DBJAir7R8UQq8x3?= =?us-ascii?Q?4qclKL43mzfQBcMQeOOQmErc4ayeD0hYx7Hr9eyC?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04729710-d8b6-4c7b-f875-08dbff846bfe X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2023 04:47:21.5065 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eYl394bZ5Qo2scsTEdstOtp36GZ21ae9n+Vh5PjbQ9mobvmf1X1BM0Q+XK5bA/4yUQQwnDo4ddRI+UytcBaqnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5060 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Xx8XNgAAY3jG6NFfbVWR5PSYx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=HPb6pEdR; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] > -----Original Message----- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH v2 13/14] RedfishDiscoverDxe: handle memory allocation > error conditions. > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 85 ++++++++++++++++--- > 1 file changed, 75 insertions(+), 10 deletions(-) > > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > index 3499a855570c..9d1678c3429e 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > @@ -748,38 +748,103 @@ InitInformationData ( > if (RedfishLocation !=3D NULL) { > > AllocationSize =3D AsciiStrSize (RedfishLocation) * sizeof (C= HAR16); > > Information->Location =3D AllocatePool (AllocationSize); > > - AsciiStrToUnicodeStrS (RedfishLocation, Information->Location, > AllocationSize); > > - DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s.\n", > Information->Location)); > > + if (Information->Location !=3D NULL) { > > + AsciiStrToUnicodeStrS (RedfishLocation, Information->Location, > AllocationSize); > > + DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s.\n", > Information->Location)); > > + } else { > > + DEBUG (( > > + DEBUG_ERROR, > > + "%a: Can not allocate memory for Redfish service location: %a.\n= ", > > + __func__, > > + RedfishLocation > > + )); > > + } > > } > > > > if (Uuid !=3D NULL) { > > AllocationSize =3D AsciiStrSize (Uuid) * sizeof (CHAR16); > > Information->Uuid =3D AllocatePool (AllocationSize); > > - AsciiStrToUnicodeStrS (Uuid, Information->Uuid, AllocationSize); > > - DEBUG ((DEBUG_MANAGEABILITY, "Service UUID: %s.\n", Information- > >Uuid)); > > + if (Information->Uuid !=3D NULL) { > > + AsciiStrToUnicodeStrS (Uuid, Information->Uuid, AllocationSize); > > + DEBUG ((DEBUG_MANAGEABILITY, "Service UUID: %s.\n", Information- > >Uuid)); > > + } else { > > + DEBUG (( > > + DEBUG_ERROR, > > + "%a: Can not allocate memory for Service UUID: %a.\n", > > + __func__, > > + Uuid > > + )); > > + } > > } > > > > if (Os !=3D NULL) { > > AllocationSize =3D AsciiStrSize (Os) * sizeof (CHAR16); > > Information->Os =3D AllocatePool (AllocationSize); > > - AsciiStrToUnicodeStrS (Os, Information->Os, AllocationSize); > > + if (Information->Os !=3D NULL) { > > + AsciiStrToUnicodeStrS (Os, Information->Os, AllocationSize); > > + } else { > > + DEBUG (( > > + DEBUG_ERROR, > > + "%a: Can not allocate memory for Redfish service OS: %a.\n", > > + __func__, > > + Os > > + )); > > + } > > } > > > > if (OsVer !=3D NULL) { > > AllocationSize =3D AsciiStrSize (OsVer) * sizeof (CHAR16); > > Information->OsVersion =3D AllocatePool (AllocationSize); > > - AsciiStrToUnicodeStrS (OsVer, Information->OsVersion, AllocationSize= ); > > - DEBUG ((DEBUG_MANAGEABILITY, "Redfish service OS: %s, Version:%s.\n"= , > Information->Os, Information->OsVersion)); > > + if (Information->OsVersion !=3D NULL) { > > + AsciiStrToUnicodeStrS (OsVer, Information->OsVersion, AllocationSi= ze); > > + DEBUG (( > > + DEBUG_MANAGEABILITY, > > + "Redfish service OS: %s, Version:%s.\n", Jus a note here: We expect the debug message will be for the= case when Information->Os is NULL. > > + Information->Os, > > + Information->OsVersion > > + )); > > + } else { > > + DEBUG (( > > + DEBUG_ERROR, > > + "%a: Can not allocate memory for Redfish OS Version:%a.\n", > > + __func__, > > + OsVer > > + )); > > + } > > } > > > > if ((Product !=3D NULL) && (ProductVer !=3D NULL)) { Not for your change, but could you please help to remove this check? I thin= k we can have a consistent code as Os/OsVer, just print out the product inf= ormation separately. Thanks Abner > > AllocationSize =3D AsciiStrSize (Product) * sizeof (CHAR16); > > Information->Product =3D AllocatePool (AllocationSize); > > - AsciiStrToUnicodeStrS (Product, Information->Product, AllocationSize= ); > > + if (Information->Product !=3D NULL) { > > + AsciiStrToUnicodeStrS (Product, Information->Product, AllocationSi= ze); > > + } else { > > + DEBUG (( > > + DEBUG_ERROR, > > + "%a: Can not allocate memory for Redfish service product: %a.\n"= , > > + __func__, > > + Product > > + )); > > + } > > + > > AllocationSize =3D AsciiStrSize (ProductVer) * sizeof (CHAR= 16); > > Information->ProductVer =3D AllocatePool (AllocationSize); > > - AsciiStrToUnicodeStrS (ProductVer, Information->ProductVer, > AllocationSize); > > - DEBUG ((DEBUG_MANAGEABILITY, "Redfish service product: %s, > Version:%s.\n", Information->Product, Information->ProductVer)); > > + if (Information->ProductVer !=3D NULL) { > > + AsciiStrToUnicodeStrS (ProductVer, Information->ProductVer, > AllocationSize); > > + DEBUG (( > > + DEBUG_MANAGEABILITY, > > + "Redfish service product: %s, Version:%s.\n", > > + Information->Product, > > + Information->ProductVer > > + )); > > + } else { > > + DEBUG (( > > + DEBUG_ERROR, > > + "%a: Can not allocate memory for Redfish service product Version= : > %a.\n", > > + __func__, > > + ProductVer > > + )); > > + } > > } > > } > > > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112631): https://edk2.groups.io/g/devel/message/112631 Mute This Topic: https://groups.io/mt/103181050/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-