public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chang, Abner" <abner.chang@amd.com>
To: Tinh Nguyen <tinhnguyen@amperemail.onmicrosoft.com>,
	gaoliming <gaoliming@byosoft.com.cn>,
	'Tinh Nguyen' <tinhnguyen@os.amperecomputing.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "patches@amperecomputing.com" <patches@amperecomputing.com>,
	"michael.d.kinney@intel.com" <michael.d.kinney@intel.com>,
	"zhiguang.liu@intel.com" <zhiguang.liu@intel.com>
Subject: Re: 回复: [PATCH v4 0/3] Add IPMI SSIF definitions
Date: Fri, 12 May 2023 09:16:27 +0000	[thread overview]
Message-ID: <MN2PR12MB3966858AAF910E05DB2714E6EA759@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <2b7be408-127b-e5c2-adbb-b60b3e1a7f91@amperemail.onmicrosoft.com>

[AMD Official Use Only - General]

Hi Tinh,  It is already merged. 
Abner

> -----Original Message-----
> From: Tinh Nguyen <tinhnguyen@amperemail.onmicrosoft.com>
> Sent: Friday, May 12, 2023 4:50 PM
> To: gaoliming <gaoliming@byosoft.com.cn>; 'Tinh Nguyen'
> <tinhnguyen@os.amperecomputing.com>; devel@edk2.groups.io
> Cc: patches@amperecomputing.com; michael.d.kinney@intel.com;
> zhiguang.liu@intel.com; Chang, Abner <Abner.Chang@amd.com>
> Subject: Re: 回复: [PATCH v4 0/3] Add IPMI SSIF definitions
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Hi Liming,
> 
> If there are no concerns, can you assist in merging them?
> 
> Thanks
> 
> - Tinh
> 
> On 08/05/2023 08:07, gaoliming wrote:
> > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> >
> >> -----邮件原件-----
> >> 发件人: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> >> 发送时间: 2023年5月7日 17:29
> >> 收件人: devel@edk2.groups.io
> >> 抄送: patches@amperecomputing.com; michael.d.kinney@intel.com;
> >> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com;
> abner.chang@amd.com;
> >> Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> >> 主题: [PATCH v4 0/3] Add IPMI SSIF definitions
> >>
> >> Change from v3:
> >>    - Add IPMI key word to commit subject
> >>
> >> Change from v2:
> >>    - Add the carbon copy (Cc) in the commit message.
> >>    - Add Bugzilla ID in the commit message.
> >>    - Mention why I set the number of retries as 250.
> >>
> >> Change from v1:
> >>    - Separate the commit for the IPMI SSIF header and IPMI SSIF PCDs
> >>    - Correct some indent and comment style.
> >>    - Change the PCDs name for a more readable.
> >>    - Support KCS/SMIC Interface Capabilities too.
> >>
> >> Tinh Nguyen (3):
> >>    MdePkg/IndustryStandard: Add definitions for IPMI SSIF
> >>    MdePkg: Add new PCDs for IPMI SSIF
> >>    MdePkg/IndustryStandard: Add IPMI Interface Capabilities definitions
> >>
> >>   MdePkg/MdePkg.dec                              | 27 ++++++
> >>   MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46 +++++++++
> >>   MdePkg/Include/IndustryStandard/IpmiSsif.h     | 98
> >> ++++++++++++++++++++
> >>   3 files changed, 171 insertions(+)
> >>   create mode 100644 MdePkg/Include/IndustryStandard/IpmiSsif.h
> >>
> >> --
> >> 2.40.0
> >

  reply	other threads:[~2023-05-12  9:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-07  9:29 [PATCH v4 0/3] Add IPMI SSIF definitions Tinh Nguyen
2023-05-07  9:29 ` [PATCH v4 1/3] MdePkg/IndustryStandard: Add definitions for IPMI SSIF Tinh Nguyen
2023-05-07  9:29 ` [PATCH v4 2/3] MdePkg: Add new PCDs " Tinh Nguyen
2023-05-07  9:29 ` [PATCH v4 3/3] MdePkg/IndustryStandard: Add IPMI Interface Capabilities definitions Tinh Nguyen
2023-05-08  1:07 ` 回复: [PATCH v4 0/3] Add IPMI SSIF definitions gaoliming
2023-05-12  8:49   ` Tinh Nguyen
2023-05-12  9:16     ` Chang, Abner [this message]
2023-05-12  9:34       ` Tinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR12MB3966858AAF910E05DB2714E6EA759@MN2PR12MB3966.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox