From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.47]) by mx.groups.io with SMTP id smtpd.web11.1737.1658800147964868058 for ; Mon, 25 Jul 2022 18:49:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=sBCDRrrg; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.47, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WHER1dnyZewkDPF6riP+aWY6N3MER2mtIV4D/NjSNddXHkzmsfrKgNo8eAGflaNat89sgqQx72QkcDIMCv2zcDWEeCih4BdeUwUR2/fYky2/Vfq8hXGIRvRF3DaU13Sx8odDtTFq0GM97B7FsAzIHsGqkghiizSMM5BGFuqJ8KBulEv+/WesbGxLxGmgyqS0eUg0/jnv0wqX7OKpYYN+8NyMlaOO288u5d3IMzV3jNqXff68LHImrJHZNlpsO+wE5fBd1aqWC2va7wt4WEZkWM30bOJnOwT1xXT1rBe4PBRAL+kIawjzdRlNUoALC8arUSSiEwUc3MqeOHtCrvYdTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7omz0qDHdZvJSlLFNM32mODMN1FRRsR9OdLaCExMFEg=; b=mhcqja7Bee7EdVzRI1DfrHoXb92l2brlebMMBAdmRXc7udh/YJwBsGVugh7PxgLi0opAjQNoetnG5vb5dKzF0zLvAYEXjLzfEGWkR3esSrsr0H6z3gexOa9GWXPgoAR00ynRX4Su7F8ITOPMpNRCFfcUj4Kf6/5TqMianOsfrN3Aal4jfWvkNjBmkCBKqXe+CkMgVUUlnQK4IwEVvE6IyE/0KqY3AvsKFmvZyc9OG4Xm+dghgrrjrfnYAuCJd8btOWLPXw982cVhnHO7ha2EaxxLnxqeXYr6CLOniuitvI07MVKzJAdiy/Xs6zxoOQP+XZFdz2KDdUJO5x4/rq/MGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7omz0qDHdZvJSlLFNM32mODMN1FRRsR9OdLaCExMFEg=; b=sBCDRrrg+WkubEY6GfqDrzpz+2A9BrEqU64a68XiXkYeD1N4SSphIUDZCSpqOZ9cP68UrpL7400Cj1CaOOa7qbVZePH3fDNFOmxPGtgUAAuvfu+4n93PdXgIJxrwfJ6/O0Brbs5/jCDDcEoURyE0GFlI/kPZS4aSP1+RZCvWjKs= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CY4PR12MB1767.namprd12.prod.outlook.com (2603:10b6:903:121::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.21; Tue, 26 Jul 2022 01:49:05 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::605a:11f4:fc16:8b06]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::605a:11f4:fc16:8b06%5]) with mapi id 15.20.5458.024; Tue, 26 Jul 2022 01:49:04 +0000 From: "Chang, Abner" To: Nickle Wang , "devel@edk2.groups.io" CC: "Yang, Atom" , Nick Ramirez Subject: Re: [edk2-staging][PATCH v2 03/15] edk2-staging/RedfishClientPkg: Update Redfish Resource Config Protocol Thread-Topic: [edk2-staging][PATCH v2 03/15] edk2-staging/RedfishClientPkg: Update Redfish Resource Config Protocol Thread-Index: AQHYn8boPzEcWzW5IEyOy0gsH1bg462P5Bsw Date: Tue, 26 Jul 2022 01:49:04 +0000 Message-ID: References: <20220725013555.926-1-nickle.wang@hpe.com> <20220725013555.926-4-nickle.wang@hpe.com> In-Reply-To: <20220725013555.926-4-nickle.wang@hpe.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-07-26T01:49:03Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=1cf92852-43e1-4caf-b71d-0245e32588b6; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5c887185-a0e1-42fb-2001-08da6ea90591 x-ms-traffictypediagnostic: CY4PR12MB1767:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vK0UKr//zZkIm4xEUg3cO0mKvjHTgz18xr/R5v/sB4/+fLOHOKVDhFdj1QWmSbpc/DBPHeQJ7jyJ4ZGwwfAM/NjcRKVGrwOOY76Hr2NJe3UXgF/fcZ9+EhSSqCn5Lg0xQWlD557ObcSKJdtFlYH5Cat5cQx7q069tch9db3368z97lRhwTw9WXULO9GEC9NRqbZ1r7xO0AAWVayO4FABfLD20G2pmAlx39/C5o3Mknlz18aci1x7deSmf5nJYkG8a/4QUT2VHVMfo3SuoFZdPzYEDUuF8WCMWS2xfv10q/A2R7G0ugTdm/imttTHRm5pje0EHCToCpm7/ErsbcxVlj1fuSMRrphLY8aZE1wClfmNP7rD11qBf0ub1BIXi8YTX0TVMFKRFCa2NiJKcQudbVpFOrqpLrS82/+umQezXw9QKA3qzdVFbXu6Am4R6DqJX5YVxwDNfQ20L36xytEnZuGJ9rGEgP7L63d4ThBvAdXhYKL7kE41J6iCg0YOnT/e4rLT9yN8xbuKCvBS40/LCl/gZ7gqnjogOIawzxPsDObfT4ah6tbd2jiFYkyfazb0Vkbsdrl3AO6xjKIRDy1scFWbm4X9Xoa5tohQZtUDrQcjzSlWJA5OgDaBqIZRUjUMgdC4BxfaNDDrHLriUh9cMk1gEECU1Af0BAvfZDF/1IDlzu2zPxdIzfzsPjP7OfjipV2FMIEOOsUyDTQBo0EXXe5Xbnf1WjI1yNkhfoQrg5jvFxz5KajlpFS9a9WBuZMxyMejwTsse66RiA55VNj6MQmkR82oLzAHpb51a9L+9RA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(366004)(39860400002)(376002)(396003)(136003)(122000001)(33656002)(8936002)(86362001)(38070700005)(52536014)(186003)(9686003)(7696005)(6506007)(83380400001)(38100700002)(53546011)(54906003)(41300700001)(110136005)(71200400001)(316002)(296002)(66476007)(76116006)(66946007)(55016003)(15650500001)(64756008)(66446008)(66556008)(8676002)(4326008)(478600001)(2906002)(5660300002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XFdGCxixlmj5IHgGFqtYWFLVK9yOQ32z6bsXGVIlcQysGhjjxlh8eDI/vMdc?= =?us-ascii?Q?jPrQwro4e1shPO8dmQ7R/6tdohKKxjT2Ta6PNJZ5eByDAId89fnpPUwIuFCD?= =?us-ascii?Q?/UX5fXt1CtTJS6ycVCi0ZbEi8hhtnrvsYywHMXtUrI3ab/RxJsozerZFWZSs?= =?us-ascii?Q?AWDpSTO+WR+G5mYwkNNw2Pi/z0gce2e4F0wcbK5xRABSMRKgNFN5vcmMkN6/?= =?us-ascii?Q?/PiKma07NGFMB4lJ365aPlhax2xgMaSGIU7z/s1NOPR+5GV6XRHDLTpPO14q?= =?us-ascii?Q?13XSb77PcjG2viu9QxI3145oSSQVznaiwy7Zm1JOqZ/2Lo8C7Pp94twAFyLL?= =?us-ascii?Q?uwSYVWXIzXy7UEExDQtn2SyvFMZarEktnKAX078mxiW5tbiifnx+jU6+ybSL?= =?us-ascii?Q?QOzQLPopwMX3sw/jfJViT4HS8XeUXddi8CPYOmjz3hADuP3LbSIjGqUJnco9?= =?us-ascii?Q?Dyd7dkypY73xhZtFNPG8UOz+4YHokAQuxJeD31BY7XppvkVLsGtxlq/ROr+P?= =?us-ascii?Q?6jPww0et3AGX0z8DoHT2II8c4j1Jz+K1VQpQRp1oENXUBM4ilSEce5QvOr2v?= =?us-ascii?Q?SaLDrFgt2HkeH13sFvOCtpVQF5VQEbvqVn/AZ65zf6LEdM4nmMFzA12PrPW9?= =?us-ascii?Q?+3vn7cbA3ajH7syyHAIobgzYqG7YE987zTKZ0M6qg1SLxu7aVAqA+MLlPTjp?= =?us-ascii?Q?85N7MemxQTTSt34XJ2w6nMQTVfsHxcePSQCPsDVHNBHWvu4PYwOIbtGTstvK?= =?us-ascii?Q?guIxe9Yrh7GlbgIiYbUr/mxM6skCwBzONOVTs6OUmwPsE9C7mOQU4cy/UkjE?= =?us-ascii?Q?bz3Mwy+C2lG8p7LLTDpqLWCqPT4uGQ5GuOT3AeIoP3l9U3x8+OelHZMlbDq/?= =?us-ascii?Q?8lzPZq+aTg/u0b3Eptu8SrgtvmLY7LgbItq49wHwih7yqeKozZbOzCTUn/0v?= =?us-ascii?Q?/ZSRcz/itZw4893NHonozfKz02Vn+Z9/zK2J191SSdK/WxiiN6XP+cXAEWo/?= =?us-ascii?Q?QQQ3dTUK887nAAIu+uSCibeCHZNj8XlqIHm1orWxkkC3koI+IuP2AE0iMQCI?= =?us-ascii?Q?Mn1/PsKhKAYfvVTeKv79rBuoRDS7Hlcsw5C2dEdwksjTnp68/jf/29oi5wY9?= =?us-ascii?Q?TNnsKAlVljEvGtNUCWMfrtptZUTIkfcKcu1A04tuw+E6OMelzVp4CaeU8Uva?= =?us-ascii?Q?4x31o4T6CyfvXReSgNnblKKkPfiqY40GA1XfDSg9AP2NgIKHJ0O0vlXXm268?= =?us-ascii?Q?F9XvozrymteG7oGv8AmF7n3lvddt1Xd9PaVrSSRkmnf1oMNW+KL2/M92OOwG?= =?us-ascii?Q?Sp9DFPc4s6PZH4xsZbVzm99q7DDHqmMkIPXRXLVFKbmQf+Xleu1Ni1O8JpcL?= =?us-ascii?Q?hH+cqV9HXJLG0yu8b8G0Jra3SgcRqkLJEBr16VJA6uE4h59yWrU+skHVbVae?= =?us-ascii?Q?Uo2DrCZwe1lGz2i1h9U8nU/3H4FFvZNh4oGXQkcv86OKtI97i8cLVynLq2s8?= =?us-ascii?Q?EwpPYh5if9PGeul4sr8KNXAvN4gOSohZtQVYkl8rBiFF6R7ue3wl7l1JEjIe?= =?us-ascii?Q?qQafAHNT86elScl8PQQ2exXfRkxEfKX3/uvvni06Y7OFlpIPGQpM2xA2AZ1F?= =?us-ascii?Q?uAij0gsPoOObInmZnUk9tiSfeYiDHB0WcQ/Z2qTZmBfY?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c887185-a0e1-42fb-2001-08da6ea90591 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2022 01:49:04.8115 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j+cDBKEb5OyOKc+iV7naCziR6e/4xg5NwJ43PyWPipCUgzF1ooH3efQ10MJWWJecr/GaHHNDhaLxYBtDmot+NQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1767 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Monday, July 25, 2022 9:36 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Yang, Atom > ; Nick Ramirez > Subject: [edk2-staging][PATCH v2 03/15] edk2-staging/RedfishClientPkg: Up= date > Redfish Resource Config Protocol >=20 > [CAUTION: External Email] >=20 > Update Redfish resource config protocol to support Identify action in ord= er to > identify remote resource and see if this is resource belongs to current o= wner or > not. Use unicode string instead of ASCII string for all interfaces to ali= gn with > HTTP interface. >=20 > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Yang Atom > Cc: Nick Ramirez > --- > .../EdkIIRedfishResourceConfigProtocol.h | 29 +++++++++++++++---- > 1 file changed, 24 insertions(+), 5 deletions(-) >=20 > diff --git > a/RedfishClientPkg/Include/Protocol/EdkIIRedfishResourceConfigProtocol.h > b/RedfishClientPkg/Include/Protocol/EdkIIRedfishResourceConfigProtocol.h > index d6c41dda52..574c82c442 100644 > --- a/RedfishClientPkg/Include/Protocol/EdkIIRedfishResourceConfigProtoco= l.h > +++ b/RedfishClientPkg/Include/Protocol/EdkIIRedfishResourceConfigProtoc > +++ ol.h > @@ -1,7 +1,7 @@ > /** @file > This file defines the EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL interface= . >=20 > - (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> + (C) Copyright 2021-2022 Hewlett Packard Enterprise Development LP
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -29,7 +29,7 @@ typedef > EFI_STATUS > (EFIAPI *EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL_PROVISIONING) ( > IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, > - IN CHAR8 *Uri, > + IN EFI_STRING Uri, > IN BOOLEAN HttpPostMode > ); >=20 > @@ -47,7 +47,7 @@ typedef > EFI_STATUS > (EFIAPI *EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL_CONSUME) ( > IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, > - IN CHAR8 *Uri > + IN EFI_STRING Uri > ); >=20 >=20 > @@ -65,7 +65,7 @@ typedef > EFI_STATUS > (EFIAPI *EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL_UPDATE) ( > IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, > - IN CHAR8 *Uri > + IN EFI_STRING Uri > ); >=20 >=20 > @@ -83,7 +83,25 @@ typedef > EFI_STATUS > (EFIAPI *EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL_CHECK) ( > IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, > - IN CHAR8 *Uri > + IN EFI_STRING Uri > + ); > + > +/** > + Identify resource on given URI. > + > + @param[in] This Pointer to > EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL instance. > + @param[in] Uri The target URI to consume. > + > + @retval EFI_SUCCESS This is target resource which we want= to handle. > + @retval EFI_UNSUPPORTED This is not the target resource. > + @retval Others Some error happened. > + > +**/ > +typedef > +EFI_STATUS > +(EFIAPI *EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL_IDENTIFY) ( > + IN EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL *This, > + IN EFI_STRING Uri > ); >=20 > // > @@ -121,6 +139,7 @@ struct > _EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL { > EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL_CONSUME Consume; > EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL_UPDATE Update; > EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL_CHECK Check; > + EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL_IDENTIFY Identify; > EDKII_REDFISH_RESOURCE_CONFIG_PROTOCOL_GET_INFO GetInfo; > }; >=20 > -- > 2.32.0.windows.2