Re: [edk2-devel] IpmiCommandLib's IpmiGetSystemUuid clarification

Re: [edk2-devel] IpmiCommandLib's IpmiGetSystemUuid clarification

[Aaron Pop]

Re sending and adding maintainers directly


On Monday, 6/26/2023 12:43 PM, Aaron Pop wrote:
> I was hoping to get a clarification on the IpmiGetSystemUuid from 
> MdeModulePkg...
> 
> IPMI specification's Get Device Guid Command says that data is returned 
> in "least signification byte first" and "this is the reverse of 
> convention described in RFC4122".
> 
> 
> IpmiGetSystemUuid specifies that it is returning an EFI_GUID. Does this 
> mean that the IpmigetSystemUuid is going to reverse the formatting and 
> return an EFI_GUID as opposed to what is directly returned from the 
> Management Device?
> 
> To help clarify:
> 
> 
> typedef struct {
>    UINT32    Data1;
>    UINT16    Data2;
>    UINT16    Data3;
>    UINT8     Data4[8];
> } EFI_GUID;
> 
> vs
> 
> 
> typedef struct {
>    UINT8     Data4[8];
>    UINT16    Data3;
>    UINT16    Data2;
>    UINT32    Data1;
> } IPMI_GUID;
> 
> Thank you,
> Aaron
> 
> 
> 
> 

Re: [edk2-devel] IpmiCommandLib's IpmiGetSystemUuid clarification

[Chang, Abner]

[AMD Official Use Only - General]

Hi Aaron,
Yes, this is a bug. We should copy the return GUID follow IPMI GUID format. Could you please create a Bugzilla ticket?  You can also send the patch to mailing list if you already had a fix.

Thank you.
Abner

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Aaron
> Pop via groups.io
> Sent: Wednesday, June 28, 2023 4:19 AM
> To: devel@edk2.groups.io
> Subject: Re: [edk2-devel] IpmiCommandLib's IpmiGetSystemUuid clarification
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Re sending and adding maintainers directly
>
>
> On Monday, 6/26/2023 12:43 PM, Aaron Pop wrote:
> > I was hoping to get a clarification on the IpmiGetSystemUuid from
> > MdeModulePkg...
> >
> > IPMI specification's Get Device Guid Command says that data is returned
> > in "least signification byte first" and "this is the reverse of
> > convention described in RFC4122".
> >
> >
> > IpmiGetSystemUuid specifies that it is returning an EFI_GUID. Does this
> > mean that the IpmigetSystemUuid is going to reverse the formatting and
> > return an EFI_GUID as opposed to what is directly returned from the
> > Management Device?
> >
> > To help clarify:
> >
> >
> > typedef struct {
> >    UINT32    Data1;
> >    UINT16    Data2;
> >    UINT16    Data3;
> >    UINT8     Data4[8];
> > } EFI_GUID;
> >
> > vs
> >
> >
> > typedef struct {
> >    UINT8     Data4[8];
> >    UINT16    Data3;
> >    UINT16    Data2;
> >    UINT32    Data1;
> > } IPMI_GUID;
> >
> > Thank you,
> > Aaron
> >
> >
> >
> >
>
>
> 
>