From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.64]) by mx.groups.io with SMTP id smtpd.web11.8692.1683076998168075601 for ; Tue, 02 May 2023 18:23:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=Sq5jRqLw; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.237.64, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CltY1p57lGZ6hgycroD1i5aeoizYf4e3qvjy8lrTb2PkpvwbOLw+lTLINU4k+/OVVs84b3T7atzn3j0U084jYrxpI3Y4AQaseASQaHqlT80kCfPqzuN12Iw/X4okJWrHJznDzLE/np2wm78PwfMJApTuAykz/n7dShtMpSXdRIuh0reDtFgGXFkJp/swjs/ok3x5bl/SOIqcrz0CAbZQX7g9jPYxxLv7pxiIcVOuNyqOKqshWTJruMwRGd/eALKCC2sAZW+7D6L0MklRJEBMKvsvh5YIQtPsxt+JkpauuVNllCDBh0k7Dd1pfUz3QpA1CPndj5BV9TIf27fb7C4nEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jvCUOSnOCiw+XnwNdrHDIvrreVqwiBAJMGsliKJpjp4=; b=iM6XAsQ3PfLtrNkSy2fRmhRUxa9CAAYsFjhHYpXOef4JEJY749LR8wT3ADLzA1Q9tvw56q6Pj/khONfVd/XaVwv72/r3NNq/ymgTYKKCYU9rncPgWDr70C0kk8yAWdAYEZ7d7L2Zgw8PyqDt84hCZZERCagxqfRnSy0wGayVrlb63KTQgGwpfWv2aUqVLu+lxiuJMuoRiP95LEQCM4Rdz6MX29N+AEaYiTiQ2ciW7nVn84DS291q9kZBD1S2ZI2mXCvYQnmGfQ3tC7aKn+k/ynjXagXSjx/FuHOCtG7yfaNF6f34qaIEAFPDiJkKSeuDELvbTvUNTccPjIUIQbEsoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jvCUOSnOCiw+XnwNdrHDIvrreVqwiBAJMGsliKJpjp4=; b=Sq5jRqLwGRudbOaA7m6cVxw4bBjl0G3BICLvgDvk5UQfVixRzq8ZMeH66tyrW6TpkuZNd5M4tnnTdlIs/Wm9dhpWRD8syttR/dcSO4yPgzhuFyFN5aRO3VIbbBUckKtCgal+senk7e/rGE9emlbwNLKcdjpsqgfwUHB0ev8KXFY= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CYYPR12MB8961.namprd12.prod.outlook.com (2603:10b6:930:bf::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 01:23:13 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3%3]) with mapi id 15.20.6340.031; Wed, 3 May 2023 01:23:13 +0000 From: "Chang, Abner" To: Tinh Nguyen , "devel@edk2.groups.io" CC: "patches@amperecomputing.com" , "michael.d.kinney@intel.com" , "gaoliming@byosoft.com.cn" , "zhiguang.liu@intel.com" Subject: Re: [PATCH v2 2/3] MdePkg: Add new PCDs for IPMI SSIF Thread-Topic: [PATCH v2 2/3] MdePkg: Add new PCDs for IPMI SSIF Thread-Index: AQHZfR6M/sNp5mxZG0iUOeBtgvOwt69HvnkAgAAB76A= Date: Wed, 3 May 2023 01:23:13 +0000 Message-ID: References: <20230502174926.2016955-1-tinhnguyen@os.amperecomputing.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-03T01:23:11Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=53e0fe5f-239c-4281-b174-8ee50d79a6d2; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|CYYPR12MB8961:EE_ x-ms-office365-filtering-correlation-id: fb45065b-b7ec-41a1-87f4-08db4b74f702 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c1l8j7j6WL26xQJ65rp/jdLhFbYLBXmbzzk4X1VXw3RGgzcwRdI7PLtoG6e+oktcvsUchNAh3r+M8aqXMK+fWYL52/DjV6Dwzundl8yMn9UCg0+9PLGKiCWo+7dgjuPFocueXHIlZt92p4PWVXhe00lR1d5daA72zrldIDWbSqU0FHGHbJSj61QErWRTvJQjliIhbACpCPJtFh6GHb+uo0KMZTOw2DbJT0BAL6v4XQBYEMrfilbxz0VV/5swFc7J7oy2cst6td4Wn+1jb0vCpivT74bKkcr5zfT27doYw+DU/62+OhIyJkP9GxNFxyCztv1NYA+HE6GPCK7S3K91+HUTJKlu7lET5gG55UByp8uSI232R7Y/HshHnlDI7iTheRyz8EuOd26pdboxc1ggBzpbfCYXBsUOvbD5s+fc06xo2g/D14vpKu4fdF97vpZrhSLvwGyn87exXIH5DZbIIC/vTDcbhgxIiRHzcXSrvAekozr4XqeIXqV2i7Y8S4lnLF/sDcwqBJ54R19c4bZCrGzzOXUSp8zxX2649oBNWoBHrZ3beMrWiZl5xMA43D+2UIq66HA1xGuotvFGCf9VuuO7+HPLio4upaL+vAQts7E= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(396003)(366004)(39860400002)(346002)(376002)(451199021)(7696005)(71200400001)(83380400001)(2906002)(38070700005)(55016003)(6506007)(9686003)(2940100002)(26005)(966005)(53546011)(186003)(110136005)(478600001)(33656002)(54906003)(122000001)(41300700001)(66476007)(76116006)(64756008)(66946007)(66446008)(66556008)(316002)(8936002)(8676002)(52536014)(86362001)(4326008)(38100700002)(5660300002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vye6lpZxLM2yeQ4eCFtNJmyeMdN58KqQydz2jF6nZKbfA0Pc6fMwZ4+BRTe2?= =?us-ascii?Q?dV6fvFjadM+qLI/Z8qC4GKMqjvsm68Sf1H/XJJHIAb/8rYNQ1cuw4A088o+y?= =?us-ascii?Q?yKmpvljATv5efUv2+5Bw1FvCA9o1eEfoQUXD+Ahi7wZvj0chuRu95Rk8MraZ?= =?us-ascii?Q?Mxmb7l2auds9K3XcBHwkSbW3vQGe4bP4ZN0cqdOYeESNIGF89fjfWIZDpKeY?= =?us-ascii?Q?vIBqHOsQON+VxJfofdFQS9hamjflEfCgzgi3TShCk8tX+6AiwfI+rDHUtmXA?= =?us-ascii?Q?ZiTBs9So0P767CAg2vwubZdukmaW5SxdfM4PhvocG7nCNskyvvT0mIVPsCps?= =?us-ascii?Q?D3+HvgPMRxxw83gi4h+Ak/CQsSwIfzCaosLLYlBi/4drNdD+S7MoBuL+ZCJ3?= =?us-ascii?Q?1CXjCEt9bcVC4B/yi8ayzDAB2q6oypyakdT3GSQZuBwVMdLmUKOIkstCApPq?= =?us-ascii?Q?jufDaNj6uDNJto7xFYqEb5hkyqt+ddsoTOxy2Lqi5ooV9CeBS6znpQj5Riqv?= =?us-ascii?Q?HppQ7RUa4StJOnJlLCnchKNznFrUneZvIZ38LYRXlVskQmTuL2MtWMc81S8Z?= =?us-ascii?Q?kMrztykhNsF7sOhkGF8Po9OWcMvGbFlrKkWn3l0iRlq5OzSx1Rf1ekUk1Ljd?= =?us-ascii?Q?kKvEKy5AfAw7FkCkT1QGtwAFE9U9Vk5hhrRTazO7p8awWnE9sjk7nFqadxr1?= =?us-ascii?Q?e3cytI+BGORketGD55ydxxVi1F3rH4xPF5iTtMO6O0hdUALhgq296bDaNWfz?= =?us-ascii?Q?qmHrTI9ZBnNapZL1Whkqmso7zlJ5hFXkm65J5ib73fkoNmr24WuApmnjfNT1?= =?us-ascii?Q?0vg1eqlOv3DK8Mtg5BAZQGLa0MkufOtzDo3eLuh1xb7L+gkPxZxE7PzDtoVC?= =?us-ascii?Q?DhY0Nic68IJti7NBfVYPHe+6NVyZdSMYQ9rb/L39wqEC5rBdarRxP2ChkOVo?= =?us-ascii?Q?tV7Qz3qPn5gkEHwOk19SqG4mCEW9OEItfUqnvQKGWq5VYJSA3991k4yQUBVr?= =?us-ascii?Q?4PJjKw0V0iU32FsEOfmnMEDTscFtZVE2qUP5ruHWCyfza4mjClaaLYX3Vdce?= =?us-ascii?Q?xx/OgplBi8FFF3R4B/lIskTbFM0SbMB6jaC0teKySZAmnPVe/XMNdhW3wSy0?= =?us-ascii?Q?QRGGHhOrrm3sG8m9gMxlyRSiqTylvStCffxBGCQf5BSvkkSHVt3XHd4UCVIf?= =?us-ascii?Q?KghvM1E4+893hD6XfzXWGwXmUFtL8cvcPTU2boNZr5wZLo5GIFOybzJ4SB0A?= =?us-ascii?Q?V7z1slXjAfwIxxfR4mVLttUbHk09KK1l3m5nUPt9sdxTnIsrZ9i2l804JrEs?= =?us-ascii?Q?Dg/r9LrTOms0DsZIHv6p0A4iafiDBdszFw1Tb6M+dD3Nqw1c3oR8ZD1o/g06?= =?us-ascii?Q?lbPfnqs2A1hNEKCsmH/v2qlwE5mAXuA9eYzW86ZqifWUHM9dCxmuveeC8Mve?= =?us-ascii?Q?ieCxU+QStUZkRSZc9PFrmvFpIP+J1GTusnko0NJYgyeb4s1n37NnIRadDTOU?= =?us-ascii?Q?lGgT31+jOJFJieCiRDkrKPBrlg7iz02Z/QE25xKnzBwFS6OhHwmR0a0HFM/n?= =?us-ascii?Q?/4uP6z01FKcesVZjzqx98tq5RB355iQgl+MjfMOm?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb45065b-b7ec-41a1-87f4-08db4b74f702 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2023 01:23:13.5234 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZAYDyW2fELR5haBQx7sp7wxkzFZEbNlPScukOmp4gj+SDmhh9w9/kRc4abHsTxldZVpfQtV4oJN2KRHSYs8XLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8961 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Ah sorry, one thing I missed. Please check feedback below. > -----Original Message----- > From: Chang, Abner > Sent: Wednesday, May 3, 2023 9:13 AM > To: Tinh Nguyen ; > devel@edk2.groups.io > Cc: patches@amperecomputing.com; michael.d.kinney@intel.com; > gaoliming@byosoft.com.cn; zhiguang.liu@intel.com > Subject: RE: [PATCH v2 2/3] MdePkg: Add new PCDs for IPMI SSIF >=20 > [AMD Official Use Only - General] >=20 > Acked-by: Abner Chang >=20 > > -----Original Message----- > > From: Tinh Nguyen > > Sent: Wednesday, May 3, 2023 1:49 AM > > To: devel@edk2.groups.io > > Cc: patches@amperecomputing.com; michael.d.kinney@intel.com; > > gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; Chang, Abner > > ; Tinh Nguyen > > > Subject: [PATCH v2 2/3] MdePkg: Add new PCDs for IPMI SSIF > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > This change adds new PCDs for IPMI SSIF. > > > > Specification reference: > > > https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/i > > pmi-second-gen-interface-spec-v2-rev1-1.html > > > > Signed-off-by: Tinh Nguyen > > --- > > MdePkg/MdePkg.dec | 26 ++++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > > 7488ccda7a00..b840092382cb 100644 > > --- a/MdePkg/MdePkg.dec > > +++ b/MdePkg/MdePkg.dec > > @@ -10,6 +10,7 @@ > > # Copyright (c) 2022, Loongson Technology Corporation Limited. All > > rights reserved.
# Copyright (c) 2021 - 2022, Arm Limited. All > > rights reserved.
# Copyright (C) 2023 Advanced Micro Devices, > > Inc. All rights reserved.
> > +# Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
> > # > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -2353,6 +2354,31 > > @@ [PcdsFixedAtBuild,PcdsPatchableInModule] > > # @Prompt IPMI KCS Interface I/O Base Address > > > > > gEfiMdePkgTokenSpaceGuid.PcdIpmiKcsIoBaseAddress|0xca2|UINT16|0x00 > > 000031 > > > > + ## This is SMBus slave address for the SSIF to the BMC. > > + # The recommended value defined by IPMI specification is 0x20 > > + (section > > 12.12). > > + # @Prompt IPMI SSIF SMBus slave address > > + > > + > > > gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifSmbusSlaveAddr|0x20|UINT8|0x00 > > 0000 > > + 32 > > + > > + ## This is the maximum number of IPMI SSIF request retries. > > + # The IPMI specification specified min value is 5 (section 12.17). > > + # @Prompt Number of IPMI SSIF request retries. > > + > > + > > > gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifRequestRetryCount|0x05|UINT8|0 > > x000 > > + 00033 > > + > > + ## This is the required interval for each IPMI request retry. > > + # The IPMI specification specified a time range of 60ms to 250ms > > + (section > > 12.17). > > + # The default setting is min. > > + # @Prompt Time between IPMI SSIF request retries. > > + > > + > > > gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifRequestRetryIntervalMicrosecond| > > 60 > > + 000|UINT32|0x00000034 > > + > > + ## This value is the maximum retries of an IPMI SSIF response # > > + @Prompt Number of IPMI SSIF response retries. Please also mention that the value of PcdIpmiSsifResponseRetryCount refers = to Linux driver. Thanks Abner > > + > > + > > > gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryCount|250|UINT8|0 > > x000 > > + 00035 > > + > > + ## This is the required interval for each IPMI response retry. > > + # The IPMI specification specified min value is 60ms (section 12.17= ). > > + # @Prompt Time-out for a response, internal > > + > > + > > > gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryIntervalMicrosecond > > |6 > > + 0000|UINT32|0x00000036 > > + > > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > > ## This value is used to set the base address of PCI express hierarc= hy. > > # @Prompt PCI Express Base Address. > > -- > > 2.40.0