From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 52362740037 for ; Tue, 3 Oct 2023 02:02:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7Trk38foa+rC5F1ezBMPMG1q6eSVqRO9/cvAJrv0wzk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696298575; v=1; b=fLP32FarBdES8O5ofojvT4Mzj3MfAfvEvyZiPPMYdmMyYnb1TKjy1BeJ+lI8hlyRcmi0Dfmy M552n92x0esaDXlbmKUfYojvv6aBFY0rPDjVBQpf4Yzlb5wtkFs/fGy/8+ortQRQ5KiHKmrY68/ q72wrJFHiPWOLwvuGGUp9Ce4= X-Received: by 127.0.0.2 with SMTP id 8iC1YY7687511xZobVXcYhLW; Mon, 02 Oct 2023 19:02:55 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.71]) by mx.groups.io with SMTP id smtpd.web11.99844.1696298574041816177 for ; Mon, 02 Oct 2023 19:02:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IBxrbxVWYnipjo/nAY6U92kVJc9+tIJpnO4q3EbnLUIdqkbXotvaIlBtMMPFQTiyXpYj7ZbCmv6IrCv8vU9VH+Ogflg7pCOpSdtdY8mm7mCCp3nbXUNueM00QG1nbyIdzR8Jvs1C5BE5GgNwsxqIVjfilq6T9u43wOp0IEq2vg2SHNNL6Xn/YoAJM8rGxGkPvgmlLB7IGcZl++5O6D8+CNDQst2eIkmX17b4katA+crwit0Ge5dFXlKNFQYHuLCKRBgZEVbRBMjv0SuGIjjbEoL2KdY04vL0I/170PnKqCXoqMtKgXNMfVD7e1AeE4LBgJBEeFAJuaGmJkulcEnyOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1gcf5wZN/GFcd8jYVswipeJ1NL2W7gfdvYijoXPAJ8U=; b=UcovcOcspCToB8APLpYnCL9yflhp1kBq3C1PEFKiZ8fVx0UrAqIC7IfoizGo/SSO+V4pDECB4mSSjgp4Kq8etSgK4CNphAhQomd+angiTD63F9vIWETpUIrig2MK9dOkFqty2xKRy+Gz06ADdiFay0rwvismcuQYEaC+JLq8SiPUvkwhEabsaEsiIrAyOw9OS5IfbExjOOJAza2rtt9N7cxBEgpguhNDle2t+XIEja5596fnuE20hnbfv13HNN5rHZnLmsMc7BAcswclHezJcxAgPNxnPomv8U3BzvuIXCUOnoITf5dT7hyZK7ZUyUu/oglXKFqxTDMblIAiT/8nFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM4PR12MB7696.namprd12.prod.outlook.com (2603:10b6:8:100::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.30; Tue, 3 Oct 2023 02:02:52 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02%5]) with mapi id 15.20.6838.029; Tue, 3 Oct 2023 02:02:51 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH 8/9] RedfishClientPkg: fix pragma pack usage Thread-Topic: [PATCH 8/9] RedfishClientPkg: fix pragma pack usage Thread-Index: AQHZ8yA69Y9jtItkuE6KDTmkCEPDtLA3VLcg Date: Tue, 3 Oct 2023 02:02:50 +0000 Message-ID: References: <20230929215915.46616-1-mike.maslenkin@gmail.com> <20230929215915.46616-9-mike.maslenkin@gmail.com> In-Reply-To: <20230929215915.46616-9-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=c4f0b376-5cd5-445e-bf0e-996a4069c789;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-03T02:01:12Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM4PR12MB7696:EE_ x-ms-office365-filtering-correlation-id: ec2c80f2-2f1b-4fb0-b794-08dbc3b4d942 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: SoYKFCxd2R2hvESCotcSNZPSFQ70iAf7FfNpIFZI50hn+iCmfk+qmf5IuK+PFAYpxSIneTcUw2hFuztoIhFo+loN/qmeueWYsK2a/uYUx8Ug4WoIwqdbZQT1f09K+kUMOMK/ujuJDjo4tKVzQpVA0/Wc40VKE63Ze9M0SNHtJfgGD5tghL5IQz1V115Fb34WPPKaJHbLGboWFSjy1nL6FeB3AADHzkbdELXedaS62MKKaFOCtctpguDhPAPu1uPGuLLOyy7I5D8owGeEJT0t1gVIiQOBktgEaG5Qq6NJL7XrNtcuStF75uDEKGR/mEzyDcdG37+FXJUONdfYzjokeavbyE7gTw5pN88zCWOrKxktP7fGznp7KAkivt0znfxtW2hZKc1gy2QlVUh/34VRJRG9EqEp9EWvPoO8WuBzAbs8bimsxbwGoJ6DQ+iOhiNUCjjH5Vvg3TF34j/gee7jNa41D2AE9Mps6f9osE6OoAAGUBpap9a4biOmRYn9mTOgIBJsBl7Kg0XEFyvUWACu2ZZwRBm3dON+D1lqeLkz9sX+tmOfc5L9rAe+3rL5FDdFTRJgrn1wKbLIW+vzzoXZF6qnTBR1J8h0mDj6/1M9zW/YCoMkS+hnaxtovS2TFIHV x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LUGccJYPA0+3sYdnwKwldLMGUxufjKHOA6cpluSBsiYJ4l5wfZ6untTFZ/D6?= =?us-ascii?Q?DxvmW0fXC66hvaRK1iGDJSz2l3Rq64emAi7iUg06JXYsZdaSu2RemFkv5PHd?= =?us-ascii?Q?dxDfsc+gj6whWONouVp0W+QM1UJgrpjveUt/aM3+if98LOMwbz12uWoE4F/X?= =?us-ascii?Q?VbmM/OS6V0/77NNPsS0N0QRY3v8wvY30lFtiwWxBE9f2RpghdLCpgiPhVM6U?= =?us-ascii?Q?A1KAwEWW1Bls/HWWcr/vcw8zWB3nWfscrLmCUhCgfKq2QwivatnG8x7b0mZA?= =?us-ascii?Q?XwBAE4notvmbWGJaJM9ZByY8Zuv53uWnj/El3TLXZxhbtuxnXlzq0LhEUeBI?= =?us-ascii?Q?eegtaGnkrLNAESoCZaLVOJLp0JY2JK8GGIfSB811zqAi6iBcrmUPLLGfoswU?= =?us-ascii?Q?RZ+oriAj9IP09Tu9IhIlFIK3A4n8qLjsf4+Wp0Ov0LblroAcy28eORkz7+gl?= =?us-ascii?Q?+I+fqC2ja9ftWl9omEGyPxFK/PCcHn0N6M4jQVVoxfKRrNzGb8igSyGHp5so?= =?us-ascii?Q?OjIfVYDmlxU9Ra9AswMX1buUQY8Z+HKh0pccl/wFKl5WKr34FQAkYLFY7dMc?= =?us-ascii?Q?JuGnt6W13fgJM5hJYaGEdCvYqJl4IaLeUW58vuAuErdAviTlvm6Z+FuZ61SF?= =?us-ascii?Q?ldgwdNoLUyI4PFFiWxEhIYlAs50t42wOm0y7UUWHChQV0LTFa6pvzs17nF58?= =?us-ascii?Q?737BLnUvpO2p1SsX06QR6bQsJTo55GmnRyJ5OkZWWKI0DlhSBGCr2nxpKt/Q?= =?us-ascii?Q?ObSWTGSb91TubTdtHdOQhdZdEtektmwYvfAkGhWKWrzIKvQc4cmawOtqpACX?= =?us-ascii?Q?jnWniYd3YlT+BH34OZNLLcJA7jebp2nQAeYSbFZGIRrvseG60x3iE7Ogdble?= =?us-ascii?Q?rSlvtd2z6JuNQoBGQzZo9SXj0D6O+R076g4E5iKcvUvuSo4GD3ThiebjJLwe?= =?us-ascii?Q?ocwpUtzI+n66PoI08HLR0+WFWIQbkHUoTJVpioPai15nnZmXv0WVpNBsgIFQ?= =?us-ascii?Q?F8YYJK84irI/WDYD2kSekopWHvoOx81jkTFIdkRFGWa2guNF1YksEuTiM0Hk?= =?us-ascii?Q?03MqNVTUmwsYvNbN5hZeSbTNjwGTp6oeT+QnGWKXFojP/1XUUXUogaMF9GGm?= =?us-ascii?Q?MVXCMybpN1L6Eokj4Zq0QFbPoVNyhIMpvR0CwYvvkeGtHNDC7R9ou5j+GDiY?= =?us-ascii?Q?1T+7FlxZ/XQBkII1Oy4XcWNMhNfOaKAEBaVLseRrAJJ+yTl+qgbgO8E8KbT3?= =?us-ascii?Q?8fzWbP5ooQdCW7WIcff/2Uo4tldbJrh7c0uFKYuUKRrTrkHpJ+5WO/LOKK0E?= =?us-ascii?Q?QcH6q+RUem/EHRoZIiRBsqypgU/wYtA3ygZBtKAosvOxjARsCWLn0xzRLFTl?= =?us-ascii?Q?Wyu/uofc+nY3LodAptgr0vdEYDra3znlnI19KjRMpT04bNqDaPkV/8mWt/vJ?= =?us-ascii?Q?cGlO5XML063hjaANJMsbo32gjjI/qcdAnI+e/5ADGO2ZhbAcYPUv//oJMf1/?= =?us-ascii?Q?hUNhAK+/BWEsTpxmaPWMod2y53JZyneaRy30twrvRaugfibhbkPjcug0PDs2?= =?us-ascii?Q?lISCiSuL5H9M/SZsX30=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec2c80f2-2f1b-4fb0-b794-08dbc3b4d942 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2023 02:02:50.9509 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: a6qFLm4gaRvtBTczTWNbD6I16VNd+p4zo9iaX5Cp8T+rRP4RkLDnmTUf6s2rf4KIcohagG/VzgMUSEYJCFHEtg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7696 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: mNbU0vRC4wdhdDCN25R1hXIYx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=fLP32Far; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] That makes sense. Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Saturday, September 30, 2023 5:59 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH 8/9] RedfishClientPkg: fix pragma pack usage > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Signed-off-by: Mike Maslenkin > --- > RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h > b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h > index 7e1bc9cefbac..9d5b10a7e909 100644 > --- a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h > +++ b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h > @@ -31,7 +31,7 @@ extern EFI_GUID gHiiToRedfishBiosFormsetGuid; > #define ID_STRING_MAX 15 > > #define ID_STRING_MAX_WITH_TERMINATOR 16 > > > > -#pragma pack() > > +#pragma pack(1) > > > > // > > // Definiton of HII_TO_REDFISH_BIOS_VARSTORE_DATA > > @@ -44,4 +44,5 @@ typedef struct { > UINT8 Reserved; > > } HII_TO_REDFISH_BIOS_EFI_VARSTORE_DATA; > > > > +#pragma pack() > > #endif > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109271): https://edk2.groups.io/g/devel/message/109271 Mute This Topic: https://groups.io/mt/101667468/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-