From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 16E5994115C for ; Wed, 18 Oct 2023 05:53:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QiFaD4bFcHmtV8FmDXZNPyqLc3EFX83LoWIvBJE0i0o=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697608382; v=1; b=utIQt2Ps9iI29RbJ0JRv5R4Y1+wtzhHhmEb3plKGdqaEmezIFTMvceQ56OqjrTPHLXdl1+mP VZT4FJIbaCS2gq3LorgjN4f7u9Fc/BrGjWP1z0gLgMDi4C+5cPjUkLUXzMoF2cfv+uQ0+w5P5Wy EK1mN1QSXG5CgxZGFiT1mtGI= X-Received: by 127.0.0.2 with SMTP id KR9VYY7687511xBXLtvOL3LE; Tue, 17 Oct 2023 22:53:02 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.87]) by mx.groups.io with SMTP id smtpd.web11.275329.1697608382082925479 for ; Tue, 17 Oct 2023 22:53:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SEq5UZ+Hx97zYT1kS1+lZpGiIndYOXMIvALvNZztnLPghwSXu3gOVs6bF/zR6qlWPXgFg2vhBwqcz8o5e3Cuc7I8L0cfvsoOgIlc5KqI/HLx5NKkvswnOLF8Bqty66kkP94fauf2U43IeHDyI+IPhF07AsP6SkHFvSw4K14YcaNtdpOSUprgQex0GhOdGv5SYIvamrVayfT4wIJdl+D6XKlz0+ULjInK6RLXcVaEDcp+hhBxJWYnU7V4DHXzPqhF579E2DUrhoPTvXozaexPj8zPASCPG01DBDypvTgBCM5wzbPqd0Z4ZHtKe4aM2RTsvEa7PuICDLnbpJjKl6nSmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=16pY5by2kPXjmMjtrLnO1KPr53UMPdRA5XOhhl0xznM=; b=Ibt0D/oBY6rjFn4IuyhfG20DJG2PqOTx3SokT+9baxZ4gI1v70/tzgBiBSB8c90B1UDyVxq3L8XkQ6jmAslK41dkKbJkwQXDyWsupBdrJHk5IvvvApLkIAYAixqdwozeN2A3IlQhJyFldR2FXXlCw5IaZAD6H8wgfI67TUgF9vYNBOsQLonS30cVbR6bSaXmtQF6WvwkMNcEDup5Q6NR3ZUJqfYB/20zTgf2bfGEk5oulNdoLNp1T6NntxcuoIfXrw53N7qTNa65bomGKOXYEMDsRWqp9kkx6swiSNXmefZAAJQntHMxDBiIPis02eFFvop8sYqRTwb22g0M6v4K7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by LV2PR12MB6016.namprd12.prod.outlook.com (2603:10b6:408:14e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.21; Wed, 18 Oct 2023 05:52:58 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::345a:6816:7343:3e6b]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::345a:6816:7343:3e6b%6]) with mapi id 15.20.6907.021; Wed, 18 Oct 2023 05:52:58 +0000 From: "Chang, Abner via groups.io" To: Konstantin Aladyshev , "devel@edk2.groups.io" CC: "isaac.w.oram@intel.com" , "Attar, AbdulLateef (Abdul Lateef)" , "nicklew@nvidia.com" Subject: Re: [edk2-devel] [PATCH edk2-platforms 00/10] MTCP-over-KCS support Thread-Topic: [PATCH edk2-platforms 00/10] MTCP-over-KCS support Thread-Index: AQHaADM+ixOCW0LAtEOo89TdHrOOVrBPDTxw Date: Wed, 18 Oct 2023 05:52:58 +0000 Message-ID: References: <20231016131816.6634-1-aladyshev22@gmail.com> In-Reply-To: <20231016131816.6634-1-aladyshev22@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=95fdd4ee-910d-4428-856a-264fde683409;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-18T05:49:11Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|LV2PR12MB6016:EE_ x-ms-office365-filtering-correlation-id: 50c0cd88-d64f-4a1b-f019-08dbcf9e7b5f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: +4wz17DD7HCNXodAtM51FGbr3swIq3Qxp+gqWGWTMROBlJxlo8uO3OXSbtNqjVDBIZaz+kFGB4oVMsIiHbRmDxs/pgSHYdJ5DJLwyi8driKNXY60RDV3Wd5lv4CWVryf+9YyOx7iAELogeghxzTunIlDe8dCNpoCeOe5Hll6CLzcf9b4FT/18Seoj6IHw1l1BM3NRffHdw44pk6c9s2/2MO0MC9UlWFe3/l7HcSRz+0bWLrGjmjlJs16DomzcgOY7WdyWZcVO8e2fO58BrBh01QUSkYpyAVrmvAyqiuumlSQ8sjvt8DMRI4AxDcdU3s7EPeII/LpL4ORshQYoIAnhTtHGZniONELogu0WdMxnLzke5GuJl7L0hNydoSYoOwc0aI73HBY8Z575Q3LuyYFiG81lbgxld5ZE692QJF2sR7CkqWOgR4zRMVyN/MaEfxL9r6Uz6qJEUxI7imIfE2/vuZDoiuCNPkrw/NtWYXbeay2npPCJQ/gBVsn2OGY+5m43vRS+psC5u37/sVc/wMWFS6Me+1X5tvHSKO5UdGHkNtJUS47ydOq7C8/Aw0hMyI5T+tb6+IT7kMzzE8qZqzK6oLdlChwjdGOaNhXgZH7JRORmOVSm1egVDqEY7bgeTK4ZyX3rOZSH9NzDGQqsbyBmg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OHiyWN1P5PGWiGNpFIAK/KcB8SexERdnYlkRL8K8NgJP9C8hy8Zl6hlnRkQo?= =?us-ascii?Q?FldsEpf+LyEzKCOdkJScowd1c/D4Lk99YqrUVINF6xcU6GtmOb6Dy8YMzeGv?= =?us-ascii?Q?swU1SBAXpfyE28M72uNniUcBRzqO9kvNUglJezgZW44JFI7D9CzEJnqTgjn+?= =?us-ascii?Q?FVENiO9OaL88RVZ5XAGI/6yogxL6ad68bpEDTCsf4jvd5dYIfAB8CfakoJfS?= =?us-ascii?Q?m5kczGTJNstu29nNawqo3jBGzUh9niDqwZMI/uar2wlAfSsGIzu8PEnDm3VB?= =?us-ascii?Q?VeBhKsgsMHcp2rE4VIdta/It73d8xSot59zu4MNYNx2ahGA0oreOfmyt/oKj?= =?us-ascii?Q?o2nKzb36oZsudOhqNZqF9VNDeuC7AA6VTenBx7XNUIF8OVU2Y9ZqWeHbGxT2?= =?us-ascii?Q?GnThXKE76BqJUXhahHV8WrKsNQ8i/f0MPUEwjnj2B+qHlyssA4umRF7NEySt?= =?us-ascii?Q?G/ZTDrNndCKoRY2L4WL+67sqYmArKfGIqSQ3+hXl154SGYYmXD0ZQo0EdcMC?= =?us-ascii?Q?WXyV/G/TkNFROoZWwyP5VaD1HQg1JnRFSV/r+G1nyG8pGoUSm0FaLBJoAodf?= =?us-ascii?Q?SJpxubc+dBuRrbwGTXsvc7C6DjIEE/tub51qGAaAyxGu6QC1pAco8AQXFTS4?= =?us-ascii?Q?2lMqv1FUwFGt9Yub+g5LOjEJuHoWX/x+vnvcCsu0ALnyfSAYzrWn4VefciaX?= =?us-ascii?Q?qvQYL54FukQts4yCXWV547NTer/m4BKlILA1Pr4kyF1GwyXcN4ZkvKPtTry3?= =?us-ascii?Q?wFQpf4+Eexnw8WuqjPj+5Kegv1QsMTV13C2dSFdH5goq360We0L+yYPbpyAr?= =?us-ascii?Q?53kcKUteJcDeCZgOZGxBqjD3i9hsrtwTB6VZ9zzFE0pNX2iKkgbYCsPxKYCO?= =?us-ascii?Q?a1L6fNylRHCCq09KYOOLf38IFbKZBRcarKXL68mWoIjZlaCecPcd2rhgJAra?= =?us-ascii?Q?5eyDEfq0aTQBbi/7ggLldafwEf/UmJevh7zSISacwINxt4Pz30NugBCXsHtO?= =?us-ascii?Q?AvbnQQvRsQEWx5txe0GwzjnRHWhjeF3bP2NPs1qz7A/QGQkU25vG5y2eD1RU?= =?us-ascii?Q?Xqy42Hf0hJ+K7c6AAFqkhXAGq7cRmj8a2v6ust7oiHbJAL0X99ReXWnNwyUA?= =?us-ascii?Q?NN2HZuJI95HTz2P88e3V6MyfgBVU9xRSNafH82WIWhOkw8YMyuEFYXNYx6ZH?= =?us-ascii?Q?5T6k5zCABqJtqvA8LgQyCDjq5NB9anr+MvWRAZd6FUDw/dGND7XWrMznn0oo?= =?us-ascii?Q?/gmonOMjYuzVEpjVtr3jYkHZ9D30rsoIDIINZXIsVgwyKOT/Ys1BpCR50f5C?= =?us-ascii?Q?e+nrl1MrmUcpVd3FJPgCjoLAnIsfOct7C3rxUWkIx/kf6SCR1VCLWWwNtYmd?= =?us-ascii?Q?3YfGeHHFRlY2pf2FN8jy6i3+WQUd8IG78rS6+hfmqPsOEGAj8eMBzHPIvHDM?= =?us-ascii?Q?e6wH9dy2zs5XTxj0xwMrvVQ/OsVXX2efbro3AlgX6Ef39iyx8180UCWqwPim?= =?us-ascii?Q?PKu29vG+/cdl/99ooBd8+CGi70SEmULeRndcWYc5VQqwRDFUcPE43jKX2EaL?= =?us-ascii?Q?P+KsovRLebLH4xu7EQOHQfCsemBD3/5AQITAPfmw?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50c0cd88-d64f-4a1b-f019-08dbcf9e7b5f X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2023 05:52:58.4186 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qNlx3nNoNnbDjTUiecrAU9kB82qkznpbUxm+STWz0+7GrUOycmANxUayrZBj0vXQg/2EKeMCSQjsYwaqeYJllQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB6016 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: VOBdDlgqk3f76vmWKJH5gU7ax7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=utIQt2Ps; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] For entire series, Reviewed-by: Abner Chang Hi Aladyshev, Could you please provide the corresponding branch somewhere that contains t= he latest version of this patch set? Then I can move forward to merge it af= ter edk2 portion is merged. Thanks for this contribution. Abner > -----Original Message----- > From: Konstantin Aladyshev > Sent: Monday, October 16, 2023 9:18 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; isaac.w.oram@intel.com; Attar, > AbdulLateef (Abdul Lateef) ; > nicklew@nvidia.com; Konstantin Aladyshev > Subject: [PATCH edk2-platforms 00/10] MTCP-over-KCS support > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > The Manageability KCS transport library needs to support requests both > from MCTP and IPMI transports. Currently the code only handles IPMI > case correctly. > In the MCTP case the communication should be based on the MCTP-over-KCS > specification (DSP0254). This specification defines a special KCS > binding header and trailer structures that need to be present in every > MCTP message. > The header structure contains a length field, therefore response packet > size is not needed to be known beforehand. > The trailer structure contains a PEC checksum that can be used to check > itegrity of the response message. > Modify Manageability KCS transport library code to check which message > is processed (IPMI or MCTP) and handle each case correctly based on its > own specification. > This patch is a result of a joint effort from the Konstantin Aladyshev > and Abner Chang . > > Tested: > PLDM communication between the HOST and BMC was tested with both > components implemented via open-source software: > - The HOST (UEFI firmware) part was based one the edk2 [1] and > edk2-platforms [2] code, > - The BMC part was based on the openbmc [3] distribution. > > The testing process and all the necessary utilities are described in > the [4] repository. > > The provided changes keep IPMI over KCS stack working as reported by > Abner Chang. > > [1]: https://github.com/tianocore/edk2 > [2]: https://github.com/tianocore/edk2-platforms > [3]: https://github.com/openbmc/openbmc > [4]: https://github.com/Kostr/PLDM > > Konstantin Aladyshev (10): > ManageabilityPkg: Add definition for the MCTP KCS TRAILER structure > ManageabilityPkg: Check MCTP EIDs for reserved values > ManageabilityPkg: Support both MCTP and IPMI in KCS tranport library > ManageabilityPkg: Check header fields in the MCTP response > ManageabilityPkg: Correct typo in MCTP destination EID field > ManageabilityPkg: Update the algorithm of using MCTP endpoint ID PCD > ManageabilityPkg: Correct value for the MCTP TAG_OWNER response bit > ManageabilityPkg: Don't check MCTP header fields if transfer has > failed > ManageabilityPkg: Use correct constants for PLDM header checks > ManageabilityPkg: Return error on multiple-packet MCTP responses > > .../Library/ManageabilityTransportMctpLib.h | 9 +- > .../Include/Protocol/MctpProtocol.h | 12 +- > .../Common/KcsCommon.c | 284 +++++++++++++++--- > .../Dxe/ManageabilityTransportMctp.c | 4 +- > .../MctpProtocol/Common/MctpProtocolCommon.c | 129 +++++++- > .../Universal/MctpProtocol/Dxe/MctpProtocol.c | 51 +++- > .../PldmProtocol/Common/PldmProtocolCommon.c | 10 +- > 7 files changed, 430 insertions(+), 69 deletions(-) > > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109710): https://edk2.groups.io/g/devel/message/109710 Mute This Topic: https://groups.io/mt/101994937/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-