From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.76]) by mx.groups.io with SMTP id smtpd.web09.9177.1659717064529233980 for ; Fri, 05 Aug 2022 09:31:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=KrVP2Vdl; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.212.76, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a8LvqSQsYEl/U9rtgfN2/8hddQxVSxDde07yVNLlLs19SH1Gmx6fl0I+Honp931uDNji8BwyjilQw1T96G2D8EJLJSCMcslQH/HLPvDPf9h6gqp03rft1PvkaTmuf4EARBntd3dOBy0O+XxTPxKuLjv/gUIF4aATbypAomzZeyYcSW80av7s2OuA9WbQaiZ/6ewI/3mdzKgZXxrgC0WqRY03Ajk3hNMIieahA409vMBmRAIVmg8D6aFN8NV/BRN3Do5xaRI5lUDDRZi9kC4KWZtbBRSO2VsVez0l9GupvmhdqYjmNDtNJJNDpsTkQul/JOZu54/MxRbLy6mnQUg9bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pKR0xCzJzXR9hG6J51zxQtvgAB9Rbwtz64Vc/ow0Mbo=; b=WZ68ug9PdmB1+xm38R2+VWr3Th5vjpJgLOAk4sbuRg4m+0218CkxijxE8d4k0aWMUrE1wsPtv4uf+5+HE1bupuKZS2Zcmu5ZF5eCCmSFEjSehwfZKe2JeapRgCqS2DacbZUSLma9BD/hrQHC6mX1z6f1Wpbn6aEUoxaJJ1K7ouy5QWrYQtEem3tZFDa6m54Y+U7NjnRRkxuVtE8dJbffTXaRb6A7B2PWEqQQK6S7ZucmQ67lqr0fbzoa4xQ65xiHN4E2btQOsQqdiyj4g02MiN6hAGmhio8IRtTccaotIo1N8d3zLBN99nUqI4A1741/MsWwr00vYiiTJd9tRfNP9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pKR0xCzJzXR9hG6J51zxQtvgAB9Rbwtz64Vc/ow0Mbo=; b=KrVP2Vdl6LhI/GeC08Xky4K3Xa8e/vjyR7a5unJdFCOzNG8J3yat5Z7pS4tRIfThFP3tTZ4G68sFZdeqNQ5iwF6vQrQOtgWFkI/ljc4UoEEbtf/p80DaSLo/dLcYVyHaICeo3mcjy4rEtPKgkjZVcfJgoeU3kBBEobOJOtI7YXk= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM6PR12MB3563.namprd12.prod.outlook.com (2603:10b6:5:11a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Fri, 5 Aug 2022 16:31:01 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e850:8264:41be:cb1f]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e850:8264:41be:cb1f%4]) with mapi id 15.20.5504.015; Fri, 5 Aug 2022 16:31:01 +0000 From: "Chang, Abner" To: Igor Kulchytskyy CC: "nickle.wang@hpe.com" , "devel@edk2.groups.io" Subject: Re: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Topic: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported Thread-Index: AQHYqBZkooOwOPqdpUetZUJUGJMh9K2ggGIw Date: Fri, 5 Aug 2022 16:31:01 +0000 Message-ID: References: <1659626705-20532-1-git-send-email-igork@ami.com> In-Reply-To: <1659626705-20532-1-git-send-email-igork@ami.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-08-05T16:30:59Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=a9855328-c0e1-4f04-bca2-152dc6f2a96d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7b36a88b-0142-43a0-1c10-08da76ffe252 x-ms-traffictypediagnostic: DM6PR12MB3563:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: P8YhyY+3iwLT0gRCvtgj2KS92lx573AoDqo333hlUXoBbE2yd0rvHw0EwvPu6EILGUNDErPKhIrk4sxzo3P0pHhYv59fuPYZdJrHbxS3BEjKIKNlUFDkATa7RQgdi2lRlXlHHDkAGK6nnQP1k1Y9bZ0/DynkO6ahdOQKOUuVcW3KizVxT9aM7frQSGRqtqR1HgdcUeW7lIVhhShRiZSYiz5jLtJi06cfqZxYRFp8JLf0d1B7HT/0iazA6uzwQTAt94ZTrfl4FipYXAcFnT/MgtqXSkc6A7GkG05b/cqzs+VJ2S4mQ5iKLzAWtn0OhHIc9trjm1PZtBU10KCbSuDySaHg1Udg+flT2wDirJKEfI6ltbjV8VZGK/f19IyemQFP0/uNFOoE8/oVLwrBI+9FbRNeE7gkriBNT2nQ0GezKAy0cOUmQEkQS2B4xkBo7F6LrfLxCSq9JJYM/OT7h0jkYojFojasyjNTj3Mj9ypItENxKzuUhjqDjiukW2vzO4tIPlCydUG4DVJ7Bx56F1jmw7D3c7kpS30V5b5tm+W6EGDuKggN/ZiDvkSPYn9BDxCCOM7x+reOt00y0ZGq2aGuJz3gtOWw4ouHaj1rSQGVwzQEXjosueXGto4O9CdxGgB5CWGf4NfsdV0nJQeoLc8KpbAJ0D3njshuxhP5uNvzwQj33jFWP8Tm6HonVYrs/Of3RSRriCeXUzXubiiTDljETtnreJLK2obd3wTTEGC0fb59d2mMc9OfAjvW64CS1bNFuXeloLvK533nrv+JiDNVti19jfzVGRPg6lqnB8IkDmSvubbXQb6NbNmLszi2aLfKtDXhlOdzUkdi0JO60FSdQQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(376002)(396003)(366004)(39860400002)(76116006)(66946007)(64756008)(66476007)(8936002)(71200400001)(8676002)(478600001)(186003)(38100700002)(4326008)(52536014)(5660300002)(66446008)(966005)(38070700005)(55016003)(122000001)(316002)(66556008)(2906002)(6916009)(86362001)(54906003)(6506007)(83380400001)(53546011)(41300700001)(26005)(33656002)(9686003)(40140700001)(7696005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BUSjO4wYWcMChVVV02tlQtBu4jRMyQRRnZJZLWfv7OXbYsz3dOM0UACb4t1z?= =?us-ascii?Q?Zs9LlL4LdptIqrGptEXImQpPaCANt1eZL98L15SxbcbssEHL2En2AHFxVMb0?= =?us-ascii?Q?ZbnZs5ZiI365sWV9H3SKFsYkczmqXDyDY5CaJWKob9KPlKOOQTeEGnRI5LAJ?= =?us-ascii?Q?KDysRG5Y5cjD/yPaXCtYVCgvouIvmYD/BpK/tBTsX11AKYM6g0F4SE7nsJtU?= =?us-ascii?Q?XzVFoycm1nHhGTG+FXJQ70O9T3YzOsghRftjXlVmwFEfszt95C8uhA5ej80M?= =?us-ascii?Q?rfe/X9irVNZWFtuyj8eyq+R2HnocAk5XF4ybg1t6h0IgNvZ6zrtH9CKlh7h2?= =?us-ascii?Q?LFWXzBpFsGel9LbTe1lZl3+huDtItvqdICCGUkdVJULwpRkHcq90PJT20sVU?= =?us-ascii?Q?C/Vy3XZYQwOror7T1JaGMhSY/anBymT6+gnwzKYMo6mfRC0tUoFrpqEVZzwG?= =?us-ascii?Q?/ZpWXK4GTzQ5XXJBbUAg8MFKMvu22Rr4z+1mnWNwFNAnW38fLomB18HQtqYT?= =?us-ascii?Q?y6GWyv9DGeBj2yq/d3I6Y6RcQGd/dsFsdU4VH37iCCVsra0tC6pcIGLBR1v3?= =?us-ascii?Q?rXqp1o77l3hPMS+wm8MDKHN41yc++p/ylxRm1vsp+/grir6nr8RtfBSvyyMx?= =?us-ascii?Q?pQS70a56y17zVMg9ZKMQN1+EMgEDu9apUNPQsQtd2OKTjNvyFYbTCnXBlnW+?= =?us-ascii?Q?b0F4pm7HkGRedqmb3rvuGKpHuEsx1v/CYz5Uiq/MgkHqPGjoQnVjx+ggFLXf?= =?us-ascii?Q?G0y0FoRpyyP0WqWCVb0hR/nFWb7br/xAoGaO72aQA5iULexo1lvQImc58mSI?= =?us-ascii?Q?CTNV3KezqgI0jnQfQIlmW4silp3vaoAPuPv1G0cUGz4Bact5zvRRhE9Z09Vx?= =?us-ascii?Q?lqiSNl/zmYz7CPklVrGp1J8Hz0cofh7ILT3hj54X884opSx0D8lGQApPANHi?= =?us-ascii?Q?LP+6dIoyvADrANIL0dZ2/Anss38KOZAwdEhS3kUS2YVFNztAGkEJX1F+sVXx?= =?us-ascii?Q?VlmNesGeYgOeS1pTvZUblu3PK+HmOesq2Lhl4eVOvh5tWrYOSGuTuC7EPwrf?= =?us-ascii?Q?WxdtJlYIQ5a6U0vAB5E9IlUgMwt54UXtnqnadeYFPUodZAhg8Crf/EM57U3A?= =?us-ascii?Q?RWzagB+QvNkYV0IcCy+QZ2aZHBXS20aljet5PjscFBGZW9TenDegHNGbG9e7?= =?us-ascii?Q?gkF4j3ZgN6Xx7rTThfFpACtbLOimu9e+95S4OyC6r0LMQIp3ccNe06iypFeb?= =?us-ascii?Q?1+85eSr9FE8RWAQ9N/cpop8rRBCPWF6ml4MtuDn2Tg8r679u6x/pipDOHLsf?= =?us-ascii?Q?45Q5WTh89VQouGDbGU/5raH6DntFMf+AyhrTT9e/tXPmGKQqf5BrKCbWr8aP?= =?us-ascii?Q?Bm8sAShuB/hlNhLtsNWQA2ahmFNusoX2sdJKZdBmxlme3bh+6sXoSx2RMo18?= =?us-ascii?Q?+iPnRL5wiUJBsgubkdFyB5RwDm6YvecLkBjSABvvUbNTIYx8El1AwF+G7t91?= =?us-ascii?Q?weMp1TspsmDoZ3VCcDejVs07o0AS4WPVix+AqE+iaccI1o3xlHC3ut87Nzdj?= =?us-ascii?Q?tg3dXWiH4KB7HAxXQcHgMjZI42g6s5OFDWff+wzP?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b36a88b-0142-43a0-1c10-08da76ffe252 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2022 16:31:01.1804 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N7/n74vvWOiWYCvDGcEDPeI6VWQAKmZGtEwt1znahTtoT4YlU+kz6lPe6lqh0fpeIXn+PdM82XJLZIM3tIFflw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3563 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Igor, Just found that you don't have the CC for maintainers and your Signed-off-b= y tag in the commit message. You can refer to below link for the correct commit message format for the p= atch. https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-= guide-for-edk2-contributors-and-maintainers Thanks Abner > -----Original Message----- > From: Igor Kulchytskyy > Sent: Thursday, August 4, 2022 11:25 PM > To: Chang, Abner > Cc: nickle.wang@hpe.com; Igor Kulchytskyy ; > devel@edk2.groups.io > Subject: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host > interface is not supported >=20 > [CAUTION: External Email] >=20 > Host Interface details are discribed by the SMBIOS Type 42 table. > The table is published by the RedfishHostInterfaceDxe driver. > That driver supports PCI-E and USB host interface types. > The table is consumed by the RedfishGetHostInterfaceProtocolData function > in the RedfishDiscoverDxe driver. > That function only supports PCI-E interface. > --- > RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c | 11 > ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) >=20 > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > index d79750b..a3b977f 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c > @@ -65,10 +65,15 @@ RedfishGetHostInterfaceProtocolData ( > RecordTmp =3D (UINT8 *)Record + Offset; >=20 > // > - // Check Device Type, only PCI/PCIe Network Interface v2 is supp= orted > now. > + // Check Device Type, PCI/PCIe and USB Network Interface v2 is > supported. > // > - if (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) { > - ASSERT (SpecificDataLen =3D=3D sizeof > (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1); > + if ((*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) || (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)) { > + if (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2){ > + ASSERT (SpecificDataLen =3D=3D sizeof > (PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1); > + } > + if (*RecordTmp =3D=3D > REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2){ > + ASSERT (SpecificDataLen > sizeof > (REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2) + 1); > + } > *DeviceDescriptor =3D (REDFISH_INTERFACE_DATA *)RecordTmp; > Offset =3D Offset + SpecificDataLen; > RecordTmp =3D (UINT8 *)Record + Offset; > -- > 2.6.1.windows.1 > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by= their > designee. If the reader of this message is not the intended recipient, yo= u are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission.