From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6F0467803CE for ; Thu, 2 Nov 2023 06:48:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1468M0q36vUcOZM78Jpk+37xCltTYz4hcWGdoPYn2Zk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698907697; v=1; b=tMBskgu+wXAyc6I6Y9zwAMUdYxYcwmsbSRGmEBoUc+YYWWL7GSqA+R977zjcyIqycvuKZXPZ eDAENLumyImTr0pZrkv69BMVWbYdvtFdzAPDdF6Racgoxj1lKXd6D5w1m+J9t5hRLbKUOj8prGU NY3DwYdasfWhSjUI7S8IJK8c= X-Received: by 127.0.0.2 with SMTP id 4umCYY7687511xyZYU7caHt0; Wed, 01 Nov 2023 23:48:17 -0700 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.77]) by mx.groups.io with SMTP id smtpd.web10.25414.1698907696315248593 for ; Wed, 01 Nov 2023 23:48:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bYOqodb/1yWIV9di9ZeWzwwQAnqjXaeD/V+roIaQx+x2a2kjscj/PWXoOAMo3cavV9VnY1KK+vyoSRtvVRbapxgf/IA9JMD2SsgM90Mo0bVO05FlylPiLxv4DlCLnvOH0Bml+nBhpDqEouZceYp4c5Fwqb+a15gFyE0AAbMg6a7B9EItopxXMRg1gULBWgd8wRVoQmHQD4YrKZCC8fffXnOQuCrE9LdopEzC8NUAthcgJ/0B+apDHh43lLO1rtJi1xE+en6u91XuOexO2Voz7BvvtLjzXjr4c4Qm01A+5w9WX3c/1U8Q3LW4R7QWJ/36UMs5exDxoYTX3zOBJRcqLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kYLr202RdDOmsgyusSQohFl2qbQhu/eKMZvp2znSTZQ=; b=CkCz5d1oBh9MasSZfLG+/OtONKQgmUoPbgUVy+JIh8w5kBVFihA5JEUtjnCEo0adsXMSw1OXaI5x2tJmONRISxkpTHhScnbplkaGri077JPHOrZiA5sFlBAZVIhsQVryf2vojO5zN43tbcqB1Un8lNWhJdOGkD0CqGchDGY0FaKJ1nrwBVt50QqHR1VX+jLRzM3AdXTpGmzbZFWGpHKqmLQBjvHdoA5/rp5Z61kBHQ9WdAWv5j36cHfNrfF5ErkFZqiU7ccAeb5JHfbK6JMldwlJNxUqH9DpnezSl8piJPooey7c9scU7YcJVffNVHN6Vl0nbelMYclVmjlDeiwssQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MN2PR12MB4485.namprd12.prod.outlook.com (2603:10b6:208:269::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.21; Thu, 2 Nov 2023 06:48:13 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420%7]) with mapi id 15.20.6954.019; Thu, 2 Nov 2023 06:48:13 +0000 From: "Chang, Abner via groups.io" To: Wei6 Xu , "devel@edk2.groups.io" CC: Nate DeSimone , Liming Gao Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: Support Standalone MM. Thread-Topic: [PATCH edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: Support Standalone MM. Thread-Index: AQHaC6d1b62yF3ywPkKhhskgxVd9rbBmmbvQ Date: Thu, 2 Nov 2023 06:48:13 +0000 Message-ID: References: <84314c396de63fbd86a8bbd2dc1493d602c44535.1698720712.git.wei6.xu@intel.com> In-Reply-To: <84314c396de63fbd86a8bbd2dc1493d602c44535.1698720712.git.wei6.xu@intel.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=191dd50d-de76-4feb-a0a1-42a840316496;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-11-02T06:48:00Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MN2PR12MB4485:EE_ x-ms-office365-filtering-correlation-id: 7ac3c71a-ed1b-47d9-183d-08dbdb6faf4a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: NGUin5lCwlD+fif7YzAk7XYGK3FnbN1Zl1951IODqoJ63N29DZlbQxZnAb1GC29acLOuwRP1x7LEE1/UTXIKJkjSTG+3lB+AU05vmWIMu5oH32GHcRKy2i98VyuVMj9rrLR2eAyridX9ndVINQijwKhV7qFA/3ByK7S9JgdMvC1imFj35f/MQ3uu6H677zQkF8moA8VXN2JxzgTKXCpuomLhStbApe6e6YtUUfnvuPM3VUqyuJTOVNvPd0I5Yc2s8S8ZMtava0hABaHLMLM2Ne9srGYhKVGXAMLrWyQj3e3yPJ5mXysZkY5eg5/fMoJbFeF/EEILpuFqzzzSFhDvtHscyFQsNSSnH9Q1oF9xls4DinvqRZHgFCpeFjN4aJHmVcKGPRQDIM2slnAHat/RmiRotTvqA0DpSqB8oN6MMX6vafyuIlq2UKNc/sP8iJRJ51PDawSuVJgKJ9SwbbPCKS0+hG24eb0hKXe75EShkNltLGm7y/ijGCuw2ESPpTP4onM0GvgAqaWMyJR+y1reirrT4t7DYRXsdhGdYm/gyzYVr6jw7zgns4lgtlzs8QtjHRzWKCwkRJfpxUt1Zm2+0x5KixbiD7YH92/ruv4Cz+p0aAHaZURCo+l8joz1sen1aKOBW6bOHeM7P5GD+/HqzjTMh6eQsckNNsZEOAvXKZk= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ALvom+o8jD5YC1PC+79EtI//lgACk08QTV8GZUwQGS53IoyyzpZkrLf7RkIN?= =?us-ascii?Q?NnYlPgZOQXOF7aojykIBDfOUULUls1JxiUD5YoEDF99NKVI1gYr+1M6z4eKb?= =?us-ascii?Q?GhDQBEf4hgeAos3yQwp8Wx8Nem4uTsmem4jV/UFi1UTBMMp/ipeYx8+Bi24g?= =?us-ascii?Q?loYWFMGsiDdapkaLal1ARpfmqBeX3Nn4ukO4nyINd+TS1C3Op94xR/6gvkh6?= =?us-ascii?Q?XoC/1wHI2H55AjRSmxjcz327C7I5lQkeMnwieuN6LME6txE9KZ2voarGhMS6?= =?us-ascii?Q?c3pYko9KayiJu0qvLi09JzVWcXHpHxspWiOMS/iWPjqJ/TqCe0b01pECWGBI?= =?us-ascii?Q?rwNsenkVRSuljQouG2/VaW6EmmLBO/zIDbH6q+YgJYctpzhc7TtFBgHHedq1?= =?us-ascii?Q?uK9uB+/1tyeEV4ZiNWkYM1IMGQ5XCZz/ImzxCiViuFrpWBmTxPIpLXrBvQYt?= =?us-ascii?Q?E5DWWL9bsuRFuzINDXG6qzOT626BLQKVw0peKCjkqqm1HsBEPKjmOMMeqnmc?= =?us-ascii?Q?sYaGajyDGJ6ZtSrKUFycevg6wGWxJFutjEL0r/FXaUCplloBc0ws1f47mygF?= =?us-ascii?Q?lCdAtcbaiPtpc9FpWtm3KO7MIrz/XgWrmRIkB3VizYfUn+NBYH3nE8PQW00K?= =?us-ascii?Q?y2xUMmh0SQ3AxLWS77wNbc2deGmWNEN7PEZTHPiHG/5awg8Ip5d0B9IrXBCH?= =?us-ascii?Q?/5yswElksiwrdM/UChrGKdjH5CSf75l76WffKtwduNnqHHGfSEeqg+Pbjcks?= =?us-ascii?Q?MAWqTndPiChS+LNY91NRzDI4xj6hKytmM1lrGXOoLejzs5qutHSugB3oiGo/?= =?us-ascii?Q?BQxhYb/4Fi+PhdCkm38F5sjeFSDTNKrbEU8goiNJiyBxWvS66ZKtAqBaMJW2?= =?us-ascii?Q?orGFQaWC6Rz+g5u6R/T9+fKulYQL9Uw6yamAUn5jxUIsz0eJLQuf6SixAXKD?= =?us-ascii?Q?c6MwmwGViWm/m4Z+h7jfLXhdJhscsXlT9CZVGafEfccNhNexMXx2vfODOQPx?= =?us-ascii?Q?Yps80CEUs8eAycqbS/WCJN9+j5ns/d0R2FYElEtPYiqi17J6/ZJ3bIaXzIoq?= =?us-ascii?Q?Z+sf6Qhu07DAgvNwJhv6mw3HMN5czSe17b9ej/HW6u+UyMaFvYaY3j9iscSa?= =?us-ascii?Q?19DWbQkGHgVh9DvWTMwA8BcXeZG/mNkpZJZq3PylTGN+F++7qgSv0kKntE4U?= =?us-ascii?Q?AKBP/2lNt807YyesuxYmSwNumDnCAVejQ6nyJM554vhflCT0pKMUHebudK4e?= =?us-ascii?Q?JgJCk1CvaM0c4LFLDlRouUuiRScZ4NgrVB0zuhvbQ4QrjFZilu44PrENgRo8?= =?us-ascii?Q?fYvmhJb3Hhch/Lbmh+RMmttsafTMTfqjzDEQRDbrF1DXnwGzzLMwiON0s6Xs?= =?us-ascii?Q?Bd2QsD0DG/mGd3aZ/JzljWx7VGePZ/5FpjYBCv/1VKPxbk6LbT/JM2t6tDBG?= =?us-ascii?Q?NnzdqrDofSgrlwbygBmtJXtKGbQWR1bNIT3O7j+eAYn6AUVXzD3vSWTSCa2n?= =?us-ascii?Q?IjkDKsh03jbBYWx2jbKqKxnv0NGxYLKY4DaCKWGqM2mcf1Vs4B1rTS/b792Q?= =?us-ascii?Q?cLiZSgw8mkYnKhZW86E=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ac3c71a-ed1b-47d9-183d-08dbdb6faf4a X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2023 06:48:13.1462 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8i5iYMTzWAcnOqZpYkuQ8YDSIEl/p0lFK4mdQhOyNgcf2ZXEBky6MCSpZj5EKCJe9JHQ+vhbPEJgzM+Y6DVvZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4485 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 20KQyacBArYufksQaSjOIWPOx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=tMBskgu+; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Wei6 Xu > Sent: Tuesday, October 31, 2023 11:08 AM > To: devel@edk2.groups.io > Cc: Wei6 Xu ; Chang, Abner ; > Nate DeSimone ; Liming Gao > > Subject: [PATCH edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: > Support Standalone MM. > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Add MM_STANDALONE type support for SmmIpmiBaseLib instance. Replace > Smst > with Mmst. Remove unused UefiBootServicesTableLib reference. > > Cc: Abner Chang > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Wei6 Xu > --- > .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c | 17 ++++++++--------- > .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.inf | 5 ++--- > 2 files changed, 10 insertions(+), 12 deletions(-) > > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmi > BaseLib/SmmIpmiBaseLib.c > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmi > BaseLib/SmmIpmiBaseLib.c > index 6282adc269f8..1c618e48abee 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmi > BaseLib/SmmIpmiBaseLib.c > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmi > BaseLib/SmmIpmiBaseLib.c > @@ -6,11 +6,10 @@ > SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > > -#include > +#include > #include > #include > -#include > -#include > +#include > #include > > STATIC IPMI_TRANSPORT *mIpmiTransport =3D NULL; > @@ -37,7 +36,7 @@ NotifyIpmiTransportCallback ( > EFI_STATUS Status; > Status =3D EFI_SUCCESS; > if (mIpmiTransport =3D=3D NULL) { > - Status =3D gSmst->SmmLocateProtocol ( > + Status =3D gMmst->MmLocateProtocol ( > &gSmmIpmiTransportProtocolGuid, > NULL, > (VOID **) &mIpmiTransport > @@ -60,15 +59,15 @@ InitializeIpmiBase ( > { > EFI_STATUS Status; > if (mIpmiTransport =3D=3D NULL) { > - Status =3D gSmst->SmmLocateProtocol ( > + Status =3D gMmst->MmLocateProtocol ( > &gSmmIpmiTransportProtocolGuid, > NULL, > (VOID **) &mIpmiTransport > ); > if (EFI_ERROR (Status)) { > - Status =3D gSmst->SmmRegisterProtocolNotify ( > + Status =3D gMmst->MmRegisterProtocolNotify ( > &gSmmIpmiTransportProtocolGuid, > - (EFI_SMM_NOTIFY_FN) NotifyIpmiTransportCallback, > + (EFI_MM_NOTIFY_FN) NotifyIpmiTransportCallback, > &mEfiIpmiProtocolNotifyReg > ); > } > @@ -127,7 +126,7 @@ Returns: > { > EFI_STATUS Status; > > - Status =3D gSmst->SmmLocateProtocol (&gSmmIpmiTransportProtocolGuid, > NULL, (VOID **) &mIpmiTransport); > + Status =3D gMmst->MmLocateProtocol (&gSmmIpmiTransportProtocolGuid, > NULL, (VOID **) &mIpmiTransport); > if (EFI_ERROR (Status)) { > ASSERT_EFI_ERROR (Status); > return Status; > @@ -164,7 +163,7 @@ GetBmcStatus ( > { > EFI_STATUS Status; > > - Status =3D gSmst->SmmLocateProtocol (&gSmmIpmiTransportProtocolGuid, > NULL, (VOID **) &mIpmiTransport); > + Status =3D gMmst->MmLocateProtocol (&gSmmIpmiTransportProtocolGuid, > NULL, (VOID **) &mIpmiTransport); > if (EFI_ERROR (Status)) { > ASSERT_EFI_ERROR (Status); > return Status; > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmi > BaseLib/SmmIpmiBaseLib.inf > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmi > BaseLib/SmmIpmiBaseLib.inf > index 7ea688fc165f..cf6b91c471fc 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmi > BaseLib/SmmIpmiBaseLib.inf > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmi > BaseLib/SmmIpmiBaseLib.inf > @@ -11,7 +11,7 @@ > FILE_GUID =3D 2B5AD78E-5CF8-45d2-B2AC-749A0942591= 1 > MODULE_TYPE =3D DXE_SMM_DRIVER > VERSION_STRING =3D 1.0 > - LIBRARY_CLASS =3D IpmiBaseLib|DXE_SMM_DRIVER SMM_CORE > + LIBRARY_CLASS =3D IpmiBaseLib|DXE_SMM_DRIVER SMM_CORE > MM_STANDALONE > > [sources] > SmmIpmiBaseLib.c > @@ -21,9 +21,8 @@ > IpmiFeaturePkg/IpmiFeaturePkg.dec > > [LibraryClasses] > - UefiBootServicesTableLib > DebugLib > - SmmServicesTableLib > + MmServicesTableLib > > [Protocols] > gSmmIpmiTransportProtocolGuid > -- > 2.29.2.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110502): https://edk2.groups.io/g/devel/message/110502 Mute This Topic: https://groups.io/mt/102290796/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-