From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.67]) by mx.groups.io with SMTP id smtpd.web11.10608.1681481627609705250 for ; Fri, 14 Apr 2023 07:13:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=j/9A9njR; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.95.67, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oa5bBI3Tx08BxX4ubwkFVm3fM4gK2YrdnpHREG8y7sYE6PFuaknVqSfAyMT7nHXXEPg0GPBaJO4Dw/kc9+R+l+n+6uZ/etFNdlqogX7nIk/FbNTQ7UnFzHJgvv7mdes/dLEMJ3keIIrO49d9JV0FTULrdJJBRHGs91zQJOiHhSCJ7wh4sj8T/OaZK9EWmMpu1NX3IF3InSeQMF1fgHLgWtc0ZQ2QhZZbCRsFVp8JpYceNiTroSsLzj+XP89stcLZBdAXfgBDhgsz5CEAbapEgdyrYOR0Oip1HPIwLrIfvcB6WUNoua6APPldETSaXbaNd5c7q4VMFRQmEUUIelseKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y1CjYRG61xQemz6V3Ms+ysZMoei08cspNWYKFzXFfnE=; b=K7gWJsjremcEk90dt7PZlUzp80WJbO1w0duQUXSPNVtIs7nXvA2X7888WxwtXAgR36RC7dpF2AO8WFZvO1vB1uvX0mmH+AUQag3leurTTKIZ+UxHuzdvsozEwAOI864Zz+X47sx9XOb8ZbDXx83WFD5tSSrgHw5Zwn8IISU72K4e/6h6epqgFkKxtBSQn5awvnT98ymBdRlIHv6D19AW5Wh+TJgoI8h1vAVw1xeRJFDM6t7f2SboAYAxRn5Z0qLrIQvtLGhc3FuJ0wzgSTT5G6okd51u0ODy3yt1iD2VJ/1YlrJH4+KNj8vN4mOu6yNFPl00Hk+9I2E7voHIOTqR0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y1CjYRG61xQemz6V3Ms+ysZMoei08cspNWYKFzXFfnE=; b=j/9A9njRoM6Eud8EQzHvQgt0pjCgYQJTqUeaagfnAorQSkSUrElkjddV45EbKmvXmhKDtemaK82iAyYLrdBhZ8fC0VDh6XLfxkSp1A8SXnVfTDRlyGsMvt4jTczeU8xOY6FXQzbc/WHmm4OxHUvdgTI4PY8chg1/+93m1JLO4QA= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by PH8PR12MB7183.namprd12.prod.outlook.com (2603:10b6:510:228::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.35; Fri, 14 Apr 2023 14:13:45 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::30f:bd83:40dd:8f1]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::30f:bd83:40dd:8f1%3]) with mapi id 15.20.6298.030; Fri, 14 Apr 2023 14:13:45 +0000 From: "Chang, Abner" To: Minh Nguyen , "devel@edk2.groups.io" CC: "patches@amperecomputing.com" , "nicklew@nvidia.com" , "igork@ami.com" , "nhi@os.amperecomputing.com" , "tinhnguyen@os.amperecomputing.com" , Vu Nguyen Subject: Re: [PATCH 5/5] RedfishPkg: Fix compile issue on Linux Thread-Topic: [PATCH 5/5] RedfishPkg: Fix compile issue on Linux Thread-Index: AQHZbqnxdyw9M4l8/0aLSZzqt4iOQ68q2S0g Date: Fri, 14 Apr 2023 14:13:45 +0000 Message-ID: References: <20230414081903.7892-1-minhnguyen@os.amperecomputing.com> <20230414081903.7892-6-minhnguyen@os.amperecomputing.com> In-Reply-To: <20230414081903.7892-6-minhnguyen@os.amperecomputing.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-04-14T14:13:43Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=c873625a-52a7-4cd7-b33c-b8a118fc0561; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|PH8PR12MB7183:EE_ x-ms-office365-filtering-correlation-id: 28a06cd4-474a-441f-dc1c-08db3cf27580 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 06YFXWKXV6NrGFJef137wzxJUqX/7kOx/5JewK25Ix7Ed9fnqarshpTdOvvQYpv85gTc7iCnWRZsY5yDGSccs9B72bLXrgH2nGGM0pQUHB0p/CTb0VDW6HPH/2fCtfg5G4ddpa9ZBRrP0SWkkc+H0e+aQf066bx8XUTPaMu9vVsCNVgSMiGinql7T/nr6YF88C9YMLkgFOJGcCGiMhsYblJ4CqTuasV5JNimk7Dpt9oSZwMnJ+rrledUBiQj9hiwzGPaHKwc8vJTWZEK5LbeumNjqFZ0VR1et+LKuIBBtCnjAN1sAj50/U7pCxp5WpFGOShZGSAG7dqwV9zfddIUDAgQKdlj0nMDLqR/gE8ibkGy2JNDHbtMhcvgY1kHpKBAqXF5dt95qXMkpBweqoZJ2+pKqDlNkmd3xM100GFa2rVpGI7BT8ZKX98UliW4GAAK6+0KCALa4JUvNRHXbdtgCQ5wN/YfJHQdFjXo8hiAWVo157ZjKHgxUeOHqy/8HDdeT8dW9stzYbMajZsu2lifqiWYYBNPgglTtSfs/nS4hWPaVVwNgvvvxJ00F4NoLVGzAqp9YhpMWJaBHwtRv58mMNlEUEr5YJ0PL03LHFJD7x2qIYn250AJDPpS6jXL3PNH x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(366004)(346002)(376002)(39860400002)(451199021)(71200400001)(7696005)(478600001)(6506007)(26005)(186003)(316002)(53546011)(110136005)(9686003)(2906002)(5660300002)(64756008)(66946007)(54906003)(76116006)(66476007)(66446008)(66556008)(8936002)(4326008)(41300700001)(8676002)(52536014)(55016003)(122000001)(38100700002)(83380400001)(86362001)(38070700005)(33656002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bEcMe6GgON+IKb+BLW1ZvdPXbOnHdnpTVpnY3YqondSGNGm7gVDEqh2QS8Wk?= =?us-ascii?Q?6bCFyQUWWtHPWhwwt05RNCaGm9xqYDJccycHiZJwDrdCRjHkdv6jR97SKurL?= =?us-ascii?Q?OOmvpjv1FdA5eYv74ug71+kd01quTXEM2eg8ddyAo3SI6VDttP/O8NTg9ciN?= =?us-ascii?Q?cm3jpn+GEJZNowv6Yrlr6tQQJ9ZaiN7BPGhG4Ol75K4vJwqtLOOgDK8IJRu9?= =?us-ascii?Q?qBB9IMWL0+qW34QlIlk7AeogbVajjLeSgD1tj/ty253EnWU6HlHZ28pyDcyU?= =?us-ascii?Q?FewDnvt64qJamkqnuMhBdMkLRgp+urG6URDZe7GhDEQj5NlUeMDSfi7nR3wa?= =?us-ascii?Q?xclkkddOuTf5Rp0wk1/l9QoZUefSVa7v0jEhIBslyBJgfC1GGUGVPON8g41k?= =?us-ascii?Q?byGa1o1S4jNJlp+MIswCj1gsD3X8hBBnsXjSEHTPEqSCP8Isqy2T1FMVD1C9?= =?us-ascii?Q?1jr9H4zVmJ1yfhhluJY5/vOHm+KboFzyj8fukIYVh+l2mDRd1eUSUGNmBEDq?= =?us-ascii?Q?HCKJHgCtXITSpkQz/IcALpyVdaHacPPVLDhT/yRpVJRH3kf3FMeJ6geOMbty?= =?us-ascii?Q?VvNjRUbtLLJweuDQm69QKKBsRwx7jVfI5rcJ2jrcXVQWwTnpS6ZxEzhgya91?= =?us-ascii?Q?z+0zsYmUJihUKhqTVxl86zdVk9DKyTqMal8E35Vc0Swbakb3u2JOFGhxMTVB?= =?us-ascii?Q?LW5bI6hEhRe75Y3HS+M7Oo2wJC3LQkG0eSlcJugfVJeaqOmW6/T2ZXu93ET8?= =?us-ascii?Q?U+rPRIclJm1mN+OR3xlSz+jh6HWsEf4D7kqev8F7/kSWQ6nSOBihJXtLhSkO?= =?us-ascii?Q?SgoPj1js3qA4KdYCoQkWisrbB4R2nkbJMdBDW9V7ogia5Dw/FKJfBVW9wJv7?= =?us-ascii?Q?jmpLu6qZtbgLmES9hrbxc07H+FzcOw0XFJEIRz/Wbq1XzwVyIFJREuTWi+k2?= =?us-ascii?Q?4Olo3MjUzAS2KCW5iLKWA8zFo8nW9hCKzF2MeraG/PkyQPyccVp0wVfbobcU?= =?us-ascii?Q?6mWuDjOwYoRPdzOdO79mFffMvH/tsIL2F+VHL7PlJ9aaXpVaEuYg1Fl6K5GQ?= =?us-ascii?Q?9sGRfez1FiDzujcQKndZ1KG+J2TkVnCjpd5InfMf0AGQruJbt6tit7EG6N/H?= =?us-ascii?Q?YOd2qeO8AO85+Z+z7p8ZJgjKV7lWz3bC8JaC/3qnMUO32rXw6Ck5FukVAFjL?= =?us-ascii?Q?7Kbo1wb608eB03IlnqFew4ChdCK2zGZ+jxn1rOu6rQdXAzsSb2JnRTZ/cwXq?= =?us-ascii?Q?mpLyRHzk+ekigpbrRyzCGd1LW1j++ubIsfVeKEqN023tzjMUeoBupW5jWzbw?= =?us-ascii?Q?Sf6y6FAYHrJXM/EwAeJBKPM4LESxmIgZyWdi6xSh93eVlAGXOS7T5s0Uk61G?= =?us-ascii?Q?CcSXvXi9UQTD9PoCAdg68YbnjL6eJHbqGlMqRjqOSuFyNT+KqR43ps2MfA5D?= =?us-ascii?Q?qWX3V1NjR/e0xenH6DuKqZJIuarOtD4OELSQIXcAhpjnfB0vNmDq+fvs9mNj?= =?us-ascii?Q?3/MAiVyKNraWgyHWMAflxOf9PNK45Xs4QX6lGx3dXSHO5WGZ0V8gWPn/ZLL8?= =?us-ascii?Q?3VsrA3CBZWNpGO8FHEQ=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28a06cd4-474a-441f-dc1c-08db3cf27580 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2023 14:13:45.3722 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pco15y8RVk3KmuPBDBF8dA6FNIl3C+K0jYOqkyszJE3k2RpjxwYgYzL6CVnch8b3l0a0JrOpShqVgcd8ZiFFFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7183 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Minh Nguyen > Sent: Friday, April 14, 2023 4:19 PM > To: devel@edk2.groups.io > Cc: patches@amperecomputing.com; Chang, Abner > ; nicklew@nvidia.com; igork@ami.com; > nhi@os.amperecomputing.com; tinhnguyen@os.amperecomputing.com; Vu > Nguyen ; Minh Nguyen > > Subject: [PATCH 5/5] RedfishPkg: Fix compile issue on Linux >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > From: Vu Nguyen >=20 > It requires a fixed size array to store the content of device path PCD. > Add the array size to solve this issue. >=20 > Signed-off-by: Minh Nguyen > --- > RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h > b/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h > index 91b1198297c2..57fc199f61f2 100644 > --- a/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h > +++ b/RedfishPkg/Include/Pcd/RestExServiceDevicePath.h > @@ -4,6 +4,7 @@ >=20 > Copyright (c) 2019, Intel Corporation. All rights reserved.
> (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -14,6 +15,8 @@ >=20 > #include >=20 > +#define MAX_DEVICE_PATH_NODE 40 > + > typedef enum { > DEVICE_PATH_MATCH_MAC_NODE =3D 1, > DEVICE_PATH_MATCH_PCI_NODE =3D 2, > @@ -32,7 +35,7 @@ typedef struct { > // > 0x03,0x0b,0x25,0x00,0x00,0x50,0x56,0xc0,0x00,0x02,0x00,0x00,0x00,0x00,0x0 > 0,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0 > x00,0x00,0x00,0x00,0x00,0x00,0x00,0x01, > // 0x7f,0xff,0x04,0x00} > // > - EFI_DEVICE_PATH_PROTOCOL DevicePath[]; > + EFI_DEVICE_PATH_PROTOCOL DevicePath[MAX_DEVICE_PATH_NODE]; > } REST_EX_SERVICE_DEVICE_PATH_DATA; >=20 > #endif > -- > 2.39.0