From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.65]) by mx.groups.io with SMTP id smtpd.web10.3192.1686036006519003767 for ; Tue, 06 Jun 2023 00:20:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=ly1fIM3W; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.223.65, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YOpLsgYLO+8MHitpP3PETyip7FAovd+oFPUNgdwIRYiY6o34Psd2wn8sEVqX4FTnxc+vejJZWJUTBMijTKGY0DU84+MCmqtk8AVu80yHZCPCmwboqzf7U7Sxr52F73H/7vVZq/eyJmGflljYpmn5z/mtkAXcqYHbQ2EjpEu1450RLe7FQ89JiHCRg0bpSnmO5oxm0WEWX3ct3GIT8FBM+obGzexAriaMkc7hKlUb9S2cPzsh3SPQsFonNM1uBv3oLWjh1PVQhqjLGawAbeilrJ27ysfQhxHlH5GadaHO17CD5quyu/fNjibOV9z+z/3oWlCltGWUfET7cMrDIhU9yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UXUA/OmC2bL4kXxvKww6UuZ5lRy7YFXit9AyoiDkuBg=; b=Lu8efZYg1vRiLQ2RU7TKB+lnieW+dVhHy0reIgfkFHItNGtMXMtib3BbAY4ElQVPN/PyKwLFrQV3JTwcclcr6ckZtx1ULvDvJVisLQnyjPhXrFh5N4TjnOJQWjlSWFquyLEJPUsSWhglZBHNj+zxBSCXtWitfMb6bIGmp9nvCRrDbQHpenZwI0M4sTav2A5i1YS0OG6qH5r1f/Kv0nc57n7M/DKe4lynoKDXPPDLCFepTVZ5kbQscXgdSNE2xUt5wkdugZHA59/jAkOUQHlvZH+kiBPZxHNyVSjTedsuZyXbrQjLVLiwjLzBaxXFzG1Jr/4kP/RjaG8M35FkChMKJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UXUA/OmC2bL4kXxvKww6UuZ5lRy7YFXit9AyoiDkuBg=; b=ly1fIM3Wrp71F0a+jVNx8vTfbKidB+XHYD6o+qDIGkydpcysblshcyhnpGoJdIO8Rc2BWxzT5Ay3qXlgukS5+GYyzKcD7UkgQUkwe5iFcOITjrd7LEv9ArgQUKYg61odcxvFbd8/lcL3QwThwhxo1gyW+NtWojiPEVugptGB4qI= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM4PR12MB5151.namprd12.prod.outlook.com (2603:10b6:5:392::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Tue, 6 Jun 2023 07:20:03 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040%6]) with mapi id 15.20.6455.030; Tue, 6 Jun 2023 07:20:03 +0000 From: "Chang, Abner" To: "Wu, Hao A" , Andrew Fish , Leif Lindholm , "Kinney, Michael D" , "Gao, Liming" , "devel@edk2.groups.io" , "Hsueh, Hong-Chih (Neo)" , "He, Jiangang" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Index: AQHZjZkboPIVCDc180mWVLPxgzEKQq9zxQmAgAC9sgCAAmLCgIAAvrYAgAAepLCAAB1jgIAD0cqAgAFu9wCAAFHMMA== Date: Tue, 6 Jun 2023 07:20:03 +0000 Message-ID: References: <28f72c221f0c7f84e6d992b434565107cdb718b4.1684858126.git.Hong-Chih.Hsueh@amd.com> In-Reply-To: Accept-Language: en-US, zh-CN X-Mentions: michael.d.kinney@intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-06-02T18:11:56.552Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM4PR12MB5151:EE_ x-ms-office365-filtering-correlation-id: b0381f69-b012-426a-c141-08db665e7273 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: T5dOsycUAppOe/vv51H0w4gwA+xR4hJiFBbi9r9h6vJqssA9z+lWYR25si7lWEvVpzYDdYTWB4suCPz1mR/KUdhzmMgvntzXJy3S77FK8q5tyVDOXL7RJVeiKD/FrOSEFcaEcalRLY8DIPkVtNaTK06KqswErkrTQll0G+lGgcelIVJAoQIRmqR2dCTAwxJ4+b9tOYhx2jlYbYP4FMfvP367BtytiggydvELWMm5U05LIFk7gbwEpRs800cfJoivvgtbS/ifcB9R8WcrIL8Mz6JMHTjzgtw5YcswGTSZNflWGLMXkQTJ2VbcBAMSvaLzm3Dfxi5tmb6ZLddtEB46wCipRle1vU6tS4tyIDRWy2ZJs6q9RWifimFPaJ+vAtdq4WCvi5YULx+fkYoTOhLn61WF9XZTg2ko+mDwim7sPNl6g5srCbZgglyt9Z/H9B+enQwv+FS83CyoZjMjjS9yg1ArwHFpdDZB8kPDHWyLMN1IdhYWSOBZY1th8xwC6N8NjziGLuPlOePr/c4FWE4lBlvnS0paclDjuJRjFhrOYsEEnSypH6qmiudw3N9XYoO5AED4sE38uTmcBZ12uAIUB6cvM8efdA2hPXkJhE2r6+NU6192KUxAXEOQINtEuBUczdlcdiaq1IYo++s0bdi2aw2finmjriY+L85qnwxAaQs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(366004)(396003)(136003)(346002)(376002)(451199021)(53546011)(9686003)(26005)(66446008)(66946007)(6506007)(921005)(316002)(83380400001)(6636002)(66556008)(122000001)(66476007)(76116006)(64756008)(7696005)(966005)(186003)(38070700005)(71200400001)(33656002)(478600001)(66899021)(110136005)(76236004)(2906002)(5660300002)(8936002)(8676002)(55016003)(86362001)(52536014)(41300700001)(166002)(38100700002)(1406899024);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7739NT3HT2FaTRu2++8UDt8Zussw4hZC/k7NNeMg2vYn3mpy4+tJyisJf/ot?= =?us-ascii?Q?v5JTjXjPgTFn5rrMPs42sVyD0b9AIg4pKenDj5EsqylnIHA6O7s1bu3KE/ml?= =?us-ascii?Q?x6keJmU3wHriqncf7vaYssKLWJ6uz3XBZwLg8yBi03w4wxLLDUrMn1Q0BrLk?= =?us-ascii?Q?0x/4s3GgHd+WPjEywIp4xx3knz7FviI20meQTcOAifLn5AjuJpmXPrHtnnX4?= =?us-ascii?Q?IFZMzNklJkVqhuUt3Clry3cGqYt/vmr3CZrybv2eAvqnZRyvY7u1CUH0vq4e?= =?us-ascii?Q?C3p/T35PbbLblcqxLvTj2PMh75jCEJ2KxOQnGB7snNJ1E3W6/JllbgEQMv+h?= =?us-ascii?Q?R1yRj6jxnIYf9+v8cy0mqyn2oNWkq9zeTo8QFlr6B5rooqTb3zNSwwgHpFme?= =?us-ascii?Q?VJU+zVMm0vvkvTho6XMK5WDJuqS/s6G+pUXpk74Jj9bwzvRWIXqm15CfS0XB?= =?us-ascii?Q?e7LkxuRzdfQxtcQGO00R2esfxSFOokPPwyBJU9ATfeTiw797MHCYWemwRCko?= =?us-ascii?Q?Q5axKlWKycO+qZPSqW5FfS9+JumHR5qjx84UjLMIYoONQTuY4axal43f/YPz?= =?us-ascii?Q?ub0wFJpPccKr5nuy4qMZg8s30CzVjEoN6LJCwimFIzyFxkeTGD2/grjdHJwg?= =?us-ascii?Q?4L6mVLWWaMgVVnDuT8AKCKc4nJ6+qDv1O37dQJ3KK/EX55Maj7iPC6azwEWM?= =?us-ascii?Q?L8xLWgdx4UcYohMjcrecBxRtCnXxCvjf0etR+M9NXgFwh4bwRS8S5bbLFrVT?= =?us-ascii?Q?BLscneH1zCo42RovG8kUax8skq0kzp4q2uE1ujlJ+8NiPzViPPeE9yEWbFDN?= =?us-ascii?Q?U0EfI62PLH7XQOY7yVX6KqsD+XWJK6LcNj2yB0RTP0eiq4LUDqMGdE96WrGr?= =?us-ascii?Q?jkT9q/0+SWsHdiMSfSqrJjrSnwR5Vyb8lQMhdeOkLBAjudlGw1vfIDwYiiVV?= =?us-ascii?Q?EiNA9+7mbx6OA5L2CFQ77kJu6ivcMyqYwIGgxtUaCXzsv9/s/rgXOEohG3P9?= =?us-ascii?Q?TZ5y0tHwv+j7HpJ4urzG2MOPrMd9p2DpgNL4Fu4994s8YZz89Bk0YYZkdiBo?= =?us-ascii?Q?sETiz635PzkpHzYM9856z7XN0487Hy2QMsdHOVbNl43YVTwbSKpQYU/I2Bei?= =?us-ascii?Q?v0vnL7wLt3DAPbsKNrH9j4dWLwi4RA3+IgBxyWTuisCPwWYQ1si/Ak6WfEhs?= =?us-ascii?Q?pdKzZ6lpwFmsIEnGek3V8/xUagLgc6+72T2dIp+Saa7daT+arYmhpPo3GRuB?= =?us-ascii?Q?kxN5x07LhAleFXdN1cPHcJqNZA7/uZHZNXXZniK6rqKbX9FFqmCCVElmF46N?= =?us-ascii?Q?krshONQN6ENaQQP7xCUK7HEhkQ1Lsv9Vn6ayz0hYg7Ry6fn7tqs8PY84Oat7?= =?us-ascii?Q?+UkngqUhWq1T7SlLgRzwPK93MhJleQXXEWw8Xasw7OMHWcAPxtP3DsqKZnmK?= =?us-ascii?Q?WDBe9/9h36QwyxwiK17riJEHnfJR1zIyhNjH8jFfwpDLignInhO9Bf0OLOna?= =?us-ascii?Q?h8LTF5Dn31LPu340tUlTSGaoEMdf5G9jx0BG1U+Wi6k8ntOoag2KJ+ptEODJ?= =?us-ascii?Q?DnY6pxJRm/1dD/V0L30=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0381f69-b012-426a-c141-08db665e7273 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2023 07:20:03.5904 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0eg83hmmWENFAQtObEMkXCrZqYsEynqF7huiv1RrAhW9z+dVaXPaTaglvmUzQbZu4LYnabp7A2156dn0U0Lteg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5151 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR12MB396693A0BE9A2688B1CF8FF8EA52AMN2PR12MB3966namp_" --_000_MN2PR12MB396693A0BE9A2688B1CF8FF8EA52AMN2PR12MB3966namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] I can't retrigger the CI to try it. @Kinney, Michael D, could you please help to retrigger it? Thanks Abner From: Wu, Hao A Sent: Tuesday, June 6, 2023 10:25 AM To: Andrew Fish ; Leif Lindholm ; Kinney, Michael D ; Gao, Liming ; devel@edk2.groups.io; Hsueh, Hong-Chih (Neo) ; Chang, Abner ; He, Jiangang Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Add Stewards. I cannot merge PR https://github.com/tianocore/edk2/pull/4478 due to consta= nt cancelled CI tests. Could someone help with the situation or help to merge the change? Thanks i= n advance. Best Regards, Hao Wu From: devel@edk2.groups.io > On Behalf Of Wu, Hao A Sent: Monday, June 5, 2023 12:32 PM To: Hsueh, Hong-Chih (Neo) >; Chang, Abner >; = He, Jiangang >; devel@edk2.= groups.io Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM Thanks all, Tried to merge the patch via PR - https://github.com/tianocore/edk2/pull/44= 78, but failed 3 times (all due to some canceled CI tests). Will re-try tomorrow. Best Regards, Hao Wu From: Hsueh, Hong-Chih (Neo) > Sent: Saturday, June 3, 2023 2:12 AM To: Chang, Abner >; Wu, Hao= A >; He, Jiangang >; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Hi Abner, Thank you for your feedback. I updated the commit and re-create the PR as b= elow: https://github.com/tianocore/edk2/pull/4471 Regards, Neo ________________________________ From: Chang, Abner > Sent: Friday, June 2, 2023 11:31 AM To: Hsueh, Hong-Chih (Neo) >; Wu, Hao A >; He, J= iangang >; devel@edk2.group= s.io > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Hi Leo, Please add Hao's RB in the commit message below your signed-off-by, thus we= know this patch has been reviewed. I also suggest to update your commit subject to "MdeModulePkg/Bus: Fix port= multiplier port in AhciPei PEIM". Please resend the PR with above updates, then Hao will add "Push" label to = this PR once your change passed CI. Thanks Abner From: Hsueh, Hong-Chih (Neo) > Sent: Friday, June 2, 2023 10:37 PM To: Wu, Hao A >; He, Jiangang= >; devel@edk2.groups.io Cc: Chang, Abner > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Hi Hao, Thank you for your review. I already created a pull request for this commit, may I know how to proceed= to merge it into master? https://github.com/tianocore/edk2/pull/4424 Regards, Neo ________________________________ From: Wu, Hao A > Sent: Thursday, June 1, 2023 10:14 PM To: He, Jiangang >; devel@e= dk2.groups.io >; Hsueh, Hong-Chih (Neo) > Cc: Chang, Abner > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Thanks. Reviewed-by: Hao A Wu > Best Regards, Hao Wu > -----Original Message----- > From: He, Jiangang > > Sent: Wednesday, May 31, 2023 10:49 PM > To: Wu, Hao A >; devel@edk2= .groups.io; Hsueh, Hong- > Chih (Neo) > > Cc: Chang, Abner > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port = in > AhciPei PEIM > > [AMD Official Use Only - General] > > We did crisis recovery and Opal HD password unlock from S3 resume from > SATA HD test on two different version of AHCI host controllers. > > Thanks, > Jiangang > -----Original Message----- > From: Wu, Hao A > > Sent: Tuesday, May 30, 2023 10:30 PM > To: devel@edk2.groups.io; Hsueh, Hong-Chih (= Neo) Chih.Hsueh@amd.com> > Cc: He, Jiangang >; Chang= , Abner > > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port = in > AhciPei PEIM > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Thanks, the code changes look good to me. > May I know what tests have been performed for the patch? > > Best Regards, > Hao Wu > > > -----Original Message----- > > From: devel@edk2.groups.io > On Behalf Of Neo > > Hsueh via groups.io > > Sent: Wednesday, May 24, 2023 1:07 AM > > To: devel@edk2.groups.io > > Cc: jiangang.he@amd.com; abner.chang@amd.co= m; Neo Hsueh > Chih.Hsueh@amd.com> > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port > > in AhciPei PEIM > > > > If there is no port multiplier, PortMultiplierPort should be converted > > to 0 to follow AHCI spec. > > The same logic already applied in AtaAtapiPassThruDxe driver. > > > > Signed-off-by: Neo Hsueh > > > --- > > MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > index cd55272c96..7bd04661d0 100644 > > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > @@ -3,6 +3,7 @@ > > mode at PEI phase. > > > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > > + reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -92,6 +93,15 @@ AhciPassThruExecute ( { > > EFI_STATUS Status; > > > > + if (PortMultiplierPort =3D=3D 0xFFFF) { > > + // > > + // If there is no port multiplier, PortMultiplierPort will be 0xFF= FF > > + // according to UEFI spec. Here, we convert its value to 0 to foll= ow > > + // AHCI spec. > > + // > > + PortMultiplierPort =3D 0; > > + } > > + > > switch (Packet->Protocol) { > > case EFI_ATA_PASS_THRU_PROTOCOL_ATA_NON_DATA: > > Status =3D AhciNonDataTransfer ( > > -- > > 2.40.0.windows.1 > > > > > > > > > > --_000_MN2PR12MB396693A0BE9A2688B1CF8FF8EA52AMN2PR12MB3966namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - General]


I can’t retrigger the CI to try it. @Kinney, Michael D, could you please help to retrigger it?<= o:p>

 

Thanks

Abner

 

From: Wu, Hao A <hao.a.wu@intel.com> Sent: Tuesday, June 6, 2023 10:25 AM
To: Andrew Fish <afish@apple.com>; Leif Lindholm <quic_llin= dhol@quicinc.com>; Kinney, Michael D <michael.d.kinney@intel.com>;= Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; Hsueh,= Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; Chang, Abner <Abner.Chang@amd.com>; He, Jiangang <Jiangang.He@amd.com>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use Only - General]<= /o:p>

 

Caution: This message originated from an External Source. Use proper caution= when opening attachments, clicking links, or responding.

 

Add Stewards.

 

I cannot merge PR https://github.com/tianocore/edk2/pull/4478 due to constant cancelled C= I tests.

Could someone help with the situation or help to mer= ge the change? Thanks in advance.

 

Best Regards,

Hao Wu

 

From: devel@edk2.groups.io <devel= @edk2.groups.io> On Behalf Of Wu, Hao A
Sent: Monday, June 5, 2023 12:32 PM
To: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; Chang, Abner <Abner.Chang@amd.com>; He, Jiangang <Jiangang.He@amd.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

Thanks all,

 

Tried to merge the patch via PR - https://github.com/tianocore/edk2/pull/4478, but failed 3 times (all du= e to some canceled CI tests).

Will re-try tomorrow.

 

Best Regards,

Hao Wu

 

From: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>
Sent: Saturday, June 3, 2023 2:12 AM
To: Chang, Abner <Abner.Ch= ang@amd.com>; Wu, Hao A <ha= o.a.wu@intel.com>; He, Jiangang <Jiangang.He@amd.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use Only - General]<= /o:p>

 

Hi Abne= r,

&n= bsp;

Thank y= ou for your feedback. I updated the commit and re-create the PR as below:

&n= bsp;

Regards= ,

Neo

&n= bsp;

From: Chang, Abner <Abner.Chang@amd.com>
Sent: Friday, June 2, 2023 11:31 AM
To: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>; Wu, Hao A <hao.a.wu@intel.com>; He, Jiangang <Jiangang.He@amd.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use Only - General]<= /o:p>

 

Hi Leo,

Please add Hao’s RB in the commit message bel= ow your signed-off-by, thus we know this patch has been reviewed.

I also suggest to update your commit subject to = 220;MdeModulePkg/Bus: Fix port multiplier port in AhciPei PEIM”= ;.

 

Please resend the PR with above updates, then Hao w= ill add “Push” label to this PR once your change passed CI.

 

Thanks

Abner

 

 

 

From: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hsueh@amd.com>
Sent: Friday, June 2, 2023 10:37 PM
To: Wu, Hao A <hao.a.wu@int= el.com>; He, Jiangang <Jia= ngang.He@amd.com>; devel@edk2.groups.io
Cc: Chang, Abner <Abner.Ch= ang@amd.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use Only - General]

 

Hi Hao= ,

 =

Thank = you for your review.

 =

I alre= ady created a pull request for this commit, may I know how to proceed to me= rge it into master?

 =

 =

 =

Regard= s,

Neo

From: Wu, Hao A <hao.a.wu@intel.com>
Sent: Thursday, June 1, 2023 10:14 PM
To: He, Jiangang <Jiangang= .He@amd.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Hsueh, Hong= -Chih (Neo) <Hong-Chih.Hsueh@= amd.com>
Cc: Chang, Abner <Abner.Ch= ang@amd.com>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use On= ly - General]

Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding.


Thanks.
Reviewed-by: Hao A Wu <hao.a.wu@in= tel.com>

Best Regards,
Hao Wu

> -----Original Message-----
> From: He, Jiangang <Jiangang= .He@amd.com>
> Sent: Wednesday, May 31, 2023 10:49 PM
> To: Wu, Hao A <hao.a.wu@intel= .com>; devel@edk2.groups.io; Hsueh, Hong-
> Chih (Neo) <Hong-Chih.Hs= ueh@amd.com>
> Cc: Chang, Abner <Abner.Chan= g@amd.com>
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier po= rt in
> AhciPei PEIM
>
> [AMD Official Use Only - General]
>
> We did crisis recovery and Opal HD password unlock from S3 resume from=
> SATA HD test on two different version of AHCI host controllers.
>
> Thanks,
> Jiangang
> -----Original Message-----
> From: Wu, Hao A <hao.a.wu@int= el.com>
> Sent: Tuesday, May 30, 2023 10:30 PM
> To: devel@edk2.groups.io; = Hsueh, Hong-Chih (Neo) <Hong-
> Chih.Hsueh@amd.com>
> Cc: He, Jiangang <Jiangang.H= e@amd.com>; Chang, Abner
> <Abner.Chang@amd.com>=
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier po= rt in
> AhciPei PEIM
>
> Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding.
>
>
> Thanks, the code changes look good to me.
> May I know what tests have been performed for the patch?
>
> Best Regards,
> Hao Wu
>
> > -----Original Message-----
> > From: devel@edk2.groups.i= o <devel@edk2.groups.io&= gt; On Behalf Of Neo
> > Hsueh via groups.io
> > Sent: Wednesday, May 24, 2023 1:07 AM
> > To: devel@edk2.groups.io<= /a>
> > Cc: jiangang.he@amd.com; abner.chang@amd.com; Neo Hsueh <Hong-
> > Chih.Hsueh@amd.com><= br> > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier p= ort
> > in AhciPei PEIM
> >
> > If there is no port multiplier, PortMultiplierPort should be conv= erted
> > to 0 to follow AHCI spec.
> > The same logic already applied in AtaAtapiPassThruDxe driver.
> >
> > Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com>
> > ---
> >  MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 +++++++= +++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > index cd55272c96..7bd04661d0 100644
> > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > @@ -3,6 +3,7 @@
> >    mode at PEI phase.
> >
> >    Copyright (c) 2019, Intel Corporation. All righ= ts reserved.<BR>
> > +  Copyright (C) 2023 Advanced Micro Devices, Inc. All right= s
> > + reserved.<BR>
> >
> >    SPDX-License-Identifier: BSD-2-Clause-Patent > >
> > @@ -92,6 +93,15 @@ AhciPassThruExecute (  {
> >    EFI_STATUS  Status;
> >
> > +  if (PortMultiplierPort =3D=3D 0xFFFF) {
> > +    //
> > +    // If there is no port multiplier, PortMultip= lierPort will be 0xFFFF
> > +    // according to UEFI spec. Here, we convert i= ts value to 0 to follow
> > +    // AHCI spec.
> > +    //
> > +    PortMultiplierPort =3D 0;
> > +  }
> > +
> >    switch (Packet->Protocol) {
> >      case EFI_ATA_PASS_THRU_PROTOCOL_ATA= _NON_DATA:
> >        Status =3D AhciNonDataT= ransfer (
> > --
> > 2.40.0.windows.1
> >
> >
> >
> >
> >

--_000_MN2PR12MB396693A0BE9A2688B1CF8FF8EA52AMN2PR12MB3966namp_--