From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.54]) by mx.groups.io with SMTP id smtpd.web10.8594.1688524716569540597 for ; Tue, 04 Jul 2023 19:38:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=ChhXToCX; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.220.54, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JbTF5ATukVYWTi/TX0X67eitvUzhAoeH5NJAad/EfubfnZz7xf9mCS0JabaDCTDKPRpbk0+29oCu7UcmMXPMHchbDxF+2SeBIAQo99o7UTJwWt+IyRQCwXIhGe6ENYc+1LD59UCWoFkxKXXF1L31eC5jrkfUDpede+JOodMJ0mDf+dwgL1Obklctg+CUy5mZRN50s5rTqc1KRmlRazEQ8vi1HALXMWeE7jkdxYq9v2Ktlk+Ku0UWwi2P8kUYuZUPxJ03DIn9/6fC66hJCvmQcWZRPgYpqeJbBNobqzLwsdv09K6Rd3nsdpoQkxtpTrYAlyUChnTKu9iwcOESHAS+lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DB+AsvNjnQIw4B+09hSFeomevHVfZS34LXFZOQ4SdY8=; b=mGzg31aU1LASLyr1mMCxGZK94+zZM2qWJLLlc8m1REl6NVVACfw3t0BBvi5j9eoiRXkXTezMMXh65cPetTke80bhb+As1TZ9ZTepR4h9JlNv93gq/Tu2cPkMHRnVKCht6UB7HDhmwNU52XpcaSgYcPwGVP0Tn0ZDqS5VSeh5LTjVI//r1iP/F91NpEK7czrAWGKyLMhcvFHhgc4kUtjzt6U68jjeFUx8auqSiA3uLt3XJFZeBfgDsk8XhFv8No3RA74HXWGr7se8BhCNsTPnSx7q+wvX7xh5kOSOGho+tRreb2K4TQEbBL25uWh9xUGWQU50UOf4AC4nvyUf1MIwZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DB+AsvNjnQIw4B+09hSFeomevHVfZS34LXFZOQ4SdY8=; b=ChhXToCXLr8A+39yC0FoEBaI8xJTBY8vv/44pBtxG+x6QWY/hAznsO/1GIWnr6d34aCaQ9PuNhzTcMQm47iFTDl8OJCfD/uwfCmFlbb9BPFL3h+y6FIqkBhZzxpGF6csMmCaV/5FFWnVwSOI77bH3ZTpxFn929eWG65ErnM4JNQ= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SN7PR12MB8817.namprd12.prod.outlook.com (2603:10b6:806:347::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Wed, 5 Jul 2023 02:38:34 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040%6]) with mapi id 15.20.6544.024; Wed, 5 Jul 2023 02:38:34 +0000 From: "Chang, Abner" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__ Thread-Topic: [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__ Thread-Index: AQHZrfaqGCUkuZOYwk+SwJCW79eNn6+qd6DA Date: Wed, 5 Jul 2023 02:38:34 +0000 Message-ID: References: <20230703213748.63317-1-mike.maslenkin@gmail.com> <20230703213748.63317-2-mike.maslenkin@gmail.com> In-Reply-To: <20230703213748.63317-2-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=b340411d-8762-4dad-8a83-978de03ca33d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-07-05T02:38:27Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SN7PR12MB8817:EE_ x-ms-office365-filtering-correlation-id: 0f7186ca-3cd6-4097-1bca-08db7d00ed75 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VNB80I6HRwsM5KspaRAeJiqsExRn99AKXfnNrtleQL2sxJhaTiS4hb2vlqFUX30dcaOG416J4vXrvA2Sjr2GUs28dQPlvfnFYEfm0ovlQWrspeekReyijFQik3yqg2MqTXUw7jaAZ56wOnEinQ6izPNVk8ly8q3btI2z+mxyxlIlaWbFCmgA6NsSSblVfGpmCD8y7rb+nMPrhYGyIoaJ55bOJy6JF1Z5dic3hbcLImWjx5a9BlgCo7T5MKKtiXdxsmft6M4w7ASurzxzRtQeAtWQfsXTfQSSc2ubF5SvqFi5G1lEb0ZVAjdzmZRUEcu9sWM2/vEh/uWkCFg30wWMbHBaDNASSsQ43zl6UXPIgEqL3gHceOhOTcl6QJ4j54rZ9mFlxVcg4NARDiKWV+FBZa8O0PTudCf1Ka3Hl9CLk98NxGnnTM8+FZ5Frccb/A6LMaawJi9F6R6i+fUvzmdZFKo8USeVTr2ErAiwVRUdNgq1bGJWfLVhGPE9FURvyD89xkdTkKNNACDN1ICvSuFWnTMSPb8AeDYjyp/8xYnLoabiHB9nov6C+subNQ5lfDmc8SOQXciZ087lA5Gdc/qAVQ8WldC00RjaYl1+TRF9YnNzvORBt5DSkuoTjkohMUxL x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(136003)(366004)(396003)(376002)(346002)(39860400002)(451199021)(66556008)(76116006)(4326008)(66446008)(66946007)(316002)(478600001)(66476007)(33656002)(64756008)(8676002)(8936002)(52536014)(5660300002)(2906002)(86362001)(41300700001)(55016003)(9686003)(38070700005)(110136005)(54906003)(7696005)(38100700002)(53546011)(6506007)(186003)(26005)(122000001)(71200400001)(83380400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?a+7KDTr+gC6oAxvFc5LxvhWYXZOtvXGG4uW/aoTx+oaAon3YR+67UNGHfZYX?= =?us-ascii?Q?q1VYt3qD67hcuJc0PgggGWgcBB3vuEXtHb1PF/6lNpON5S8Dir551gWzkLyP?= =?us-ascii?Q?XClK+asc2rFXqZ79uQ2EumnhHjO0lLTSLz9DnkdiZH8d2whTCFIPY2U3+MQj?= =?us-ascii?Q?vrY9AW4fzmL3OduiJ42YKzxHABQ31vRkhptE2q00BQIX2p86gTDQwWEL/LaG?= =?us-ascii?Q?gptVSsV1Dzp2VE5BBj6DWBrqQFv40JX/AOq1JW1SNcJpoNVSjXQFc2KuaIkn?= =?us-ascii?Q?gSDRMBobPfZ/qT7S797P7dL5u57KaMB+A/qZnx7WwSZO+Ka5hUfpKWxHGrXb?= =?us-ascii?Q?r1EyU32S0FoOUy31GPrJdqA6GRw77N6oJnIJsX8xZEvucJu+RtgSS2JrbKW5?= =?us-ascii?Q?IQPqcVKs+Wl7k4hpiRkek/xEEEfPotbzW7cTYiPEKBW1JJC05i8VuT0fPJ4Y?= =?us-ascii?Q?Avjv1EKt56YYcJZ43kM+pfmSmapnu7QSSXA5/C/gaezz6k7S4NnOtAqOnS5p?= =?us-ascii?Q?OUV+SyHulXf3UyndURtoCNSmDSOcaFQ51DDp3xA5zH6XHsHEQrZ1QmK4ELSj?= =?us-ascii?Q?1RvRWMM2EU/6Ah1xW+aNDpge3x5n6nqOZEg3DszRossMtjyeVdf5U7OE2rLD?= =?us-ascii?Q?KikOlLVicrt27nx3pbyzoPlm2Wj3uhEy379c2l1nAtrMAhxLMU3/hi9bdRnG?= =?us-ascii?Q?BNh0QNnv1xOMuXuAKOrlzozlkuHSHzA5wbnFS4ZgHr4aBPu8izVmTT4HBTDZ?= =?us-ascii?Q?43tEN6bIPYQqHn5fWiFIfupqWwq3pWzZEmSHIG0rktjBlQVhS8djXE7kQdG9?= =?us-ascii?Q?7yXDSxjokDuK+usjjV8fF63x0LoBldAgRuJ4hq/s/2NJVnAogsxjLL31YfZ/?= =?us-ascii?Q?WeGsVdAKm1MIOM5JpDYanFHhGoqWnEqkCVai4PvBroegLKNiPGN68n1qvVsw?= =?us-ascii?Q?pcCkn1Ix4y0kXW85JnUFF83plQdbq8MiODILjAo4tsvmqqqx3ssYp56WzFKU?= =?us-ascii?Q?uGjyTs/uQE/kepfA72MfL0jR6pDz2D6x+O5JuAWKOnEioInzvoHVVYiEkJ6h?= =?us-ascii?Q?hytKC1ZrwN284yt2C2Gp82k0OEH5xqyqTWlfgYknyL6fTGZE9eri2iPu9wpc?= =?us-ascii?Q?IZBp4MF0oQEeFGHPYbxCn3tOiZs8jGbCSW3/IIda5c8KiAcv1Aar4qdApSlo?= =?us-ascii?Q?eYbu0MQXa6W6QRNeWomuyFKdQPkMVk4XFeYAlb8ctSNiRl9A2yL8eN08GTNe?= =?us-ascii?Q?5jZ1z02kCWfLQW9rw/22Gj7eoMevDao2QmvkVeuQ1zeE/s0zH8VaikN7d36f?= =?us-ascii?Q?iqeCrMZIhgZIQI1XOdhx0cPN37QyAxiEVjQopYxU4AorXusIuGEjxey6nwGg?= =?us-ascii?Q?X9Z78kv9R1eli6jTJtj6LLxkF0d5k0fsyVBl3iax1XytmX5j9sdvLCjGfplO?= =?us-ascii?Q?LZikg5b0ZWindkXHFkejcO+xt6AqO9242chfbH6ACTkEtp8hfCpz0gewLsE/?= =?us-ascii?Q?h1WTTNfxIHLmyGttv0HZNRn3NVRR9OMwadzmqvhl124fxrq3e39ooRUBbxvh?= =?us-ascii?Q?tIuBO9Tb1je95HqCE2c=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f7186ca-3cd6-4097-1bca-08db7d00ed75 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2023 02:38:34.0284 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: euWItzDJmuIocza0NoZBh+QnVz47A+51/ZqkVbw+AfFav87VJ/WNBeyxUrnKww7EXTBoOiyxtwNrObGo13iYOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8817 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Tuesday, July 4, 2023 5:38 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format us= ed > for output __func__ > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Signed-off-by: Mike Maslenkin > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > --- > .../ComputerSystemCollectionDxe/ComputerSystemCollectionDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.c > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.c > index 3ba2529c9cea..8f2054e1e161 100644 > --- > a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.c > +++ > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.c > @@ -44,7 +44,7 @@ HandleResource ( > // Check and see if this is target resource that we want to handle. > > // Some resource is handled by other provider so we have to make sure = this > first. > > // > > - DEBUG ((REDFISH_DEBUG_TRACE, "%s Identify for %s\n", __func__, Uri)); > > + DEBUG ((REDFISH_DEBUG_TRACE, "%a Identify for %s\n", __func__, Uri)); > > ConfigLang =3D RedfishGetConfigLanguage (Uri); > > if (ConfigLang =3D=3D NULL) { > > Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Pri= vate- > >InformationExchange); > > -- > 2.32.0 (Apple Git-132)