From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.64]) by mx.groups.io with SMTP id smtpd.web11.11344.1678675147898975888 for ; Sun, 12 Mar 2023 19:39:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=TW0gDlCH; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.237.64, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mLSssiP2KND03/TVjtBCzlfiLFFCBgrD5fEaw2btcbjOAfGzAcsGacVzlEuxxfaBsqoZKmA5oXQD2OtT19tyDATziADUWHEwAXpCE3hCMzxYnHxhiZ/1U4CdNKQnqd1ez9/oiFtxGBBgpv750IXMSTQKbV3n45mQI4WkH2edKoC769D2QWOWm6599tIpzhDD2N01WDJca22/pXUF808DELVycKDYpl0bz0PVMG4hdnVo9kbakX/etISQx2wNAQKeOFYHMVhH0UCWp2y83Ehpmm0KIHQttmTPySMXXl5Mhx5OsiSJno0bsPYq68iAgOvSZo/9NNmDkv/jeKmQrAyoUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l+yVqsIarLzaNlqlY8BDz43wUDJ9ezUNH75Ha1+pzCs=; b=nJNlcaZS6D1gJGS117W9bfLAydO46Bw2rz3hAioW6wNmSRsyJl8YM+jsaCNxWOf0fokyE6SrbvXPz/+BNRkF80U+QoRhsVA6pUq7ScVT4SjP5xWYtPIdOQlVijcdOQMfK0bmRgj7yGkXzJ+6BwpNop4+WWASa9dXuCatFTQBrrUpbJFygxaZQvEE2ZwQ55jLfVYzNSQh6UOwKAMwsnublIGuDuxKw/7P9u16Eu3uLLYClshQMctYmNMA3/N2UBgxKmid/oKp48qRd+0co8fI9ea+nGA8A6UstOj24fF/7kKmIUy6ezbpCHVWETOQU866wFS+whDgnIuRDJeD53/vtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l+yVqsIarLzaNlqlY8BDz43wUDJ9ezUNH75Ha1+pzCs=; b=TW0gDlCHOfk6Q/PDF2sJuduDmL0uIy38V4lxrsBvYgBOxa7o2qBARPjOWRG6wjtWMSD1q6BLA1K6c0HMVNEt2o64CGUsb9z9Ri+TlufLkKQIgST2orKKbl3dkcKxxi+wxSLRHohVzlMl1EZXG4mFNG/68FlXrsbR/qdGRzF3x4k= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by BL3PR12MB6545.namprd12.prod.outlook.com (2603:10b6:208:38c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24; Mon, 13 Mar 2023 02:39:04 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::8136:1f56:53e5:6fe]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::8136:1f56:53e5:6fe%3]) with mapi id 15.20.6178.024; Mon, 13 Mar 2023 02:39:04 +0000 From: "Chang, Abner" To: "devel@edk2.groups.io" , "Chang, Abner" CC: Michael D Kinney , Liming Gao , Zhiguang Liu , Nickle Wang , Igor Kulchytskyy , Isaac Oram , "Attar, AbdulLateef (Abdul Lateef)" Subject: Re: [edk2-devel] [PATCH V2] MdePkg/Include: Add IPMI KCS definitions Thread-Topic: [edk2-devel] [PATCH V2] MdePkg/Include: Add IPMI KCS definitions Thread-Index: AQHZUczjscNMUFqbOkC5zaLMEbLzjK7w9lgQgAcP4PA= Date: Mon, 13 Mar 2023 02:39:04 +0000 Message-ID: References: <174A78FC34F9F88C.23983@groups.io> <174A794AF245E853.23983@groups.io> In-Reply-To: <174A794AF245E853.23983@groups.io> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-03-13T02:39:03Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=aac65184-a7e1-4612-80be-c188cc6288fe; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|BL3PR12MB6545:EE_ x-ms-office365-filtering-correlation-id: 958a30a4-d502-4973-4681-08db236c1c80 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KXpCuE1A0VtUbOtViAoQzDg4i8ZbAWLseFcoQB/i+fo03uNkn5DqQ/FIBxXmMzicLO853uhw75koWZ6fXXpbkT3ysfHTRFMfe7wnxsaZy2EARI3OqTf85c5BIEU1Zw8Iwv1p4vcOTvcrsbpJPZK1grQ4zWGk7Q8tNxvJVUG0hgCfzptvN7UKtvO7aS20HpwNEIJdunETRTMph6LnQKLMwbetE7GhbHaeRZYg0Riy6vWbwnR0YDAx2pfr2hMq8fqLhdr0AcTqU7zBQ/cKBakE+rKLmGgFH7LXb81bd87E6svrK4e1i6F9LYNIdMSfDaCVaT5GtRuak0cZwNKVfWl8lt7551URwO3fPk4Iu+PlDdSe8mDHngHm607jvV2nXiNlzDFbdgyx2r7kGSfU14LvYQBpkVkoJb7ChvpGW1kevzwcVNR2M+1qGRm6oHXTdwfN3mJyq0F22KhswHQxtK4jubsezDHf2l60hNpfvOG/u1TbscK7yKD2xejiuYo0v66F36QzjzahB7usAaMXKcJ8l8T+IpIl0gBscmsM4uYbgM+Ij2029sJM9VWscGFpOAwE7VkyIumRBM8Eud2ow5LsNFBLVK0StYPIiJvV6GU6HKMt2lSS+XmUo6NsLMUPbdVbc4Xhpf9JvjTT2ArBEdBR0GuSr8v0uotNZOkOxI1xQ0XIE1O0OE/bIiqXyLn3aF/+MSM2knlwWoTpMmyUV0Y7xyKyRIjllFlncB5G/dxou80= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(346002)(396003)(136003)(366004)(376002)(451199018)(966005)(66899018)(2906002)(83380400001)(7696005)(26005)(6506007)(9686003)(5660300002)(53546011)(55016003)(33656002)(52536014)(8936002)(186003)(71200400001)(8676002)(86362001)(41300700001)(38070700005)(4326008)(66446008)(66556008)(76116006)(64756008)(66946007)(66476007)(478600001)(122000001)(110136005)(38100700002)(316002)(54906003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CQVMMMpQSDY/fZUYvGLktxRlM+q5LPTNTIT0m4tbsbuUt343ldxsW2SY0A9e?= =?us-ascii?Q?OU4MiOSYhnoA8aM85FX+pXbJbzajkCW4KXd0sfavilJhdsRdykJPpbRZLwtd?= =?us-ascii?Q?I4YhI549DBJ0ASzPHVqAafL8JvC2IqE8GNsCU0Tgi55xWWMQuDkytgrQa2Io?= =?us-ascii?Q?VIijyuQpKQ+v0X4EZdchWZ7vcTfgBK2ZzJT9IVp1DyOG+yq0rPfuoW/Zg5jh?= =?us-ascii?Q?UpirogfeI0ICt/q8uECYniYHJuwNd89KWy1hXlPh/+y+SIkKkAGjEnbDjqzy?= =?us-ascii?Q?6z3q8m+Z/to/4eVpa93pLIXrN6h9rxvWOZUvJn/rfOc3o7tH8FQi/S/4nJdK?= =?us-ascii?Q?2+e61kZRAdR7JHi1XOz76dtIeN7uGOffMzNXlfj0RtQOjOw4L0n3oP6gcGyB?= =?us-ascii?Q?Ga3FNiqTRss4e+p6y3lUQ1I1yry5BtjyW/QN/kWBmFR3OKHtLOFrpmUBYLF6?= =?us-ascii?Q?IoAvyt1L9ipX1Yblu2ImZZkYMbJ9wnpBdG5LEuqJi54oNQ41rjAK3y8rVTsJ?= =?us-ascii?Q?ttn3GAZUdP+tjmb8OPv/wLFDUhQ2NR7uQtuWiawcE7cjzEDWzLMRRL0i0Qob?= =?us-ascii?Q?kVaJQkWdYkrAqUawOZeCQCxyVHPP6X5bOEhytUnmdJ2oWqXOg+5L4HmyO9BB?= =?us-ascii?Q?AKhbjuYUTLsX4fWDpbNtHZk11I+5yBktKODA3KfplNQ/UvU+TyGPQNtQebc/?= =?us-ascii?Q?5dWEm08qUAm4ggRLpVhSbxvaw7YpISJJzF9lKH5DpuMhbO+uWnMPFlcMjNvH?= =?us-ascii?Q?rc5VmkK1NTKHpHrhfHEWNMnY30JDxg486dt7oyof7rAmi37Rbog9q0xHjHzo?= =?us-ascii?Q?pCkSZPLUVGLic8iSKgGiuKJlelCH3iyEIu4p2CuYmWaCblwzIEB2go4JW5ZW?= =?us-ascii?Q?9lvW2fMPn0/lid0ksdU9V903eNIp0mcclaXeV1xhrUZeEleVjuYweF1cCba3?= =?us-ascii?Q?q1hBKnnB/v08B/PKwvoFzJh99Mbh9abz7oK0X3AOad3XbZYaPOLgo5InBQYn?= =?us-ascii?Q?fQq35sSZKuV8O8GLPzWpPirRig5qi9nITZvFRKJSxiR1wupLSSWbJjHZE/Ho?= =?us-ascii?Q?Q2IJhy75dFtgNp/Uy3LJUbNhbkfzpWjSgoXfj+FL+pzS5xfVQu1hfCUu5A0e?= =?us-ascii?Q?Y3mMtzvI2zDX0pXo16JwX32YrdaPLGFpNfCh0uSpFoE0kp/C//0d1XLgChO3?= =?us-ascii?Q?5A/iP6goAHJiVbgZnISo3qsrepYExWIB4h0qfWA1WT/tpqMy4hZikazkq5Vh?= =?us-ascii?Q?sY7L2rDdeeeAdV6Bz3vl6ANkO44rVllf2Olo17buXCCRHJtDoqxqHVDDOX3l?= =?us-ascii?Q?oZV8Lc/A5wHShcMyhp5xklj4hLM8qWTxfmKT1ODLVuGWWq6ZCACbpV5J3fu4?= =?us-ascii?Q?Rks0DUwp/gzOEHlXjmKK4LvTJvtN+rELyKCUm/XitIHLQuCRcHLxf2ZCBhwv?= =?us-ascii?Q?AarFzukD49UU3OwLVJiweGlelIhEP4M58wqBQwYRFmpAD6tGAzIr4Gv0gTLU?= =?us-ascii?Q?geZS21T+VF0PpXYlEscxBbEZO9IRaDS+ijoHYCiITdiWgrY0nN1mQw7SolWs?= =?us-ascii?Q?6WszLp51OkxfIr3SfycIPcy0/NVpOkDBH7CFTm+A?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 958a30a4-d502-4973-4681-08db236c1c80 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2023 02:39:04.4353 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YnLsZk7+aS5jkHtHZTDPWawyiRJW7t3r3dFYDrZn8aPYT63KP02m00cAq7d+n19haPclQOgXJep1yFPdGjyOyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6545 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Maintainers @michael.d.kinney@intel.com, @Liming Gao and @Zhiguang Liu, Please review and merge it if there is no problems with this patch, this he= lps the follow up development works. Please note that Isaac has his Acked-by: Isaac Oram to this patch. Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Wednesday, March 8, 2023 10:53 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Nickle > Wang ; Igor Kulchytskyy ; Isaac > Oram ; Attar, AbdulLateef (Abdul Lateef) > > Subject: Re: [edk2-devel] [PATCH V2] MdePkg/Include: Add IPMI KCS > definitions >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > [AMD Official Use Only - General] >=20 > In V2 , > CompletionCode is removed from structure IPMI_KCS_RESPONSE_HEADER, > because it is returned in the response data. >=20 > Thanks > Abner >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Chang, > > Abner via groups.io > > Sent: Wednesday, March 8, 2023 10:47 PM > > To: devel@edk2.groups.io > > Cc: Michael D Kinney ; Liming Gao > > ; Zhiguang Liu ; > > Nickle Wang ; Igor Kulchytskyy ; > > Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) > > > > Subject: [edk2-devel] [PATCH V2] MdePkg/Include: Add IPMI KCS > > definitions > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > From: Abner Chang > > > > BZ #4354 > > This change adds definitions for IPMI KCS. > > > > Spec ref: > > > https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/i > > pmi-second-gen-interface-spec-v2-rev1-1.html > > > > Signed-off-by: Abner Chang > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Nickle Wang > > Cc: Igor Kulchytskyy > > Cc: Isaac Oram > > Cc: Abdul Lateef Attar > > Acked-by: Isaac Oram > > --- > > MdePkg/MdePkg.dec | 5 ++ > > MdePkg/Include/IndustryStandard/IpmiKcs.h | 76 > > +++++++++++++++++++++++ > > 2 files changed, 81 insertions(+) > > create mode 100644 MdePkg/Include/IndustryStandard/IpmiKcs.h > > > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > > 80b65590531..808c487bb49 100644 > > --- a/MdePkg/MdePkg.dec > > +++ b/MdePkg/MdePkg.dec > > @@ -9,6 +9,7 @@ > > # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development > > LP
# Copyright (c) 2022, Loongson Technology Corporation Limited. > > All rights reserved.
# Copyright (c) 2021 - 2022, Arm Limited. > > All rights reserved.
> > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > > +reserved.
> > # > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -2339,6 +2340,10 > @@ > > # @Prompt Memory Address of GuidedExtractHandler Table. > > > > > gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress|0x1000 > > 000|UINT64|0x30001015 > > > > + ## This value is the IPMI KCS Interface I/O base address used to > > + transmit > > IPMI commands. > > + # @Prompt IPMI KCS Interface I/O Base Address > > + > > + > > > gEfiMdePkgTokenSpaceGuid.PcdIpmiKcsBaseAddress|0xca2|UINT16|0x0000 > > 0031 > > + > > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > > ## This value is used to set the base address of PCI express hierarc= hy. > > # @Prompt PCI Express Base Address. > > diff --git a/MdePkg/Include/IndustryStandard/IpmiKcs.h > > b/MdePkg/Include/IndustryStandard/IpmiKcs.h > > new file mode 100644 > > index 00000000000..c3baf80bd76 > > --- /dev/null > > +++ b/MdePkg/Include/IndustryStandard/IpmiKcs.h > > @@ -0,0 +1,76 @@ > > +/** @file > > + IPMI KCS Register Definitions > > + > > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > > + reserved.
> > + SPDX-License-Identifier: BSD-2-Clause-Patent > > + > > + @par Revision Reference: > > + IPMI Specification > > + Version 2.0, Rev. 1.1 > > + > > > +https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ > > ipmi > > +-second-gen-interface-spec-v2-rev1-1.html > > +**/ > > + > > +#ifndef IPMI_KCS_H_ > > +#define IPMI_KCS_H_ > > + > > +#define IPMI_KCS_STATUS_REGISTER_OFFSET 1 > > +#define IPMI_KCS_COMMAND_REGISTER_OFFSET 1 > > +#define IPMI_KCS_DATA_OUT_REGISTER_OFFSET 0 > > +#define IPMI_KCS_DATA_IN_REGISTER_OFFSET 0 > > + > > +/// > > +/// IPMI KCS Interface Status Bits > > +/// > > +#define IPMI_KCS_OBF BIT0 > > +#define IPMI_KCS_IBF BIT1 > > +#define IPMI_KCS_SMS_ATN BIT2 > > +#define IPMI_KCS_COMMAND_DATA BIT3 > > +#define IPMI_KCS_OEM1 BIT4 > > +#define IPMI_KCS_OEM2 BIT5 > > +#define IPMI_KCS_S0 BIT6 > > +#define IPMI_KCS_S1 BIT7 > > + > > +/// > > +/// IPMI KCS Interface Control Codes > > +/// > > +#define IPMI_KCS_CONTROL_CODE_GET_STATUS_ABORT 0x60 > > +#define IPMI_KCS_CONTROL_CODE_WRITE_START 0x61 > > +#define IPMI_KCS_CONTROL_CODE_WRITE_END 0x62 > > +#define IPMI_KCS_CONTROL_CODE_READ 0x68 > > + > > +/// > > +/// Status Codes > > +/// > > +#define IPMI_KCS_STATUS_NO_ERROR 0x00 > > +#define IPMI_KCS_STATUS_ABORT 0x01 > > +#define IPMI_KCS_STATUS_ILLEGAL 0x02 > > +#define IPMI_KCS_STATUS_LENGTH_ERROR 0x06 > > +#define IPMI_KCS_STATUS_UNSPECIFIED 0xFF > > + > > +/// > > +/// KCS Interface State Bit > > +/// > > +typedef enum { > > + IPMI_KCS_IDLE_STATE =3D 0, > > + IPMI_KCS_READ_STATE, > > + IPMI_KCS_WRITE_STATE, > > + IPMI_KCS_ERROR_STATE > > +} IPMI_KCS_STATE; > > + > > +/// > > +/// IPMI KCS Interface Request Format /// typedef struct { > > + UINT8 NetFunc; > > + UINT8 Command; > > + UINT8 Data[0]; > > +} IPMI_KCS_RESQUEST_HEADER; > > + > > +/// > > +/// IPMI KCS Interface Response Format /// typedef struct { > > + UINT8 NetFunc; > > + UINT8 Command; > > +} IPMI_KCS_RESPONSE_HEADER; > > +#endif > > -- > > 2.37.1.windows.1 > > > > > > > > > > >=20 >=20 >=20 >=20