From: "Chang, Abner" <abner.chang@amd.com>
To: "Attar, AbdulLateef (Abdul Lateef)" <AbdulLateef.Attar@amd.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Attar, AbdulLateef (Abdul Lateef)" <AbdulLateef.Attar@amd.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg
Date: Wed, 12 Apr 2023 05:24:59 +0000 [thread overview]
Message-ID: <MN2PR12MB396696760A5D0850FC7C3A49EA9B9@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <MN2PR12MB396602D1DF25F37D15E8EEE7EA9A9@MN2PR12MB3966.namprd12.prod.outlook.com>
[AMD Official Use Only - General]
Forget to CC Sean.
Hi Sean,
The package naming AmdMinBoardPkg looks good to you?
Thanks
Abner
> -----Original Message-----
> From: Chang, Abner
> Sent: Tuesday, April 11, 2023 7:05 PM
> To: Abdul Lateef Attar <abdattar@amd.com>; devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm
> <quic_llindhol@quicinc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>
> Subject: RE: [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg
>
> [AMD Official Use Only - General]
>
> Is any one has additional comments on the V4 patch set? Otherwise I will
> push it to edk2-platforms.
>
> Thanks
> Abner
>
> > -----Original Message-----
> > From: Abdul Lateef Attar <abdattar@amd.com>
> > Sent: Monday, April 3, 2023 7:23 PM
> > To: devel@edk2.groups.io
> > Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard
> > Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm
> > <quic_llindhol@quicinc.com>; Chang, Abner <Abner.Chang@amd.com>;
> > Michael D Kinney <michael.d.kinney@intel.com>
> > Subject: [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg
> >
> > V4 changes:
> > Rename MinBoardPkg to AmdMinBoardPkg.
> > removed empty Guid section.
> > V3 changes:
> > Dropped the PlatformPkg package.
> > Rename BoardPkg to MinBoardPkg
> > Addressed review comments from Leif and Abner.
> >
> > Adds AMD/AmdMinBoardPkg to support MinPlatformPkg framework.
> >
> > PR: https://github.com/tianocore/edk2-platforms/pull/75
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Abdul Lateef Attar <abdattar@amd.com>
> >
> > Abdul Lateef Attar (3):
> > Platform/AMD: Adds AmdMinBoardPkg to support MinPlatformPkg
> > Platform/AMD/MinBoardPkg: Adds SetCacheMtrrLib library
> > Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers
> >
> > .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 19 +++
> > .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 30 ++++
> > .../SetCacheMtrrLib/SetCacheMtrrLib.inf | 35 +++++
> > .../Library/SetCacheMtrrLib/SetCacheMtrrLib.c | 133
> ++++++++++++++++++
> > Maintainers.txt | 5 +
> > 5 files changed, 222 insertions(+)
> > create mode 100644
> > Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec
> > create mode 100644
> > Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc
> > create mode 100644
> >
> Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib
> > .inf
> > create mode 100644
> >
> Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib
> > .c
> >
> > --
> > 2.25.1
next prev parent reply other threads:[~2023-04-12 5:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 11:23 [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg Abdul Lateef Attar
2023-04-03 11:23 ` [PATCH v4 1/3] Platform/AMD: Adds AmdMinBoardPkg to support MinPlatformPkg Abdul Lateef Attar
2023-04-10 2:32 ` Chang, Abner
2023-04-03 11:23 ` [PATCH v4 2/3] Platform/AMD/MinBoardPkg: Adds SetCacheMtrrLib library Abdul Lateef Attar
2023-04-10 2:32 ` Chang, Abner
2023-04-03 11:23 ` [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers Abdul Lateef Attar
2023-04-10 2:32 ` Chang, Abner
2023-04-11 11:04 ` [PATCH v4 0/3] Adds Platform/AMD/AmdMinBoardPkg Chang, Abner
2023-04-12 5:24 ` Chang, Abner [this message]
[not found] ` <175268F40268DC52.3977@groups.io>
2023-04-17 5:56 ` [edk2-devel] [PATCH v4 3/3] Maintainers.txt: Adds AMD/AmdMinBoardPkg maintainers Attar, AbdulLateef (Abdul Lateef)
2023-04-17 11:44 ` Leif Lindholm
2023-04-18 17:35 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB396696760A5D0850FC7C3A49EA9B9@MN2PR12MB3966.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox