From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.51]) by mx.groups.io with SMTP id smtpd.web10.4341.1666153078170046570 for ; Tue, 18 Oct 2022 21:17:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=sUtrrLKw; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.102.51, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KACFFQeQM85gPlQXnv9F0bAbH/ypFuIz5IlY26zFwemyfv93/y3vvW30Dt3y/zSfR+UDtCThOKJyIZ+EYMYlADXL/5UO8MFMv/BCjobwxsRFuH+GWnG6upeNO56t4Fa6N1t/JlLEtfBSlYMcYGZlMO0/v7hPH4jw0958I4Zas5H21PVGOa1dJss5KY3h0Hgv3yi2O7TzVM3CGhnzKJsarDAXZJ3RcS3V1dWhk3ZRi0Y5/D6Sw95bug37dzW48UB79ysJjgJbw//p5Zhl9wZxSQb1qxHcuSgyVF11+iO17BET+mIouN5wmto4iwJpCRov9EZVc2te5AlLzvuS+AwRZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q1Qxq0MRQdDFdTM2dpZfjC13krKhagLmmXrINtKBlkE=; b=M6mDonNysMOgQH9yo1IbquC8omgEBV4mlPg9S9xUX1G00/mKIlQstQOX2k0g1ZK9Jtz3VStFuj9llnlupyQgiqvShs+ZeHhujPO2924yPI6s99/4bSYCazJzt0/8evEwKKiWpJw7MChSHRlkTLGBVvHyLX4oDny+Le3+4TAGLyz2vjPvcDhhnljN/DX/V2kOqZXJ20jcc6kH1TT03cou5S4o2aKNVAnKtkRteqPjTpJyWoJVNgKWk8nQWkHUuJZRcsWaMLTjwV6wWIa4DDXNr3eBEXUCGnmR5jYL4ypN3wlRwZkDppbecAfGP3V1HU2Dl70wZMLbLEBbuteMn9NtMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q1Qxq0MRQdDFdTM2dpZfjC13krKhagLmmXrINtKBlkE=; b=sUtrrLKwLELPalcnKzAzODBNhL88N1QOQ9G4nnLvHQFRlAeyNSiQbbuFBH7CSCVvle2bpAFhjFdSribDOryM9/PZusO6Di8k7q4VCDEFKWXNTRNKYsQE6ibo2vVa+SvSiawC1xsTsPdXNl8G15inhGknpsG46VWdwvZ6UXEu9gY= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by BL1PR12MB5062.namprd12.prod.outlook.com (2603:10b6:208:313::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Wed, 19 Oct 2022 04:17:56 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2eab:b851:827c:1d88]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2eab:b851:827c:1d88%3]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 04:17:56 +0000 From: "Chang, Abner" To: "Ni, Ray" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Coding Standard: Updates 4.2 and 4.3 sections Thread-Topic: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Coding Standard: Updates 4.2 and 4.3 sections Thread-Index: AQHY4rcWPTSlQa6vmkKZa0/ySI3iUK4T5O5QgAEtAwCAAAtHoA== Date: Wed, 19 Oct 2022 04:17:56 +0000 Message-ID: References: <20221015114757.383-1-abner.chang@amd.com> <20513.1666072896702226815@groups.io> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-10-19T04:17:54Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=d4b5f60a-4fb7-4166-a135-6e172f03b143; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|BL1PR12MB5062:EE_ x-ms-office365-filtering-correlation-id: 3969ebd0-ba6c-4605-8f74-08dab188e625 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IRTyiAnslMDJyulbwEnc2wH2Li1fXyhlVeJ7vv9pqRqkn8s7zsoKWKW1JShbDEO39e1fmLXyun0H5U9lCprpIQ4jMKh9vFPabY2FU2DR4+9Qio9UdVKuhi1t4OYLi8UKhS2bVzmC2zSNfJD2m95Ep9ytEURH8P+F1N4VjnCvLVExbt7B74Xuv8n3KoCZ4YG08sSXYUdyFTj4g9tXNyBAp64n8V2r7cf/tJPPFWhk3x9HIRass7PjkZsdP5FEG+ED78ZkHdzjH9+BdPGk0QYj/JJ+aDkAJUQn49e+HnlUwqV8czjAcPNujL/U4SmVVatPfClcJbM+B0af/7A0TgbsmneCZH5HKE1b6ado1UHmUS7B4ri/YRqss05sCvFKXw2Vhr8eo9uMIHbpQY/MRNRzh4yhVeeRXx9gOgr3HKdEKV17ttxExz3Zkj7WiTZ5ghqZkwDmeQpc38YmtEEpZg1ZkCiCADJcUy++hbf9Ua43+1SiF2WurkBSXF0eYgS4u7TGfXqBM4iM2h+bqISDSZwseR+RPfKV8xBusTWQybWDqb1vuz4zyMmlbFm8Da7YVOtDN2I3YboSyt+nXv/nwl22thBgT/XIwqCX5yjbet7oinI7TcPf5ySWQYcpAw/CVvsbh88dUcqb8+VpHsNFqmdXTCmNaqNNLw4o62c97OSXcbQ2zigTeU2+fb7BZUT5BPRPoS0ffLjsi9lIeU3FDva8LskxqZsIBuI4QYzUytzD1Iq9P+40eYoNXMf7O618xN5mctIWiKrPfIVhyeamlAz9Lw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(346002)(366004)(136003)(451199015)(41300700001)(26005)(186003)(64756008)(478600001)(38070700005)(86362001)(2906002)(6506007)(33656002)(52536014)(8936002)(53546011)(9686003)(5660300002)(38100700002)(7696005)(110136005)(316002)(122000001)(55016003)(71200400001)(8676002)(66446008)(83380400001)(66556008)(66476007)(76116006)(66946007)(15650500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?M34bMMw2H+/iPiPukrVKe+nuEt8+xtyGxHdUq+gwPja+0bIHNjrtkpjQtgSR?= =?us-ascii?Q?76XP021wlWJr5Tq1016ysOvrMg/ebiMkKk2+VIE+xZDHXbLb37SmOi2SLU8R?= =?us-ascii?Q?vr6P1LJHZtGHIy/MzPSscVd6LoqbfrWKdlqFSTDW0pA9csPLcXaNWJbcW+QA?= =?us-ascii?Q?f7i/YqwyWwRaqVUOFEYo8vaIsfZ1IcXFpoYxIHx1rZHEtOnfun2e1kAqCSKE?= =?us-ascii?Q?2g4UBafCExMXPnt2TY56TsCmCFM1dCgnhWY88xrbKN2xfsS9Pvq9ky8k2k5M?= =?us-ascii?Q?wEyGvwItQYAZhhjfAT1KQLM+QzIKLMF84jVMd0aBADhaq8XJ70HQs+zcxVA3?= =?us-ascii?Q?HG7hPlT7J/9bv3PGUHZvgBLl79cpVAx0A5409fzYHG/MTwrKhgVizekHKLwf?= =?us-ascii?Q?nSa88SCyyWyWm78AgnpFTlHog844TBhr1on2P1qPjtJjmIJ6A8wxHyJEybvh?= =?us-ascii?Q?sX52gQDLsKCizcN4IYozZVyPSXSOCzXFxALxrXERbbz3QxyoHHEffgp34jCL?= =?us-ascii?Q?bLTp3TH70tBpoZJ51yzk5Lwf2INzI3tH45Mh5nOL8RG8u0a57h6aqeeG3MCR?= =?us-ascii?Q?Oe9Gj50eb20WwlOsmM2acQlGLNiFi9jXJ4kn2MKGk7j77p0Pd4Ym8JesbJan?= =?us-ascii?Q?yn8txPJCNpkmDAfhnmY9acuN2zFVqlqmMEv7XfywYTatyZqxBOVvCg/frioz?= =?us-ascii?Q?C1kV4pZaFoVAJnXAIk3n2UsofCCF5Bc/WDG2ntNU41I0LQu/gHr+PSpwz5PF?= =?us-ascii?Q?waXBjGE6rL1NG9YZjlfGes6ogUnkLiLCc6mhRjgs/gv/kQ1e7Y3+CjVi5pT2?= =?us-ascii?Q?JabYlDW83AudhmhKyrjCocJTDeadNpjaN7DjQee5PjqOUr1VIwuYD6jjjoED?= =?us-ascii?Q?01DAN/btZ9ORKQUfLoH2r/M7MX4w+BXuPGw8SDK2THpL1F/pL2a4svcJ4gMv?= =?us-ascii?Q?+Glb041/OBpf5oHkp5XjBYv9z3J2buu1hWGgszn4dTocRY0PmoOoY8v+fH4e?= =?us-ascii?Q?eJUWCoke9iEpaXy0eOHj1pDNCgHBp96dhtaJopl3g5pZox3MwDqyZ5DWpeCd?= =?us-ascii?Q?ostRmNOheb15IdxaTwB7YWYKIG0ZbM6MZHQP/rywA8r1IcVlTeKZ2MkG1GyV?= =?us-ascii?Q?p75bNpvK7GMYin+4yPO7Xcwjj4Did7gV5ZH7/g12BGmymwMti1KON6JtYTes?= =?us-ascii?Q?8doa7VIzE2nCY7dqjrsH1Atn8N0Yt5imHSkdmB2DO9hHtiVkfb3ckh4wlSe1?= =?us-ascii?Q?zdgKlTxlOKV2oRoeOEKjqG3pUcwkmb7k59Wyga2A8TCrKW01tyn1npc2NeOq?= =?us-ascii?Q?x71yueXOHdtuslXZFO9J6wJNDDmYeiWBLf65UJn7fVJI46wXiFh7mv494qmJ?= =?us-ascii?Q?eeixGiDb/UfL5r2cpHMtZCBebyxdqT0KAssEnb88EVLxCWvW4G/1g0yNV5di?= =?us-ascii?Q?4TFAv7Uu5/qLSt3g7gWKoqoRUiVu4aiZKxFYEX+tQQmWAyO3pOOK60G4tj4p?= =?us-ascii?Q?dsNMazQ2tCtGrqkgFor+q8jHUv1KJvE28ML3IxoDI3YHXDy2aWKPqO47WS77?= =?us-ascii?Q?555Jz5HOxG+R+mKF/s9Eq9K7VUpI9H2tBVlt4kRL?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3969ebd0-ba6c-4605-8f74-08dab188e625 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 04:17:56.0923 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wCjlT2ie3Hpu6ANdWAjOh8tjMYheVDS/Go3HS3SeCsx3QEQQ9lMbAM9FQRTDs+syGlnegv1AIrFqkCT6SZHvBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5062 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR12MB3966974D5109E5FB3B64C8DFEA2B9MN2PR12MB3966namp_" --_000_MN2PR12MB3966974D5109E5FB3B64C8DFEA2B9MN2PR12MB3966namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Thanks! I will send out the V3 for the update. Will work on the spec public= ation with Mike. Abner From: Ni, Ray Sent: Wednesday, October 19, 2022 11:34 AM To: Chang, Abner ; devel@edk2.groups.io Subject: RE: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Coding St= andard: Updates 4.2 and 4.3 sections Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Oh I see! Reviewed-by: Ray Ni > From: Chang, Abner > Sent: Tuesday, October 18, 2022 5:50 PM To: Ni, Ray >; devel@edk2.groups.= io Subject: RE: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Coding St= andard: Updates 4.2 and 4.3 sections [AMD Official Use Only - General] Hi Ray, ][].* The simple naming rule was already defined in the 4.3.1 to 4.3.= 4 sections. We are not intending for defining the file naming style. This s= ection is mainly for the format of attaching and to the = filename. For example, how do we add AMD to SmmCpuFeaturesLib? Is "Amd"SmmCpuFeatures= Lib or SmmCpuFeaturesLib"Amd"? This is what we would like to define for the= processor archs and vendors. My opinion is we can just leave the file format naming as it was defined in= this spec. Or how about if we say "Refer to 4.3.1 to 4.3.4 sections for the file namin= g format" for in below? [][].* OPTIONAL The is represented with a BNF, ::=3D'Ia32' | 'X64' | 'Arm' | 'AArch64' | = 'RiscV64' | 'LoongArch64' | 'Ebc' ::=3D []* Example: Ia32X64Arm or RiscV64LoongArch64 OPTIONAL * REQUIRED Refer to 4.3.1 to 4.3.4 sections for the file Naming format. Thanks Abner From: Ni, Ray > Sent: Tuesday, October 18, 2022 2:02 PM To: Chang; Chang, Abner >; = devel@edk2.groups.io Subject: Re: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Coding St= andard: Updates 4.2 and 4.3 sections Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. All look good to me. Thanks for addressing my comments regarding simplifyin= g the rules. Except for one minor comment: I still don't think we need to define rules f= or source file names (4.3.5.4 EDK II source files within a Library/Module i= nstance). And the rule "[][].*" doesn't specify what could be. That leads t= o allowing any style of the file name. --_000_MN2PR12MB3966974D5109E5FB3B64C8DFEA2B9MN2PR12MB3966namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Officia= l Use Only - General]

 

Thanks! I will send out the V3 for the update. Will = work on the spec publication with Mike.

 

Abner

 

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Wednesday, October 19, 2022 11:34 AM
To: Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io Subject: RE: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Co= ding Standard: Updates 4.2 and 4.3 sections

 

Caution: This message originated from an External Source. Use proper caution= when opening attachments, clicking links, or responding.

 

Oh I see!

 

Reviewed-by: Ray Ni <ray.ni@intrel.com>

 

From: Chang, Abner <Abner.Chang@amd.com>
Sent: Tuesday, October 18, 2022 5:50 PM
To: Ni, Ray <ray.ni@intel.com= >; devel@edk2.groups.io
Subject: RE: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Co= ding Standard: Updates 4.2 and 4.3 sections

 

[AMD Officia= l Use Only - General]

 

Hi Ray,

 

<CpuArch>][<Vendor>]<FileName>.*

 

The simple <FileName> naming rule was already =  defined in the 4.3.1 to 4.3.4 sections. We are not intending for defi= ning the file naming style. This section is mainly for the format of attach= ing <CpuArch> and <Vendor> to the filename.

For example, how do we add AMD to SmmCpuFeaturesLib?= Is ”Amd”SmmCpuFeaturesLib or SmmCpuFeaturesLib”Amd”= ;? This is what we would like to define for the processor archs and vendors= .

My opinion is we can just leave the file format nami= ng as it was defined in this spec.

 

Or how about if we say &= #8220;Refer to 4.3.1 to 4.3.4 sectio= ns for the file naming format” for <FileNmae> in below?

 

[<CpuArch>][&l= t;Vendor>]<FileName>.*

 

   <Cpu= Arch>   OPTIONAL   The <CpuArch> is represente= d with a BNF,

   &n= bsp;            = ;          <arch> ::=3D'= Ia32' | 'X64' | 'Arm' | 'AArch64' | 'RiscV64' |

   &n= bsp;            = ;            &n= bsp;       'LoongArch64' | 'Ebc'

   &n= bsp;            = ;          <CpuArch> ::= =3D <arch>[<arch>]*

 

   &n= bsp;            = ;          Example: Ia32X64Arm= or RiscV64LoongArch64

   <Ven= dor>    OPTIONAL   *

   <Fil= eName>  REQUIRED   Refer to 4.3.1 to 4.3.4 sections for t= he file

   &n= bsp;            = ;          Naming format.

 

Thanks

Abner

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Tuesday, October 18, 2022 2:02 PM
To: Chang; Chang, Abner <A= bner.Chang@amd.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Co= ding Standard: Updates 4.2 and 4.3 sections

 

Caution: This message originated from an External Source. Use proper caution= when opening attachments, clicking links, or responding.

 

All look good to me. Thanks for addressing my comments regarding simplif= ying the rules.

Except for one minor comment: I still don't think we need to define rule= s for source file names (4.3.5.4 EDK II source files within a Library/Modul= e instance). And the rule "[][].*" doesn't specify what could be.= That leads to allowing any style of the file name.

--_000_MN2PR12MB3966974D5109E5FB3B64C8DFEA2B9MN2PR12MB3966namp_--