From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 60DEDAC0B4F for ; Tue, 28 Nov 2023 04:41:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mpBrRr7+scA0PIyP5GtTd0OaXs7/wfmjIyLy3/+U+ao=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701146502; v=1; b=VSPzG3zozxp/ZaiVlhRQ8LaKd/iLIMxZee+drTsJgQnuKEsq/FwJY27PrbFs4fRBkWi5P+2c AdQZaPucJz0b1KNEEFwXnfqeoFPuODa4fdvIj6006OIfdQtlQbkxlMPaLTIGd8bux9iqtSoI3f3 yAgitcyWSipAq7KPyhI7AfDc= X-Received: by 127.0.0.2 with SMTP id P1MRYY7687511xJDqHrStNKW; Mon, 27 Nov 2023 20:41:42 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web10.25736.1701146501738435526 for ; Mon, 27 Nov 2023 20:41:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BGTG1fxifP/p+q3mmaYDkpaVOCZ3fk8jKAkZQMaaV3TQWmF0BUqmOcRcgxFQJoAJzUm8fuZWkYtms6nS5crciqdYpBBrdM6TNkDspOYao3WQJV97fnr1lmFVuBbLVxKu3IJedyLaDCs5ZsYNlhXQY9CyWRmgsQ2pEC/rBC/3wIvqKo7cfMD0aOFgCZH2TiJWwrgYHNytem48U5XPk8M/G3ADt2b79qUqwqNiTNhtSORDrZK5fEs3Gbl6G6GJz/xauJDf465udUzJEcD2cZMUH0whKw9Kej0EeZruJwH0i5HJ6t93riQ01KXhkKVZBjM3gZMgsvpSfgs7pswSJE05rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KL4xtpI8M6ic+hMusI+Gs2aQG+DtI2UKbCbH7C3SEOE=; b=mxUwcMoAF/Ud+F8VfGUMZxyluRt+2o1YzrLmVRvoYe4WTgg5U9vaTa1arGZ5I357Pkm9ms60gMyjGYUSMZgvtipyBVYXn1aaFMdWia6aJq/WGg4/3YQPPxrDOH64EhaZNJK5JGi+baGf4qaexYHVUQoQs3EyONZ4ClrxweIHScEltYb/63t0PReqtwdh4b7/RNwtsrX1WNyXZsOdqtyeSY6kYRiR+9W0Xw7TkbPtLOR8QnBecSlIDSQvMOicqDwYiK/n+pmW5CyZNqA5ivwYcNiRkEDjDo+z0t/jLziL/CgL3UCy03GJu/SkqN1qR6OwR6Vsq1K/oG4BMWtUxRXxhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CYYPR12MB8853.namprd12.prod.outlook.com (2603:10b6:930:cb::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Tue, 28 Nov 2023 04:41:38 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7025.022; Tue, 28 Nov 2023 04:41:38 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 4/6] RedfishClientPkg/ConverterLib: fix empty attribute value issue Thread-Topic: [edk2-redfish-client][PATCH 4/6] RedfishClientPkg/ConverterLib: fix empty attribute value issue Thread-Index: AQHaHhortBpoYBhwWkSxHWp4pX8PJrCPLhVg Date: Tue, 28 Nov 2023 04:41:38 +0000 Message-ID: References: <20231123143411.3500-1-nicklew@nvidia.com> In-Reply-To: <20231123143411.3500-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=226a82b5-e391-4231-b4ae-8e1584a2bcf8;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-11-28T04:41:25Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|CYYPR12MB8853:EE_ x-ms-office365-filtering-correlation-id: 4629542f-0323-4c2f-894f-08dbefcc4f42 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: MONRZbGGLtx4kMkXbMysYfv5w7twe5Ckg7//4ZYKuOkZEOcBuVJNm6siQFPxephX1QDtsjsthSRWr9xK8VlZ0Oao0QX93vog3HYqIjJywmx5fkNh4976V1ErTtx1HFGtUsEBflF+9MT1uo2XCFHUaGWnFHkBM2DGSDRVQDuUvx8SEUBkaNxYCbS+RnK1fwN/Rr2/a++qs5cL75GUgh1nhGHFrgYkC6DK/gJokjNdvfdDzlOFwqD9CoXRMrrQcrDFz0jEKLQRZps9oLC9qquX8Ttis3aV362EbrrJvOnvbMBqukKTnTgcRjIoUD72QrMU7LF9I0ovAspZ3FuR69GgjbexqDEJLcZmK3rsN99dTk/I/902/2gRMdrF0DQEkpvOs/cpngTypieBzk7CnjxK8zThuzvsxyvajOfVg5KZPuhOSivXchAv7fsGwPim4cait/LMbdgl4ht5kY9sFzk2L1fYAV7gKqECmx78oRVBj+/AwPwOx4KfS9Av4rInNLmKSOwq8HN2LoLbiRitVlslQwTRqDYtx3K19X71DZzT0Ru+UDHbNIKFpVlyQHjKoEhh2h/frAkg+YDG3liHsuq4ce56x8pj6LAIsFOS4ERqh6wbl0nWNsfkNhohVE/1HgkDBfFUhCJYhWGfQHM5fcqcNQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WcwMNZGJ3rN5ZmzAJLMNw+a6lP49KEjXUkxc+o+VwPwVizeqjwkqP7uTgk/Q?= =?us-ascii?Q?I01+nA+jfvELwxwUKv69QKJ4sVwxXVc3ngAX1sEiTB9sQaJ+nC4sDhG1PzR/?= =?us-ascii?Q?VfKusljgGfpis7HHVAr/wXKpq1W8p0K1RKwatWydBQxyU4PJa7o1WAQD4Gsd?= =?us-ascii?Q?9P/bMW5Pt62pqGaYfVb3Zs7HkOxCVFUTeT1Utou4HoYhPn0ZGgXEQwQCpfxD?= =?us-ascii?Q?79fphH6p00WnplT5abaB6aaucCd3oK7u79FrY/hFuliQdsv/LTmhJGZHI5y4?= =?us-ascii?Q?tcqMdpMDbUuQe8t2hsta1Xk+RPtiJYkrwnOs/1DLMgKr6q2IEwj5hx06HNoZ?= =?us-ascii?Q?Pfl4/MZPFZvneoi0Y1wYH+NL4cA61pbXeZn3CB+J92xoWpfVFphMl6LdBd4i?= =?us-ascii?Q?RnaTFzSRvFqmAjQvQuCIYpP5A5GX+jLByugrvNu8Ul47beCuVCElXE6mpqYl?= =?us-ascii?Q?Y7VCvJTQqIkvdeJSoYuVsrIDjkA4dLr4P9aAFbvj3ApJcxznTqT1M64p6hCN?= =?us-ascii?Q?kEDTzo4DwR8W70zGVc1+HGFzFsQlcacZYfofnDMFPuteFIosN0aGp/Ee3JzK?= =?us-ascii?Q?ACYCcE4fi0CwtVGmtI1dmZdWqoA0lRw/2uqFgapb7yyUppYSIG8t1tA/v/d/?= =?us-ascii?Q?pNhfecwaQyZ5uOTNSZmG9DmsYACjqOEvyFpt+v6FtyJHbrCAOFOtn2WiijZ9?= =?us-ascii?Q?1rTQPdGOPKlC/e48aFmYFQzB6J9/Uhh4LMQfRCNL3IOMacEKSKjAMyzOMAne?= =?us-ascii?Q?OPeM3eEha9VuLlo2KhzFGGml3ZSzUraMylfPKhHtTywO2WjsHHEkiVRTynqr?= =?us-ascii?Q?zmEgygbvgLBPsoxc9P1V6baJmDn4Sd10HEX3dWEhRKjWaJuSP2EYNeu/49Em?= =?us-ascii?Q?1wUPeSaiYXWCkYrcNjdPMk7/Nd1VLDp5xz0mpxFjejQHjO3PWzTpyEPcP1UJ?= =?us-ascii?Q?POd+ukbDSdvjUyL3mlT/GyTxm95q8ZlfPXcD5bCh/LGgmy1J/cjgaFwV1R60?= =?us-ascii?Q?8C1kIc2p82CSuXSdndFo5noib/5d4RnBZl8CqlcoK2TAClgxsprHLKujf5MP?= =?us-ascii?Q?tcV3JT+u4b/wft7NFHFFuaS1L6i2h6C677//SsKZCeCdrPo3ODAFtd2GBbw/?= =?us-ascii?Q?uakGeKsMwTxtiII/YBKY+1AoHe4TRLIgxCwG+skqAqaU1yEPLNLK4nlWqMA3?= =?us-ascii?Q?FbAfUUL3urpth4/3DxaEsSPQlGLpOE4o7AH3bFNpozV5vqWXAu/34hqcv6Pp?= =?us-ascii?Q?drqgi6gvPmeTNlCjA5nSgb/gV0mC6T00L3NSk/5hy8uzDlimDFz/ViSsN3dW?= =?us-ascii?Q?0y/qeZginJvCorei78dCka8o+IZIgwwotD7/nP1Bs4u9vJ8fQLK0wzpEXKg3?= =?us-ascii?Q?LeaO5SU6p6G3K5svjoQ2UoEaku1hBr3Q/h1YbMgRGJneKaXfZTSzZ7S3MgRL?= =?us-ascii?Q?zu7L/kT2hJdXTQmGosJnVQJplMXUL07St2uUw7u6uVdl+BkbTVMFaTW8/70e?= =?us-ascii?Q?0ZI00hOfFCe3w+M+q9oVWSRCnixQgEmEze/zHntBpZX2WaekxdngZpL08VfJ?= =?us-ascii?Q?Do2k2j7HErRFHOH7wRc=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4629542f-0323-4c2f-894f-08dbefcc4f42 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2023 04:41:38.4832 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jNQlreJRsNMAvCPKvyTwIEa6wur8jVpcy5tI5vIRCeHG5WUnWXxahZpm45TZR/icEaDWfH/Ey3gJk8YNx4e4hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8853 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 67GkmvOHTmXodOjm8dLGvPwQx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=VSPzG3zo; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Thursday, November 23, 2023 10:34 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 4/6] RedfishClientPkg/ConverterLib: = fix > empty attribute value issue > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > When attribute is empty string, converter library creates NULL > attribute value in C structure instead of empty string. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c > b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c > index 02fcb2b2..7c2fa3c9 100644 > --- a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c > +++ b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c > @@ -1,6 +1,7 @@ > /** @file > > (C) Copyright 2018-2022 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -446,6 +447,9 @@ CreateEmptyPropCsJson ( > if (TempJsonObj =3D=3D NULL) { > return RedfishCS_status_not_found; > } > + } else { > + // Dump JSON from JsonObj. > + TempJsonObj =3D JsonObj; > } > > Status =3D allocateRecordCsMemory (Cs, sizeof > (RedfishCS_Type_EmptyProp_CS_Data), (void **)&CsTypeEmptyPropCS); > -- > 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111792): https://edk2.groups.io/g/devel/message/111792 Mute This Topic: https://groups.io/mt/102767546/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-