From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9A6A6AC06F0 for ; Mon, 2 Oct 2023 02:45:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0jKMbTHje5r4rHJqN1HWoQmEp/FqzlIY/GdEStnljyQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696214727; v=1; b=sugEfKoU6hZVhxoYHOE77KU0dXCovBxKTd3F24fjq9rmM8B9XVLjuRO/Rsdx0mtMfk4xb3Ja 7UyLVyutVgXWkwi9PFI+9QsDqAdIC9KRLv7NyTcKnyLzi4Y+I5Rg7JZ+Yhy3rq8DB5hvtqc0bfy n6CSSnFcgb9K260yCLUHxrDU= X-Received: by 127.0.0.2 with SMTP id 3kFzYY7687511xgpXVbw5y47; Sun, 01 Oct 2023 19:45:27 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web10.73963.1696214726363518326 for ; Sun, 01 Oct 2023 19:45:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=howxrQ1389b3m8DhmorMCy8h16Dl9z2mIhQFBR35JQjbcEwR2e6GMAvRyY0gt6UTUK6hxpkjc3Xs/tw3cgehLt+z7LF94yihl4KUq24J9odkCx/ZD8EgOM1o95ynbiX3nU6G5iQX+x2ypf5+MEwyFaKMaIMjWf8PpRgP9tpgR7aYyEIn8NUdwCbPPkZ4iAdQnxTZVwo6BXvPTJ1WMingMtbbWt4itBNPeQTmc+Ea0lmSR+PnZHQp+eUuwiFpqarCtth+yW0+5Mg1O2XUX3P12Du4iGoQmr8E4AHYimB/5O9zHKUCn73HVl+cFL9TPSWS/lrkQusdew4N+YJkm5ZA0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5ftWZWtQTf9TFBj5a/tqvGtMDr8H+iULw8IIbbUkrhk=; b=Z2Mban+Y86bM3h+trRlHpCRSkdizoO5IopdPBAgGQi4SMvahilMVIimrw2mal8zc3MA8VnzXfe6wZ1dO3bLnlPpjPBtZn/mL74emD51t7xqMCj0aaFro50I5S/Xcv3btuF7H12qdHnvqTncNFo9ILJLBGXdlIAmgH9zwwvVpF2VmbbHFcjInfUqheCK/gTHeZmN5XMS5rP9AGy5YZGf+B9YB9taUXLFYvuDCsxPjv6XUfzyk/T4I4TR8qOLNSAzl8/t4pwE021judJH6cFX8vIUlK9yCPMT60hwiidHFMzGSA5kqDZX1tajmkgDNmvWwZ+vFV3xbnbQEGPGFm1sCnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by PH7PR12MB5710.namprd12.prod.outlook.com (2603:10b6:510:1e1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.35; Mon, 2 Oct 2023 02:45:22 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02%5]) with mapi id 15.20.6838.029; Mon, 2 Oct 2023 02:45:22 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" , "nicklew@nvidia.com" CC: "igork@ami.com" Subject: Re: [edk2-devel] [PATCH 8/9] RedfishClientPkg: fix pragma pack usage Thread-Topic: [PATCH 8/9] RedfishClientPkg: fix pragma pack usage Thread-Index: AQHZ8yA69Y9jtItkuE6KDTmkCEPDtLA1zhJA Date: Mon, 2 Oct 2023 02:45:22 +0000 Message-ID: References: <20230929215915.46616-1-mike.maslenkin@gmail.com> <20230929215915.46616-9-mike.maslenkin@gmail.com> In-Reply-To: <20230929215915.46616-9-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-Mentions: nicklew@nvidia.com X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=f46730de-1a59-445e-a01b-bd2147803cfb;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-02T02:43:01Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|PH7PR12MB5710:EE_ x-ms-office365-filtering-correlation-id: 60e1c5b0-31a5-467d-8147-08dbc2f19fc3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Dvu3KRohzbLz3owoi9WOFArrmb4AD0IPhKlQptPXqizHpSK0aWdFSbtKyX7z0nhbeMrt1HPk/hO2aHD4bmjuIU3iwyGP2BEnj3cd2LhxT82xUpJC4XjreV7NPYcbEQFWJhrJxRKYW9rDGAMR6A8Yue35vS2pFLTvUNYIgbLe+IWfDFxWTOvr1af6u1Sr/zRLfRXBNhv5fk7PFdDEMINadWn1idspVhxmJHPSMn8t/zmLj1mssRsGL/xBqIcgo8YwurPNSkkLoBbl/gEt6gWVesM3DjKtR1KJqNbLdyq1x+a1roPTapgLGkEmeTYSqsqQIEz65SCv8QxxVGt7+x/R35hcxpVv6nAR1Rl8togkKrEEECD1YLY5IzzgMfKXZOow/swP1tsQpbhyQRQo8LtJSrCnhZ8SWWTSatkKvWTm841XJTsdzFfxqyaZ75agPVwCID4W8Sf920Gp/V90DF53qTpefaUZ2ZPBmy/Df8Sjj+i5gMWDXWO41eWWUXwhwFolIM04bR9bgVQzWE8BEDKY5bYAIO3Aok/ZG61ZgqUsyrGVE7LSVlN2K+v/6eruMyDhXAddfSaPupARvPBmz0wlbjl5dHFpZOLckXQa8JIa1YF8Yb+OWPLXR5FHf9ks98uV x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LIqrlMan50pqpRyWotJqPTBOeJRL5/k4zHoiXcq4cG0Jk0Jyfwlp2NL2gpij?= =?us-ascii?Q?0sqa3QZFdmE3UEVRNvvE0VGir+TCEDUXPAdwois3MzhGBUydmsYmydmfFCw6?= =?us-ascii?Q?t8B8FsYS2RT9HmiaWqYjeZM/JEqp8eWyaFjTg1easWEKHyj0lhV/yWgs87HX?= =?us-ascii?Q?HZPFeXdG8QrYAm5h3sqekTKKY5Tj61BQZ4YCKSfKWtYxB8RugaGrzh/erdCz?= =?us-ascii?Q?9RAtPBsRd/bDpJpB2pat8kDm6FsUqO7LR1gxNDYpNQ6swF6AVjWgnwaITDMJ?= =?us-ascii?Q?nSSJNY/E76/QG+xuAu2j6cVF8TsUVLjFsHjWmQRArRwK1MvN+dXUc/Yp3nP4?= =?us-ascii?Q?7Ikirz/nBRmpAWNBTPske+WYPeIBk5KrtVFQBMbXOwGYSHcraz6tWiM2Mz9G?= =?us-ascii?Q?DGmvCgEofxtMZKW3pWRRdR8/ngZljmPnChh3tn9MmFGOzfdvzpkg9wGEBpC+?= =?us-ascii?Q?/HFSoEt6vbpEDcm4wugnrRdPKWFvpp66TsJ+T+wM7cKzJnL+CcrgzRlQrUqS?= =?us-ascii?Q?uWxYsFWkkIjl9cMk6c5Mu7NI5rRRVaSsJf3/TDpJOhOdUWSgYtzgBPq8APym?= =?us-ascii?Q?QaznXNHguJYeejmZrbIYG4QelOiKdobAAySeK0ojRCFGAkDdZHWGpl+55ukp?= =?us-ascii?Q?kw9+506KFxDtS/AYDJUdf3DZi9aBTMYsG56IIn5D1os6c+WNDpyx4Fs8sOvS?= =?us-ascii?Q?Ksa5H3JVyVX3kV6dqp+OHCKFjv25SQgrZDcKYPQ6ztBCJr4t5X8JzywfpoFw?= =?us-ascii?Q?9Pp2NhwWRAA9NiRoa3o4PwFQkog+2nwb3m2pVcYAIBh9AYJNdK87+jStph6H?= =?us-ascii?Q?Paj7YiyKOgWg980EvfOG6mTq1rl2p7KwWieaazqQnnOmNF7r84/jKHnz8mqt?= =?us-ascii?Q?WTul3B2Ox3GUhatmMC2v3NwkOxaL6CW8moWiSBeGGLuYIdlP8dO3OldtS4qz?= =?us-ascii?Q?lbIcNLLbcZNPoNpoIu3gnWUJ96qSpmJbUB7Dk9twcbIm3ZOjAAc9K63c7V01?= =?us-ascii?Q?gfrFTRLXXz82BMgsYustfOwEI+8Nlaj7/ypsmmYneRM9me4j1J/wOqkktfvG?= =?us-ascii?Q?EOP4o3GeA9/SyaoY/qrwcFSjq8A/TDyL9+su38loRh3p5WKi2iRaBLR9eAQP?= =?us-ascii?Q?Sh7jZavMLdFQ+lTxAyDM8lTrOmEh5qwrbiXUrySxmojfVYzau978DB66QzIc?= =?us-ascii?Q?FjefydyT4ATkXIrsEyNOmf/7yiNvkzjV2Ityk4NP9rNJdIW5o0B10uKlELbN?= =?us-ascii?Q?8A9shMHoBdtj8sU/4QUv7mIdca36rI6mXGkx22UoJlNBKiChC+Uf23u3oxaB?= =?us-ascii?Q?dqTbspJgslvvhqHwcAEdGPXdyhg1tWmZ7AWsaWffzjAtUpfxrqNIATU7FOPv?= =?us-ascii?Q?VAWhlUV1iBaPF1WfcBC9UErivAfwxtSSFYQ6UI2k1ZW4KS5T7ySnFcTzeSdC?= =?us-ascii?Q?P5RUMXW0ywgSRcY/QyjgDbCuQzCzbactzgQjuRhqFbIkUhWMClImsUshQ4TV?= =?us-ascii?Q?hnT8vbcjVlChwdyL2kXz1gKtD7H9J1EaTOCOVEVaJaDCG30JubauYumzdvoA?= =?us-ascii?Q?GFck2R7FTrJZCiD9yRk=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60e1c5b0-31a5-467d-8147-08dbc2f19fc3 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2023 02:45:22.5744 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tvs6Jzi2VmE2Z8O/N1VsTQKqyvDL/BdcA6FrmAYzTxmGbmHELVMxCS0EKMlQzmIBWgNIJLmAothKUhuYPsZKgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5710 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5ZfxS9yVXNVOBsq2PwF4o2Xzx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=sugEfKoU; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] > -----Original Message----- > From: Mike Maslenkin > Sent: Saturday, September 30, 2023 5:59 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH 8/9] RedfishClientPkg: fix pragma pack usage > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Signed-off-by: Mike Maslenkin > --- > RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h > b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h > index 7e1bc9cefbac..9d5b10a7e909 100644 > --- a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h > +++ b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h > @@ -31,7 +31,7 @@ extern EFI_GUID gHiiToRedfishBiosFormsetGuid; > #define ID_STRING_MAX 15 > > #define ID_STRING_MAX_WITH_TERMINATOR 16 > > > > -#pragma pack() > > +#pragma pack(1) Do we need pack(1) for this structure? We can remove pack directive if we = don't need to have packed structure members. @nicklew@nvidia.com, could you= please confirm this? Thanks Abner > > > > // > > // Definiton of HII_TO_REDFISH_BIOS_VARSTORE_DATA > > @@ -44,4 +44,5 @@ typedef struct { > UINT8 Reserved; > > } HII_TO_REDFISH_BIOS_EFI_VARSTORE_DATA; > > > > +#pragma pack() > > #endif > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109248): https://edk2.groups.io/g/devel/message/109248 Mute This Topic: https://groups.io/mt/101667468/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-