public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chang, Abner" <abner.chang@amd.com>
To: Minh Nguyen <minhnguyen1@amperemail.onmicrosoft.com>,
	Minh Nguyen <minhnguyen1@os.amperecomputing.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "patches@amperecomputing.com" <patches@amperecomputing.com>,
	"nicklew@nvidia.com" <nicklew@nvidia.com>,
	"igork@ami.com" <igork@ami.com>,
	"nhi@os.amperecomputing.com" <nhi@os.amperecomputing.com>,
	"tinhnguyen@os.amperecomputing.com"
	<tinhnguyen@os.amperecomputing.com>
Subject: Re: [PATCH V3 0/5] Adding necessary changes for RedfishPkg
Date: Fri, 5 May 2023 05:45:03 +0000	[thread overview]
Message-ID: <MN2PR12MB39669D6FEBEAFC58F557A896EA729@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <32fa8d9b-251b-c258-ae20-01002fb1a539@amperemail.onmicrosoft.com>

[AMD Official Use Only - General]

Ok, because the patch in email always has format problem when apply the patch, plus I can't get the patch from group.io; could you please create a PR on your Github thus I can review patches from there.
Just let me know the PR # after you creating it.

Thanks
Abner

> -----Original Message-----
> From: Minh Nguyen <minhnguyen1@amperemail.onmicrosoft.com>
> Sent: Friday, May 5, 2023 1:35 PM
> To: Chang, Abner <Abner.Chang@amd.com>; Minh Nguyen
> <minhnguyen1@os.amperecomputing.com>; devel@edk2.groups.io
> Cc: patches@amperecomputing.com; nicklew@nvidia.com; igork@ami.com;
> nhi@os.amperecomputing.com; tinhnguyen@os.amperecomputing.com
> Subject: Re: [PATCH V3 0/5] Adding necessary changes for RedfishPkg
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Hi Abner,
> 
>   Yes, me too. I have sent the email to miki.demeter@intel.com for checking
> it.
> 
> Thanks,
> 
> Minh Nguyen
> 
> On 5/5/2023 12:03 PM, Chang, Abner wrote:
> > [AMD Official Use Only - General]
> >
> > Hi Minh,
> > I don't know why however I can't see V3 patch set on group.io. Can you see
> those patches on group.io?
> >
> > Abner
> >
> >> -----Original Message-----
> >> From: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
> >> Sent: Friday, May 5, 2023 11:58 AM
> >> To: devel@edk2.groups.io
> >> Cc: patches@amperecomputing.com; Chang, Abner
> <Abner.Chang@amd.com>;
> >> nicklew@nvidia.com; igork@ami.com; nhi@os.amperecomputing.com;
> >> tinhnguyen@os.amperecomputing.com;
> >> Minh Nguyen <minhnguyen1@os.amperecomputing.com>
> >> Subject: [PATCH V3 0/5] Adding necessary changes for RedfishPkg
> >>
> >> Caution: This message originated from an External Source. Use proper
> >> caution when opening attachments, clicking links, or responding.
> >>
> >>
> >> This patchset adds necessary changes for RedfishPkg to avoid some
> >> unexpected cases and fix compilation.
> >>
> >> Changes since v3:
> >>   + Replaced __FUNCTION__ with __func__ to be more C11 compliant.
> >> Changes since v2:
> >>   + Added "Cc:" to maintainers in commit message.
> >>   + Corrected patch format subject prefix.
> >> Changes since v1:
> >>   + Removed redundant change and change the commit message for more
> >> precise in PATCH 2/5.
> >>
> >> Nhi Pham (1):
> >>    RedfishPkg: Add missing newline character
> >>
> >> Vu Nguyen (4):
> >>    RedfishPkg: Correct variable type to prevent memory corruption
> >>    RedfishPkg: Fix condition checking of error status
> >>    RedfishPkg: Create RestEx child on selected interface
> >>    RedfishPkg: Fix compile issue on Linux
> >>
> >>   RedfishPkg/Include/Library/RestExLib.h                       |   3 +
> >>   RedfishPkg/Include/Pcd/RestExServiceDevicePath.h             |   5 +-
> >>   RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h            |   3 +-
> >>   RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c               | 153
> ++++++++----
> >> --------
> >>   RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c           |   4 +-
> >>   RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c |   3 +-
> >>   6 files changed, 73 insertions(+), 98 deletions(-)
> >>
> >> --
> >> 2.39.0

  reply	other threads:[~2023-05-05  5:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05  3:58 [PATCH V3 0/5] Adding necessary changes for RedfishPkg Minh Nguyen
2023-05-05  3:58 ` [PATCH V3 1/5] RedfishPkg: Correct variable type to prevent memory corruption Minh Nguyen
2023-05-05  3:58 ` [PATCH V3 2/5] RedfishPkg: Fix condition checking of error status Minh Nguyen
2023-05-05  3:58 ` [PATCH V3 3/5] RedfishPkg: Create RestEx child on selected interface Minh Nguyen
2023-05-05  3:58 ` [PATCH V3 4/5] RedfishPkg: Add missing newline character Minh Nguyen
2023-05-05  3:58 ` [PATCH V3 5/5] RedfishPkg: Fix compile issue on Linux Minh Nguyen
2023-05-05 22:57   ` [edk2-devel] " Pedro Falcato
2023-05-05 23:32     ` Michael D Kinney
2023-05-07  5:39     ` Minh Nguyen
2023-05-07  6:22       ` Minh Nguyen
2023-05-05  5:03 ` [PATCH V3 0/5] Adding necessary changes for RedfishPkg Chang, Abner
2023-05-05  5:35   ` Minh Nguyen
2023-05-05  5:45     ` Chang, Abner [this message]
2023-05-05  6:01       ` Minh Nguyen
2023-05-05  6:50         ` Minh Nguyen
2023-05-08 13:45           ` Chang, Abner
2023-05-09  0:46             ` Minh Nguyen
  -- strict thread matches above, loose matches on Subject: below --
2023-05-05  6:45 minhnampere
2023-05-05  7:38 ` Chang, Abner
2023-05-05  7:47   ` Minh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR12MB39669D6FEBEAFC58F557A896EA729@MN2PR12MB3966.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox