From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7224078003C for ; Tue, 19 Dec 2023 03:40:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=nQFGKmeUyHo0m7j0hHTFNP7PeiPuzq6qtXE41RkFYNg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702957217; v=1; b=aKQ1MPQzuqI1qTNTVS6t7K6W8Udty4m1iLDN5ekgdXeKJUET8Vrtsd5vXufGdnf0SHHdQHCU 1YZkOXd1Z6hVmnzjewxttAKIxujvj6bMLtUeo2fDW1H87tddFx9p5npEROI1gjBCOJVFsGYSsdI nFOz+D1vMuvtOdRLwbxW0Vpo= X-Received: by 127.0.0.2 with SMTP id 1pcwYY7687511xIl11KVOfW4; Mon, 18 Dec 2023 19:40:17 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.48]) by mx.groups.io with SMTP id smtpd.web11.4853.1702957216477111220 for ; Mon, 18 Dec 2023 19:40:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WBuRf52JPL25UVJGNMc4llnMNGVfLnaH0/bnjY4yFgQy1MUBIGivD/U4KoBPG7mUxDwupVfbnMICZsCW8wdSfx1AaKLHqImStPXA283EkoFuzm5sBiMlVoG3Aobw/V/spdbSii7jnl8cg3tVvS0eDEtrYxegCqvLRXFEBdC170m04jumhoJbqZKbI7WPoU+UWs1h6zyrwmSik+piL5Ks3P4+dnd6X/hjfd8+q//EwZM3XBhPwxfW0D6A6rzlzu+GLNzSpsyH5Bw2dC4VFT/gBjcLSFgrCEIK4eVqwHvGo6JRk5rZTUnrK8HKu5kZGTsjBbnuzjrPytpQ5myAVaVyOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xLYcnUcksSoyl7d9xyOuMDtaPFaTzuaBDUXNsddd+T0=; b=HANi45B0xqDiwtrkiBEacGaA+akuiy4cR+3Bfthyjs/gP/JIiUMEUFwnyyiNZsaL67cFQ08VxDa12sGbkLZsX+Qw1FGi9rfVzo6xIWPyaG8ysuDdmSoN7QBBjotIut9byAcTPEITKc5PzYI7eM7LMdsRA4b6vjVd6AqvcQ0xwz/N7jgujO0vyW1ERNcUWY+atxO/NHwwQsX2MW8Hlp+3Sp3flvRxbnFvGMMou47Kh5zbijS5NetUhrW0+P5XtmxWeQohe0+kkvSHnfg4DokZT8yiX/Oae/SMthAi2rRjCkWRIS3u/wa7XqegnOn3D3mO0YS4XSKYsGmaUZbghRwAtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM6PR12MB4043.namprd12.prod.outlook.com (2603:10b6:5:216::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Tue, 19 Dec 2023 03:40:14 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7091.034; Tue, 19 Dec 2023 03:40:14 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH v2 3/3] RedfishClientPkg: fix access to unitialized variable. Thread-Topic: [edk2-redfish-client][PATCH v2 3/3] RedfishClientPkg: fix access to unitialized variable. Thread-Index: AQHaMhbLYMW9mLhIBU6jMaFo4HzyCrCv9faQ Date: Tue, 19 Dec 2023 03:40:14 +0000 Message-ID: References: <20231219010023.56603-1-mike.maslenkin@gmail.com> <20231219010023.56603-4-mike.maslenkin@gmail.com> In-Reply-To: <20231219010023.56603-4-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=508ecb17-b1ef-4ef6-a442-1df3ea6e2db6;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-12-19T03:40:11Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM6PR12MB4043:EE_ x-ms-office365-filtering-correlation-id: 87b42f7d-2a30-4e35-6009-08dc0044360f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: koospVs4nFAL+0LVc2z9PQJBJrmvcY2UWdZkX6uOqHlKcH++AAi1j931GHhHn++f3y/0F5qI9Uyzu8o+MLOHm7e7cFmFFlDeKWs8IUFhAeY5kS9idbbn/lgwnIIYuqqZo8KOUxdteJGFEDNKGFYsZWz+CBEWUQa6fA1icfD1ki8vhYsoJBAU1V8LLNtBy9r/wJJb3SUNIwm4MyByL1d2N6DMY7NRsGxYuiTJHJgcbZl2E74ha4kET1f7HoGRPAlnuM0PsLvSTvT/eAG/JTl39PtkMDLveyT2j17lSq5N65PupjpSVvZUKjumOtLKF5JiQoXjeXUx7rUWp2B+PXaK5fv2PLCULMUFVL598QQ726VA29tJuYllVQ067MkEx/KQkFjqYQqA7A1rI1bnXopIVmooz49g9Uta28IImVBvZNNj6w/zA5GIGl2G0SpA5aqhCbebYF/1mRT9+Md2KVeAwVOEpobcxmo2NtbBB+V1m1n4dn/3ORStvVmCJDMX3B1xfCqpk5VXHHom1ASlr83QK57UjjzjvCpzxLMVHGydFxsOGnWi1dG2aa69KINKcpwzhYVYMNEJq3Blp2Oyq3gOA8HRx6FzjAluhhEucI8ch4ld3fbVqB/AI6961bwSj5nUN+/STodb2E6i9+8MvFejkxMh6ZupUTtIa0Y/wNdLp1c= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XoXqxAWNkjFXR9ky/QY9zsxEhEk4XXpH7agCX33Ocl2Kmho73NYMWz/IYZ/D?= =?us-ascii?Q?RtKqMJLmIq/IpxBuOZrUfsgyUKppOEea7psh+dNRDb5VX/elVlMO9vwOwUwn?= =?us-ascii?Q?FlNwSAKF7ytJ+frqJ1u7JozMWKc+rQeRFFwYhGX6MTCFQBrZlWtOmMZzeST0?= =?us-ascii?Q?hmyq6Hdv84l9usLpFnXmCzsnKVnnw160thDiTvHfTFDy2sY5nSqCz3BujyZo?= =?us-ascii?Q?Hrji+RuOjPiI3vK2HDwsHLg1flaDRZJHB5GIBPNk/0mYx5hCcCFJCAfwYjQF?= =?us-ascii?Q?VjGpJSPWyzi4RwDli8WoSqkZguD7Z4iQyjRADrneDkGrP99WzxOPBjPHRVFW?= =?us-ascii?Q?BmRYY7U/yi7hSbpyF5Mg0ibfZe1vRUoVUOf+C6u0R2DRhM0yApe8tB9aYF0K?= =?us-ascii?Q?vnDtiKOMGofD6l8dcHDeSVWVlpfgbdR0fDRTpePf8DLotahqZYR9oD4olGvP?= =?us-ascii?Q?JE8xyoQb8V1hONmDaiA7ymwCrcfvmcl/wvx0Cdk6c9/NuEZldIWnBCAYBkrd?= =?us-ascii?Q?GvbZUkBOPz3kgmyffHH/LEUdMrAYd/jlIqt43pdWO4tV1pAH1Xfyw2eqmWYt?= =?us-ascii?Q?xLju1Lm9I9SMNTVQWOFjiMf3bEgRzCy6n+n6AB72NXhp7KLdJP1cRu2/ozE1?= =?us-ascii?Q?73adJwdndb+qaDUlv67H58EzXt+X0iQAFvtqe3Hsfwx+OblnHIZzojkkhawh?= =?us-ascii?Q?z3+arej2u4o1gok502nqtJ18rECqNSJo5/DMhkc2LLHh6rDgekEi+xwAp6Bt?= =?us-ascii?Q?VNcxy2Y/knLv9QjHpOJHudH1OQ8EkJE0Si5G9j1p/0FRD9VuZvOoitYwWkwl?= =?us-ascii?Q?Wvq/lg2f7RRKFSlx55BcNMKgGmk50TOpJsmAcpLT/zry2UebV718F6+q4N4Z?= =?us-ascii?Q?BsSuSt4ayeyEVvlTZOu3MSzV0gAulLndRhXqk877e37Yg7HB7bb0RNd8yJ2d?= =?us-ascii?Q?aNzKkzwoeydIe4Yb3TJgedng1NlkQKFoxdtDGKbOAUJX/jz5quSAP5f3PcGz?= =?us-ascii?Q?jfI+yHH5XqjKpasoJbOQdZAXo1Gwi9PwgvSjdyrLMi3KeBUuSJKunF8sWZwC?= =?us-ascii?Q?VwqnMCkxvH2lFhtgJa/S49poKZMxQgfoO2uBhT6Cs/2+KEYfM8kQEq4p2eyF?= =?us-ascii?Q?z9uQw0R4Ur6C3zvXL0Um5kcl1Rvwb1E7RJgUyhHpQMDxMFCJyylyf2tnsxBx?= =?us-ascii?Q?kA8Fm8BCf8XRVv3la5U550R4b2VTS/qUXnbZiVoejowflCnM25lCdG+AfMWf?= =?us-ascii?Q?YsUXeMiC8KVIX7SVmH9QgC8bv5EInfpGgfTA+jWGBgpSQhpgzRDtQxEO/OIQ?= =?us-ascii?Q?DfNEV3ReVL7iGdejk03+oRznEHvIpzBzfsQ/QP2o+mu687KxcNI6jLDvt/RA?= =?us-ascii?Q?8nxX8xt3pkfEGh11BxIhHYqyns3mCpODsDin7X4cLgEDXG9IBgQt4o9wNcIn?= =?us-ascii?Q?qtIhvqFYG/vDNrrfJNRi9PR8FxP39KoSdeyMAs4F4MuenY91f1kX+bFtEPNm?= =?us-ascii?Q?6Xqejc3NAiB64/S+AriSW2ntwpIqDCqy9i71V7O4ZRVL1v+QR+AI+dwPGy88?= =?us-ascii?Q?ab1k1pWeN07wpIPk1i5iSCcn6uQQMU5Hm7xmvbh2?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87b42f7d-2a30-4e35-6009-08dc0044360f X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2023 03:40:14.4365 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Xcag0uQgIdgbvWNnR2R/1/Z6O0AZznmzXuBBgleR4+NSxT2YpCo620J4J9FjDjXsnIaeNbC0B5VMQg+3QEt2/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4043 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Nz1xbFG5arneVXyxIUhkH9sdx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=aKQ1MPQz; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Tuesday, December 19, 2023 9:00 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [edk2-redfish-client][PATCH v2 3/3] RedfishClientPkg: fix access= to > unitialized variable. > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > It is possible that at the time of accessing to AsciiLocation pointer > the memory is not allocated. > > Also gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) emits a warning for > this case: > > RedfishFeatureUtilityLib.c:1889:37: error: 'AsciiLocation' may be used > uninitialized in this function [-Werror=3Dmaybe-uninitialized] > *Location =3D StrAsciiToUnicode (AsciiLocation); > > Cc: Abner Chang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > Reviewed-by: Nickle Wang > > --- > .../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > index 0f0b050d7eba..01c054ae3b70 100644 > --- > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > +++ > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > @@ -1856,7 +1856,8 @@ GetEtagAndLocation ( > } > > > > if (Location !=3D NULL) { > > - *Location =3D NULL; > > + *Location =3D NULL; > > + AsciiLocation =3D NULL; > > > > if (*(Response->StatusCode) =3D=3D HTTP_STATUS_200_OK) { > > Header =3D HttpFindHeader (Response->HeaderCount, Response->Header= s, > HTTP_HEADER_LOCATION); > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112676): https://edk2.groups.io/g/devel/message/112676 Mute This Topic: https://groups.io/mt/103255138/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-