Re: [PATCH 2/3] RedfishPkg/Include: Add Redfish IPMI definitions

["Chang, Abner" <abner.chang@amd.com>]

[AMD Official Use Only - General]

I forgot to address these comments on V2. The V3 just sent for this.
Thanks
Abner

> -----Original Message-----
> From: Igor Kulchytskyy <igork@ami.com>
> Sent: Saturday, December 24, 2022 1:20 AM
> To: Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io
> Subject: RE: [EXTERNAL] [PATCH 2/3] RedfishPkg/Include: Add Redfish IPMI
> definitions
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Hi Abner,
> Please see my comments in the text below.
> Thank you,
> Igor
> 
> -----Original Message-----
> From: abner.chang@amd.com <abner.chang@amd.com>
> Sent: Friday, December 23, 2022 7:34 AM
> To: devel@edk2.groups.io
> Cc: Abner Chang <abner.chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>
> Subject: [EXTERNAL] [PATCH 2/3] RedfishPkg/Include: Add Redfish IPMI
> definitions
> 
> 
> **CAUTION: The e-mail below is from an external source. Please exercise
> caution before opening attachments, clicking links, or following guidance.**
> 
> From: Abner Chang <abner.chang@amd.com>
> 
> Add the definitions of Redfish Host Interface credential bootstrapping IPMI
> commands.
> 
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
>  .../RedfishHostInterfaceIpmi.h                | 50 +++++++++++++++++++
>  1 file changed, 50 insertions(+)
>  create mode 100644
> RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h
> 
> diff --git
> a/RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h
> b/RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h
> new file mode 100644
> index 00000000000..892b744c458
> --- /dev/null
> +++ b/RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h
> @@ -0,0 +1,50 @@
> +/** @file
> +  Redfish Host Interface IPMI command
> +
> +  Copyright (c) 2022 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
> +  SPDX-License-Identifier: BSD-2-Clause-Patent **/
> +
> +#ifndef REDFISH_HOST_INTERFACE_IPMI_H_
> +#define REDFISH_HOST_INTERFACE_IPMI_H_
> +
> +#include <Uefi.h>
> +#include <IndustryStandard/IpmiNetFnGroupExtension.h>
> +
> +#define REDFISH_IPMI_GROUP_EXTENSION                          0x52
> +#define REDFISH_IPMI_GET_BOOTSTRAP_CREDENTIALS_CMD            0x02
> +#define REDFISH_IPMI_BOOTSTRAP_CREDENTIAL_ENABLE              0xA5
> +#define REDFISH_IPMI_BOOTSTRAP_CREDENTIAL_DISABLE             0x00
> +#define REDFISH_IPMI_COMP_CODE_BOOTSTRAP_CREDENTIAL_DISABLED
> 0x80
> +
> +///
> +/// Per Redfish Host Interface Specification 1.3, The maximum lenght of
> +/// username and password is 16 characters long.
> +//
> Igor: One '/' symbol missed
> 
> +#define USERNAME_MAX_LENGTH  16
> +#define PASSWORD_MAX_LENGTH  16
> +#define USERNAME_MAX_SIZE    (USERNAME_MAX_LENGTH + 1)  // NULL
> terminator
> +#define PASSWORD_MAX_SIZE    (PASSWORD_MAX_LENGTH + 1)  // NULL
> terminator
> +
> +#pragma pack(1)
> +
> +///
> +/// The definition of IPMI command to get bootstrap account credentials
> +/// typedef struct { typedef struct {
> Igor: Duplication of typedef
> 
> +  UINT8    GroupExtensionId;
> +  UINT8    DisableBootstrapControl;
> +} IPMI_BOOTSTRAP_CREDENTIALS_COMMAND_DATA;
> +
> +///
> +/// The response data of getting bootstrap credential /// typedef
> Igor: Duplication of typedef
> 
> +typedef struct {
> +  UINT8    CompletionCode;
> +  UINT8    GroupExtensionId;
> +  CHAR8    Username[USERNAME_MAX_LENGTH];
> +  CHAR8    Password[PASSWORD_MAX_LENGTH];
> +} IPMI_BOOTSTRAP_CREDENTIALS_RESULT_RESPONSE;
> +
> +#pragma pack()
> +
> +#endif
> --
> 2.37.1.windows.1
> 
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.