From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.65]) by mx.groups.io with SMTP id smtpd.web10.195848.1672278926865440612 for ; Wed, 28 Dec 2022 17:55:27 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=rL4OovlM; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.94.65, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QlvxWP7Bt24Cdv4RfxS2C7KODtIViT2g7c8xo4HKE/3Y7FSdVxFGIpOxQJ01DfJnuZBbaMc20Ki2FVDk2Elz+0RzQ1+Ic4fuRMuREoqERQ6lqzRi+8ZKKcIz1C7L0DnYdIbhqZddxB3sVwjA/vyIpDWK0vs8LHWRx4Kl7IZTJiJX9Si/7m2z9qN01j40/Xz448MZhm26ATIIhvGdGDbuzbnd12mtQlabtMJcAmmFLx++40KIGVNdoRkioXqYJwxvcFbSwYxv/gSauztSguqDSGKL6dC6pG7bk1Ws6jjLs85KvPmuKbC5LjdSBg2CK+VKIf1N1G4faJXTlGnFa3ZoqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wrxqXNyxTG86DiIr2RkIpO6kMOetdoPoYgP3lPgEiz0=; b=h1vHGir7G9/SxEDFDJiY8vcfvkJN+ddURiXQoqwZreR5CLjZXZ7YynY6Nb5Ot3AuabS2WppoHl+uxgiUq1m1mH67yYc+mWljoQRJjHeztVKLa5tqI8VISxKgbddvUM49NXM3Y0ah57lWEnnVX9lck6wsmWpRzCyDiWaYrDrfyc6HCCOG8yIeuiaYSL9dYu2HCg9Q0U8NDwr/FDe5+ZseJH9vj7USoMfV6sKqq9ud7PNlwWNkCzIDmLgcaBH5XOs49Xv1KSxq+eBfw2o4uC23b4Wt9FliE+R9xvG84xZAtaCc/xBfwoGrQAGRb5mI+5gOm98UQR/zW098YYVGXAKhUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wrxqXNyxTG86DiIr2RkIpO6kMOetdoPoYgP3lPgEiz0=; b=rL4OovlMUoa5sfrsFaj5COLxnlV7KmkyY+dIp+GE9Iui14PT+T9sPL3xmDdHKzVd5hpUtFZr5pA4/JDCHBew7QTce9HABZ8uxbDA5APl/pGPxClNGbUO5Ey77XtA8nofnOpP71c/wzgX/BUobFmw/QA1ZjNGZcCsFydFHD6JrWk= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SA3PR12MB8021.namprd12.prod.outlook.com (2603:10b6:806:305::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16; Thu, 29 Dec 2022 01:55:23 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4%5]) with mapi id 15.20.5944.016; Thu, 29 Dec 2022 01:55:22 +0000 From: "Chang, Abner" To: Igor Kulchytskyy , "devel@edk2.groups.io" Subject: Re: [PATCH 2/3] RedfishPkg/Include: Add Redfish IPMI definitions Thread-Topic: [EXTERNAL] [PATCH 2/3] RedfishPkg/Include: Add Redfish IPMI definitions Thread-Index: AQHZFsrdBS9Hw+N8n0miAExDKoqaUq57t+cAgAhrjPA= Date: Thu, 29 Dec 2022 01:55:22 +0000 Message-ID: References: <20221223123336.2014-1-abner.chang@amd.com> <20221223123336.2014-3-abner.chang@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-12-29T01:55:21Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=b3030d0a-b394-46fe-8c6b-84867ed2cb2e; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SA3PR12MB8021:EE_ x-ms-office365-filtering-correlation-id: 1c1062f9-0889-482f-c658-08dae93fbf52 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SclSj+QLZ5nridLODkN2fFddGUFS1eduj28M2L9q0vr9svq6dsfqklMJghf2QbKIucAQhhSYRfa1HexEN84KMNQ2qTopyFLeeT3jjdKGdH7zKDy/K6g2eNvWgwVoJ6yAthGUbQwY0dyNTSsAoTxpbKPiRcbjK5tWrZxF2NHFsai5np1aMdIRPZstiOhd/RerJoyQPZHtuwKka68++5zZfMKonTsfqE8jCmwxmlAzK9jhITdWzqBJBMOTsqffWnnmjxvr5ycfBx67kTttDPURxabXMxlW0YsmJ3rQX7pPEW8DqmxnisJ/LI7eyayfbFhXBjrL6o9e9ablkvqZ1oWdpT61TzLjW9Gcrv4D2dHzfnWuIAB6sd1wIy/W90hBVlEgDbLYh71VxcEe2/hzOBkRs8Mdgp8tA4gDxvbKdp5G6a3QS2Ajd5h5u7hdzDB+K2BXqjsRXA1uwLFhEgSJiDH4oBxpcNWDQe1Mm73vVcA7p6LnP3k9kUTdiHSe/eScUg1MWxcxzoaYJbnCzfaPUwGyg0pE7nIBfHYZZYJABF5kEQpULTB7EAEqKGPRFftVeCnhq5qiviSzvjuc9ewtt8W3aUySx1L/uWf90rmsSuW7pvWc40VtMJ3DmhwnwJGHE9StFdtPqYwd8EjMfyfVCVSaSUR206fax+cWHZaB4B6lZ1YhV+Wbr6puf3gZjl5Cqk8VHExVp1qV8F90zl8PPr+vYA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(136003)(366004)(376002)(346002)(39860400002)(451199015)(83380400001)(5660300002)(2906002)(7696005)(52536014)(8936002)(122000001)(66946007)(64756008)(66446008)(66476007)(8676002)(66556008)(38100700002)(76116006)(40140700001)(71200400001)(55016003)(53546011)(38070700005)(186003)(33656002)(26005)(9686003)(316002)(41300700001)(110136005)(6506007)(478600001)(86362001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EtOjV+8M0K1cKb/2V2tFv5CEQfzG6yJWHk7Z0OspNsOAL7fqJL3hKN5gqZqv?= =?us-ascii?Q?zx7eh5wqia61wIwQ4rmOHtGoM9JP7smFuv0dussBgDvd3vON6xa08+iNLxfz?= =?us-ascii?Q?oiPSeofNIW4IJFlGsn1VhbFG0iCONPCLEYTcG6OJHNdEmbAXMhQy4ZadIT4m?= =?us-ascii?Q?1JdioQgNMDyR/V25khGh5Zgxw7oxQyeYuFWv0ExNoBFgJybLq1NPcsMYqHIF?= =?us-ascii?Q?WzLUB/J9twLdv6fXqwmnGOGkbw8KkYo+FG6Yqy2n+zcVZ0K6fKQFryiTSdy3?= =?us-ascii?Q?5ngf/164RpzMRpwrT2S7HQUmVwv3VgOWMt+amuckbpZ6BDCd2JlGjJXdI15a?= =?us-ascii?Q?NXqEmIxtOm6xe/NIIvox8LuuC1Ba1CvEye6/WpY5yx2PB4dhalMtw8KNC/NT?= =?us-ascii?Q?HpXtRm/DqqTvSY8icK65vx/GGL4J48Po3LRSoDjiRXIMaqJ7NC3GySec6poA?= =?us-ascii?Q?+HchuVJBa86ywnbXWKV51zsUGq/Ks3TDQkFKrGeNrc7qccxJFB/ELKdb5fkr?= =?us-ascii?Q?CU/wW03hmCk+QyLmdbndenXMoninsVuSub99JC3Y3GqQIrmY+MUBk9GwYNS4?= =?us-ascii?Q?Fov/NyCrANWxZ/WiufndhjYTL4a2Xm2xIUcDFNTMqcZlrUxFCaTZU6K6Hoov?= =?us-ascii?Q?iJ50Z79LDAGQNzzRpmtBM7Qic9n1mhyYxiA6BegMm5GGdtwQle7ZFNb+QCDB?= =?us-ascii?Q?qzAkuDUsamO55lsR1GDL+pRz/l2B1YyW5V00eCuJte3J1sh0hx3FmhzdTcJK?= =?us-ascii?Q?AoTgiTuJAgHbor9A3B9ugi2P0QGLR13ZzfwmvsAZiV98oKQHAdCBujjh4aWf?= =?us-ascii?Q?bpVodChzy2tjm82Ycft/gtMnEzV1+Aoqk6jY66iyReS8I//j0+JiZ4zdmZAW?= =?us-ascii?Q?wM01BXnQZmWRXw7KFO/ba24j08RttyxmwCAPyQWUu5yagOgSedhJPkBlaJw1?= =?us-ascii?Q?LeyTdYBEmeXOSW03lxlG6rXXfopjKFz196AqffG5Ng9D33uKHNCIw5x1yxvx?= =?us-ascii?Q?2TavDITe7UybbAsvJ01rjTDdsijtUdys7BYscgUllnMbwvEvUQ4wIsiKYV3t?= =?us-ascii?Q?y/l4cWnwKhqvFo88QXlu43WBD3qz+uxdgqC//bAPxjyxmtmp0xgPXJsRdJ2U?= =?us-ascii?Q?G3OTFnfHJUqBVgyHuEw01bLI9utPkJJTGglelfQeZLuu10zz/KcJb3Frx1nk?= =?us-ascii?Q?h5Iu2/3g14UQPL9G1T1fttExJDBe5j8popuysWOu64Xuc5p+JNdEi4he9Awr?= =?us-ascii?Q?zO9C2+Nk3rEMrNTVtnQJr/pbJa4I3MCOCHVcOPorZ8iRPkpxgA/pZSIqnctL?= =?us-ascii?Q?098HOLgTFJn5CS/cXMwu/+wsit0xr11A2Q/aLOh6eBHXzm3QIWV68JwcYU6M?= =?us-ascii?Q?wameQBWdoA6K3O0mVzGqrj+0qQqcDNQjQb6AG19SvdqCO6rvtCrqZCckCZr7?= =?us-ascii?Q?WKEAyrfaSgJF9jRDnhEXtMtQQXYdEbQHt9c12ym4hH01ORPajdamrU5dElZl?= =?us-ascii?Q?dqRE4uEtjsacLeLsdoyVTE5rT29QozL0mIFMgzA7arZdM2+xIiAZSAbO2R3f?= =?us-ascii?Q?Y6F/Cc+7rrFRhPvaDGMznHHcAbXvpVSDh8LIFavy?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c1062f9-0889-482f-c658-08dae93fbf52 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2022 01:55:22.7805 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YSRsedzAw+rrrGx1q2bEa1n64Oxg2NO9ai6HRa8LXnpo+hYMDVn+TbvkAmp+RhhP6EGVe/8R4H7dB8Z1/cr4EA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB8021 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] I forgot to address these comments on V2. The V3 just sent for this. Thanks Abner > -----Original Message----- > From: Igor Kulchytskyy > Sent: Saturday, December 24, 2022 1:20 AM > To: Chang, Abner ; devel@edk2.groups.io > Subject: RE: [EXTERNAL] [PATCH 2/3] RedfishPkg/Include: Add Redfish IPMI > definitions >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > Hi Abner, > Please see my comments in the text below. > Thank you, > Igor >=20 > -----Original Message----- > From: abner.chang@amd.com > Sent: Friday, December 23, 2022 7:34 AM > To: devel@edk2.groups.io > Cc: Abner Chang ; Igor Kulchytskyy > > Subject: [EXTERNAL] [PATCH 2/3] RedfishPkg/Include: Add Redfish IPMI > definitions >=20 >=20 > **CAUTION: The e-mail below is from an external source. Please exercise > caution before opening attachments, clicking links, or following guidance= .** >=20 > From: Abner Chang >=20 > Add the definitions of Redfish Host Interface credential bootstrapping IP= MI > commands. >=20 > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > --- > .../RedfishHostInterfaceIpmi.h | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 > RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h >=20 > diff --git > a/RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h > b/RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h > new file mode 100644 > index 00000000000..892b744c458 > --- /dev/null > +++ b/RedfishPkg/Include/IndustryStandard/RedfishHostInterfaceIpmi.h > @@ -0,0 +1,50 @@ > +/** @file > + Redfish Host Interface IPMI command > + > + Copyright (c) 2022 NVIDIA CORPORATION & AFFILIATES. All rights reserve= d. > + SPDX-License-Identifier: BSD-2-Clause-Patent **/ > + > +#ifndef REDFISH_HOST_INTERFACE_IPMI_H_ > +#define REDFISH_HOST_INTERFACE_IPMI_H_ > + > +#include > +#include > + > +#define REDFISH_IPMI_GROUP_EXTENSION 0x52 > +#define REDFISH_IPMI_GET_BOOTSTRAP_CREDENTIALS_CMD 0x02 > +#define REDFISH_IPMI_BOOTSTRAP_CREDENTIAL_ENABLE 0xA5 > +#define REDFISH_IPMI_BOOTSTRAP_CREDENTIAL_DISABLE 0x00 > +#define REDFISH_IPMI_COMP_CODE_BOOTSTRAP_CREDENTIAL_DISABLED > 0x80 > + > +/// > +/// Per Redfish Host Interface Specification 1.3, The maximum lenght of > +/// username and password is 16 characters long. > +// > Igor: One '/' symbol missed >=20 > +#define USERNAME_MAX_LENGTH 16 > +#define PASSWORD_MAX_LENGTH 16 > +#define USERNAME_MAX_SIZE (USERNAME_MAX_LENGTH + 1) // NULL > terminator > +#define PASSWORD_MAX_SIZE (PASSWORD_MAX_LENGTH + 1) // NULL > terminator > + > +#pragma pack(1) > + > +/// > +/// The definition of IPMI command to get bootstrap account credentials > +/// typedef struct { typedef struct { > Igor: Duplication of typedef >=20 > + UINT8 GroupExtensionId; > + UINT8 DisableBootstrapControl; > +} IPMI_BOOTSTRAP_CREDENTIALS_COMMAND_DATA; > + > +/// > +/// The response data of getting bootstrap credential /// typedef > Igor: Duplication of typedef >=20 > +typedef struct { > + UINT8 CompletionCode; > + UINT8 GroupExtensionId; > + CHAR8 Username[USERNAME_MAX_LENGTH]; > + CHAR8 Password[PASSWORD_MAX_LENGTH]; > +} IPMI_BOOTSTRAP_CREDENTIALS_RESULT_RESPONSE; > + > +#pragma pack() > + > +#endif > -- > 2.37.1.windows.1 >=20 > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by= their > designee. If the reader of this message is not the intended recipient, yo= u are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission.