public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: Nickle Wang <nicklew@nvidia.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Igor Kulchytskyy <igork@ami.com>, Nick Ramirez <nramirez@nvidia.com>
Subject: Re: [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller
Date: Thu, 26 Oct 2023 06:09:57 +0000	[thread overview]
Message-ID: <MN2PR12MB3966A382F12AF6F9CB1F6FCCEADDA@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231024083944.16275-1-nicklew@nvidia.com>

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Tuesday, October 24, 2023 4:40 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> Subject: [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Call Ex interface to get HTTP headers and return to caller.
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> ---
>  RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c
> b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c
> index f4045044829a..5e06d516ba84 100644
> --- a/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c
> +++ b/RedfishPkg/PrivateLibrary/RedfishLib/RedfishLib.c
> @@ -356,7 +356,7 @@ RedfishGetByUri (
>
>    ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE));
>
> -  JsonValue            = getUriFromService (RedfishService, Uri, &RedResponse-
> >StatusCode);
> +  JsonValue            = getUriFromServiceEx (RedfishService, Uri, &RedResponse-
> >Headers, &RedResponse->HeaderCount, &RedResponse->StatusCode);
>    RedResponse->Payload = createRedfishPayload (JsonValue, RedfishService);
>
>    //
> @@ -498,10 +498,12 @@ RedfishPatchToUri (
>
>    ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE));
>
> -  JsonValue = (EDKII_JSON_VALUE)patchUriFromService (
> +  JsonValue = (EDKII_JSON_VALUE)patchUriFromServiceEx (
>                                    RedfishService,
>                                    Uri,
>                                    Content,
> +                                  &(RedResponse->Headers),
> +                                  &(RedResponse->HeaderCount),
>                                    &(RedResponse->StatusCode)
>                                    );
>
> @@ -661,12 +663,14 @@ RedfishPostToUri (
>
>    ZeroMem (RedResponse, sizeof (REDFISH_RESPONSE));
>
> -  JsonValue = (EDKII_JSON_VALUE)postUriFromService (
> +  JsonValue = (EDKII_JSON_VALUE)postUriFromServiceEx (
>                                    RedfishService,
>                                    Uri,
>                                    Content,
>                                    ContentSize,
>                                    ContentType,
> +                                  &(RedResponse->Headers),
> +                                  &(RedResponse->HeaderCount),
>                                    &(RedResponse->StatusCode)
>                                    );
>
> --
> 2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110076): https://edk2.groups.io/g/devel/message/110076
Mute This Topic: https://groups.io/mt/102154017/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-10-26  6:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24  8:39 [edk2-devel] [PATCH 3/3] RedfishPkg/RedfishLib: return HTTP headers to caller Nickle Wang via groups.io
2023-10-26  6:09 ` Chang, Abner via groups.io [this message]
2023-10-26 12:49   ` Igor Kulchytskyy via groups.io
2023-10-26 12:58     ` Nickle Wang via groups.io
2023-10-26 13:09       ` Igor Kulchytskyy via groups.io
2023-10-26 13:20         ` Nickle Wang via groups.io
2023-10-26 13:30           ` Igor Kulchytskyy via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR12MB3966A382F12AF6F9CB1F6FCCEADDA@MN2PR12MB3966.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox