From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C43A37803CE for ; Mon, 2 Oct 2023 02:25:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wqfCl0+XpZU+IkTYXtFF5RrawLDyaf6qFjqC42SOPg0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696213507; v=1; b=BIet3s0t/6OSz8nEVanE4k71Y3/wo4XIQPEt5tozA9xB+Y+P2xI62pFFGyG9gzw3mstLLccs +Is/XVpQeZrmk23cwPrfXThZmFllEvVWc7IzJdc2Afzeb69O9LC9rWsD6Z6eRxsF7s/96PONIFY jRTcuqmw2BWZYVAMm/g1JyaI= X-Received: by 127.0.0.2 with SMTP id 37hEYY7687511xjgrdruXr7J; Sun, 01 Oct 2023 19:25:07 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.70]) by mx.groups.io with SMTP id smtpd.web11.73657.1696213506787880511 for ; Sun, 01 Oct 2023 19:25:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XZED1CK8HrHCvPTm9NAUPJJTfxwSCS6WTBGweJPiHt40WMD3id0NcqiTGO9OP85U0cW0o+1Q1mcQqxwDgbLwBNF4mxRZWftLGZ6SwWVAhXD0Qw63T0gbZq56318QyT5FfhEuHtYpXFXbxooBznJ8hAGCYTwGNIpNn0VaTz5h78zzKbSo2eHceBh3qp6BwPcRD0ebh9mo7gNdD9mxZtcYCLSQxGSyEp7svLZULfs5cTSKQ6XfZ9MNqjr+WHUkiaFcz9bptjQj8C02diQAaEBHAih7f+J7SrjVsaW0Pl8Jd07Ncmx5cMwBy+Emc6Q8lbOV1msVxeiObb6sbqKfOkVJmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LKZdlTmT1mlAl0YmBU/eKNJh/i/Y9IklcvQTTxBKiL4=; b=GdfjQAuO0hIJL7QOu6vrFDt5MPOpovewl3hB6DsBhStqSUmA5cy0ZF9kUlmkTaGkO5sX1WjX+7aIouRMzj+PIYYd3YN/8GLLh8rNO42PthJ/rj45yXCLxnVbxXyKlXqzRkhKefa2rd9vxPQ4jJSgQtkWvuv2q5WGS0WFFuul4mxz4e7qcKHbBABH35RC3vSUwz6suGHSZ0ie5UwcSDPU55des7Uk1wqtTDSzUpKiUWfVZSjklWfVCKIkDiSo+qif4YhMBk/FlNN8yqyMmYt5wE51ZkCkXKxqeaTstnMQqQeUX6INIMoTzJj8eveAccfs1Uuiu5Vwf71C/YsffSiffg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SJ2PR12MB8036.namprd12.prod.outlook.com (2603:10b6:a03:4c1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.25; Mon, 2 Oct 2023 02:25:04 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02%5]) with mapi id 15.20.6838.029; Mon, 2 Oct 2023 02:25:04 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH 4/9] RedfishClientPkg: RedfishFeatureUtilityLib: fix memory leaks Thread-Topic: [PATCH 4/9] RedfishClientPkg: RedfishFeatureUtilityLib: fix memory leaks Thread-Index: AQHZ8yA4tKvVYc4QIUe7ZXMeAdLwBbA1yQdw Date: Mon, 2 Oct 2023 02:25:03 +0000 Message-ID: References: <20230929215915.46616-1-mike.maslenkin@gmail.com> <20230929215915.46616-5-mike.maslenkin@gmail.com> In-Reply-To: <20230929215915.46616-5-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=60e15f7f-8d47-4368-bfc3-0efd1e990e9c;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-02T02:24:58Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SJ2PR12MB8036:EE_ x-ms-office365-filtering-correlation-id: 961a7a81-9c7e-4383-2c54-08dbc2eec96d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Pg/Z8LJBMKOyrpKX9+ELCfLOaBm38LZTXU+bxOGBr9w1mnFdPZwT1GEbe8GQJ1rUhg0H1Pw50dUUJ4M9YgpastxxbYi+YJN9BILSXPQWoh39EFWrDeW10m2FENFk4hbBG1XYOG5h0NUQaI+YTj4hX2cjQelAy6xm3sEU7/efqFD9w3FvcAr3IzpiFG80RYP8Outr2H9+9+7nODuUPiYPK32dwYizgzE6BOqZLyAQwN7FcIyYj2jcLlvskR0mn+aegiY84l55hqfBPZY8p8Q9OizEgPP/blnzpNFkq241PZFf6QfoWfuP7M/fTtHvcGe/SBFmOIKCZceHxSkdFTPorpRimPIxJ6jZ5oQjxaYlEpXADRpn9OVHmfYLocxgKXloSk0DP1AgrBjTVjOIuooe4sFB+of6AQJsr+jRxOYJMKKACMVGYxZl8d2gWGeTefZWzSmpMACglk7C/niTKV8GLtKxt0YmSmrJDWnHwgVcXmx+qnvBY+goXXfarIsRsbrvAmvpWpYo/aJlOqALdaVfzISD3+er5uXTnrbX3vnLenAxtOUKUwz+sF/HuFnC41VXpcPTl/zLhiifcAUMjxWYpXZf9VBeQ6qaZjc7cqbfKKUpwj4XwbKZlMP0SRbfdnXu x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?a5/yv/EKAJniFpffe9ELmEjV4mh+oPeVdo91HQ8W9LOvTy3vVUM8ZeMpaMUF?= =?us-ascii?Q?6oDS6X3H7eNTtsmdj7h5tXRSRWl+/DPmJR8yh3t6HzW5IE05zWSEuB3J7HLS?= =?us-ascii?Q?/dmMAHS465mLGdMQCpOQjcOKT1+vQmIpp+G8KMYsoLHYsnt/9TsH8VCKniK+?= =?us-ascii?Q?fLWmpBFAbCNJTukwGVg1Td3XkcEUNM0Br0visrDhB2F95YpZY/bEu0vWHaRM?= =?us-ascii?Q?16Hexpgqd9ksEctkcs2yBSzxysn2pUjnGp6y6Rgc/1iL7+7WtfvE/h6nmiAt?= =?us-ascii?Q?O3n2nbkaTALkG9eO4aGLdLdwAhK76ZYoFeS7Z+AZ6AGQwST9oIS8W+WP0Sv+?= =?us-ascii?Q?LXOkehYPGttyd9JHsvW1VX+LpBCr6fbruEaNqI+uT4/uoPYZOB7ze3xeUtN6?= =?us-ascii?Q?XbSOOzNXSJJjfTKSiXoVuIFWmuhIvWfuovZkf1ksQ08LfLQ+BDd2iGulBlAv?= =?us-ascii?Q?qDOu5qNyuOxHdX2ee0BG9a5zTb+kGP/Yd2Vk2u9NRZ4jRcTztvPD7k87Wlqm?= =?us-ascii?Q?Rn/je000NXZ917o/ULSwpH0dJ+DyZnO1Pqnux2ej4g9XnCUJxdvOC7tiHbQA?= =?us-ascii?Q?bSHDe5epJmrWidxFG3BGgqZ/uSlvSWoKRZFc4gHY1dY4ff7nLxNZZAdie3iZ?= =?us-ascii?Q?0AeLfaM3VhBzYeWTtSNoI7D6lGxw5fuwYZUA/BncydVDmRc93snGUIXeNOOr?= =?us-ascii?Q?Cf/YXWluZUaMkVNswyz47Fb3sKb23qITKmtawBQb9EU/SBucd1C5j9G547sw?= =?us-ascii?Q?XVyBrI/OJX1R+v+oLPmAbfQRFfcxXravDi7vmS87Lpt+gUmS4p/AkLVxp7he?= =?us-ascii?Q?zGomeqJiFqaSBZz3OUrYfP7JafGn0tWmcOIICbe5K2IAbda+tessBy6N01ms?= =?us-ascii?Q?PkxS/lG/+Xoi2U9S18+5wpO1NOwFjqluPZzt4VcZuwIIaPZc01IthmKeMrRo?= =?us-ascii?Q?c30PxtW0B37J5V9mmgrJTNOgqpg2+I5zfcKbzFDE8zJzsLtttWARuQmUUXur?= =?us-ascii?Q?AEd9DO/OHAJPDUgH4jdPG4EHrRu1eBAUfX3Bko/ZgRpFToAaass+y9nrrmhU?= =?us-ascii?Q?h1+RETz0VAMQkLdtuskRlnOvFOPVM7qBTor8ROU+6iIQ8bF0UrDPLdy7BZdT?= =?us-ascii?Q?r68eUg8+aQsHTJ+GEnW7rtt+/DpoJEBCCIbSO2ZFCOL0IsNgHvxJnhVkbEqU?= =?us-ascii?Q?0V3eQ44aLIuPbemC3ECwQBOdaJ184kt45ChWsFEa7yeRPZ9S/zLValaE0uIn?= =?us-ascii?Q?ItkUrLcPZ42EDrDQFHvLjzTMyjWvIVnI6FF3zVHbGY0XB2aJKiXcSr4Ns2vu?= =?us-ascii?Q?hMy8lRKiBpvOG4s9xhzmJDpMmia7wFLGJ59QHXyuKFa4NMV5QLrWRGfffKSe?= =?us-ascii?Q?GiaEPa0ZXhYdEUeWwFcmYKg8EmCZZDHafHIL4XcMVlt/8U1Ptkw3tPAfWzGK?= =?us-ascii?Q?MQHl7QD+zgkO0j95lOfEclyJ8CYpk1MzffrNq6H/XB0nUBSwWcwwlzOEN0oG?= =?us-ascii?Q?sZGjbEYft7MN6g3xUWj0NQm5RMEs1esQpy4UOUrx2rRG1uwp31KBJHH9+KB0?= =?us-ascii?Q?h+c3iadGsc5yXvubHtI=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 961a7a81-9c7e-4383-2c54-08dbc2eec96d X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2023 02:25:04.0112 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: luJnBFYX/GJBl9nbhRco5v7rXvPZPlFmtIbEa+vKJFnzWa9aeJcYERyrhYlW8p81clqeFTKXwiiH84OmFgfK2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8036 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 37FMVfQcIZTMEYshHRYZ0VJsx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=BIet3s0t; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Saturday, September 30, 2023 5:59 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH 4/9] RedfishClientPkg: RedfishFeatureUtilityLib: fix memo= ry > leaks > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Signed-off-by: Mike Maslenkin > --- > .../RedfishFeatureUtilityLib.c | 30 +++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > index 35e342c817b7..8fa1dc2c3535 100644 > --- > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > +++ > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > @@ -515,6 +515,7 @@ ApplyFeatureSettingsVagueType ( > Status =3D UnicodeStrToAsciiStrS (ConfigureLang, ConfigureLangAscii, S= trLen > (ConfigureLang) + 1); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, Convert the configureLang of vague key of > %a.%a %s failed: %r\n", __func__, Schema, Version, ConfigureLang, Status)= ); > > + FreePool (ConfigureLangAscii); > > return Status; > > } > > > > @@ -1972,6 +1973,7 @@ RedfishGetUri ( > // > > if (*Target =3D=3D '\0') { > > DEBUG ((DEBUG_ERROR, "%a, invalid format: %s\n", __func__, > ConfigLang)); > > + FreePool (ResultStr); > > return NULL; > > } > > > > @@ -1983,6 +1985,7 @@ RedfishGetUri ( > TempStrSize =3D (ConfigLangLen - RemainingLen + 1) * sizeof (CHAR16= ); > > TempStr =3D AllocateCopyPool (TempStrSize, Head); > > if (TempStr =3D=3D NULL) { > > + FreePool (ResultStr); > > return NULL; > > } > > > > @@ -1996,6 +1999,8 @@ RedfishGetUri ( > ); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, Can not find: %s\n", __func__, TempStr))= ; > > + FreePool (ResultStr); > > + FreePool (TempStr); > > return NULL; > > } > > > > @@ -2102,10 +2107,14 @@ GetConfigureLang ( > > > Status =3D AsciiStrToUnicodeStrS (Uri, UnicodeUri, StringSize); > > if (EFI_ERROR (Status)) { > > + FreePool (UnicodeUri); > > return NULL; > > } > > > > ConfigLang =3D RedfishGetConfigLanguage (UnicodeUri); > > + > > + FreePool (UnicodeUri); > > + > > if (ConfigLang =3D=3D NULL) { > > return NULL; > > } > > @@ -2117,11 +2126,14 @@ GetConfigureLang ( > StringSize =3D StrSize (ConfigLang) + ((AsciiStrLen (PropertyName) + 1= ) * sizeof > (CHAR16)); > > ResultStr =3D AllocatePool (StringSize); > > if (ResultStr =3D=3D NULL) { > > + FreePool (ConfigLang); > > return NULL; > > } > > > > UnicodeSPrint (ResultStr, StringSize, L"%s/%a", ConfigLang, PropertyNa= me); > > > > + FreePool (ConfigLang); > > + > > return ResultStr; > > } > > > > @@ -2296,9 +2308,12 @@ GetPropertyStringValue ( > Status =3D RedfishPlatformConfigGetValue (Schema, Version, > ConfigureLangBuffer, &RedfishValue); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, %a.%a query current setting for %s failed: > %r\n", __func__, Schema, Version, ConfigureLangBuffer, Status)); > > + FreePool (ConfigureLangBuffer); > > return NULL; > > } > > > > + FreePool (ConfigureLangBuffer); > > + > > if (RedfishValue.Type !=3D RedfishValueTypeString) { > > DEBUG ((DEBUG_ERROR, "%a, %a.%a %s value is not string type\n", > __func__, Schema, Version, ConfigureLang)); > > return NULL; > > @@ -2354,9 +2369,12 @@ GetPropertyNumericValue ( > Status =3D RedfishPlatformConfigGetValue (Schema, Version, > ConfigureLangBuffer, &RedfishValue); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, %a.%a query current setting for %s failed: > %r\n", __func__, Schema, Version, ConfigureLangBuffer, Status)); > > + FreePool (ConfigureLangBuffer); > > return NULL; > > } > > > > + FreePool (ConfigureLangBuffer); > > + > > if (RedfishValue.Type !=3D RedfishValueTypeInteger) { > > DEBUG ((DEBUG_ERROR, "%a, %a.%a %s value is not numeric type\n", > __func__, Schema, Version, ConfigureLang)); > > return NULL; > > @@ -2416,9 +2434,12 @@ GetPropertyBooleanValue ( > Status =3D RedfishPlatformConfigGetValue (Schema, Version, > ConfigureLangBuffer, &RedfishValue); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, %a.%a query current setting for %s failed: > %r\n", __func__, Schema, Version, ConfigureLangBuffer, Status)); > > + FreePool (ConfigureLangBuffer); > > return NULL; > > } > > > > + FreePool (ConfigureLangBuffer); > > + > > if (RedfishValue.Type !=3D RedfishValueTypeBoolean) { > > DEBUG ((DEBUG_ERROR, "%a, %a.%a %s value is not boolean type\n", > __func__, Schema, Version, ConfigureLang)); > > return NULL; > > @@ -2517,9 +2538,12 @@ GetPropertyStringArrayValue ( > Status =3D RedfishPlatformConfigGetValue (Schema, Version, > ConfigureLangBuffer, &RedfishValue); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, %a.%a query current setting for %s failed: > %r\n", __func__, Schema, Version, ConfigureLangBuffer, Status)); > > + FreePool (ConfigureLangBuffer); > > return NULL; > > } > > > > + FreePool (ConfigureLangBuffer); > > + > > if (RedfishValue.Type !=3D RedfishValueTypeStringArray) { > > DEBUG ((DEBUG_ERROR, "%a, %a.%a %s value is not string array type\n"= , > __func__, Schema, Version, ConfigureLang)); > > return NULL; > > @@ -2588,9 +2612,12 @@ GetPropertyNumericArrayValue ( > Status =3D RedfishPlatformConfigGetValue (Schema, Version, > ConfigureLangBuffer, &RedfishValue); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, %a.%a query current setting for %s failed: > %r\n", __func__, Schema, Version, ConfigureLangBuffer, Status)); > > + FreePool (ConfigureLangBuffer); > > return NULL; > > } > > > > + FreePool (ConfigureLangBuffer); > > + > > if (RedfishValue.Type !=3D RedfishValueTypeIntegerArray) { > > DEBUG ((DEBUG_ERROR, "%a, %a.%a %s value is not string array type\n"= , > __func__, Schema, Version, ConfigureLang)); > > return NULL; > > @@ -2659,9 +2686,12 @@ GetPropertyBooleanArrayValue ( > Status =3D RedfishPlatformConfigGetValue (Schema, Version, > ConfigureLangBuffer, &RedfishValue); > > if (EFI_ERROR (Status)) { > > DEBUG ((DEBUG_ERROR, "%a, %a.%a query current setting for %s failed: > %r\n", __func__, Schema, Version, ConfigureLangBuffer, Status)); > > + FreePool (ConfigureLangBuffer); > > return NULL; > > } > > > > + FreePool (ConfigureLangBuffer); > > + > > if (RedfishValue.Type !=3D RedfishValueTypeBooleanArray) { > > DEBUG ((DEBUG_ERROR, "%a, %a.%a %s value is not string array type\n"= , > __func__, Schema, Version, ConfigureLang)); > > return NULL; > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109245): https://edk2.groups.io/g/devel/message/109245 Mute This Topic: https://groups.io/mt/101667463/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-