public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 0/2][edk2-redfish-client] fix trivial misprint
@ 2023-07-03 21:37 Mike Maslenkin
  2023-07-03 21:37 ` [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__ Mike Maslenkin
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Mike Maslenkin @ 2023-07-03 21:37 UTC (permalink / raw)
  To: devel; +Cc: abner.chang, nicklew, igork, Mike Maslenkin

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__
  2023-07-03 21:37 [PATCH 0/2][edk2-redfish-client] fix trivial misprint Mike Maslenkin
@ 2023-07-03 21:37 ` Mike Maslenkin
  2023-07-04 13:14   ` Nickle Wang
  2023-07-05  2:38   ` Chang, Abner
  2023-07-03 21:37 ` [PATCH 2/2][edk2-redfish-client] Tools: fix script name in README Mike Maslenkin
  2023-07-05  2:39 ` [PATCH 0/2][edk2-redfish-client] fix trivial misprint Chang, Abner
  2 siblings, 2 replies; 8+ messages in thread
From: Mike Maslenkin @ 2023-07-03 21:37 UTC (permalink / raw)
  To: devel; +Cc: abner.chang, nicklew, igork, Mike Maslenkin

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
---
 .../ComputerSystemCollectionDxe/ComputerSystemCollectionDxe.c   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCollectionDxe.c b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCollectionDxe.c
index 3ba2529c9cea..8f2054e1e161 100644
--- a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCollectionDxe.c
+++ b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCollectionDxe.c
@@ -44,7 +44,7 @@ HandleResource (
   // Check and see if this is target resource that we want to handle.
   // Some resource is handled by other provider so we have to make sure this first.
   //
-  DEBUG ((REDFISH_DEBUG_TRACE, "%s Identify for %s\n", __func__, Uri));
+  DEBUG ((REDFISH_DEBUG_TRACE, "%a Identify for %s\n", __func__, Uri));
   ConfigLang = RedfishGetConfigLanguage (Uri);
   if (ConfigLang == NULL) {
     Status = EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Private->InformationExchange);
-- 
2.32.0 (Apple Git-132)


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/2][edk2-redfish-client] Tools: fix script name in README
  2023-07-03 21:37 [PATCH 0/2][edk2-redfish-client] fix trivial misprint Mike Maslenkin
  2023-07-03 21:37 ` [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__ Mike Maslenkin
@ 2023-07-03 21:37 ` Mike Maslenkin
  2023-07-04 13:15   ` Nickle Wang
  2023-07-05  2:38   ` Chang, Abner
  2023-07-05  2:39 ` [PATCH 0/2][edk2-redfish-client] fix trivial misprint Chang, Abner
  2 siblings, 2 replies; 8+ messages in thread
From: Mike Maslenkin @ 2023-07-03 21:37 UTC (permalink / raw)
  To: devel; +Cc: abner.chang, nicklew, igork, Mike Maslenkin

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
---
 Tools/Redfish-Profile-Simulator/README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Tools/Redfish-Profile-Simulator/README.md b/Tools/Redfish-Profile-Simulator/README.md
index 660938f8805d..d71c1bb0bbe2 100644
--- a/Tools/Redfish-Profile-Simulator/README.md
+++ b/Tools/Redfish-Profile-Simulator/README.md
@@ -32,7 +32,7 @@ Copyright 2016-2018 Distributed Management Task Force, Inc. All rights reserved.
 
 ## Usage
 
-* ` python redfishProfileSimulatorMain.py [options]`
+* ` python redfishProfileSimulator.py [options]`
 * `[Options]`:
 
         -V,  --Version,--- the program version
-- 
2.32.0 (Apple Git-132)


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__
  2023-07-03 21:37 ` [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__ Mike Maslenkin
@ 2023-07-04 13:14   ` Nickle Wang
  2023-07-05  2:38   ` Chang, Abner
  1 sibling, 0 replies; 8+ messages in thread
From: Nickle Wang @ 2023-07-04 13:14 UTC (permalink / raw)
  To: Mike Maslenkin, devel@edk2.groups.io; +Cc: abner.chang@amd.com, igork@ami.com


Reviewed-by: Nickle Wang <nicklew@nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Tuesday, July 4, 2023 5:38 AM
> To: devel@edk2.groups.io
> Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for
> output __func__
> 
> External email: Use caution opening links or attachments
> 
> 
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
>  .../ComputerSystemCollectionDxe/ComputerSystemCollectionDxe.c   | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo
> llectionDxe.c
> b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo
> llectionDxe.c
> index 3ba2529c9cea..8f2054e1e161 100644
> ---
> a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo
> llectionDxe.c
> +++
> b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSystemCo
> llectionDxe.c
> @@ -44,7 +44,7 @@ HandleResource (
>    // Check and see if this is target resource that we want to handle.
> 
>    // Some resource is handled by other provider so we have to make sure this
> first.
> 
>    //
> 
> -  DEBUG ((REDFISH_DEBUG_TRACE, "%s Identify for %s\n", __func__, Uri));
> 
> +  DEBUG ((REDFISH_DEBUG_TRACE, "%a Identify for %s\n", __func__, Uri));
> 
>    ConfigLang = RedfishGetConfigLanguage (Uri);
> 
>    if (ConfigLang == NULL) {
> 
>      Status = EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Private-
> >InformationExchange);
> 
> --
> 2.32.0 (Apple Git-132)


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2][edk2-redfish-client] Tools: fix script name in README
  2023-07-03 21:37 ` [PATCH 2/2][edk2-redfish-client] Tools: fix script name in README Mike Maslenkin
@ 2023-07-04 13:15   ` Nickle Wang
  2023-07-05  2:38   ` Chang, Abner
  1 sibling, 0 replies; 8+ messages in thread
From: Nickle Wang @ 2023-07-04 13:15 UTC (permalink / raw)
  To: Mike Maslenkin, devel@edk2.groups.io; +Cc: abner.chang@amd.com, igork@ami.com


Reviewed-by: Nickle Wang <nicklew@nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Tuesday, July 4, 2023 5:38 AM
> To: devel@edk2.groups.io
> Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [PATCH 2/2][edk2-redfish-client] Tools: fix script name in README
> 
> External email: Use caution opening links or attachments
> 
> 
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
>  Tools/Redfish-Profile-Simulator/README.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Tools/Redfish-Profile-Simulator/README.md b/Tools/Redfish-Profile-
> Simulator/README.md
> index 660938f8805d..d71c1bb0bbe2 100644
> --- a/Tools/Redfish-Profile-Simulator/README.md
> +++ b/Tools/Redfish-Profile-Simulator/README.md
> @@ -32,7 +32,7 @@ Copyright 2016-2018 Distributed Management Task Force,
> Inc. All rights reserved.
> 
> 
>  ## Usage
> 
> 
> 
> -* ` python redfishProfileSimulatorMain.py [options]`
> 
> +* ` python redfishProfileSimulator.py [options]`
> 
>  * `[Options]`:
> 
> 
> 
>          -V,  --Version,--- the program version
> 
> --
> 2.32.0 (Apple Git-132)


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__
  2023-07-03 21:37 ` [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__ Mike Maslenkin
  2023-07-04 13:14   ` Nickle Wang
@ 2023-07-05  2:38   ` Chang, Abner
  1 sibling, 0 replies; 8+ messages in thread
From: Chang, Abner @ 2023-07-05  2:38 UTC (permalink / raw)
  To: Mike Maslenkin, devel@edk2.groups.io; +Cc: nicklew@nvidia.com, igork@ami.com

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Tuesday, July 4, 2023 5:38 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used
> for output __func__
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
>  .../ComputerSystemCollectionDxe/ComputerSystemCollectionDxe.c   | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste
> mCollectionDxe.c
> b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste
> mCollectionDxe.c
> index 3ba2529c9cea..8f2054e1e161 100644
> ---
> a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste
> mCollectionDxe.c
> +++
> b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste
> mCollectionDxe.c
> @@ -44,7 +44,7 @@ HandleResource (
>    // Check and see if this is target resource that we want to handle.
>
>    // Some resource is handled by other provider so we have to make sure this
> first.
>
>    //
>
> -  DEBUG ((REDFISH_DEBUG_TRACE, "%s Identify for %s\n", __func__, Uri));
>
> +  DEBUG ((REDFISH_DEBUG_TRACE, "%a Identify for %s\n", __func__, Uri));
>
>    ConfigLang = RedfishGetConfigLanguage (Uri);
>
>    if (ConfigLang == NULL) {
>
>      Status = EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Private-
> >InformationExchange);
>
> --
> 2.32.0 (Apple Git-132)


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2][edk2-redfish-client] Tools: fix script name in README
  2023-07-03 21:37 ` [PATCH 2/2][edk2-redfish-client] Tools: fix script name in README Mike Maslenkin
  2023-07-04 13:15   ` Nickle Wang
@ 2023-07-05  2:38   ` Chang, Abner
  1 sibling, 0 replies; 8+ messages in thread
From: Chang, Abner @ 2023-07-05  2:38 UTC (permalink / raw)
  To: Mike Maslenkin, devel@edk2.groups.io; +Cc: nicklew@nvidia.com, igork@ami.com

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Tuesday, July 4, 2023 5:38 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [PATCH 2/2][edk2-redfish-client] Tools: fix script name in README
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
>  Tools/Redfish-Profile-Simulator/README.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Tools/Redfish-Profile-Simulator/README.md b/Tools/Redfish-
> Profile-Simulator/README.md
> index 660938f8805d..d71c1bb0bbe2 100644
> --- a/Tools/Redfish-Profile-Simulator/README.md
> +++ b/Tools/Redfish-Profile-Simulator/README.md
> @@ -32,7 +32,7 @@ Copyright 2016-2018 Distributed Management Task
> Force, Inc. All rights reserved.
>
>
>  ## Usage
>
>
>
> -* ` python redfishProfileSimulatorMain.py [options]`
>
> +* ` python redfishProfileSimulator.py [options]`
>
>  * `[Options]`:
>
>
>
>          -V,  --Version,--- the program version
>
> --
> 2.32.0 (Apple Git-132)


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/2][edk2-redfish-client] fix trivial misprint
  2023-07-03 21:37 [PATCH 0/2][edk2-redfish-client] fix trivial misprint Mike Maslenkin
  2023-07-03 21:37 ` [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__ Mike Maslenkin
  2023-07-03 21:37 ` [PATCH 2/2][edk2-redfish-client] Tools: fix script name in README Mike Maslenkin
@ 2023-07-05  2:39 ` Chang, Abner
  2 siblings, 0 replies; 8+ messages in thread
From: Chang, Abner @ 2023-07-05  2:39 UTC (permalink / raw)
  To: Mike Maslenkin, devel@edk2.groups.io; +Cc: nicklew@nvidia.com, igork@ami.com

[AMD Official Use Only - General]

Thank you Mike, please just create a PR for this.

Abner

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Tuesday, July 4, 2023 5:38 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [PATCH 0/2][edk2-redfish-client] fix trivial misprint
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2023-07-05  2:39 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-03 21:37 [PATCH 0/2][edk2-redfish-client] fix trivial misprint Mike Maslenkin
2023-07-03 21:37 ` [PATCH 1/2][edk2-redfish-client] RedfishClientPkg: fix format used for output __func__ Mike Maslenkin
2023-07-04 13:14   ` Nickle Wang
2023-07-05  2:38   ` Chang, Abner
2023-07-03 21:37 ` [PATCH 2/2][edk2-redfish-client] Tools: fix script name in README Mike Maslenkin
2023-07-04 13:15   ` Nickle Wang
2023-07-05  2:38   ` Chang, Abner
2023-07-05  2:39 ` [PATCH 0/2][edk2-redfish-client] fix trivial misprint Chang, Abner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox