From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E41CD940D09 for ; Thu, 14 Sep 2023 03:33:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7T0yqbMpHTm+zBVzVlQhqzE+hUXlafL1DriYp8Pjxbc=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694662391; v=1; b=WSs+dNwG04vrO0zeOdmNuC2ExPnudtdWOYw9IcJLoayPplgeTkccTo8ZOC4SHvEQcD31fdSW Ss8WBU0nMbazQf50xDxHv/vRNPql8QEWrRs9PFma83qOowwHS4++xDmQ1QvS+WDDwjnY3olerb4 3Ic/hBWbSf8+Eqfy52Alc/BI= X-Received: by 127.0.0.2 with SMTP id gTK9YY7687511xCIQxVe1GPA; Wed, 13 Sep 2023 20:33:11 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.72]) by mx.groups.io with SMTP id smtpd.web11.4264.1694662390607472445 for ; Wed, 13 Sep 2023 20:33:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NIbTRI17qkwbddIWGqXdYOK4uH0jx+sFIffaMUeS0xceoFJeCYEUiVzs8HGNVZPmqkW4ks3Jbu7ql4RdElCnKdeMU1/g7iGxg9FionYH8v4eUn/Y5Tw2sl3ukfyl9q8YN/A956qBWCWCuDc+I3cNhsDLZNsmYo9kNJJDQjbCdorMScWmdtzNKuwnl2Vo2RvAfslFp78Pbr4cL6jlcqizi8HahP0g/oWNGR/V0l5ELJRAV9S/M3+6L7qHGdwje7AvYCQ6a3LI7fl9K0jUdkR3FRxOjG0XiXC77Vi961aMMBp2Kok7G/PA393bWbYJWvmiihij2jxinXNjyE2NxwVbvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vd+w2nK7KM95/+mglgtCm733SgRa7BswHZUCB2TUBJk=; b=QlprnkyM2Unn6R6ST1b1KQ2Cbrq7JZxr2LT1PTaxwnx6Kf0sizkYuJ6r/qeb6oo5EtyNEjKS4IY7zhsV/drMF53tsmk1KZlNLte6Miq22A+bM8vdlICoK0TAAEOONpPYDC2UkdYmDFMPl60CVkG/KuGBfLAgFWH/0GhXCSaGeoXfrsFOD6HVJBnhFb45hGDe2UKXMT/+fIeJN3mdPiMaHdJ+4dpedb20msZeiuTvBkMBP2qTQIrokpCAmVBaIgzrqnUM1wMnauSlYVxyoq/7Pwm9C9Bg3Ag71ec7PNJ8o60mIdI0X3WVuSJ9OM0ABzRlwSymkUPHtHw/5dN36uh8AQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MN0PR12MB5883.namprd12.prod.outlook.com (2603:10b6:208:37b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.31; Thu, 14 Sep 2023 03:33:08 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02%4]) with mapi id 15.20.6792.020; Thu, 14 Sep 2023 03:33:07 +0000 From: "Chang, Abner via groups.io" To: Igor Kulchytskyy , Nickle Wang , "devel@edk2.groups.io" CC: Nick Ramirez Subject: Re: [edk2-devel] [PATCH v2 1/1] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue. Thread-Topic: [EXTERNAL] [PATCH v2 1/1] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue. Thread-Index: AQHZ5UcEjnqq9f07e0yQO/eSkw2m7rAXjiQAgAIfnlA= Date: Thu, 14 Sep 2023 03:33:07 +0000 Message-ID: References: <20230912070134.13729-1-nicklew@nvidia.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=6133b4e1-e5ff-46ba-8e5e-de93d8cf2fb5;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-09-14T03:32:58Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MN0PR12MB5883:EE_ x-ms-office365-filtering-correlation-id: d9392936-31e7-4928-f615-08dbb4d34fe3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: a7xhrXvw1+u2ind7XvlN+71DhH5tBkyXECCkwZhhwFXQrsLuoV6yS8bTNcxtAfMzlDrBh0P89X05GVLiE2ofHJRtT/GD2I6r5Y6Y0ZsZMlDjWGFLDaho6Nh/HTY+ptVIfbcMjYxOY1STt+4x1vIRb+gQt4wX9NWEj1jfiVBq0i4e5pjKa3mNfQ4K7VutIMphNZQ+XLMNzSVKYVsT7f7JNUqk6mZ7qxUf+ujcFxgQ5oEgQ6h1D3z/QavtU+JPoHXYSQWq56AvC/PikCX0iXva9GfOY59P2N/mhG7HYfjdMMop3uxE6Y+ui7zxisw2L8sAGkt2nlHdZ8olc53ErgAz5kc12pkvF7B3aGbqDR91GvTOsgDPzoMw3m7qz7JBlup5zF1b75GyIKNO1zFb5mm1i4ikPUtOSd9SwT1YU5alGrh/unDj3/KeCSUJf78/QM+O+JBpu3PGt3UeZCenpubhBJrm5DUR0yZRulPQwnDqYu4tG6oqZf44u6sl40/MDw/oMOg8TBT0RHNyfBtr9h954dyhiiDtJRVXXL5iJVo0l+k4cvBM+Xd+iqMYqIlCx5NwgUl9tulqPE/etu69VKhMLwJ3u4phtkA6Y7zqIJdx1AJan873QGipYo3G3zy+JWb/ x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tccrRW8QWqZnU9GYdIJBRPOrRJJ2qH8ubnC4gqhehdpHBA9OzCuQIk95dNXO?= =?us-ascii?Q?TkO4q2+oAtkDWUZdexatoBOOE5T/WorG3FfFJmRPYPwOT5LiW/1noDeoCTUY?= =?us-ascii?Q?BoIjP/BJ+vxN1K3NyUU1Dq3e4MZi3XKuGA/T9OHgGpDmd/i6IJamfDmvfBhT?= =?us-ascii?Q?bCXV98Rhr3MH3oXKv5Up9L+YiNd/To0WL12Uw9aK+1Sb4iJmmMDAvwYdIHmX?= =?us-ascii?Q?qq7M17Rf6u7qjzC0aD2TyYqOP94giJq+OcYmsi7sABxcGkyexnGojmpZ/vuS?= =?us-ascii?Q?PUv6WCfOeDFjyFAFksS2M/qF9eThxMzoIK2Y6xm0Vqg087mGc/EsauEHcWXq?= =?us-ascii?Q?MBf7NTlbISqr4J3i+Wix67S7XfVMkqbs6KHhOGg2KGW7EP1IPAd89iW+MCM4?= =?us-ascii?Q?3tyzOdFi+ByoKioDfiZjRuA/3dQwmKC0vuIIzxW9HS5QbAoa8z2DBhMr8PSe?= =?us-ascii?Q?eaawGgGfc7UdrmhvfdPqfjVF7ExriqSd43O73pift9WlXXbTMSGQadKC5JcT?= =?us-ascii?Q?4+VZnLPY9MIaGJgp2ZhHgm8RN4pPabA5VATxt6WR5UpsNKEPxkCJKz7Q4NDo?= =?us-ascii?Q?OKjHzD8YBEqTy++hU1BSeTE7w6XYwH7zC/hLg1JOlJNgxqBy89YDUZrv5If0?= =?us-ascii?Q?+jM9O/RqbovfIwTlXVLP8NEhtzYvFlIJYDjeUBtf7udSCe2bW8kB7S3hvf8P?= =?us-ascii?Q?Q4GsxShBIeuulYsfXxjqooIHsYWbl0z1zzV47iL1bg5DJgi399f1CB05+ksd?= =?us-ascii?Q?VUYR8/cSXd/wH3/yQiBaLafHToCfWfNA/TzAT87xdsOPvbvMMxPOojSWq/0m?= =?us-ascii?Q?pqsJpP34sqqGSdNF1HwOOvPbnZWFsK9f36hIzkn7EtBS7QZPGTr7vkbRBiHF?= =?us-ascii?Q?9YmUUU9uVWEQwY3yxFagCuoC8ZFeXYIFBwdFAjft0uD/CoyBniWrxqF186Gd?= =?us-ascii?Q?s4JPXpQfm2BIUZNFDRNPaHeaeTunmxV9ZkuBeXqeGjxjtSo5HrfImMXxLuQk?= =?us-ascii?Q?xyo1EMluyM405FBfwrQQzP/B3lSdX3Defjotsb0kjI5a/V7nLcMcK5i55dus?= =?us-ascii?Q?7nHPTdS7ANbiJB/EABBFAaEeLTcgOlqr5Q6z+yF2/WUKKqLbjrm/4+8GyOJQ?= =?us-ascii?Q?2cDNFHLPiiE4qQabES778Puur7i5HVocaZ+4TX7eXNvNkSetyNH/e9kpDPPm?= =?us-ascii?Q?2TCbD7Ci8rLpGRYzWIkrzPh1ALcSLVfZpzjhBpo1sFXnPBSsTDfj1LhxOAuE?= =?us-ascii?Q?l41xWa6Xi3gCANtBHRSr8zkzHjvjYQZ5RygAeR17+/sk/OQmHjve1BskftzG?= =?us-ascii?Q?XwXmBq1ISN7dWT7ix2wUdKeoFgagsoPdhYTAOmaw/he2drMc+19PHWwUQstz?= =?us-ascii?Q?Ymi7af5SB4Bwsboacr8sB5k++5GPsFEXJyJR7WcHS1mspc3fpXmC2xPA84Ll?= =?us-ascii?Q?YAxEbcJNFIGCfkCz/4GBfsh58JGKSOAlij04pi9jX6WsVh51nWksUGGtP8UD?= =?us-ascii?Q?PN+h5RHtnKsSx14vE4E4GfTFiMYKRGoFFplFo9hW6j5O4kHp6/27Ve3b5xX3?= =?us-ascii?Q?ig9a2TGcGIfN6K7bsV8=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9392936-31e7-4928-f615-08dbb4d34fe3 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2023 03:33:07.4233 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IAp7jhJtQEfovCI+xRc5NNbaBwfX0pVqWQTMiDzA5NE1j93SjupwpOXPpLlJERuJM2PXYLQpsZl9P7pDv6/qTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5883 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Pc2CEStzp2ecDIeync4rkshtx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=WSs+dNwG; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Igor Kulchytskyy > Sent: Wednesday, September 13, 2023 3:07 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Chang, Abner ; Nick Ramirez > > Subject: RE: [EXTERNAL] [PATCH v2 1/1] > RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue. > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Reviewed-by: Igor Kulchytskyy > > Regards, > Igor > > -----Original Message----- > From: Nickle Wang > Sent: Tuesday, September 12, 2023 3:02 AM > To: devel@edk2.groups.io > Cc: Abner Chang ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [EXTERNAL] [PATCH v2 1/1] RedfishPkg/RedfishPlatformConfigDxe: > fix can not set one-of option issue. > > > **CAUTION: The e-mail below is from an external source. Please exercise > caution before opening attachments, clicking links, or following guidance= .** > > StatementValue->Buffer is converted from ASCII to Unicode by caller > already so we don't have to convert it again. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > .../RedfishPlatformConfigDxe.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe= .c > b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > index f2a8e77d9b00..30d2ef351eca 100644 > --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c > @@ -1660,12 +1660,11 @@ RedfishPlatformConfigSetStatementCommon ( > // in string format from HII point of view. Do a patch here. > // > if ((TargetStatement->HiiStatement->Operand =3D=3D EFI_IFR_ONE_OF_OP= ) && > (StatementValue->Type =3D=3D EFI_IFR_TYPE_STRING)) { > - TempBuffer =3D StrToUnicodeStr ((CHAR8 *)StatementValue->Buffer); > - if (TempBuffer =3D=3D NULL) { > - return EFI_OUT_OF_RESOURCES; > - } > - > - FreePool (StatementValue->Buffer); > + // > + // Keep input buffer to TempBuffer because StatementValue will be > + // assigned in HiiStringToOneOfOptionValue(). > + // > + TempBuffer =3D (EFI_STRING)StatementValue->Buffer; > StatementValue->Buffer =3D NULL; > StatementValue->BufferLen =3D 0; > > -- > 2.17.1 > > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by= their > designee. If the reader of this message is not the intended recipient, yo= u are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by telep= hone > at 770-246-8600, and then delete or destroy all copies of the transmissio= n. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108632): https://edk2.groups.io/g/devel/message/108632 Mute This Topic: https://groups.io/mt/101310452/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-