From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.71]) by mx.groups.io with SMTP id smtpd.web10.9351.1678287173729718148 for ; Wed, 08 Mar 2023 06:52:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=tIJnvkNx; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.95.71, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FGdfYMIjNNiC+jhadqTsXm4di5gk24HhXDJhEVQBQcNJL89Za/sUKu65VQQEfXW9deZMFqMCzYqDjFkBg2MDYCzOvtc2dT5gcw+2+RTf0RViNRWhyrkyN6qD6nSFprNrT9Uf/jaSMlnD8gSgf6yed/c3gBMHuzw9z67aKZYaNlC35SRtUESxI5MMwnlRNzvzesYhupmi5nr2PsVDzismc0d5kuCTR/6kDwybm5sKconXYuMEhphdllxvkHO9ieLmv9Hrklvz7H2F0S8LTh4mzis2aBzwc4MMElHdcQsDC9zNd5lv/EoFgSc8tMC08hlYnYF1Mf9S4eQi7/PCsH+X2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sh7a6/d6LOjzL4sAlgvQzbuanCko387zgxHcZDxxtmw=; b=YfNc8GAoqdoL4AGg+z97GTP38SYCDiy8RGU3U1BTrdSscJ1ANbUQQIosNl2b0Kxsyc/SsahTHY28Lc08ksLsirco+bVbZDDsPCP5RpF7ML5QZjyKcbw9tfY9Eggi2BzAkvOqpBZkNCp0mPgEFM4fQHQrZRuzQe9ySbkA8DcjJEzy0+qYQgtmp4uJgAL/L8/Mn664BeWi+2lxceoko9HavkXn3vm3cKcvg+Z4l9rP/BiZ9Qp/wo5DMSr/wP4EtCCjJlciXLivsiz2rS8k+47q+nCHuz5AmBbXphR036yA2QqFYOI9rvbaFW8qsn6FxL8SSehwFst38PpqJSJ5AhUljQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sh7a6/d6LOjzL4sAlgvQzbuanCko387zgxHcZDxxtmw=; b=tIJnvkNxmtPjYb2h05IXv+HEdIsYM2DJ314CZ99uVuxph+SCv7DcvoZGmxo/Me4tBwgcZogDNpsTgjR5Ij1H2NVAx1yKURcla/EaCmTdyq5AT6vFfpGuS4G4CpISn8cT+VLKzoQ+2TTRla7SqsFTNAfDNq9SencZFf9eMxhMiC0= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SN7PR12MB7108.namprd12.prod.outlook.com (2603:10b6:806:2a3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.29; Wed, 8 Mar 2023 14:52:51 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::8136:1f56:53e5:6fe]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::8136:1f56:53e5:6fe%3]) with mapi id 15.20.6156.028; Wed, 8 Mar 2023 14:52:51 +0000 From: "Chang, Abner" To: "devel@edk2.groups.io" , "Chang, Abner" CC: Michael D Kinney , Liming Gao , Zhiguang Liu , Nickle Wang , Igor Kulchytskyy , Isaac Oram , "Attar, AbdulLateef (Abdul Lateef)" Subject: Re: [edk2-devel] [PATCH V2] MdePkg/Include: Add IPMI KCS definitions Thread-Topic: [edk2-devel] [PATCH V2] MdePkg/Include: Add IPMI KCS definitions Thread-Index: AQHZUczjscNMUFqbOkC5zaLMEbLzjK7w9lgQ Date: Wed, 8 Mar 2023 14:52:51 +0000 Message-ID: References: <174A78FC34F9F88C.23983@groups.io> In-Reply-To: <174A78FC34F9F88C.23983@groups.io> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-03-08T14:52:48Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=6779c59c-5ea7-412f-9dff-4983779c315b; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SN7PR12MB7108:EE_ x-ms-office365-filtering-correlation-id: 7a3054e0-8a44-42c8-dd75-08db1fe4ca91 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5tLUOAOCuZx8D8QZuKqvAduXIJ4cK9r/iS6lAR0QCgqvsPF8Fqr8c6qiXfcsa/6TUpmpqRXPcbPMvennpEXnJhRecR73hX71foCAR5y6CgQq5mEdeN4TK/sRqCkLEYZkhdtsRsyyauSrGD8riFxnj+rOpEcRE+e3e9rOga+8dXD8+dAM0qBG/hXJj9nJU07h+rTif28tRY5PGYhmZJ8kuRWbyubPlEaMBbLoI+Yw/FUVKdS4gddr6wMOK+Vn1hKiLnUKMxtF5j1MfIuQrnHBzmTjm1beZVLVy+UIekuCKhauxltz2T2mFZPP7nNl3BAEyF0ga5IfgUIeFsT4g2wAEDyfLNODqt5NjN4drOSb54T6PivPQzp3gPc6nMPIq8SBlCXuRdkfJ+9PgWvgeGLLB+TC0bNBWJLsJp2BWm/FVkLOy0vsZFsCP8hSh4bEyh9cRwGO/SrUeDXXVaFS4zwMxv91Dkr1kiM6BfC0UVOcXLymRSDCOdlT/3bJB+tHAFYrTT+I2jjU9Eg/8/FXhz/VAzOBpaPcsQVD78s4yrgQaG/Oi4qY6MyTLwxT/uUiXH0cyQIk5rrXSaUGzI7mkTwfduGIL6t0BYngWXTddYuKN07BrDoMBcN2FPUJ4APC3fKC0UtjFw+Kxlsbmk74PMZeh/o2WpvWGUiBT0aiWHR/BHBjdXUxCwNps4g+E8Q7ex0Qgy2I6GdlasD+ruOM1tNDSSL93oX0pAdWK6ooVL1xpyo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(396003)(39860400002)(136003)(346002)(376002)(366004)(451199018)(66899018)(316002)(110136005)(54906003)(33656002)(55016003)(38070700005)(6506007)(86362001)(38100700002)(186003)(122000001)(83380400001)(53546011)(9686003)(71200400001)(26005)(64756008)(5660300002)(8936002)(52536014)(2906002)(478600001)(7696005)(76116006)(966005)(41300700001)(4326008)(66556008)(8676002)(66446008)(66946007)(66476007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fK0rTbXBQH7WXTC7KNHLUw6UfQ0i+CECCl2zY9e2J7ibYU6bPQPTzO0dLOam?= =?us-ascii?Q?KA7m1UU60IaOmx6qUcShLvF/g+ouFtmvJnYIzORn3L193Db5/HG2VbYlQ60O?= =?us-ascii?Q?reiPDJ1GWZo1OjSaUxcXxsyachcw9naFANFuQDKYbCVzo6UvUGScS568v4XE?= =?us-ascii?Q?mCFfvP1GbtWU/gQveAlsHBNW6QlyTvdz7bTYZ7JPqQvFYnv9oK6eqds2BwlU?= =?us-ascii?Q?cp77GVY2KO6qvAwdMp9D29e/KtXdeqZevcexetDQPFDb+eLFuxmUzv27eNya?= =?us-ascii?Q?mSZq2erLuWwEC3zfrvz4p6HkCXefHOYWFRcrOsF5hpQAZmZccIwlE6jd2cGm?= =?us-ascii?Q?booAh6eywUlnHpZXDmq8wLnk0G/hzoerBU9ktgk6grl4P4YeJNbaJsWeFodn?= =?us-ascii?Q?sxEoY29cPuaBTUToIUNg3nbeun2E3K7qH377M4nQUxZFLRszsP2HT6pEYkDi?= =?us-ascii?Q?1ifDwezbhUzI0FSXWLiZ/l4uzep9UPlXsbsHdiazoFo9xaVnBS3h54sJbzBn?= =?us-ascii?Q?yDCqZqZV8xIU+MUwULv1pwkyIhpHs4+r3jJO0WS1JuwcXx+LS1dk9r25EpR3?= =?us-ascii?Q?ukn7iQ9CsLS3OAYI8DOzoCj9BLhKMDzJ9GLvtMh2ByE8gXJShbSioyALwzxB?= =?us-ascii?Q?gtLa5/UjdEQVaHcTTJwwobwxwWwxWjRQhQa3URZTgakiMLflmcJSjsLKcniK?= =?us-ascii?Q?QSOoKnrdEo+UlEmFDVM2tl3NCOukd3DmG4mSBrfoRgcm0Jb62X5gpevFZ7O0?= =?us-ascii?Q?CZjJC+D9HZfpgjObO9IDtTTZeR+eTCFOKF9Ej1DlCS+JA92Rv+y/jlQUCEV5?= =?us-ascii?Q?5cgsz2Ew5qdVsjnNEB2Dch+dDEF67PRWPTIs72lDgoBQdPKjMsfuT+hzaKfn?= =?us-ascii?Q?J6YzjccVjQWwOVrhfe3z08LSI2RMUxTZ0nq70Tkc6Qk9lqBaogScSF9TuJ92?= =?us-ascii?Q?on2Q4sODZU3lDRDiDQRPJelWfoj2eChrPcqTmHQ2/NvZPj9wgg7She00oCbP?= =?us-ascii?Q?itBuYA7Hh7sRBlc2+asvhswITCbKdp7IDvEJETvXUNpS23nAa3keIv6nUUdN?= =?us-ascii?Q?9FNhfcCl5MQh2I3bBGCLL/QcuL0mQLUDzuPGBBTxsySsOoNx7FP8NXBxNKDU?= =?us-ascii?Q?Wn2K72BsVzttpDcApfblPom7KjQnyY2vms1IL/xiSAvENKjplhplIfNvSJn2?= =?us-ascii?Q?NL0Vm0UNFAMZYI9uL2ydudU1MCvY0zfkxe5uFfCVNuzefN9UzqSrigrxwWI0?= =?us-ascii?Q?gxHToTDxUGIdV+86GynjkLEEXuxV4VelCTvxI/v4yz39xiCcn3ShIbZMPPkb?= =?us-ascii?Q?UXOgCead6UmdeXRRICOdfj+OdFjzow9eDK8HAqR3bUEfPzNJsUAUJMbZ8jaC?= =?us-ascii?Q?Idb10ePYItIgujGNMUPZEOLeezAV9EwuQiL0Uz7qL2al4Oj9DbKVrVVQP9yD?= =?us-ascii?Q?FoDEikWdDgxo7ILjw1dY1WZ4aro5iXRAxleeh3lfirgMLlnp2NiRUWtXanYs?= =?us-ascii?Q?AXu8H+tVBw61PvSyyUSCCYAXwLV6yF7zZyXREGZv7LMUApSO8DJ6yCfvKDQy?= =?us-ascii?Q?bCD2OjfsvbhedhEbpLxX0Zbp3FzCpFVibFbaRnr2?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a3054e0-8a44-42c8-dd75-08db1fe4ca91 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2023 14:52:51.4306 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jUsxdCNyVQJh+0fecX8tGhMRj696SdyU6oe/vB6wRNVSsFY+P+r8UI51Xlx1Jadq1jU94OyayUcyofkw3Se15w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7108 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] In V2 , CompletionCode is removed from structure IPMI_KCS_RESPONSE_HEADER, because = it is returned in the response data. Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Wednesday, March 8, 2023 10:47 PM > To: devel@edk2.groups.io > Cc: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Nickle > Wang ; Igor Kulchytskyy ; Isaac > Oram ; Attar, AbdulLateef (Abdul Lateef) > > Subject: [edk2-devel] [PATCH V2] MdePkg/Include: Add IPMI KCS definitions >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > From: Abner Chang >=20 > BZ #4354 > This change adds definitions for IPMI KCS. >=20 > Spec ref: > https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/i > pmi-second-gen-interface-spec-v2-rev1-1.html >=20 > Signed-off-by: Abner Chang > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc: Isaac Oram > Cc: Abdul Lateef Attar > Acked-by: Isaac Oram > --- > MdePkg/MdePkg.dec | 5 ++ > MdePkg/Include/IndustryStandard/IpmiKcs.h | 76 > +++++++++++++++++++++++ > 2 files changed, 81 insertions(+) > create mode 100644 MdePkg/Include/IndustryStandard/IpmiKcs.h >=20 > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > 80b65590531..808c487bb49 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -9,6 +9,7 @@ > # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development LP > # Copyright (c) 2022, Loongson Technology Corporation Limited. All rights > reserved.
# Copyright (c) 2021 - 2022, Arm Limited. All rights > reserved.
> +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > +reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -2339,6 +2340,10 @@ > # @Prompt Memory Address of GuidedExtractHandler Table. >=20 > gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress|0x1000 > 000|UINT64|0x30001015 >=20 > + ## This value is the IPMI KCS Interface I/O base address used to trans= mit > IPMI commands. > + # @Prompt IPMI KCS Interface I/O Base Address > + > + > gEfiMdePkgTokenSpaceGuid.PcdIpmiKcsBaseAddress|0xca2|UINT16|0x0000 > 0031 > + > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > ## This value is used to set the base address of PCI express hierarchy= . > # @Prompt PCI Express Base Address. > diff --git a/MdePkg/Include/IndustryStandard/IpmiKcs.h > b/MdePkg/Include/IndustryStandard/IpmiKcs.h > new file mode 100644 > index 00000000000..c3baf80bd76 > --- /dev/null > +++ b/MdePkg/Include/IndustryStandard/IpmiKcs.h > @@ -0,0 +1,76 @@ > +/** @file > + IPMI KCS Register Definitions > + > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > + reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent > + > + @par Revision Reference: > + IPMI Specification > + Version 2.0, Rev. 1.1 > + > +https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ > ipmi > +-second-gen-interface-spec-v2-rev1-1.html > +**/ > + > +#ifndef IPMI_KCS_H_ > +#define IPMI_KCS_H_ > + > +#define IPMI_KCS_STATUS_REGISTER_OFFSET 1 > +#define IPMI_KCS_COMMAND_REGISTER_OFFSET 1 > +#define IPMI_KCS_DATA_OUT_REGISTER_OFFSET 0 > +#define IPMI_KCS_DATA_IN_REGISTER_OFFSET 0 > + > +/// > +/// IPMI KCS Interface Status Bits > +/// > +#define IPMI_KCS_OBF BIT0 > +#define IPMI_KCS_IBF BIT1 > +#define IPMI_KCS_SMS_ATN BIT2 > +#define IPMI_KCS_COMMAND_DATA BIT3 > +#define IPMI_KCS_OEM1 BIT4 > +#define IPMI_KCS_OEM2 BIT5 > +#define IPMI_KCS_S0 BIT6 > +#define IPMI_KCS_S1 BIT7 > + > +/// > +/// IPMI KCS Interface Control Codes > +/// > +#define IPMI_KCS_CONTROL_CODE_GET_STATUS_ABORT 0x60 > +#define IPMI_KCS_CONTROL_CODE_WRITE_START 0x61 > +#define IPMI_KCS_CONTROL_CODE_WRITE_END 0x62 > +#define IPMI_KCS_CONTROL_CODE_READ 0x68 > + > +/// > +/// Status Codes > +/// > +#define IPMI_KCS_STATUS_NO_ERROR 0x00 > +#define IPMI_KCS_STATUS_ABORT 0x01 > +#define IPMI_KCS_STATUS_ILLEGAL 0x02 > +#define IPMI_KCS_STATUS_LENGTH_ERROR 0x06 > +#define IPMI_KCS_STATUS_UNSPECIFIED 0xFF > + > +/// > +/// KCS Interface State Bit > +/// > +typedef enum { > + IPMI_KCS_IDLE_STATE =3D 0, > + IPMI_KCS_READ_STATE, > + IPMI_KCS_WRITE_STATE, > + IPMI_KCS_ERROR_STATE > +} IPMI_KCS_STATE; > + > +/// > +/// IPMI KCS Interface Request Format > +/// > +typedef struct { > + UINT8 NetFunc; > + UINT8 Command; > + UINT8 Data[0]; > +} IPMI_KCS_RESQUEST_HEADER; > + > +/// > +/// IPMI KCS Interface Response Format > +/// > +typedef struct { > + UINT8 NetFunc; > + UINT8 Command; > +} IPMI_KCS_RESPONSE_HEADER; > +#endif > -- > 2.37.1.windows.1 >=20 >=20 >=20 >=20 >=20