public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: Mike Maslenkin <mike.maslenkin@gmail.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "nicklew@nvidia.com" <nicklew@nvidia.com>,
	"igork@ami.com" <igork@ami.com>
Subject: Re: [edk2-devel] [PATCH 1/9] RedfishPkg: fix RedfishPlatformHostInterfaceLib library class name typo.
Date: Mon, 18 Dec 2023 02:29:38 +0000	[thread overview]
Message-ID: <MN2PR12MB3966A7C25A199997723B0465EA90A@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231212145412.50434-2-mike.maslenkin@gmail.com>

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Tuesday, December 12, 2023 10:54 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [PATCH 1/9] RedfishPkg: fix RedfishPlatformHostInterfaceLib library
> class name typo.
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> PlatformHostInterfaceBmcUsbNicLib is the library instance name not the class
> name.
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
>  .../PlatformHostInterfaceBmcUsbNicLib.inf                       | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> faceBmcUsbNicLib.inf
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> faceBmcUsbNicLib.inf
> index 838a1721a7ae..3660249a3588 100644
> ---
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> faceBmcUsbNicLib.inf
> +++
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> faceBmcUsbNicLib.inf
> @@ -14,7 +14,7 @@
>    FILE_GUID                      = C4837B58-225E-4352-8FDC-4C52A5D65891
>
>    MODULE_TYPE                    = DXE_DRIVER
>
>    VERSION_STRING                 = 1.0
>
> -  LIBRARY_CLASS                  = PlatformHostInterfaceBmcUsbNicLib
>
> +  LIBRARY_CLASS                  = RedfishPlatformHostInterfaceLib
>
>
>
>  [Sources]
>
>    PlatformHostInterfaceBmcUsbNicLib.c
>
> --
> 2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112615): https://edk2.groups.io/g/devel/message/112615
Mute This Topic: https://groups.io/mt/103130778/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-12-18  2:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12 14:54 [edk2-devel] [PATCH 0/9] Redfish related fixes and improvements Mike Maslenkin
2023-12-12 14:54 ` [edk2-devel] [PATCH 1/9] RedfishPkg: fix RedfishPlatformHostInterfaceLib library class name typo Mike Maslenkin
2023-12-18  2:29   ` Chang, Abner via groups.io [this message]
2023-12-12 14:54 ` [edk2-devel] [PATCH 2/9] RedfishPkg: fix RedfishPlatformCredentialLib " Mike Maslenkin
2023-12-18  2:30   ` Chang, Abner via groups.io
2023-12-12 14:54 ` [edk2-devel] [PATCH 3/9] RedfishPkg: get rid of unused definitions from RedfishCrtLib.h Mike Maslenkin
2023-12-12 14:54 ` [edk2-devel] [PATCH 4/9] RedfishPkg: RedfishPlatformConfigDxe: reduce memory allocations Mike Maslenkin
2023-12-12 14:54 ` [edk2-devel] [PATCH 5/9] RedfishPkg: RedfishDiscoverDxe: fix memory leak on error path Mike Maslenkin
2023-12-12 14:54 ` [edk2-devel] [PATCH 6/9] RedfishPkg: add Component Name protocols to RedfishConfigHandler driver Mike Maslenkin
2023-12-13  1:09   ` Igor Kulchytskyy via groups.io
2023-12-12 14:54 ` [edk2-devel] [PATCH 7/9] RedfishPkg: add proper initialization of IPMI request Mike Maslenkin
2023-12-12 14:54 ` [edk2-devel] [PATCH 8/9] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService Mike Maslenkin
2023-12-12 14:54 ` [edk2-devel] [PATCH 9/9] EmulatorPkg: RedfishPlatformHostInterfaceLib: get rid of unused variable Mike Maslenkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR12MB3966A7C25A199997723B0465EA90A@MN2PR12MB3966.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox