From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id ACABA740035 for ; Tue, 28 Nov 2023 02:30:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+3vs7Cgrn6A378N1t+27fU62MGEgYI6Gsiq/3owHtlY=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701138652; v=1; b=jJdiKCbqhs6o9Si4UDQU0l2vC5P8xdvBjH5/piarR3T5uU7OFJKn+GORXr7kUGP5WNzkxcQN bjRMtYJTeEsAQzb+THoSPHydTCTId4mBR8rKcOm3cEYpiO7Mz0Vv1wtA/RA4i7TsEWUlzRDMQTc +dlrcT590GeFPQCLNz95CuW8= X-Received: by 127.0.0.2 with SMTP id WPSZYY7687511xigYsGAdyTa; Mon, 27 Nov 2023 18:30:52 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.59]) by mx.groups.io with SMTP id smtpd.web10.22235.1701138651652197504 for ; Mon, 27 Nov 2023 18:30:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EN5AVdYpsQ7jLJB7hzvqSifYaXYLdLqXXQFQfXpe4rkrv5S4ptGA3+bjSoHnskPOj2ao/C9noouXYNGNJHpbTLJtgPhAopVW8rClRHLyZZLKqbma/Nl6Wkg9pQ+H4gvragVdTf/Gh8Oqj5kvHIbkeb4CTJBfHIARKTjCOBDy+Bj6tRjNf4HUlsDoPY7O/Ej73rZh4l5sTVQ4qMeWpBHgsf/DZcdOdFEGZq7JMjVBaw0lpzYryB/Gcn/kcIVrhm74nZ5YoTZaHv3ksnFs404THrUs0Ll5T922rfGomMmDWHFijQd5PWFuCgmm2/HvEjE1ewP6xXTojkQ4VSSPZduHFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oYanuLXyog2F9vLLBm25KA8VMkLPaDs8r0PckXhRzaY=; b=DuDp5acVS3OkR+e6DLiJaf7nYLPHi/v7vOlJ5a/m5HTgTvpYEEhJAdy5pU0n5mjoxLcBMoiG74OLJw1jzzMgjuOupRGD5cAbU29Y72lXY/ab3nnEae+P/e/WgUlnKk09PmFBQjMxRsXfRmHbdrWQmENBXBdjyEJLdtzsOMjIFPVX6JUrdX71IyHl1qgXnXArKM3PSKhD6Cs64zV4fZovIyGzwbl8Ifgbq+a1681PIxtKNOGXIr1UHYAFk0bc37mxXsWQnxrRURcqwqT7GL8hyVO44oQV2z7F0gN82n8bNEeSKZAxEFpANxb6zPtnpEeUMS+ZxnYC/0tL9O81rKP+fQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CY5PR12MB6597.namprd12.prod.outlook.com (2603:10b6:930:43::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.29; Tue, 28 Nov 2023 02:30:48 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7025.022; Tue, 28 Nov 2023 02:30:48 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/ComputerSystemCollectionDxe: handle more scenarios Thread-Topic: [edk2-redfish-client][PATCH] RedfishClientPkg/ComputerSystemCollectionDxe: handle more scenarios Thread-Index: AQHaHhc9jjBL7ndHeEqIA2Hy5Ie82LCPCXkw Date: Tue, 28 Nov 2023 02:30:48 +0000 Message-ID: References: <20231123141307.32052-1-nicklew@nvidia.com> In-Reply-To: <20231123141307.32052-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=c3c62024-fea8-42af-b2af-5f3005934f94;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-11-28T02:30:18Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|CY5PR12MB6597:EE_ x-ms-office365-filtering-correlation-id: 6f47e389-c68a-4a2c-0316-08dbefba086d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 6fs76IFq4UG0JEdUrhdYiAHCWPs3FC/Cr4RwivrdTAaFESL2YvRb1G7wFceTnmgPh0HaAi2eu9+fx//AsMxbnJoSArxR3Ao4UQUxnDjZ0+QSxR4bsWE1NmvXnUS9jlJ1AFc7IdM/Pe9p/M3oTMV9WaiKq+yXE2K3izne6Nnt9w0QuTGCiGgZTM4sb6gJ8zlHjnoaPZJp26I0282AGnPTQrgOPnWyLb62ItJr3JBlx3OiS+SlUX7esj1JnqTKREmPIa4QCAxFJPl8VNtidJgNa/k7iD6JA5xeGogIQRJyicnEmFJyg3ITRCIt4mrvnFJOauNd27oHlqNNV7OwC2r7IwuDa/hSxa5CtuETt/+FHRmPneH5Je0P0+vLS/AhsRf35Pi+5Yazr9hRjTHO4alXfzmYmKYjhlEw9mvFrc5a6Vxc/wqO+IWiWdMDMTAtO2iK2LzuunKfTMBQf9F4CUbAam+HUa+8lrWCuK6k2qJMccKyXGLz5CfdfozXPR9DI0VOl75t3MZp/rbok8h7MHMwDrqYoAGYuCDc7ixdDpLwx8VNW1RJIDuU1LLBtXcNLLo27b5tgjWRPWz3lEDznX5XvNk+/Tl5odqUtUIhEJvXjwdRAe2pwFTu/MTTIEtVZYuoe61Y92++/gGU3khU5C9InsJ8cvLiVi1KOB62CvtOaVY= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5yuVbeasRCqSle46IpizTvl20OkoF74SOqwKqgVuB+S1H5bIuuq1p5YnmP27?= =?us-ascii?Q?5eiPmEtR6n104v5ZptnXXpMFH5N+2kZOFIZFLzUqwPmE00gKyddzCeoXqzL2?= =?us-ascii?Q?yoOVqNT7QQzqdTJA/7zI3GZbD+xef9ZD7imSalfaYL2jFi+TQwLPsSk3juv6?= =?us-ascii?Q?Hebrlca4EBO4tzbT0K4hl5JEViNCUmdIILTVi9e7/tTtN0Nk6xnTAWv5d9I/?= =?us-ascii?Q?309QcIeRnod8nONcPHlch5XpixZsfa4ylZZk2V6368KKuHiV4t3DILNIN5r7?= =?us-ascii?Q?45rJ7r9Qk4EGC9hwgG6Lj+H0qY1woqSoNtUz17BSsZpYjeh5eweMErNMwys1?= =?us-ascii?Q?1jQlG+ez+RDyK4W8LzwN27CREj4zW+9ZDAjdwuuDfNmDZg72KoCoqIhBoTrX?= =?us-ascii?Q?RJIceqGAvwDEmkBjCvwiz9rMhc5yNv+Xk0OD4Awk+kP8yD2H6XOONAhpv+gK?= =?us-ascii?Q?QV1reL6xYGItW2YwaOWP+JtF3W+QorJhl07YDn3z2osAOjLqg0fZG2w/+bum?= =?us-ascii?Q?wdDvEeZbeT0igdku1V3VD5+bavpQEbHBdXeKqNkui/YFo7Tsv18Bo2Udn5Mx?= =?us-ascii?Q?wuBCWz8F2i1sMXpgwx5ocSO/SNjTqCMUKcvgejAYPagNa1jM9rfK1P2T9BGo?= =?us-ascii?Q?pcefiM36uFmmaCIcakFZtevlpT3KzExs/3XntQNppEamqcc/Wc4hdPSdFXWe?= =?us-ascii?Q?2W71GoVs61+yJZuTkMUtYyrqT2aQQQQspw2BxV1fqI89NyiKLa006MH57xsz?= =?us-ascii?Q?AzpYr/xLspxJ30A17Sip4wEs8OFCLi7Y0mMADBTavBkxCnobtu/u/I3CS1uU?= =?us-ascii?Q?E0kPvOBgOo4utCnSqEEyKRSKGmH+gsCVOq3lWmz5cU4E/WPwiW0A2dXjWDlP?= =?us-ascii?Q?WWcGOMoZ1K574t9RMR00nquw4/6/Tk2CGxBVvTb2RCEFZErKY2uOHZSJ6U4u?= =?us-ascii?Q?nG1WqlOKJHS542/LDVhFePhQChek9E0YdizUQNRS6YpAAakEo71E/n13Jsfy?= =?us-ascii?Q?7JQFQD+ZAJBfbKNKg+p+LSWZcJZQIsvMuXlXAYfaPJEW+CFh/8WBPMEfk8Ro?= =?us-ascii?Q?OmXI4dhu5pp+cvD0XHCdEiA2hMesbGLXtrrJTej2zzboJrdi5spxKKxrBU8G?= =?us-ascii?Q?sCnZs8PZ0BovG9djxPzW12tAuZ6BFfePDxBRh5VPMKF5tzEnlRa4spfg+QnY?= =?us-ascii?Q?wxvoQga+3PMWysAGBz7ZIaqw103uzQOMKoEsuvDXy7+rQDGnbac05jRjeeV/?= =?us-ascii?Q?zekpFlQi4447rmUujF8AFijrZ8gYjzGrWUQiP/D7tf9shJzPo6gyqq3fKxzm?= =?us-ascii?Q?VoVc5Ib2fGRWQNBZY35H4asC+CJcDISvBssaQbO5Q9QnZpe2FSBptVOXgUTf?= =?us-ascii?Q?a75Jh7OGh0INHuK7t+k6dFgOWI0enolIn5XOf8qJ5PUE0P2a5uxVAHlFDpCr?= =?us-ascii?Q?BJtxz7xyngRVuetAjla3teHR54fHBfTLbSZNTViEj/pNONNfEawVp2wGSH49?= =?us-ascii?Q?4WQuJ3DkEwdAssl0xRO/OQ1P6EbnsS+1zGILtsV8D8dyB3slE5UdAJHYsaNZ?= =?us-ascii?Q?K3cDE0AvNk5oLdJ2/9E=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f47e389-c68a-4a2c-0316-08dbefba086d X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2023 02:30:48.7258 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kfg1SjUW4MyblSfDbWc8i+sFW1exk2cJ3Kg67/bonB65guU3ohvja9klkf8n4+pfjrqszZQiFW1+IEZsQTERSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6597 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: mJnK3sTjQfytvM3Grw1AEFCfx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=jJdiKCbq; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Thursday, November 23, 2023 10:13 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH] > RedfishClientPkg/ComputerSystemCollectionDxe: handle more scenarios > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > This change defines two more error returns and allow feature driver to > handle the scenarios while 1) the resource is not owned by feature > driver. 2) feature driver owns this resource but there is nothing to > manage on this resource now. > Detail changes are: > - Use "%a:" instead of "%a," in debug macro. > - Add two error return from EdkIIRedfishResourceConfigIdentify(). > - EFI_UNSUPPORTED: this resource is not owned by feature driver. > Caller should ignore this resource. > - EFI_NOT_FOUND: this resource is owned by feature driver but > there is nothing to handle now. Caller may ignore rest of > operations and proceed to next Redfish resource. > - Add error return from EdkIIRedfishResourceConfigCheck(). > - EFI_UNSUPPORTED: this resource it not owned by feature driver. > Caller should ignore this URI. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > .../Library/EdkIIRedfishResourceConfigLib.h | 9 ++- > .../ComputerSystemCollectionDxe.c | 59 +++++++++++-------- > 2 files changed, 43 insertions(+), 25 deletions(-) > > diff --git a/RedfishClientPkg/Include/Library/EdkIIRedfishResourceConfigL= ib.h > b/RedfishClientPkg/Include/Library/EdkIIRedfishResourceConfigLib.h > index a7856033..8999868a 100644 > --- a/RedfishClientPkg/Include/Library/EdkIIRedfishResourceConfigLib.h > +++ b/RedfishClientPkg/Include/Library/EdkIIRedfishResourceConfigLib.h > @@ -77,6 +77,8 @@ EdkIIRedfishResourceConfigUpdate ( > @param[in] Uri The target URI to consume. > > @retval EFI_SUCCESS Value is returned successfully. > + @retval EFI_UNSUPPORTED This resource is not owned by feature > driver. > + Caller should ignore this resource. > @retval Others Some error happened. > > **/ > @@ -94,7 +96,12 @@ EdkIIRedfishResourceConfigCheck ( > @param[in] InformationExchange Pointer to > RESOURCE_INFORMATION_EXCHANGE. > > @retval EFI_SUCCESS This is target resource which we want= to handle. > - @retval EFI_UNSUPPORTED This is not the target resource. > + @retval EFI_UNSUPPORTED This resource is not owned by feature > driver. > + Caller should ignore this resource. > + @retval EFI_NOT_FOUND This resource is owned by feature dri= ver but > there > + is nothing to handle now. Caller may = ignore the > + rest of operations like check(), prov= isioning(), > + consume() and update(). > @retval Others Some error happened. > > **/ > diff --git > a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.c > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.c > index 1e362d49..111f8212 100644 > --- > a/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.c > +++ > b/RedfishClientPkg/Features/ComputerSystemCollectionDxe/ComputerSyste > mCollectionDxe.c > @@ -3,6 +3,7 @@ > Redfish feature driver implementation - ComputerSystemCollection > > (C) Copyright 2020-2022 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -32,11 +33,11 @@ HandleResource ( > // Resource match > // > > - DEBUG ((REDFISH_DEBUG_TRACE, "%a, process resource for: %s\n", > __func__, Uri)); > + DEBUG ((REDFISH_DEBUG_TRACE, "%a: process resource for: %s\n", > __func__, Uri)); > > Status =3D GetRedfishSchemaInfo (Private->RedfishService, Private- > >JsonStructProtocol, Uri, &SchemaInfo); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, failed to get schema information from: %s > %r\n", __func__, Uri, Status)); > + DEBUG ((DEBUG_ERROR, "%a: failed to get schema information from: %s > %r\n", __func__, Uri, Status)); > return Status; > } > > @@ -50,15 +51,19 @@ HandleResource ( > Status =3D EdkIIRedfishResourceConfigIdentify (&SchemaInfo, Uri, Pri= vate- > >InformationExchange); > if (EFI_ERROR (Status)) { > if (Status =3D=3D EFI_UNSUPPORTED) { > - DEBUG ((DEBUG_MANAGEABILITY, "%a, \"%s\" is not handled by us\n"= , > __func__, Uri)); > + DEBUG ((DEBUG_MANAGEABILITY, "%a: \"%s\" is not handled by us\n"= , > __func__, Uri)); > + return EFI_SUCCESS; > + } else if (Status =3D=3D EFI_NOT_FOUND) { > + DEBUG ((DEBUG_MANAGEABILITY, "%a: \"%s\" has nothing to > handle\n", __func__, Uri)); > + RedfisSetRedfishUri (L"/Systems/{1}", Uri); > return EFI_SUCCESS; > } > > - DEBUG ((DEBUG_ERROR, "%a, fail to identify resource: \"%s\": %r\n"= , > __func__, Uri, Status)); > + DEBUG ((DEBUG_ERROR, "%a: fail to identify resource: \"%s\": %r\n"= , > __func__, Uri, Status)); > return Status; > } > } else { > - DEBUG ((REDFISH_DEBUG_TRACE, "%a, history record found: %s\n", > __func__, ConfigLang)); > + DEBUG ((REDFISH_DEBUG_TRACE, "%a: history record found: %s\n", > __func__, ConfigLang)); > // > // Set exchange information > // > @@ -70,7 +75,7 @@ HandleResource ( > AllocateZeroPool (sizeof > (REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG)); > > if (Private->InformationExchange- > >ReturnedInformation.ConfigureLanguageList.List =3D=3D NULL) { > - DEBUG ((DEBUG_ERROR, "%a, Fail to allocate memory for > REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG.\n", __func__)); > + DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for > REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG.\n", __func__)); > return EFI_OUT_OF_RESOURCES; > } > > @@ -78,7 +83,7 @@ HandleResource ( > Private->InformationExchange- > >ReturnedInformation.ConfigureLanguageList.List[0].ConfigureLang =3D > (EFI_STRING)AllocateCopyPool (StrSize (ReturnedConfigLang), (VOI= D > *)ReturnedConfigLang); > } else { > - DEBUG ((DEBUG_ERROR, "%a, > GetArrayIndexFromArrayTypeConfigureLang fail: %r\n", __func__, Status)); > + DEBUG ((DEBUG_ERROR, "%a: > GetArrayIndexFromArrayTypeConfigureLang fail: %r\n", __func__, Status)); > } > > FreePool (ConfigLang); > @@ -91,13 +96,18 @@ HandleResource ( > DEBUG ((REDFISH_DEBUG_TRACE, "%a Check for %s\n", __func__, Uri)); > Status =3D EdkIIRedfishResourceConfigCheck (&SchemaInfo, Uri); > if (EFI_ERROR (Status)) { > + if (Status =3D=3D EFI_UNSUPPORTED) { > + DEBUG ((REDFISH_DEBUG_TRACE, "%a: \"%s\" is not handled by us\n", > __func__, Uri)); > + return EFI_SUCCESS; > + } > + > // > // The target property does not exist, do the provision to create pr= operty. > // > DEBUG ((REDFISH_DEBUG_TRACE, "%a provision for %s\n", __func__, Uri)= ); > Status =3D EdkIIRedfishResourceConfigProvisionging (&SchemaInfo, Uri= , > Private->InformationExchange, FALSE); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, failed to provision with GET mode: %r\n"= , > __func__, Status)); > + DEBUG ((DEBUG_ERROR, "%a: failed to provision with GET mode: %r\n"= , > __func__, Status)); > } > > return Status; > @@ -109,7 +119,7 @@ HandleResource ( > DEBUG ((REDFISH_DEBUG_TRACE, "%a consume for %s\n", __func__, Uri)); > Status =3D EdkIIRedfishResourceConfigConsume (&SchemaInfo, Uri); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, failed to consume resource for: %s: %r\n", > __func__, Uri, Status)); > + DEBUG ((DEBUG_ERROR, "%a: failed to consume resource for: %s: %r\n", > __func__, Uri, Status)); > } > > // > @@ -118,7 +128,7 @@ HandleResource ( > DEBUG ((REDFISH_DEBUG_TRACE, "%a update for %s\n", __func__, Uri)); > Status =3D EdkIIRedfishResourceConfigUpdate (&SchemaInfo, Uri); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, failed to update resource for: %s: %r\n", > __func__, Uri, Status)); > + DEBUG ((DEBUG_ERROR, "%a: failed to update resource for: %s: %r\n", > __func__, Uri, Status)); > } > > return Status; > @@ -145,7 +155,7 @@ HandleCollectionResource ( > return EFI_NOT_READY; > } > > - DEBUG ((REDFISH_DEBUG_TRACE, "%a, process collection for: %s\n", > __func__, Private->CollectionUri)); > + DEBUG ((REDFISH_DEBUG_TRACE, "%a: process collection for: %s\n", > __func__, Private->CollectionUri)); > > // > // Convert JSON text to C structure. > @@ -157,7 +167,7 @@ HandleCollectionResource ( > (EFI_REST_JSON_STRUCTURE_HEADE= R **)&Collection > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, ToStructure() failed: %r\n", __func__, > Status)); > + DEBUG ((DEBUG_ERROR, "%a: ToStructure() failed: %r\n", __func__, > Status)); > return Status; > } > > @@ -182,7 +192,7 @@ HandleCollectionResource ( > if (MemberUri !=3D NULL) { > Status =3D HandleResource (Private, MemberUri); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, process ComputerSystemCollection > resource: %a failed: %r\n", __func__, UriData->Uri, Status)); > + DEBUG ((DEBUG_ERROR, "%a: process ComputerSystemCollection > resource: %a failed: %r\n", __func__, UriData->Uri, Status)); > } > > FreePool (MemberUri); > @@ -216,19 +226,19 @@ CreateCollectionResource ( > return EFI_INVALID_PARAMETER; > } > > - DEBUG ((REDFISH_DEBUG_TRACE, "%a, create resource for collection for: > %s\n", __func__, Private->CollectionUri)); > + DEBUG ((REDFISH_DEBUG_TRACE, "%a: create resource for collection for: > %s\n", __func__, Private->CollectionUri)); > > Status =3D GetSupportedSchemaVersion (REDFISH_SCHEMA_NAME, > &SchemaInfo); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, failed to find supported schema from HII > database: %r\n", __func__, Status)); > + DEBUG ((DEBUG_ERROR, "%a: failed to find supported schema from HII > database: %r\n", __func__, Status)); > return Status; > } > > - DEBUG ((REDFISH_DEBUG_TRACE, "%a, supported schema: %a > %a.%a.%a\n", __func__, SchemaInfo.Schema, SchemaInfo.Major, > SchemaInfo.Minor, SchemaInfo.Errata)); > + DEBUG ((REDFISH_DEBUG_TRACE, "%a: supported schema: %a > %a.%a.%a\n", __func__, SchemaInfo.Schema, SchemaInfo.Major, > SchemaInfo.Minor, SchemaInfo.Errata)); > > Status =3D EdkIIRedfishResourceConfigProvisionging (&SchemaInfo, Priva= te- > >CollectionUri, Private->InformationExchange, TRUE); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, failed to create resource for: %s: %r\n", > __func__, Private->CollectionUri, Status)); > + DEBUG ((DEBUG_ERROR, "%a: failed to create resource for: %s: %r\n", > __func__, Private->CollectionUri, Status)); > } > > return Status; > @@ -283,14 +293,14 @@ CollectionHandler ( > return EFI_INVALID_PARAMETER; > } > > - DEBUG ((REDFISH_DEBUG_TRACE, "%a, collection handler for %s\n", > __func__, Private->CollectionUri)); > + DEBUG ((REDFISH_DEBUG_TRACE, "%a: collection handler for %s\n", > __func__, Private->CollectionUri)); > > // > // Query collection from Redfish service. > // > Status =3D GetResourceByUri (Private->RedfishService, Private->Collect= ionUri, > &Private->RedResponse); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, unable to get resource from: %s :%r\n", > __func__, Private->CollectionUri, Status)); > + DEBUG ((DEBUG_ERROR, "%a: unable to get resource from: %s :%r\n", > __func__, Private->CollectionUri, Status)); > goto ON_RELEASE; > } > > @@ -350,6 +360,7 @@ RedfishCollectionFeatureCallback ( > > RedfishService =3D Private->RedfishService; > if (RedfishService =3D=3D NULL) { > + DEBUG ((DEBUG_ERROR, "%a: no Redfish service configured\n", > __func__)); > return EFI_NOT_READY; > } > > @@ -368,7 +379,7 @@ RedfishCollectionFeatureCallback ( > // > ResourceUri =3D (EFI_STRING)AllocateZeroPool (MAX_URI_LENGTH * sizeof > (CHAR16)); > if (ResourceUri =3D=3D NULL) { > - DEBUG ((DEBUG_ERROR, "%a, Fail to allocate memory for full URI.\n", > __func__)); > + DEBUG ((DEBUG_ERROR, "%a: Fail to allocate memory for full URI.\n", > __func__)); > return EFI_OUT_OF_RESOURCES; > } > > @@ -386,7 +397,7 @@ RedfishCollectionFeatureCallback ( > > Status =3D CollectionHandler (Private); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, CollectionHandler failure: %r\n", __func__= , > Status)); > + DEBUG ((DEBUG_ERROR, "%a: CollectionHandler failure: %r\n", __func__= , > Status)); > } > > return EFI_SUCCESS; > @@ -492,7 +503,7 @@ EfiRestJasonStructureProtocolIsReady ( > (VOID **)&mRedfishCollectionPrivate->JsonStructProtoco= l > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, failed to locate > gEfiRestJsonStructureProtocolGuid: %r\n", __func__, Status)); > + DEBUG ((DEBUG_ERROR, "%a: failed to locate > gEfiRestJsonStructureProtocolGuid: %r\n", __func__, Status)); > } > > gBS->CloseEvent (Event); > @@ -528,7 +539,7 @@ EdkIIRedfishFeatureProtocolIsReady ( > (VOID **)&FeatureProtocol > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, failed to locate > gEdkIIRedfishFeatureProtocolGuid: %r\n", __func__, Status)); > + DEBUG ((DEBUG_ERROR, "%a: failed to locate > gEdkIIRedfishFeatureProtocolGuid: %r\n", __func__, Status)); > gBS->CloseEvent (Event); > return; > } > @@ -540,7 +551,7 @@ EdkIIRedfishFeatureProtocolIsReady ( > (VOID *)mRedfishCollectionPrivate > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, failed to register %s: %r\n", __func__, > REDFISH_MANAGED_URI, Status)); > + DEBUG ((DEBUG_ERROR, "%a: failed to register %s: %r\n", __func__, > REDFISH_MANAGED_URI, Status)); > } > > mRedfishCollectionPrivate->FeatureProtocol =3D FeatureProtocol; > -- > 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111779): https://edk2.groups.io/g/devel/message/111779 Mute This Topic: https://groups.io/mt/102767203/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-