From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 384C4AC0A29 for ; Mon, 18 Dec 2023 02:48:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=J1aifnLCGm7+qEKJpgLxzAGsYRm8OMnIEZf8zyUP7Sk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702867697; v=1; b=AGWHeaGJKBxHRCveEQ5e9VJoyyk9uZquWx5MXI03PIqa0ZOL2ns3pzK6GEsoieYd2hWrf0Uw 4s3BMx670pQ65Qjp9LRUf6ZIHx95xePqAON64ykj+3+mAWN+xwaO1A/sjxZzUSUWQYbmmtQl2r1 y0OHP0mSwnWyikj89YjJfHsY= X-Received: by 127.0.0.2 with SMTP id AnV4YY7687511xz0ataYFHmJ; Sun, 17 Dec 2023 18:48:17 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.63]) by mx.groups.io with SMTP id smtpd.web11.34283.1702867697141812256 for ; Sun, 17 Dec 2023 18:48:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fd5lvL1FsH8N0Gjb64KpNE2cm8pLXmTcmUii6+OMIy7f7AlWzJBFvN2HBONCHVx04iRYTiCm8kfTjWOGT963Bv6m8NCuSqQfzIyS7rVuVRKwZhc3RsIXSKdBBfg/TKFyP3fA1IMzZgVw1dMC71SIu4HoxQk6A1n8DVLGxTg09TbZJyerZUGIXLZY8TTFerzjyCMN5p8SIo+brPI1R4yjyCWBmkmoq7twoHgX06HzQ5X6NQX4EfCA8LoG+PiWRbsUVln8Y+6ij1KKvucC2fheXn0nAMq7/crqG3U0USWN/p4Qtv296jvDJEtn4rg+gQM2orZqJsgxmzdam9KUj/QpFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LGn6jUdWCsouwTtKL8BtfQ7cytWAW3ksG1BzXRReBeY=; b=gIMkeeqf1UQQztpHL+Bw1x4mHaqpN51r1aRCBuLWPjB/+VpiV8HoJtdEGmaJ0ZrhRzoj4xc8INIxMICYxHZyiu7Hj4+J+wPhFcb4S/ccc9rFn9h3aWD1h3KV7zF0thPcfUjPK43AY0RiWoLX1ZAG5wwsktuCaQEIkBFb8K9ey7g8s2v2MapOXYr3NdXs5OqAIrwjjCYRJugcz032iAFKdPrwQxF79dIsd+Tk2obVPYlvIs0SidybJyDMqosY0whR62+fVV4+BOrhx9GMT/JYR7B+nsGH+jd7ypCqNZzBJb4Rt3D1TrEVCGHD0dNnr9dfapo2BCHxmnxwBZakN5pksw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DS7PR12MB6071.namprd12.prod.outlook.com (2603:10b6:8:9d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 02:48:15 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7091.034; Mon, 18 Dec 2023 02:48:15 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 05/14] RedfishPkg: RedfishDiscoverDxe: fix memory leak on error path. Thread-Topic: [PATCH v2 05/14] RedfishPkg: RedfishDiscoverDxe: fix memory leak on error path. Thread-Index: AQHaLuTH6gl3M2Iirk+l8YgPIqH6i7CuW2/w Date: Mon, 18 Dec 2023 02:48:14 +0000 Message-ID: References: <20231214232458.4636-1-mike.maslenkin@gmail.com> <20231214232458.4636-6-mike.maslenkin@gmail.com> In-Reply-To: <20231214232458.4636-6-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=c8d38788-285e-4c76-b74e-6bcb6324ee14;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-12-18T02:47:59Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DS7PR12MB6071:EE_ x-ms-office365-filtering-correlation-id: 97aa831b-9212-464e-c757-08dbff73c858 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 35BoDPHlhSFJrCn1SHi2cvKaYMEsuMlskEyoEmSLis3BvVbyCAy+Axgb7J/48xdv9Kt62LGJAsm2P4iz1mZHnzwmdld4rYTh7FGddxv3pGzQIUynnQV/iTPUGg2qytYHXas3g3MSzequRJV1GcjuYfFSul39Erpz2jY32+9dYGbA94zEmLHM2DJ+LcSHnxAU/1qKh3vk7LcZqkBwYg7UZ/R5WnSQTmzKdspd+obrp/tT2yPGgrWfi/GqRQJNQEvjEDqosnKRd4X3R0HxAvDmI84qL1RTPIiOWrEocC90F690ucScj2dPzMlsd4uYD1EyVaUKlncDJSZrb08NgOdo0Gdx+9zLHn7TMpw1p3bUcGrOMf2n5bvngxqQuL3KDLdIcQ87ABXyQsvIQtZEevxGEGg7lV25OLLHEiCIbQWviVnhPgLgc5k+jTgmxA4jEf5y0P/9kwXsEP2IGsI5N3mx6pAYNSZk8BWwEQjwaRtaeYf1rfECbEVIT/BHP1ATzJe9w7vbOqUCudRIJpaD1uaMQuJxfhXVngx1w+oFIGYIGJMJWKBa26TwBBWd17OJxrdT5QfZKzPiUog8pJHdhA0pbRw5wOuP4IRfVpsByHFZQzm3+fEEezvMDbPqy6Py6tvTOB8GNxqXmb2hMK/9Iy27bNfSS67EnK7S1EgHe8ChCd8= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/6NRa6Lrc6RYKmTxyc6YCM5U1gfFCZ/JHYk29BfnTdrvgHV4rdKZKm2pXfMk?= =?us-ascii?Q?4FVfUhF9RWYqBxnr7CnuUiF7pSYg+Gsf9vsDUGSXafyei+kMi+Z+25PE6Ure?= =?us-ascii?Q?14yR/qT0w2rSkvmb4Adhu1geSKnPy9r0Gq8CupuZrEzfvCl4kuQDM7iNHtON?= =?us-ascii?Q?esfEemdRoLuJ1aDvgaDxrfmQCe8y8V5vVeZwMzj2C2KCDpMcyLZXTaCfti06?= =?us-ascii?Q?TRk5WDlDXFU8lbJ3zt348qnZ4nzzNA48JvOlkzVQ7/jkDTFK7kTbS3NWtIgt?= =?us-ascii?Q?M3G0v0Le4LMHLGcHfZ7hOg6DJlFXYomVOtABqz8HxmMqgIulSLodbHW9QSr0?= =?us-ascii?Q?e2UjzpNLV7vtQMpJ0+oDq3WIWIM9hSPRI+pnUpDo7PYSJJn7TQAkqlZS571J?= =?us-ascii?Q?FcmLTPwtiHu/MZRuqJDCRQQHZGjHCa/PkKR+zqwarzOm0OJNSKAeUedZdJYj?= =?us-ascii?Q?gxGD4QcA2KfWnrZ3/pr1c2QEgO0FavPhfswKsGZ8yz8BpCA8rUX0aEiJBxC8?= =?us-ascii?Q?k54qPYK7zFq4IsBAwA0udMREaos3aun/byGUCI4iFm18eTMEk5/l+KsU4El3?= =?us-ascii?Q?dZfWc4AbdG+X8GkzkwpSJEJSzW86vDViSuNYaZFWLJ1PhJFHjxFWb8h9uwan?= =?us-ascii?Q?3Lu+S64HCVsZZZBYikmDK6IhjhCfp1l3kc/wzpHnykE5/cOlelT8bxJP+m+c?= =?us-ascii?Q?Uipwxq8wMR1N3/8AGbhKZp5CY5MeV8FgnM8sQelUFzWvL2LI/XfMJ/oFFTyF?= =?us-ascii?Q?3U/TVHSW8JHYzFYioZQ77zBe8CiwojfmzulVSg+vV2jdiN3SAxVYwpgD2GTK?= =?us-ascii?Q?Cq6+Ur6unPNbV5Z+J9cjNr8N0w4Eqt+8aotGrsPdsIP26VIbQmcuQolRRKlA?= =?us-ascii?Q?/q4XquQN6RYZPBNBvWr9oQMsAtxnFj7MpCaooxm/vTtX6iRzOEHawgAOoa9+?= =?us-ascii?Q?yfKennBzUa/O7JQmXNE7iTVUlBpjnMOHCwII7s9UlRUwVGW36IPeJ1F0VQCd?= =?us-ascii?Q?iyXesYPoLa6gw5TlRJhjBh8YVBnmcW883Qz9Cd5aPoJSzFnBvr5VzSG5M/X+?= =?us-ascii?Q?CaHKpC7kMXc1ry8Y82MTOCwcQd7kz7RASOYikpa045XHMj1D1XAnLDWxaHU1?= =?us-ascii?Q?jfE3J0eg2YZ+7AcSt4suiYDJOmrqHwy3Rmywp0h0o20mHjXz9Pr24/i7Otfr?= =?us-ascii?Q?Y5Zn+IO0FOojWZiWzbVQRr2wPLQUMKw2zZ4iZzkpJvSJ/eFPBNGlNl/h61y5?= =?us-ascii?Q?TEoP0YOdOl58nAMjoQFECXcIYZEUNmhxGoYbbEO8aNhyNr0I4Ju3AHWnLzF4?= =?us-ascii?Q?Ggy09SjjYR2foUiM2BVPmDm+ztxzt2zwtiwGzM0k1ccWMHVlVByMC1Rl446V?= =?us-ascii?Q?4QLrMo92nBFod3pVhNuAD60YVWr5BcNsH1hJumKQduS1rAMaYXL9L95Ry+CC?= =?us-ascii?Q?KqB2cdJ9GOhf5b+ooT6umGyzJAXeVlD+9yHMOSgjbJY5dC3q/dF9mDXOd0kJ?= =?us-ascii?Q?UdLiSjPbiZJeBAFFE0Q+BQqqMgmcOnnT9XVZ2+UCdM/6p0+fWmIxnKkR87ud?= =?us-ascii?Q?4dFp7Jfrv0qX1WG7YAY=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97aa831b-9212-464e-c757-08dbff73c858 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2023 02:48:15.0081 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q0pNBwpz2bBgQs08RbSRlixMfLuWCSQybaLP/qtA+k5/5ODq0lmSxqvdp1Nb9RgxfpavxaCarNDu9x/7AkvDhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6071 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YlH6Od4hFBP8NbNCsvpkODFxx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=AGWHeaGJ; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH v2 05/14] RedfishPkg: RedfishDiscoverDxe: fix memory leak > on error path. > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > index 06d8d00da7fb..e344e06d8dcc 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > @@ -829,6 +829,10 @@ AddAndSignalNewRedfishService ( > } while (TRUE); > > } > > > > + if (Char16Uuid !=3D NULL) { > > + FreePool (Char16Uuid); > > + } > > + > > if (NewFound || InfoRefresh) { > > if (!InfoRefresh) { > > DiscoveredList =3D (EFI_REDFISH_DISCOVERED_INTERNAL_LIST > *)AllocateZeroPool (sizeof (EFI_REDFISH_DISCOVERED_INTERNAL_LIST)); > > @@ -907,10 +911,6 @@ AddAndSignalNewRedfishService ( > } > > } > > > > - if (Char16Uuid !=3D NULL) { > > - FreePool ((VOID *)Char16Uuid); > > - } > > - > > Status =3D EFI_SUCCESS; > > if (NewFound || InfoRefresh) { > > // > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112621): https://edk2.groups.io/g/devel/message/112621 Mute This Topic: https://groups.io/mt/103181040/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-