From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.83]) by mx.groups.io with SMTP id smtpd.web10.42268.1682753955667152829 for ; Sat, 29 Apr 2023 00:39:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=dZxnGhYZ; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.237.83, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TvWOlwue+H9vwBLmdcNcMlKGne2G2mpgLTTu67dfR8xvd3TGtPxm7feqb1Crwm5aXfXkgmdHcLnnNy/CdZNvOazbaRJHjIQl6izsVALBdtEFp+otdrbciT8adTnm6/pDJ4kdJSllS2etYQr5YXbdXqHyulfB9hi4+ETSfJUfTLP9tNgfdTXz4ybomgorqgBhdGmFj+LSwkMkf1l/I+qkP41cYUueXxE86kLlpkoP5Jl+FZJx+6LSw5d/ZRvngDONu4WmHpQq29OSR9TZDbAk6JjriTVBD0QowfINnSjjOgL0cwopim9E+gocsqIdySkJXBStnWObGsrVecmES1nYMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xBHvHlZ2qjDu/1s41NS76irDlwa4m6tr01o1JUW43XQ=; b=AY6qvitOnfGTpZK4mpUifs8DYkZx5ofzMXC8KzGtBuzNGhd8ESlWd33npEgIT1Gz9k9XrRELefpIbpMq6VZKIYSWF1xJOo1Fb9QFt8OUSiaoyMr9kclk+XEnjVFj53ODDm1WFIiEO7NG09RJg3jdMuzVbH2cISQyYQvzOROBQgabIL8/1b5WDuOtjuYkBCT+sPKpHl5pKptr/2GnlEB7rv0LrLo3h1GF291i+qkxzlCR/Ic2rqQrKdbaSYXac79a0zynottsm+2J/0IxjUhSPVXwumbACnjUAxTZVwTuCLwKxivgF8hi0tHX6xueFbhAG6XVYznp73O9O8JPDeAhJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xBHvHlZ2qjDu/1s41NS76irDlwa4m6tr01o1JUW43XQ=; b=dZxnGhYZI3j6nJXAd8aePChzk6tMNaIJVivC4MrM/nzsu8uIhWpFgECiLd8F1093Tvfzb0qcF3kKYA+RYerACsbckShca44I97AzGu7kpmSCAGMJxIdnIz3VN2cgXXX20FiNmX9nLPZaNZPObq84HQFsCAVXaH0MLi6j2MTj/dI= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DS7PR12MB5957.namprd12.prod.outlook.com (2603:10b6:8:7c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.24; Sat, 29 Apr 2023 07:39:13 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3%3]) with mapi id 15.20.6340.022; Sat, 29 Apr 2023 07:39:12 +0000 From: "Chang, Abner" To: "devel@edk2.groups.io" , "Attar, AbdulLateef (Abdul Lateef)" CC: "Grimes, Paul" , Eric Dong , Ray Ni , Rahul Kumar , Gerd Hoffmann , Michael D Kinney , Liming Gao , Zhiguang Liu , Ard Biesheuvel , Jiewen Yao , Jordan Justen Subject: Re: [edk2-devel] [PATCH v9 0/9] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib Thread-Topic: [edk2-devel] [PATCH v9 0/9] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib Thread-Index: AQHZeA/xRa6OZBdUtEqw9mSJfeArU69B6xNw Date: Sat, 29 Apr 2023 07:39:12 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-04-29T07:39:10Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=680dc50a-b65d-46f8-a27c-804fbb2a620f; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DS7PR12MB5957:EE_ x-ms-office365-filtering-correlation-id: ccfd0ec1-93b8-40ce-a0d0-08db4884d3be x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 313pxjYiDm0iItlVO0yb2otDB8g3E1FUZ97GmDWAFW9UTLA4lp+Fvh6xF859jiXJNq9UZb6hdpnHGNdR/1/9kLkqFKMA4eCyqaDUMcrI6/6yVzgNvjwoTX/z7QN4okJdjfThoVlmIEoZbsLD/wmyataeS3VeJz6+KxjDghma6duKPB17+DWufjHpDywlWSCFXjyrYQXSvoY6AEmKSb7uLpdM20VuXhsH5ffKnjabzcGjqc8GjIz6wDPQ20K7AruLYyk14guEkQVDPGZHwjKYUZqj55DlWgicItnNF2krPfiuDrYB892HXVyodIGkrcka4GcYhKw8ulBqlllW2EzgPL5CizUh/jo4Bkntc3W3UXwEN92j2ixpfPa+c2wYFtzIwftfM2rsoWiK+YiYNHuCMfpPd0uOnhRpmlDgpE8nY1/nt8F+FQ6m5G1/n/01kMFSYg3l5ywIJaApmjK6t3atv4zu5b5S0cWczyHsTrTk3421t05xVd6kD/+Io/KthKY+KwiigbfHSgfSVlyjRH9x+faHaNyWV02gGjQ9Q5gcyKEK/iqrCpkZWtQ/cnNQiakY9qGmaHpPZgjUJJQEfLfnQVDEYMv4R1cbHzh6p5pShhFo9YbsV+1o1Fk15HO3bduE x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(4636009)(136003)(376002)(346002)(366004)(39860400002)(396003)(451199021)(5660300002)(38100700002)(54906003)(86362001)(478600001)(19627235002)(110136005)(83380400001)(8676002)(8936002)(52536014)(7416002)(2906002)(66899021)(33656002)(71200400001)(7696005)(66476007)(66556008)(66946007)(76116006)(316002)(6506007)(26005)(9686003)(53546011)(122000001)(66446008)(4326008)(64756008)(6636002)(41300700001)(186003)(38070700005)(966005)(55016003)(213903007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1j32fPsrGVFuvSQxG97qxSDNxJVlV7uKcgUpD6ZbFpWijYYOQcziT0CRTXr8?= =?us-ascii?Q?psWpgUaO8nT68TGIl6FAdLFA2Sd0Xn2zkaqi6HCPszTNRzK8xHdqGIY4Huam?= =?us-ascii?Q?GbClp4VdrCmTOuh9S6fXYnfG5nfOTUz5Gp9d5XvII2MQLPRJwOxKPOsauwqj?= =?us-ascii?Q?aOo3O9TpQ04HVaCeBgCzMalX9EnzIkujDWzCBQVTcHPRooKZfl7TEoL6G8yF?= =?us-ascii?Q?CmRwW9t8YmUsfw9b+9TXpFTDzsGFjlNI7cjb4TecAPWmq7lePj3hkEGDeiEi?= =?us-ascii?Q?ZO8yAMs7XmYv5SOIY6vjQz8WyXGjXESNgiiipnP5983C6mOygj42SC4vf9Sl?= =?us-ascii?Q?mrRnBmXXwOhBxu5pdC9BSEP9sclf6mH+qBLj1rMF69mBdN3Sdqp/mpB2qTt7?= =?us-ascii?Q?n0uBidYwxDqe/bryb8C96V/u0NyAarpIu6F7EgYJjxXbHVLzxGcUYpT02SQt?= =?us-ascii?Q?04pA+5lBNW+fHeZswdrV2KG3xzal7uIO2lhFBNIBt7TbeXLcvljcE8Uc9lC1?= =?us-ascii?Q?AvFeUJia9MgHMwQ8KGXfsMPMOBw/Cbg8bxFN1IRqLBGByLpgUXbzka1/9W8f?= =?us-ascii?Q?ZXLx8mClLM2p5zFtoio2+k7rNrwFTCCj534O5y+9T39KqUeQk7IQako74IMa?= =?us-ascii?Q?sMsWh+FzvqAQWhWFfniJsPbK+95YIC7v1pcn21aqznV9eIDiORny9ydyh+1F?= =?us-ascii?Q?8Nm6bCQOi4Cox/MTTR7RAwg57AdjT8JdOO6VQR/YkQLmOlYkF21JRXNXk06z?= =?us-ascii?Q?4lN860RZgIdq/ETGJPjy3RWIDlPpNNlcBbclhAcwEwnGxEnVt1mPjrEkWgkY?= =?us-ascii?Q?8o02owJYN7r562QgGUJkVl+iWB6tltxlVLg2HtVy3dikR/DMLnanQuVsOk+r?= =?us-ascii?Q?H4qLU8GJ2hNpgGnnymM7ZU0n0IIqlWktX7f+FHo+S84s0mQSiFK/OKHK6H4/?= =?us-ascii?Q?mFRqHMsDqZUMsZFk6AsYJbqpGaXvc7uzZamZ//xJHELxC32emq3cYoAXowjx?= =?us-ascii?Q?wRvuuDQKnCw96tsjcaA4a9cJhMmOdA2H1yQfEAYUCvRXw8/dLInZAnpv2Ebr?= =?us-ascii?Q?9Kc/SRt+wvZV3BMDrDr5byyNVTPVs5pmIz2MM7Vk7muzBpU646TGK3fhnGE8?= =?us-ascii?Q?GHqXQ7L2FTHqmyuYlwLaCBHfOXLyiQuloS5zXxQ0wyVPTAT1O7mHDYYgG8fg?= =?us-ascii?Q?qRK1BXbxhQUxT5nvrUK5QgFJ2CqqLW/0jT1Yq6AcWHuqaiZSo4Bwmj+0uZq3?= =?us-ascii?Q?NlPOJq6u69QtPKw9nSGGFLtd3nHl22DKOaDzpming9tjyyI/rjIM1MtLqGrg?= =?us-ascii?Q?F8D8Tc7ch6iLktFP74G2T/Xw2+epymsJEtohLwgMmR3/47Lq8x9lSC59r3c2?= =?us-ascii?Q?WMoFy6idSq9lR97TQJOIf7EoQT/pCb2UgikDl0zEs7CAwlG24wIOKAv4k0S/?= =?us-ascii?Q?mCBxIPgdYtQ+fW/hZ0FuZPp8c7ai5PSMRHpn7hF5sCc4j3du6zAsd+y/m/Lp?= =?us-ascii?Q?+3L3MntwcM59h6d47997U0fOz89Wauk13YMTTyqJCZRTF6/npHbF9tcWZRIe?= =?us-ascii?Q?p6r0Sy6U3jO1A01IwJ0=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ccfd0ec1-93b8-40ce-a0d0-08db4884d3be X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2023 07:39:12.7880 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LNAVsU5qArbAztoVNaZzFtkTSTwT57lpyqWTxEz5NSFgA0yhAHYw9P9RC+uFtTFpXaPz+1imW1wJI9W4NI6mxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5957 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Abdul, We can remove Garrett Kirkendall from CC when you send the next patch set. Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Abdul > Lateef Attar via groups.io > Sent: Wednesday, April 26, 2023 3:22 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; > Grimes, Paul ; Garrett Kirkendall > ; Chang, Abner ; > Eric Dong ; Ray Ni ; Rahul Kumar > ; Gerd Hoffmann ; Michael > D Kinney ; Liming Gao > ; Zhiguang Liu ; Ard > Biesheuvel ; Jiewen Yao > ; Jordan Justen > Subject: [edk2-devel] [PATCH v9 0/9] Adds AmdSmmCpuFeaturesLib and > MmSaveStateLib >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > PR: https://github.com/tianocore/edk2/pull/4282 >=20 > V9: Delta changes: > Addressed review comments. > Rename to MmSaveStateLib. > Also rename SMM_ defines to MM_. > Implemented OVMF MmSaveStateLib. > Removes SmmCpuFeaturesReadSaveStateRegister and > SmmCpuFeaturesWriteSaveStateRegister > function interface. > V8 delta changes: > Addressed review comments from Abner, > Fix the whitespace error. > Seperate the Ovmf changes to another patch > V7 delta changes: > Adds SmmSmramSaveStateLib for Intel processor. > Integrate SmmSmramSaveStateLib library. > V6 delta changes: > Addressed review comments for Ray NI. > removed unnecessary EFIAPI. > V5 delta changes: > rebase to master branch. > updated Reviewed-by > V4 delta changes: > rebase to master branch. > added reviewed-by. > V3 delta changes: > Addressed review comments from Abner chang. > Re-arranged patch order. >=20 > Cc: Paul Grimes > Cc: Garrett Kirkendall > Cc: Abner Chang > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Abdul Lateef Attar >=20 > Abdul Lateef Attar (9): > MdePkg: Adds AMD SMRAM save state map > UefiCpuPkg: Adds MmSaveStateLib library class > UefiCpuPkg: Implements MmSaveStateLib library instance > UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code > UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family > UefiCpuPkg: Implements MmSaveStateLib for Intel > UefiCpuPkg: Implements MmSaveStateLib for Ovmf > UefiCpuPkg: Removes SmmCpuFeaturesReadSaveStateRegister > OvmfPkg: Uses MmSaveStateLib library >=20 > UefiCpuPkg/UefiCpuPkg.dec | 4 + > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 3 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > UefiCpuPkg/UefiCpuPkg.dsc | 25 + > .../MmSaveStateLib/AmdMmSaveStateLib.inf | 28 + > .../MmSaveStateLib/IntelMmSaveStateLib.inf | 28 + > .../MmSaveStateLib/OvmfMmSaveStateLib.inf | 29 + > .../AmdSmmCpuFeaturesLib.inf | 38 + > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 2 + > .../Include/Register/Amd/SmramSaveStateMap.h | 194 +++++ > UefiCpuPkg/Include/Library/MmSaveStateLib.h | 70 ++ > .../Include/Library/SmmCpuFeaturesLib.h | 52 -- > .../Library/MmSaveStateLib/MmSaveState.h | 102 +++ > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 56 +- > .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 767 ------------------ > .../Library/MmSaveStateLib/AmdMmSaveState.c | 309 +++++++ > .../Library/MmSaveStateLib/IntelMmSaveState.c | 413 ++++++++++ > .../MmSaveStateLib/MmSaveStateCommon.c | 138 ++++ > .../Library/MmSaveStateLib/OvmfMmSaveState.c | 612 > ++++++++++++++ .../SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c | 387 > +++++++++ > .../IntelSmmCpuFeaturesLib.c | 70 ++ > .../SmmCpuFeaturesLibCommon.c | 128 --- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 11 +- > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 500 +----------- > MdePkg/MdePkg.ci.yaml | 4 +- > UefiCpuPkg/UefiCpuPkg.ci.yaml | 1 + > 27 files changed, 2465 insertions(+), 1508 deletions(-) create mode 100= 644 > UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveStateLib.inf > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveStateLib.inf > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/OvmfMmSaveStateLib.inf > create mode 100644 > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.inf > create mode 100644 > MdePkg/Include/Register/Amd/SmramSaveStateMap.h > create mode 100644 UefiCpuPkg/Include/Library/MmSaveStateLib.h > create mode 100644 UefiCpuPkg/Library/MmSaveStateLib/MmSaveState.h > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveState.c > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/MmSaveStateCommon.c > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/OvmfMmSaveState.c > create mode 100644 > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c >=20 > -- > 2.25.1 >=20 >=20 >=20 >=20 >=20